Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196487 --- src/checks/checks_runtime.hpp Lines 39 (patched)

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Jan. 30, 2018, 10:05 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196727 --- src/checks/checks_runtime.hpp Lines 32-66 (patched)

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196986 --- src/checks/checks_runtime.hpp Lines 48 (patched)

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 8, 2018, 7:44 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 65394: Added separate structs for health check runtime and check types.

> On Feb. 7, 2018, 1:18 p.m., Alexander Rukletsov wrote: > > src/checks/checks_runtime.hpp > > Lines 55-57 (patched) > > > > > > This is not quite true: you only mean command health checks. HTTP and > > TCP are still

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 12, 2018, 10:50 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197337 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 2

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197348 --- src/checks/checks_runtime.hpp Lines 1-15 (patched)

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 16, 2018, 11:25 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197831 --- Ship it! Ship It! - Joseph Wu On Feb. 16, 2018, 3:25 p.m., A

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197872 --- Fix it, then Ship it! src/checks/checks_types.hpp Lines 52-56

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197925 --- src/checks/checks_types.hpp Lines 57-58 (patched)

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 22, 2018, 1:41 a.m.) Review request for mesos, Alexander Rukletso