[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11157 **[Test build #63099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63099/consoleFull)** for PR 11157 at commit [`efc1d18`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11157 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11157 **[Test build #63098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63098/consoleFull)** for PR 11157 at commit [`a8e828f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11157 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63098/ Test FAILed. ---

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r73074211 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait MesosSchedule

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11157 **[Test build #63098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63098/consoleFull)** for PR 11157 at commit [`a8e828f`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #14446: [SPARK-16841][SQL] Improves the row level metrics perfor...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14446 **[Test build #63097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63097/consoleFull)** for PR 14446 at commit [`1054b74`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #14434: [SPARK-16828][SQL] remove MaxOf and MinOf

2016-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14434#discussion_r73073652 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -662,10 +662,6 @@ object NullPropagation extends Rule

[GitHub] spark pull request #14446: [SPARK-16841][SQL] Improves the row level metrics...

2016-08-01 Thread clockfly
GitHub user clockfly opened a pull request: https://github.com/apache/spark/pull/14446 [SPARK-16841][SQL] Improves the row level metrics performance when reading Parquet table ## What changes were proposed in this pull request? When reading from Parquet table, Spark updates

[GitHub] spark issue #14411: [SPARK-16804][SQL] Correlated subqueries containing LIMI...

2016-08-01 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/14411 @hvanhovell, First, my apologies for delaying the replies. I am travelling this week, only getting spontaneous connections. Thank you for your explanation of the implementation and the reason

[GitHub] spark issue #14445: [SPARK-16320] [SQL] Fix performance regression for parqu...

2016-08-01 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14445 @gatorsmile Thanks! updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73070005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -279,9 +280,15 @@ case class HashAggregateEx

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63095/ Test FAILed. ---

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14445: [SPARK-16320][SQL] Fix performance regression for parque...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14445 Maybe, we can correct the PR description and make it more accurate. This PR avoids the extra memory copy when the vectorized parquet record reader is not being used for reading a non-part

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63095/consoleFull)** for PR 14384 at commit [`119e576`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14445: [SPARK-16320][SQL] Fix performance regression for parque...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14445 **[Test build #63096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63096/consoleFull)** for PR 14445 at commit [`272fb81`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14442: [SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14442 LGTM FYI, MySQL and PostgreSQL support NOW as a synonym of CURRENT_TIMESTAMP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63094/consoleFull)** for PR 14384 at commit [`b376dfb`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63094/ Test FAILed. ---

[GitHub] spark pull request #14445: [SPARK-16320][SQL] Fix performance regression for...

2016-08-01 Thread clockfly
GitHub user clockfly opened a pull request: https://github.com/apache/spark/pull/14445 [SPARK-16320][SQL] Fix performance regression for parquet table with nested fields ## What changes were proposed in this pull request? For non-partitioned parquet table with nested column

[GitHub] spark pull request #14439: [SPARK-16714][SPARK-16735][SPARK-16646] array, ma...

2016-08-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14439#discussion_r73064350 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -157,6 +145,26 @@ object TypeCoercion { })

[GitHub] spark issue #14439: [SPARK-16714][SPARK-16735][SPARK-16646] array, map, grea...

2016-08-01 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14439 It will be good to summarize the behaviors of other systems in the description. Let's also explain the behavioral change of this pr in the description. So, others can understand its implication.

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63095/consoleFull)** for PR 14384 at commit [`119e576`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #14212: [SPARK-16558][Examples][MLlib] examples/mllib/LDAExample...

2016-08-01 Thread yinxusen
Github user yinxusen commented on the issue: https://github.com/apache/spark/pull/14212 @MLnick They serve different purpose. This one is for users who have built their tools upon it. The `LatentDirichletAllocationExample` is for ML docs. --- If your project is set up for it, you can

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/1 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-01 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/1 @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14444: [SPARK-16839] [SQL] redundant aliases after clean...

2016-08-01 Thread eyalfa
GitHub user eyalfa opened a pull request: https://github.com/apache/spark/pull/1 [SPARK-16839] [SQL] redundant aliases after cleanupAliases ## What changes were proposed in this pull request? a failing test, soon to add a proposed fix ## How was this patch tested?

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63093/ Test FAILed. ---

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63093/consoleFull)** for PR 14384 at commit [`b376dfb`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63090/ Test PASSed. ---

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63094/consoleFull)** for PR 14384 at commit [`b376dfb`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14441 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14441 **[Test build #63090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63090/consoleFull)** for PR 14441 at commit [`0e0136a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/14384 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #14443: [SPARK-15869][Streaming]Fix a potential NPE in St...

2016-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14443 Thanks! Merging to master and 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14443 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14443 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63091/ Test PASSed. ---

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14443 **[Test build #63091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63091/consoleFull)** for PR 14443 at commit [`8b06b72`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73053436 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends QueryTes

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63093/consoleFull)** for PR 14384 at commit [`b376dfb`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63092/ Test FAILed. ---

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14384 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14353: [SPARK-16714][SQL] `array` should create a decimal array...

2016-08-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14353 Close this for the better PR https://github.com/apache/spark/pull/14439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14433 https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L138 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63092/consoleFull)** for PR 14384 at commit [`d5433f6`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14353: [SPARK-16714][SQL] `array` should create a decima...

2016-08-01 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/14353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #14442: [SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_...

2016-08-01 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14442 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark pull request #14398: [SPARK-16774][SQL] Fix use of deprecated timestam...

2016-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14442: [SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14442 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14442: [SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14442 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63088/ Test PASSed. ---

[GitHub] spark issue #14398: [SPARK-16774][SQL] Fix use of deprecated timestamp const...

2016-08-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14398 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73051607 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends Quer

[GitHub] spark issue #14442: [SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14442 **[Test build #63088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63088/consoleFull)** for PR 14442 at commit [`f614781`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-01 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14433 @felixcheung Let me check the code of launching the sparkR shell. Can you point me the code? Thanks! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread ooq
Github user ooq commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73050331 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -279,9 +280,15 @@ case class HashAggregateExec(

[GitHub] spark issue #11443: [SPARK-13244][SQL] Migrates DataFrame to Dataset

2016-08-01 Thread vlad17
Github user vlad17 commented on the issue: https://github.com/apache/spark/pull/11443 There may be small bug introduced here. Please see my comment inline: https://github.com/apache/spark/pull/11443/files#diff-c3d0394b2fc08fb2842ff0362a5ac6c9R836 --- If your project is set up for

[GitHub] spark pull request #11443: [SPARK-13244][SQL] Migrates DataFrame to Dataset

2016-08-01 Thread vlad17
Github user vlad17 commented on a diff in the pull request: https://github.com/apache/spark/pull/11443#discussion_r73048593 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -745,6 +825,80 @@ class DataFrame private[sql]( } /** +

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048060 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class CreateDataSourc

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048108 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends QueryTes

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048087 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -449,6 +449,22 @@ class DataFrameReaderWriterSuite ex

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73047977 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class CreateDataSourc

[GitHub] spark issue #9207: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Try adding PM...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9207 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63086/ Test PASSed. --- I

[GitHub] spark issue #9207: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Try adding PM...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9207 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #9207: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Try adding PM...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9207 **[Test build #63086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63086/consoleFull)** for PR 9207 at commit [`8103b76`](https://github.com/apache/spark/commit/81

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14443 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark issue #14384: [Spark-16443][SparkR] Alternating Least Squares (ALS) wr...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14384 **[Test build #63092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63092/consoleFull)** for PR 14384 at commit [`d5433f6`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Oh, sorry for misunderstanding, @hvanhovell . I think we can integrate `ResolveRelation` and this one. I'll be back after some testing in this evening. Also for the common approach, I will bri

[GitHub] spark issue #14443: [SPARK-15869][Streaming]Fix a potential NPE in Streaming...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14443 **[Test build #63091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63091/consoleFull)** for PR 14443 at commit [`8b06b72`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #14443: [SPARK-15869][Streaming]Fix a potential NPE in St...

2016-08-01 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/14443 [SPARK-15869][Streaming]Fix a potential NPE in StreamingJobProgressListener.getBatchUIData ## What changes were proposed in this pull request? Moved `asScala` to a `map` to avoid NPE.

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63089/ Test PASSed. ---

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14308 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14308 **[Test build #63089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63089/consoleFull)** for PR 14308 at commit [`a556742`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14441 **[Test build #63090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63090/consoleFull)** for PR 14441 at commit [`0e0136a`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/14441 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14266: [SPARK-16526][SQL] Benchmarking Performance for Fast Has...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/14266 Just a minor nit. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #14266: [SPARK-16526][SQL] Benchmarking Performance for F...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14266#discussion_r73040155 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala --- @@ -576,4 +576,605 @@ class AggregateBenchmark

[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function

2016-08-01 Thread junyangq
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14258 @felixcheung Sorry I still didn't get there. It seems that internally it checks via `args.primaryResource`. I was wondering if there is a good way to access to that in sparkR. Thanks! --- If your

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73039793 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -499,14 +499,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #14392: [SPARK-16446] [SparkR] [ML] Gaussian Mixture Mode...

2016-08-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14392#discussion_r73039485 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +659,106 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"), function(object

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73039235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -499,14 +499,16 @@ object SQLConf { .intConf

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14308 **[Test build #63089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63089/consoleFull)** for PR 14308 at commit [`a556742`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73038918 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -141,8 +141,16 @@ class RowBasedHashM

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73038709 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -660,36 +778,74 @@ case class HashAggregateE

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14433 Correct, I don't think should name the function `sc.setLogLevel` The message is coming from Scala - I changed the default logging level for python and R recently so I think I know where it is

[GitHub] spark issue #14355: [SPARK-16726][SQL] Improve `Union/Intersect/Except` erro...

2016-08-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14355 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14439: [SPARK-16714][SPARK-16735][SPARK-16646] array, map, grea...

2016-08-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14439 @yhuai do you have a concrete suggestion other than being careful here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73037506 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -459,52 +476,115 @@ case class HashAggregate

[GitHub] spark issue #14398: [SPARK-16774][SQL] Fix use of deprecated timestamp const...

2016-08-01 Thread ckadner
Github user ckadner commented on the issue: https://github.com/apache/spark/pull/14398 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14308 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63087/ Test PASSed. ---

[GitHub] spark issue #14308: [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs

2016-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14308 **[Test build #63087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63087/consoleFull)** for PR 14308 at commit [`479819d`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73036933 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -279,9 +280,15 @@ case class HashAggregateEx

[GitHub] spark issue #14396: [SPARK-16787] SparkContext.addFile() should not throw if...

2016-08-01 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14396 @JoshRosen LGTM for the current patch. However, I have a question about the following description in your PR: > At file download time, Spark tasks will fail with exceptions if an executor a

[GitHub] spark pull request #14176: [SPARK-16525][SQL] Enable Row Based HashMap in Ha...

2016-08-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73036686 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java --- @@ -165,10 +165,16 @@ private

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14182 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14182: [SPARK-16444][SparkR]: Isotonic Regression wrapper in Sp...

2016-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14182 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63085/ Test PASSed. ---

<    1   2   3   4   >