Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r98613398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -293,6 +293,12 @@ object SimplifyConditionals exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r98613430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -293,6 +293,12 @@ object SimplifyConditionals exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r98613413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -293,6 +293,12 @@ object SimplifyConditionals exte
Github user titicaca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r98612545
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,11 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !=
Github user titicaca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r98611766
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,11 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !=
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16746
BTW, @klinvill .
Do you use a real instance? Could you advice how the other persons like me
can verify your PR on Teradata? Maybe, can we check Teradata Express or AWS
Marketplace?
---
I
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16746#discussion_r98608480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16746#discussion_r98607602
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16043
**[Test build #72189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72189/testReport)**
for PR 16043 at commit
[`81442fc`](https://github.com/apache/spark/commit/81
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16746#discussion_r98607321
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13932
**[Test build #72188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72188/testReport)**
for PR 13932 at commit
[`93eb511`](https://github.com/apache/spark/commit/93
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16726
+1 for reducing the dependency!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/13932
jenkins ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98604570
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -188,24 +189,45 @@ class BlockManagerMasterEndpoint(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603116
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1131,14 +1131,47 @@ private[spark] class BlockManager(
}
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98604381
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -188,24 +189,45 @@ class BlockManagerMasterEndpoint(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603889
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -188,24 +189,45 @@ class BlockManagerMasterEndpoint(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603866
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1152,20 +1185,25 @@ private[spark] class BlockManager(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98605803
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -188,24 +189,45 @@ class BlockManagerMasterEndpoint(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603462
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1152,20 +1185,25 @@ private[spark] class BlockManager(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603908
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -188,24 +189,45 @@ class BlockManagerMasterEndpoint(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98602812
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1131,14 +1131,47 @@ private[spark] class BlockManager(
}
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r98603310
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1131,14 +1131,47 @@ private[spark] class BlockManager(
}
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16737
+1. LGTM except one typo! @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r98605236
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,11 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r98605157
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,11 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16739#discussion_r98605173
--- Diff: R/pkg/R/DataFrame.R ---
@@ -680,14 +680,45 @@ setMethod("storageLevel",
storageLevelToString(callJMethod(x@sdf, "storageLevel"))
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16722
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72184/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16722
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16722
**[Test build #72184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72184/testReport)**
for PR 16722 at commit
[`159c5a6`](https://github.com/apache/spark/commit/1
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/16749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16749
merged to branch-2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72186/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72186/testReport)**
for PR 16689 at commit
[`8379c38`](https://github.com/apache/spark/commit/8
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16739#discussion_r98604331
--- Diff: R/pkg/R/DataFrame.R ---
@@ -680,14 +680,45 @@ setMethod("storageLevel",
storageLevelToString(callJMethod(x@sdf, "storageLevel")
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14412
**[Test build #72187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72187/testReport)**
for PR 14412 at commit
[`016ea9f`](https://github.com/apache/spark/commit/01
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/14412
jenkins ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72183/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72183/testReport)**
for PR 16736 at commit
[`9614ff3`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16740
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16740
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72185/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16740
**[Test build #72185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72185/testReport)**
for PR 16740 at commit
[`0b3c085`](https://github.com/apache/spark/commit/0
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16737#discussion_r98602527
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Softwa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72186/testReport)**
for PR 16689 at commit
[`8379c38`](https://github.com/apache/spark/commit/83
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16722
Thanks for taking a look @imatiach-msft, much appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/16731
understood. they really were lots of functions -- let's tell users to use
`expr("approx_percentile(...)")`.
closing this. thanks for the comments!
---
If your project is set up for it, you
Github user lw-lin closed the pull request at:
https://github.com/apache/spark/pull/16731
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16722
sorry haven't finished reviewing yet, will look more tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98600282
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -126,20 +127,22 @@ class RandomForestClassifier
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98600175
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -126,20 +127,22 @@ class RandomForestClassifier
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98599986
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -106,14 +122,18 @@ class DecisionTreeClassifier
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98599783
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -45,7 +48,7 @@ import org.apache.spark.sql.Datas
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98599033
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala ---
@@ -31,7 +31,7 @@ object TestingUtils {
* Note that if x o
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98599006
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala ---
@@ -48,7 +48,7 @@ object TestingUtils {
/**
* Priva
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16739#discussion_r98598572
--- Diff: R/pkg/R/DataFrame.R ---
@@ -680,14 +680,45 @@ setMethod("storageLevel",
storageLevelToString(callJMethod(x@sdf, "storageLevel"))
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16740
@sethah Thanks for your review. Yes, using `foldLeft` would be the simplest
fix. I have included both your suggested changes in the new commit.
Yes, we could handle the special case of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16740
**[Test build #72185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72185/testReport)**
for PR 16740 at commit
[`0b3c085`](https://github.com/apache/spark/commit/0b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16722
**[Test build #72184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72184/testReport)**
for PR 16722 at commit
[`159c5a6`](https://github.com/apache/spark/commit/15
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72181/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16749
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16749
**[Test build #72181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72181/testReport)**
for PR 16749 at commit
[`f421a1c`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72183/testReport)**
for PR 16736 at commit
[`9614ff3`](https://github.com/apache/spark/commit/96
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r98592980
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -221,17 +221,8 @@ class SQLConfSuite extends QueryTest with
SharedS
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16603
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72179/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16603
**[Test build #72179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72179/testReport)**
for PR 16603 at commit
[`3176756`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72182/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72182/testReport)**
for PR 16689 at commit
[`7903bb3`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15237
@erenavsarogullari sorry to push back, but if you're willing to do the
filename thing now, why not just tackle it in this same pr? seems pretty minor
to separate into its own issue, and conceptually
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72182/testReport)**
for PR 16689 at commit
[`7903bb3`](https://github.com/apache/spark/commit/79
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r98591359
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala ---
@@ -51,8 +54,39 @@ private[spark] class TaskDescription(
val index
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16749
**[Test build #72181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72181/testReport)**
for PR 16749 at commit
[`f421a1c`](https://github.com/apache/spark/commit/f4
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/16749
[BACKPORT-2.1][SPARKR][DOCS] update R API doc for subset/extract
## What changes were proposed in this pull request?
backport #16721 to branch-2.1
## How was this patch tested?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/16748
[BACKPORT-2.1][SPARKR][DOCS] update R API doc for subset/extract
## What changes were proposed in this pull request?
backport #16721 to branch-2.1
## How was this patch tested?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72178/
Test PASSed.
---
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/16748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16664
**[Test build #72178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72178/testReport)**
for PR 16664 at commit
[`752125a`](https://github.com/apache/spark/commit/7
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16712
LGTM. cc @hvanhovell for final sign off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r98589964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -464,6 +464,16 @@ object SQLConf {
.intConf
.create
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72177/
Test PASSed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16745
Thanks! Merging to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16664
**[Test build #72177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72177/testReport)**
for PR 16664 at commit
[`b0392ed`](https://github.com/apache/spark/commit/b
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r98589474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -464,6 +464,16 @@ object SQLConf {
.intConf
.createWith
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r98589278
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with
SharedS
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16744
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72175/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16744
**[Test build #72175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72175/testReport)**
for PR 16744 at commit
[`2298dd7`](https://github.com/apache/spark/commit/2
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98579939
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -86,13 +86,9 @@ private[ml] class IterativelyReweight
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98578921
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,54 @@ class GeneralizedLinearRegressi
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16740
Since we already compute the number of features in the train method, why
don't we just check if `numFeatures == 0` and then just compute the intercept
as the link of the weighted average of the label
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r98580805
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -336,14 +361,19 @@ class GeneralizedLinearRegres
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15821
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72180/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15821
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
1 - 100 of 358 matches
Mail list logo
