[GitHub] spark issue #12217: [WIP][SPARK-14408][CORE] Changed RDD.treeAggregate to us...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12217 **[Test build #3773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3773/testReport)** for PR 12217 at commit

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-02 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/18181 -1, with comments on the JIRA issue. I think it is better to include the Parquet fixes in 1.8.2 since Parquet doesn't pull in Avro 1.8.1 - that happens when users declare their own dependency on

[GitHub] spark issue #18167: [SPARK-19236][SQL][BACKPORT-2.2] Added createOrReplaceGl...

2017-06-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18167 +1, LGTM for backport. Please update the JIRA information, https://issues.apache.org/jira/browse/SPARK-19236. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18181 Also, cc @rdblue and @mallman . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12217: [WIP][SPARK-14408][CORE] Changed RDD.treeAggregate to us...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12217 **[Test build #3773 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3773/testReport)** for PR 12217 at commit

[GitHub] spark issue #18188: [SPARK-20790] [MLlib] Remove extraneous logging in test

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18188 **[Test build #3772 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3772/testReport)** for PR 18188 at commit

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77678/testReport)** for PR 18159 at commit

[GitHub] spark pull request #18183: [SPARK-20961][SQL] generalize the dictionary in C...

2017-06-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18183#discussion_r119890824 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/Dictionary.java --- @@ -0,0 +1,31 @@ +/* + * Licensed to the

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18187 +1, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18188: [SPARK-20790] [MLlib] Remove extraneous logging in test

2017-06-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18188 Is it very noisy? I can see just removing it if so. The alternative is to turn it down to debug and guard both the statements with a check on the log level, for performance. --- If your project is

[GitHub] spark issue #12217: [WIP][SPARK-14408][CORE] Changed RDD.treeAggregate to us...

2017-06-02 Thread NathanHowell
Github user NathanHowell commented on the issue: https://github.com/apache/spark/pull/12217 Nothing looks obviously broken, their combiner looks fine. Rerunning the tests would help. On Jun 2, 2017 07:02, "Hyukjin Kwon" wrote: > Hi

[GitHub] spark issue #17941: [SPARK-20684][R] Expose create[OrReplace]GlobalTempView ...

2017-06-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17941 If @felixcheung provides the real open source implementation for that in a near future, that would be perfect. Why don't you make a PR as a PoC first if the implementation isn't going to be

[GitHub] spark issue #13833: [SPARK-16124][SQL] fix `getHiveFile` return file url in ...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13833 +1 for closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #12456: [Spark-14686] Allow setting local properties that are no...

2017-06-02 Thread marcintustin
Github user marcintustin commented on the issue: https://github.com/apache/spark/pull/12456 Feel free to close -- Marcin Tustin Tel: +1 917 553 3974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13720: [SPARK-16004] [SQL] Correctly display "Last Access Time"...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13720 ping @bomeng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #12456: [Spark-14686] Allow setting local properties that are no...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12456 I just want to be sure. Is it waiting for reviewer's comment or you just happened to don't have some time to keep this up-to-date? If it is the latter case, I think we could leave this closed

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13373 @lianhuiwang, I understand it is painful to keep the PR up-to-date. However, shouldn't we probably have the Jenkins build passed at the last even if it has conflicts? --- If your project is

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-06-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18159 @adrian-ionescu I've included the suggested metrics per file/partition. The `writingTime` metric is also changed to record actual time on writing data. --- If your project is set up for it, you can

[GitHub] spark issue #13171: [SPARK-15380][SQL][WIP] Generate code that stores a floa...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13171 gentle ping @kiszk. Probably, this is the same instance with https://github.com/apache/spark/pull/12894#issuecomment-305799473. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #12894: [SPARK-15117][SQL][WIP] Generate Java code that gets a v...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12894 @kiszk, I do understand it is painful to keep PR up-to-date but shouldn't we probably have the Jenkins pass at the last even if it has conflicts? --- If your project is set up for it, you can

[GitHub] spark issue #12456: [Spark-14686] Allow setting local properties that are no...

2017-06-02 Thread marcintustin
Github user marcintustin commented on the issue: https://github.com/apache/spark/pull/12456 I am not actively working on this. -- Marcin Tustin Tel: +1 917 553 3974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77677/testReport)** for PR 18159 at commit

[GitHub] spark issue #12456: [Spark-14686] Allow setting local properties that are no...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12456 Hi @marcintustin and all, where are we on this? is this still active? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #12257: [SPARK-14483][WEBUI] Display user name for each job and ...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12257 gentle ping @ajbozarth @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #12252: [SPARK-14460] [SQL] properly handling of column name con...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12252 ping @bomeng for ^. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18188: [SPARK-20790] [MLlib] Remove extraneous logging in test

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18188 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #12217: [WIP][SPARK-14408][CORE] Changed RDD.treeAggregate to us...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12217 Hi @jkbradley and @srowen, could we retest this just to see the error messages? It looks the last test results are not accessible (to me). --- If your project is set up for it, you can reply

[GitHub] spark pull request #18188: [SPARK-20790] [MLlib] Remove extraneous logging i...

2017-06-02 Thread davideis
GitHub user davideis opened a pull request: https://github.com/apache/spark/pull/18188 [SPARK-20790] [MLlib] Remove extraneous logging in test ## What changes were proposed in this pull request? Remove extraneous logging. ## How was this patch tested? Unit

[GitHub] spark issue #12217: [WIP][SPARK-14408][CORE] Changed RDD.treeAggregate to us...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/12217 @NathanHowell, do you maybe have any idea on this (sorry, probably wrong person to cc but I know no one I could think ... )? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #17882: [WIP][SPARK-20079][try 2][yarn] Re registration of AM ha...

2017-06-02 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17882 @jerryshao @vanzin Would you take some time to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #18158: [SPARK-20936][CORE]Lack of an important case abou...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119859774 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -461,19 +461,17 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark issue #10162: [SPARK-11250] [SQL] Generate different alias for columns...

2017-06-02 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/10162 @HyukjinKwon do you mean closing or fixing the PR ? As I understand from @gatorsmile he wants to close it --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #11887: [SPARK-13041][Mesos]add driver sandbox uri to the dispat...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/11887 gentle ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18170: [SPARK-20942][WEB-UI]The title style about field ...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18158: [SPARK-20936][CORE]Lack of an important case abou...

2017-06-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119858243 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -461,19 +461,17 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark issue #18170: [SPARK-20942][WEB-UI]The title style about field is erro...

2017-06-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18170 Merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #10162: [SPARK-11250] [SQL] Generate different alias for columns...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/10162 Hi @NarineK, is there any opinion on ^? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18161: [MINOR][PYTHON] Ignore pep8 on test scripts gener...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18152: [SPARK-20930][ML] Destroy broadcasted centers aft...

2017-06-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18152#discussion_r119855432 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -320,6 +320,7 @@ class LocalLDAModel private[spark] (

[GitHub] spark issue #18161: [MINOR][PYTHON] Ignore pep8 on test scripts generated in...

2017-06-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18161 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18022: [SPARK-20790] [MLlib] Correctly handle negative values f...

2017-06-02 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18022 You can link the same JIRA since it's a small follow up On Fri, 2 Jun 2017 at 15:16, davideis wrote: > Does it need another jira ticket? > > On Jun 2,

[GitHub] spark issue #18022: [SPARK-20790] [MLlib] Correctly handle negative values f...

2017-06-02 Thread davideis
Github user davideis commented on the issue: https://github.com/apache/spark/pull/18022 Does it need another jira ticket? On Jun 2, 2017 9:13 AM, "Nick Pentreath" wrote: > Yeah you can just open a small follow up PR > On Fri, 2 Jun 2017

[GitHub] spark issue #18022: [SPARK-20790] [MLlib] Correctly handle negative values f...

2017-06-02 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18022 Yeah you can just open a small follow up PR On Fri, 2 Jun 2017 at 15:10, davideis wrote: > *@davideis* commented on this pull request. >

[GitHub] spark pull request #18022: [SPARK-20790] [MLlib] Correctly handle negative v...

2017-06-02 Thread davideis
Github user davideis commented on a diff in the pull request: https://github.com/apache/spark/pull/18022#discussion_r119852009 --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala --- @@ -455,6 +487,22 @@ class ALSSuite targetRMSE = 0.3)

[GitHub] spark issue #17503: [SPARK-3159][MLlib] Check for reducible DecisionTree

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17503 (gentle ping @jkbradley) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17533: [SPARK-20219] Schedule tasks based on size of input from...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17533 Hi @jinxing64, how is it going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17638: [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not ...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17638 Hi all, where are we on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17645: [SPARK-20348] [ML] Support squared hinge loss (L2 loss) ...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17645 ping @hhbyyh, where are we on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17681: [SPARK-20383][SQL] Supporting Create [temporary] Functio...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17681 Hi all, where are we on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17689: [SPARK-20378][CORE][SQL][SS] StreamSinkProvider should p...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17689 ping @ymahajan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17716: [SPARK-19952][SQL] Remove various analysis exceptions

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17716 @hvanhovell, how is it going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17721: [SPARK-20013][SQL]merge renameTable to alterTable in Ext...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17721 ping @windpiger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17759: [DOCS] Fix a typo in Encoder.clsTag

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17759 ping @mineo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17791: [SPARK-20515][SQL] Fix reading of HIVE ORC table with va...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17791 ping @umehrot2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17882: [WIP][SPARK-20079][try 2][yarn] Re registration of AM ha...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17882 ping @witgo how it is going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17937: Reload credentials file config when app starts with chec...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17937 ping @victor-wong, how it is going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17985: Add "full_outer" name to join types

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17985 Ping @BartekH, how is it going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18187 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77676/ Test PASSed. ---

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18187 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18187 **[Test build #77676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77676/testReport)** for PR 18187 at commit

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions for nulls...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18164 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions for nulls...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77675/ Test PASSed. ---

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions for nulls...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18164 **[Test build #77675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77675/testReport)** for PR 18164 at commit

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions for nulls...

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18164 Aaa...okay that's fine to me. NA always reminds me of R first :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] Add fill functions for nulls...

2017-06-02 Thread rberenguel
Github user rberenguel commented on the issue: https://github.com/apache/spark/pull/18164 @HyukjinKwon I changed it, does it look any clearer? I have always thought of `na` in terms of Python and not R anyway :) --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18164 BTW, mind fixng the title/contents in the PR to be a bit more descriptive, for example, saying "null" instead of "NA"? Not a big deal but non R guys might get confused ... --- If your

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18181 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18181 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77673/ Test FAILed. ---

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18181 **[Test build #77673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77673/testReport)** for PR 18181 at commit

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18185 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77672/ Test PASSed. ---

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #77672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77672/testReport)** for PR 18185 at commit

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18187 **[Test build #77676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77676/testReport)** for PR 18187 at commit

[GitHub] spark issue #18187: [SPARK-20967][SQL] SharedState.externalCatalog is not re...

2017-06-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18187 cc @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #18187: [SPARK-20967][SQL] SharedState.externalCatalog is...

2017-06-02 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18187 [SPARK-20967][SQL] SharedState.externalCatalog is not really lazy ## What changes were proposed in this pull request? `SharedState.externalCatalog` is marked as a `lazy val` but actually

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18164 Ah... I see. Sorry, I misunderstood. BTW, AppVeyor only runs SparkR tests on Windows currently. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119813861 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala --- @@ -124,6 +134,13 @@ class DataFrameNaFunctionsSuite extends

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on the issue: https://github.com/apache/spark/pull/18164 @ueshin @HyukjinKwon thanks for giving it a very thorough look and sorry for my previous comment, that was terribly unclear. I was confused because the Appveyor tick mark was green for commit

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119813043 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala --- @@ -124,6 +134,13 @@ class DataFrameNaFunctionsSuite extends

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812943 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala --- @@ -36,6 +36,15 @@ class DataFrameNaFunctionsSuite extends

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -196,6 +196,24 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812666 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -196,6 +196,24 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812590 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812631 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18164 **[Test build #77675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77675/testReport)** for PR 18164 at commit

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119812409 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119808351 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119810367 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -196,6 +196,24 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119810649 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala --- @@ -36,6 +36,15 @@ class DataFrameNaFunctionsSuite extends

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119808075 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119810057 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -196,6 +196,24 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119808932 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+--+---+

[GitHub] spark pull request #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119811145 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala --- @@ -124,6 +134,13 @@ class DataFrameNaFunctionsSuite extends

[GitHub] spark issue #18186: [SPARK-20966]Table data is not sorted by startTime time ...

2017-06-02 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18186 @srowen @ajbozarth @jerryshao Help to review the code, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #18186: [SPARK-20966]Table data is not sorted by startTime time ...

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18186 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18186: [SPARK-20966]Table data is not sorted by startTim...

2017-06-02 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/18186 [SPARK-20966]Table data is not sorted by startTime time desc, time is not formatted and redundant code in JDBC/ODBC Server page. ## What changes were proposed in this pull request?

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77674/ Test FAILed. ---

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18164 **[Test build #77674 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77674/testReport)** for PR 18164 at commit

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18164 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18164: [SPARK-19732][SQL][PYSPARK] fillna bools

2017-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18164 **[Test build #77674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77674/testReport)** for PR 18164 at commit

<    1   2   3   4   >