Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r128200260
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1458,4 +1475,167 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r128202464
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1458,4 +1475,167 @@ class
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18605
@wangmiao1981 This is expected, see my comment
[here](https://github.com/apache/spark/pull/18613#discussion_r127011929) . This
uncovers an existing bug for ```forceIndexLabel```. I will send a
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18612#discussion_r127584690
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -162,7 +162,7 @@ private[ml] trait HasThreshold extends Params
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18613
Merged into master. Thanks for all reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18613
@felixcheung We don't silently drop features, we use ```handleInvalid``` to
let users decide how to handle invalid features or label. The behavior is
consistent with Scala which suppor
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18613#discussion_r127260481
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -501,4 +501,51 @@ class RFormulaSuite extends SparkFunSuite with
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18613
@felixcheung @wangmiao1981 In Scala, we set ```handleInvalid``` for both
estimator and model, although it only takes effect for model prediction. The
reason behind this is we should support
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18610
This failure is irrelevant. Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18613#discussion_r127011929
--- Diff: R/pkg/tests/fulltests/test_mllib_tree.R ---
@@ -225,7 +225,7 @@ test_that("spark.randomForest", {
expect_error(collect(p
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18613
cc @felixcheung @wangmiao1981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18610
cc @dbtsai @sethah @MLnick @hhbyyh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/18613
[SPARK-20307][ML][SPARKR][FOLLOW-UP] RFormula should handle invalid for
both features and label column.
## What changes were proposed in this pull request?
```RFormula``` should handle
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18582
LGTM, merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18610#discussion_r126911229
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -113,7 +115,14 @@ trait DefaultReadWriteTest extends
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/17117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/18610
[SPARK-21386] ML LinearRegression supports warm start from user provided
initial model.
## What changes were proposed in this pull request?
Allow users to set initial model when training
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r126872238
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1441,4 +1460,33 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r126871919
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -452,6 +452,8 @@ object
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r126873611
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1441,4 +1460,33 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r126873706
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1187,6 +1189,23 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r126872077
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1441,4 +1460,33 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18554#discussion_r126868713
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -317,7 +318,12 @@ final class OneVsRest @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18554#discussion_r126710934
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -317,7 +318,12 @@ final class OneVsRest @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18582#discussion_r126679441
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -86,15 +87,11 @@ final class Bucketizer @Since("1.4.0"
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18582#discussion_r126689856
--- Diff: python/pyspark/ml/feature.py ---
@@ -3058,26 +3035,37 @@ class RFormula(JavaEstimator, HasFeaturesCol,
HasLabelCol, JavaMLReadable, JavaM
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18582#discussion_r126682178
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -460,16 +460,16 @@ object LinearRegression extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18582#discussion_r126681028
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -74,16 +74,12 @@ private[feature] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18582#discussion_r126679343
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -36,7 +36,8 @@ import org.apache.spark.sql.types.{DoubleType
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18305
@MLnick I remembered a bug I hit several months ago: we forgot to destroy a
broadcast variable in source code, but it throws exception after we add destroy
explicitly. This is because we put
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r126582816
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18523
Merged into master, thanks for all!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18523
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18523#discussion_r125876862
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -113,12 +113,15 @@ class VectorAssembler @Since("
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17862
I'm in favor of discarding OWLQN. Take LiR or LoR as examples, if you
replace LBFGS with OWLQN for regression with L2 regularization, we can saw
OWLQN may converge faster than LBFGS in a ce
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18523
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18523
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18523#discussion_r125804032
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -113,12 +113,15 @@ class VectorAssembler @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r125671626
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularization.scala
---
@@ -32,40 +34,45 @@ private[ml] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r125675084
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r125675879
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18523#discussion_r125652869
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -113,12 +113,15 @@ class VectorAssembler @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125606256
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -136,6 +137,14 @@ private[ml] object Param {
s
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125564145
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -187,12 +188,12 @@ class NaiveBayes @Since("
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125606191
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -229,6 +238,16 @@ object ParamValidators {
def arrayLengthGt[T
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125642693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -93,8 +93,8 @@ private[classification] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125647745
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -199,7 +199,7 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125648566
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -460,7 +463,7 @@ object LinearRegression extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125605206
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -83,19 +85,16 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125605561
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -106,4 +105,13 @@ object
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18534
LGTM, merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18453
Merged into master. Thanks for all you reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18453#discussion_r125176981
--- Diff: python/pyspark/ml/feature.py ---
@@ -2132,6 +2132,12 @@ class StringIndexer(JavaEstimator, HasInputCol,
HasOutputCol, HasHandleInvalid
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18453#discussion_r125159512
--- Diff: python/pyspark/ml/feature.py ---
@@ -2132,6 +2132,12 @@ class StringIndexer(JavaEstimator, HasInputCol,
HasOutputCol, HasHandleInvalid
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17862
@hhbyyh Make sense, does it mean both LBFGS and OWLQN produce the same
solution if fitting without intercept? If so, I'm prefer to change the solver
to LBFGS rather than adding a new o
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157589
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -53,7 +53,23 @@ import org.apache.spark.storage.StorageLevel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157587
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -143,7 +143,18 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157502
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -421,6 +435,18 @@ object LinearRegression extends
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18495
LGTM, merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125155063
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -53,7 +53,23 @@ import org.apache.spark.storage.StorageLevel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125155049
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -75,17 +78,13 @@ private[classification
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16699
#18489 fixed the build failure. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18489
Merged into master to fix scala-2.10 build failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/18489
[ML] Fix scala-2.10 build failure of GeneralizedLinearRegressionSuite.
## What changes were proposed in this pull request?
Fix scala-2.10 build failure of ```GeneralizedLinearRegressionSuite
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16699
@hvanhovell I will send a quick fix soon, thanks for your kindly remind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16699
Merged into master. Thanks for contribution and all reviews! This great
feature will benefit lots of users.
@actuaryzhang Could you send follow-up PRs to address the two inline
comments
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17862
@hhbyyh If different handling of intercept scaling is the major cause for
result difference between sklearn and Spark, do you check whether fit model
without intercept will produce same model
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124737247
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,6 +327,16 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124739973
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -944,15 +984,22 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124733535
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala
---
@@ -27,3 +27,29 @@ import org.apache.spark.ml.linalg.Vector
* @param
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124737015
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -134,6 +134,25 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124733379
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala
---
@@ -27,3 +27,29 @@ import org.apache.spark.ml.linalg.Vector
* @param
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124737056
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -134,6 +134,25 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124753530
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -961,14 +1008,16 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r124730326
--- Diff: python/pyspark/ml/classification.py ---
@@ -1327,8 +1327,6 @@ class MultilayerPerceptronClassifier(JavaEstimator,
HasFeaturesCol, HasLabelCol
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12414
Merged into master. Thanks for all your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16699
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user yanboliang reopened a pull request:
https://github.com/apache/spark/pull/12414
[SPARK-14657][SPARKR][ML] RFormula w/o intercept should output reference
category when encoding string terms
## What changes were proposed in this pull request?
Please see [SPARK
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/12414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12414
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/18453
[SPARK-19852][PYSPARK][ML] Python StringIndexer supports 'keep' to handle
invalid data
## What changes were proposed in this pull request?
This PR is to maintain API parity wi
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12414
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12414
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124281406
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -961,14 +1007,30 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124235464
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,6 +317,17 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124272947
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -798,77 +798,184 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124271108
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -578,6 +578,79 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124261785
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -339,15 +364,16 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124258933
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquaresSuite.scala
---
@@ -43,7 +43,7 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124268761
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -798,77 +798,160 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124233224
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -406,6 +437,14 @@ object
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124269044
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -798,77 +798,184 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124212354
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala
---
@@ -27,3 +27,28 @@ import org.apache.spark.ml.linalg.Vector
* @param
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124236849
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -440,13 +479,13 @@ object
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124234628
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -168,6 +179,9 @@ private[regression] trait
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124262306
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquaresSuite.scala
---
@@ -156,7 +156,7 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124265572
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquaresSuite.scala
---
@@ -169,29 +169,29 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124272854
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -798,77 +798,184 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124237318
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -944,15 +983,22 @@ class
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12414
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
301 - 400 of 2646 matches
Mail list logo
