Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199497880
Merged into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199491169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199491164
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199490844
**[Test build #53706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53706/consoleFull)**
for PR 11636 at commit
[`6b07e69`](https://g
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199451226
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56886878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199446045
**[Test build #53706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53706/consoleFull)**
for PR 11636 at commit
[`6b07e69`](https://gi
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199444953
Here are benchmark results in the latest code.
Without this PR
```
model name : Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
Partitioned Table:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56883452
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,19 +241,29 @@ private[sql] case class DataSourceScan(
/
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56866480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,19 +241,29 @@ private[sql] case class DataSourceScan(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199356553
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199356521
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199355887
**[Test build #53678 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53678/consoleFull)**
for PR 11636 at commit
[`9ec61ce`](https://g
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56840405
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,19 +241,29 @@ private[sql] case class DataSourceScan(
/
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199318644
Have you rerun the benchmark with these changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199313491
**[Test build #53678 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53678/consoleFull)**
for PR 11636 at commit
[`9ec61ce`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199251039
**[Test build #53674 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53674/consoleFull)**
for PR 11636 at commit
[`fb693d2`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199251045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199251041
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-199249367
**[Test build #53674 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53674/consoleFull)**
for PR 11636 at commit
[`fb693d2`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56782696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,19 +241,29 @@ private[sql] case class DataSourceScan(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198082685
**[Test build #53468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53468/consoleFull)**
for PR 11636 at commit
[`5efadf3`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198084216
**[Test build #53468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53468/consoleFull)**
for PR 11636 at commit
[`5efadf3`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198598006
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56575717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -199,7 +210,8 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56567171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -199,7 +210,8 @@ class CodegenContext {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197460528
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198079212
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198085861
**[Test build #53470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53470/consoleFull)**
for PR 11636 at commit
[`8c9d054`](https://gi
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56453365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordinal
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198198837
**[Test build #53500 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53500/consoleFull)**
for PR 11636 at commit
[`e08472b`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197410160
**[Test build #53324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53324/consoleFull)**
for PR 11636 at commit
[`c522a68`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198109663
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56567647
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -199,7 +210,8 @@ class CodegenContext {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198597887
**[Test build #53584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53584/consoleFull)**
for PR 11636 at commit
[`cdd3078`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198585189
**[Test build #53584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53584/consoleFull)**
for PR 11636 at commit
[`cdd3078`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198372505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198079203
**[Test build #53466 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53466/consoleFull)**
for PR 11636 at commit
[`5544c96`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198084229
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198372017
**[Test build #53537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53537/consoleFull)**
for PR 11636 at commit
[`a7ac8fb`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198079210
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198598009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198218039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197460112
**[Test build #53324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53324/consoleFull)**
for PR 11636 at commit
[`c522a68`](https://g
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56691811
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -199,15 +199,20 @@ private[sql] case class DataSourceScan(
//
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56540019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -199,7 +210,8 @@ class CodegenContext {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56692635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,39 @@ object BindReferences extends L
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56692854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,39 @@ object BindReferences extends L
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56691971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198109532
**[Test build #53470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53470/consoleFull)**
for PR 11636 at commit
[`8c9d054`](https://g
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56692918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,39 @@ object BindReferences extends L
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56364323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -158,9 +158,13 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56404151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordinal
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198217769
**[Test build #53500 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53500/consoleFull)**
for PR 11636 at commit
[`e08472b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198671636
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198671637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198671563
**[Test build #53611 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53611/consoleFull)**
for PR 11636 at commit
[`cdf4333`](https://g
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197378611
@nongli , is it possible to change the name of API from
```ColumnVector.getIsNull()``` to ```ColumnVector.isNullAt()```. If it is
possible, we can remove a change of this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198109665
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56724708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
//
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198077981
**[Test build #53466 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53466/consoleFull)**
for PR 11636 at commit
[`5544c96`](https://gi
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56736654
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -199,15 +199,20 @@ private[sql] case class DataSourceScan(
//
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56691784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -199,15 +199,20 @@ private[sql] case class DataSourceScan(
//
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56408960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordina
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56482715
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -158,9 +158,13 @@ class CodegenContext {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198218038
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56364150
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordina
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198327451
**[Test build #53537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53537/consoleFull)**
for PR 11636 at commit
[`a7ac8fb`](https://gi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56725827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
/
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56692563
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56736677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
//
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56736640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -199,15 +199,20 @@ private[sql] case class DataSourceScan(
//
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56692279
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198652882
**[Test build #53611 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53611/consoleFull)**
for PR 11636 at commit
[`cdf4333`](https://gi
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198652819
@davies I am glad to work on what the community wants.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56745689
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
//
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56745695
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -228,8 +240,9 @@ private[sql] case class DataSourceScan(
|
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197460537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56335579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -186,6 +190,13 @@ class CodegenContext {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198084238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56455795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordina
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-197404951
@kiszk Feel free to change that API
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56744525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,32 @@ object BindReferences extends L
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56744501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,32 @@ object BindReferences extends Lo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198372501
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56744426
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
//
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56736684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,39 @@ object BindReferences extends Lo
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11636#issuecomment-198632150
@kiszk I think this is pretty close to what we want, thanks for working on
it.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56743990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -228,8 +240,9 @@ private[sql] case class DataSourceScan(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56743967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,32 @@ object BindReferences extends L
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56743960
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
/
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56743931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56730574
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
//
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56728827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
//
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56729652
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56736738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -104,3 +104,39 @@ object BindReferences extends Lo
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56189923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -186,6 +190,13 @@ class CodegenContext {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56189439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -170,7 +179,8 @@ private[sql] case class PhysicalRDD(
|
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56189147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -158,9 +158,13 @@ class CodegenContext {
1 - 100 of 116 matches
Mail list logo
