Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134559485
The test failure must be spurious; this is a scaladoc-only change, and
compilation / style checks succeed.
---
If your project is set up for it, you can reply to this em
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134559021
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134559022
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134558965
[Test build #41529 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41529/console)
for PR 8308 at commit
[`73ce4ac`](https://github.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134530480
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134524278
[Test build #41529 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41529/consoleFull)
for PR 8308 at commit
[`73ce4ac`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134523182
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134523157
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37745530
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -769,7 +790,9 @@ class DAGScheduler(
}
}
- /** Ca
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134172434
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134172233
**[Test build #41450 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41450/console)**
for PR 8308 at commit
[`f835ae8`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134172432
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134110172
[Test build #41450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41450/consoleFull)
for PR 8308 at commit
[`f835ae8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134108340
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-134108356
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133088404
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133088408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133088399
[Test build #41326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41326/console)
for PR 8308 at commit
[`100f9a7`](https://github.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556991
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1162,17 +1190,20 @@ class DAGScheduler(
}
cas
Github user ehnalis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556883
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1162,17 +1190,20 @@ class DAGScheduler(
}
ca
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133084239
[Test build #41326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41326/consoleFull)
for PR 8308 at commit
[`100f9a7`](https://gith
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556418
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -178,35 +185,41 @@ class DAGScheduler(
}
/**
- * U
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556365
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1162,17 +1190,20 @@ class DAGScheduler(
}
cas
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133082325
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133082301
[Test build #41325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41325/console)
for PR 8308 at commit
[`4911559`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133082327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556264
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -716,11 +735,14 @@ class DAGScheduler(
}
}
- /**
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133081841
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133081814
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133081591
[Test build #41325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41325/consoleFull)
for PR 8308 at commit
[`4911559`](https://gith
Github user ehnalis commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133081165
I went through it, also reorganized a method to the front and made method
comments consistent.
---
If your project is set up for it, you can reply to this email and hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133080507
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-133080468
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132607672
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132607676
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132607463
[Test build #41234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41234/console)
for PR 8308 at commit
[`2a70faf`](https://github.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132559067
I think the additional changes I mentioned are worth fixing here since
they're very much of the same form. If you have time to scan for similar
problems in nearby source,
Github user ehnalis commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-13238
Would you like if I go through all of them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132546896
[Test build #41234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41234/consoleFull)
for PR 8308 at commit
[`2a70faf`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132540152
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132540139
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132540092
Yeah, pretty trivial but true. Same for taskSetFailed I think.
Also executorLost and executorAdded could probably refer to a
"TaskScheduler _implementation_" to be mor
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132539949
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8308#issuecomment-132538832
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user ehnalis opened a pull request:
https://github.com/apache/spark/pull/8308
Fixed a typo in DAGScheduler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ehnalis/spark master
Alternatively you can review and apply these
46 matches
Mail list logo
