[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558564 --- Diff: core/src/main/scala/org/apache/spark/scheduler/local/LocalSchedulerBackend.scala --- @@ -59,6 +62,12 @@ private[spark] class LocalEndpoint(

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558472 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,179 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558527 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,179 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558450 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -993,6 +993,12 @@ class DAGScheduler(

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558431 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -232,6 +225,13 @@ private[spark] class Executor( }

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-21 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93558401 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,14 +136,10 @@ private[spark] class Executor( startDriverHeartbeater()

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89886595 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -232,6 +225,13 @@ private[spark] class Executor( }

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89889108 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -247,28 +248,29 @@ class

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89872502 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,179 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89872712 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,179 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89895008 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -993,6 +993,12 @@ class DAGScheduler(

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93079839 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,179 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93078511 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-12-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r93077759 --- Diff: core/src/main/scala/org/apache/spark/scheduler/local/LocalSchedulerBackend.scala --- @@ -59,6 +62,12 @@ private[spark] class LocalEndpoint(

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-24 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89483305 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89249162 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -592,47 +579,6 @@ class TaskSetManagerSuite extends SparkFunSuite

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89249175 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,178 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89246494 --- Diff: mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackendSuite.scala --- @@ -345,7 +374,17 @@ class

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89246343 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89166735 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -592,47 +579,6 @@ class TaskSetManagerSuite extends SparkFunSuite

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89167206 --- Diff: mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackendSuite.scala --- @@ -345,7 +374,17 @@ class

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89166210 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,178 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89166493 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r89166279 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -17,27 +17,178 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-07 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r8669 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -486,7 +481,7 @@ private[spark] class Executor( * Download any missing

[GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...

2016-11-06 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r86703926 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -486,7 +481,7 @@ private[spark] class Executor( * Download any missing