[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17758 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126354324 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala --- @@ -352,4 +353,40 @@ class FileStreamSinkSuite extends Stream

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126352411 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala --- @@ -352,4 +353,40 @@ class FileStreamSinkSuite extends Str

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126083104 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,23 @@ +-- Catch case-sensitive name duplication +SET spark.sql.caseSe

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126074994 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,23 @@ +-- Catch case-sensitive name duplication +SET spark.sql.caseSe

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126074450 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,23 @@ +-- Catch case-sensitive name duplication +SET spark.sql.cas

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126074238 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,23 @@ +-- Catch case-sensitive name duplication +SET spark.sql.caseSe

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r126073404 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,23 @@ +-- Catch case-sensitive name duplication +SET spark.sql.cas

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125891743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -422,6 +405,18 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125889801 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -422,6 +405,18 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125889675 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -422,6 +405,18 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125564439 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -304,7 +329,13 @@ case class DataSource( cas

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125564070 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -304,7 +329,13 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125498171 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125489566 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125483095 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceValidator.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to the

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-04 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125482229 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125400282 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -87,6 +87,14 @@ case class DataSource( lazy val

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125400239 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -334,6 +352,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125396517 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceValidator.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to t

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125396465 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125395801 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -334,6 +352,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125395258 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -87,6 +87,14 @@ case class DataSource( lazy v

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125270419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -87,6 +87,14 @@ case class DataSource( lazy val

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125267663 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122898892 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122868692 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -62,13 +63,8 @@ case class Inser

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122867659 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -62,13 +63,8 @@ case class In

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122867252 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -328,6 +333,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122866890 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122866830 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -355,12 +356,12 @@ object ViewHelper { analyzedPlan: L

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122866332 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -328,6 +333,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122865863 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -355,12 +356,12 @@ object ViewHelper { analyzedPlan

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122865721 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122863353 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -328,6 +333,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122862830 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(spar

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122862386 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -687,4 +688,52 @@ class DataFrameReaderWriterSuite exten

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122853060 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122831948 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122610979 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource( thr

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122596253 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122595919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -328,6 +333,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122595783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122595701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122595287 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -687,4 +688,52 @@ class DataFrameReaderWriterSuite e

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122584251 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala --- @@ -59,9 +59,7 @@ abstract class JsonDataSource e

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-17 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122582071 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala --- @@ -59,9 +59,7 @@ abstract class JsonDataSource ex

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122558846 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122558842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -62,13 +63,8 @@ case class Inser

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122557795 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122557773 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122557676 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -355,12 +356,12 @@ object ViewHelper { analyzedPlan: L

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122557657 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122555690 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122539610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -62,13 +63,8 @@ case class I

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122538611 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -328,6 +333,9 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122538571 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -182,6 +183,10 @@ case class DataSource(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122535046 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122534924 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122534244 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -355,12 +356,12 @@ object ViewHelper { analyzedPla

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122534073 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122407108 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(spar

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122378171 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122375436 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(spar

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122375082 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122374729 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/SchemaUtilsSuite.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122374556 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122374471 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122374344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122128317 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,9 @@ +-- Check name duplication in a regular case +CREATE TABLE t (c

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122128225 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -466,13 +467,15 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122128029 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -741,14 +742,7 @@ object JdbcUtils extends Logging

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122127202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -466,13 +467,15 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122126852 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,9 @@ +-- Check name duplication in a regular case +CREATE TABLE t (c S

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r122126261 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -741,14 +742,7 @@ object JdbcUtils extends Logging {

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-14 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121878933 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -741,14 +742,7 @@ object JdbcUtils extends Logging

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121591640 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,5 @@ +-- Check name duplication in a regular case +CREATE TABLE t (c

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121288368 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -687,4 +687,46 @@ class DataFrameReaderWriterSuite extend

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121288462 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/util/SchemaUtil.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121287958 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/util/SchemaUtil.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121288362 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -687,4 +687,46 @@ class DataFrameReaderWriterSuite extend

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-06-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r121288487 --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql --- @@ -0,0 +1,5 @@ +-- Check name duplication in a regular case +CREATE TABLE t (c S

[GitHub] spark pull request #17758: [SPARK-20460][SQL] Make it more consistent to han...

2017-04-25 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/17758 [SPARK-20460][SQL] Make it more consistent to handle column name duplication ## What changes were proposed in this pull request? This pr made it more consistent to handle column name duplication.