uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508672674
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -331,7 +333,6 @@ public boolean contains(final UTF8String substring) {
if (subs
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508674676
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508674676
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508704687
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508803718
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -585,10 +604,23 @@ object ContainsExpressionBuilder extends
Str
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508867241
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +343,21 @@ public boolean contains(final UTF8String substring) {
return
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508868584
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
retur
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508872841
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
return
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508873927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +608,21 @@ object ContainsExpressionBuilder extends
Str
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508881130
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +343,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508881751
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +608,21 @@ object ContainsExpressionBuilder extends
Stri
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508917781
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -61,6 +61,5 @@ class StringType private(val collationId: Int) extends
AtomicType with Se
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508920123
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,33 @@ case class Lower(child: Expression)
abstra
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508922010
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ tes
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508925352
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ tes
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1508983490
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,33 @@ case class Lower(child: Expression)
abstract
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509069300
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509075313
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -61,6 +61,5 @@ class StringType private(val collationId: Int) extends
AtomicType with Ser
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509076371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509083011
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1509069300
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510723361
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510723989
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -183,6 +183,266 @@ class CollationSuite extends DatasourceV2SQLBase {
}
}
+ test(
cloud-fan commented on PR #45216:
URL: https://github.com/apache/spark/pull/45216#issuecomment-1975976208
@uros-db unfortunately it has code conflicts now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510755527
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,32 @@ case class Lower(child: Expression)
abstra
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510763028
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -497,10 +497,32 @@ case class Lower(child: Expression)
abstract
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510829030
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +608,38 @@ object ContainsExpressionBuilder extends
St
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510831636
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -234,6 +438,7 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanH
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1510831636
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -234,6 +438,7 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanH
cloud-fan commented on PR #45216:
URL: https://github.com/apache/spark/pull/45216#issuecomment-1976739454
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cloud-fan closed pull request #45216: [SPARK-47131][SQL][COLLATION] String
function support: contains, startswith, endswith
URL: https://github.com/apache/spark/pull/45216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502735262
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -66,6 +66,13 @@ public static class Collation {
*/
public fina
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502735941
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -586,9 +584,17 @@ object ContainsExpressionBuilder extends
Stri
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502762736
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -105,6 +105,9 @@ public Collation(
private static final Collation[] c
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502762736
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -105,6 +105,9 @@ public Collation(
private static final Collation[] c
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502765099
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +340,15 @@ public boolean contains(final UTF8String substring) {
return
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502774167
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val prett
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502776606
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val prett
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502777283
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val prett
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502783545
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -622,10 +646,24 @@ object StartsWithExpressionBuilder extends
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502789593
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -174,4 +174,237 @@ class CollationSuite extends QueryTest with
SharedSparkSession {
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502791434
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +340,15 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502792597
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val pretty
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502795006
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -622,10 +646,24 @@ object StartsWithExpressionBuilder extends
S
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502795006
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -622,10 +646,24 @@ object StartsWithExpressionBuilder extends
S
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502937584
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +340,15 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1503794242
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -174,4 +174,237 @@ class CollationSuite extends QueryTest with
SharedSparkSession {
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1503794927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val pretty
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1503800082
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +340,15 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1504086524
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -622,10 +646,24 @@ object StartsWithExpressionBuilder extends
S
mkaravel commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505438346
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -559,6 +559,25 @@ case class BinaryPredicate(override val prett
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505447421
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -327,11 +329,10 @@ public UTF8String substringSQL(int pos, int length) {
/**
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505448239
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -105,6 +105,9 @@ public Collation(
private static final Collation[]
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505449019
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
retur
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505450164
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505450164
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505450164
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505460392
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -105,6 +105,9 @@ public Collation(
private static final Collation[] co
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505461280
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
retur
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505462011
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -105,6 +105,9 @@ public Collation(
private static final Collation[]
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505471123
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505471123
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506037403
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -331,7 +333,6 @@ public boolean contains(final UTF8String substring) {
if (sub
dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506039038
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506046182
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
retur
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506048114
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -355,14 +371,43 @@ public boolean matchAt(final UTF8String s, int pos) {
retu
cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506054121
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -585,10 +604,23 @@ object ContainsExpressionBuilder extends
S
69 matches
Mail list logo