Re: [ros-dev] The situation with version 0.4.14

2021-02-09 Thread Hermès BÉLUSCA-MAÏTO
I would like to just release the 0.4.14, as we already have a ton of release candidates of it on Sourceforge, so that we are done with it now, and then branch 0.4.15 and do the usual regression testing from there. Regards, Hermes -Original Message- From: Ros-dev On Behalf Of Victor Per

Re: [ros-dev] Status Meeting (November 2020)

2020-12-21 Thread Hermès BÉLUSCA-MAÏTO
And it's not possible to use these tools and libraries as plug-in and -out? I mean, for example, for people interested in these, and some of our buildbots, to do "configure+build using libc++ and LLVM" in order to get more info about the code they write in ROS, and in such a way that it is also pos

Re: [ros-dev] Status Meeting (November 2020)

2020-12-02 Thread Hermès BÉLUSCA-MAÏTO
A detailed investigation would be needed for sure, but I am currently thinking about two things: - some Vista+ functions being used (for example: GetTickCount64, some functions using the SRW locks …) - the possible usage of apisets dlls. In any case in order to cope with that in ROS, we would

Re: [ros-dev] Status Meeting (November 2020)

2020-11-25 Thread Hermès BÉLUSCA-MAÏTO
What about that discussion about why we have ditched out MSVC 2010 support (starting to depend on that fact, and thus, breaking any possibility of self-hosting ROS building on ROS using MSVC compiler (without the IDE), since later versions of MSVC only work on Vista+, and as an indirect consequence

[ros-dev] MS Console/Terminal stuff (was: "RE: Ros-dev Digest, Vol 177, Issue 2")

2019-05-07 Thread Hermès BÉLUSCA-MAÏTO
Hi, I’m trying to answer point by point. 1. Their license is MIT. At least it allows us to borrow ideas from their code for how to implement stuff in ReactOS’ console/terminal. (I suppose that if one wants to copy entire chunks of code, that I wouldn’t do it, I’m not sure how the lice

[ros-dev] Microsoft open-sources its console / terminal code! (MIT-licensed)

2019-05-07 Thread Hermès BÉLUSCA-MAÏTO
Dear All, Yes you've read correctly! Microsoft released the code of its terminal + the Windows console host (conhost.exe) under MIT license at: https://github.com/microsoft/Terminal I think this is a really great move!! This can definitively help us for: * first, allowing us to improv

Re: [ros-dev] "[shell32] Shell dialog issues" .- CORE-10481

2018-12-02 Thread Hermès BÉLUSCA-MAÏTO
At least some people at MS / windows testers didn’t think it was a good idea, because on Windows 7 at least (I suppose it’s the same on Vista and on Windows 10) these kind of property dialogs get again an entry in the taskbar. H. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part d

Re: [ros-dev] Win8 theme for ReactOS?

2018-09-08 Thread Hermès BÉLUSCA-MAÏTO
Please don't include any "GreenteaOS" stuff in ReactOS!! Hermès. > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de theUser BL > Envoyé : samedi 8 septembre 2018 16:54 > À : ros-dev@reactos.org > Objet : [ros-dev] Win8 theme for ReactOS? > > A while a

Re: [ros-dev] Virtual consoles using ntvdm

2018-09-04 Thread Hermès BÉLUSCA-MAÏTO
Hi, That’s on my plan, and this is certainly not to be done in ntvdm, as it’s indeed just another console app, so you would better implement your multiple consoles in winsrv.dll / win32k / whatever (actually the best way would be using a similar architecture as Win10). Best, Hermes

Re: [ros-dev] [ros-diffs] 01/04: [REACTOS] RtlAssert(): use "%lu" as LineNumber format.

2018-08-09 Thread Hermès BÉLUSCA-MAÏTO
7d3b3ce3349fa87d01ee > 29d0d08ff2ca8618a7d > > > > commit 97d3b3ce3349fa87d01ee29d0d08ff2ca8618a7d > > Author: Serge Gautherie > > AuthorDate: Thu Jun 21 05:05:50 2018 +0200 > > Commit: Hermès Bélusca-Maïto > > CommitDate: Wed Aug 8 21:24:07 2018 +

Re: [ros-dev] Postponing the July Meeting

2018-08-02 Thread Hermès BÉLUSCA-MAÏTO
t > be > as visible for people to find in google searches. > > > > Ged. > > > > > > -Original Message- > > From: Ros-dev On Behalf Of Hermès > BÉLUSCA-MAÏTO > > Sent: Wednesday, 01 August 2018 20:20 > > To: 'ReactOS Development

Re: [ros-dev] Postponing the July Meeting

2018-08-01 Thread Hermès BÉLUSCA-MAÏTO
Hi, This sounds interesting, for potential developers wanting just to work on some module, but not wanting to deal with the whole OS thing. Would this mean that we also have to think about git submodules? Because (in the case of the NTFS driver for example) it would be in a different git repo,

[ros-dev] Repetitive "shell submit results failed" errors when running testbot manually

2018-08-01 Thread Hermès BÉLUSCA - MAÏTO
Hello! I repeatedly get an error "shell submit results failed" while trying to run testbot on a PR  patch, see for example https://build.reactos.org/builders/Test%20KVM/builds/20818 and as a result I cannot obtain the results under reactos.org/testman . Can someone investigate what is going on?

Re: [ros-dev] [ros-diffs] 01/01: [WIN32SS] Fix NtUserGetClipboardData for text paste (#645)

2018-07-07 Thread Hermès BÉLUSCA-MAÏTO
af6cc7b7c57ff9c6bcc4a919cf85d1e > > Author: Katayama Hirofumi MZ > > AuthorDate: Sun Jul 1 00:12:23 2018 +0900 > > Commit: Hermès BÉLUSCA - MAÏTO > > CommitDate: Sat Jun 30 17:12:23 2018 +0200 > > > > [WIN32SS] Fix NtUserGetClipboardData for text pas

Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.

2018-06-09 Thread Hermès BÉLUSCA-MAÏTO
; Envoyé : samedi 9 juin 2018 09:21 > À : ros-dev@reactos.org; Hermès Bélusca-Maïto > Objet : Re: [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; > fix few comments; fix the default empty window title string. > > On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote: > &

Re: [ros-dev] [ros-diffs] 02/08: [NTOSKRNL] Forbid processes without the Tcb prvilege to perform a user-mode hard-error BSOD.

2018-04-02 Thread Hermès BÉLUSCA-MAÏTO
, I say “f$ck these!” Regards, Hermès De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Alex Ionescu Envoyé : lundi 2 avril 2018 04:20 À : ReactOS Development List; Hermès Bélusca-Maïto Cc : Linda Wang Objet : Re: [ros-dev] [ros-diffs] 02/08: [NTOSKRNL] Forbid processes without

Re: [ros-dev] [ros-diffs] 01/01: [WINLOGON] Clean up part 2 - Replace the UNICODE_STRING usMessage by a PWSTR pszMessage. - Use the "%02d:%02d:%02d" time format and get rid of the safe string printf b

2018-04-02 Thread Hermès BÉLUSCA-MAÏTO
If I remember correctly you can make shutdowns delayed of many days on Windows (using the InitiateSystemShutdown(Ex) function), in which case the 2-digit hour won't work at all. Best, Hermès > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas >

Re: [ros-dev] RFC: Change Rapps 'Size' field

2018-02-08 Thread Hermès BÉLUSCA-MAÏTO
lob/master/7zip.txt#L6 On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO wrote: What 'size' field are you exactly talking about? > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen > Envoyé : jeudi 8 février 2018 20:43

Re: [ros-dev] RFC: Change Rapps 'Size' field

2018-02-08 Thread Hermès BÉLUSCA-MAÏTO
What 'size' field are you exactly talking about? > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen > Envoyé : jeudi 8 février 2018 20:43 > À : ros-dev@reactos.org > Objet : [ros-dev] RFC: Change Rapps 'Size' field > > Hello, > > I'd like

Re: [ros-dev] Making bluescreens more useful

2018-01-13 Thread Hermès BÉLUSCA - MAÏTO
___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] Making bluescreens more useful

2018-01-10 Thread Hermès BÉLUSCA-MAÏTO
Let’s bring the NT-4-type BSODs back!! \o/ De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de David Quintana (gigaherz) Envoyé : jeudi 11 janvier 2018 00:53 À : ReactOS Development List Objet : Re: [ros-dev] Making bluescreens more useful Looks nice! On 11 January 2018 at

[ros-dev] *PREVIEW* : ReactOS 1st-stage GUI installer testing on Windows

2018-01-06 Thread Hermès BÉLUSCA-MAÏTO
Hello everyone, Lately I was continuing working on my “setup_improvements” branch: https://github.com/HBelusca/reactos/commits/setup_improvements (whose main purpose, I recall, is to share a maximum of installation code between our working 1st-stage text-mode usetup and our 1st-stage GUI-mode

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Hermès BÉLUSCA-MAÏTO
That's why I'm extremely in favour of keeping the HAL x86 Standard PC mono-processor separate from the other hals (I mean, as a separate dll). But if you find inside some code that can be shared with the ACPI/APIC/whatever other hal, then just share it! (maybe use some #ifdefs inside as long as i

Re: [ros-dev] PineappleFund

2017-12-13 Thread Hermès BÉLUSCA-MAÏTO
… Because OpenBSD is ? https://www.reddit.com/r/Bitcoin/comments/7jj0oa/im_donating_5057_btc_to_charitable_causes/dr6pabe/ De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part d

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Hermès BÉLUSCA-MAÏTO
if present). If people still want to run on a PIC VM (why???) or old computer, then we can also maintain the HAL PIC x86 for UP. Hence there would only be 2 HALs. Best regards, Alex Ionescu On Mon, Dec 11, 2017 at 1:07 AM, Colin Finck wrote: Am 11.12.2017 um 01:18 schrieb Hermès BÉL

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
lto:ros-dev-boun...@reactos.org] De la part de Hermès > BÉLUSCA-MAÏTO > Envoyé : lundi 11 décembre 2017 02:03 > À : 'ReactOS Development List' > Objet : Re: [ros-dev] Merging our x86 HALs > > Also, there is (at least parts of) HKLM\HARDWARE tree that is built at > ins

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
ader (ntldr / winldr) also has the capability of detecting the HAL to use and load, unless being specified otherwise by a switch in the command-lines in boot.ini (ntldr) or somewhere in the BCD (bootmgr/winldr). H. > -----Message d'origine- > De : Ros-dev [mailto:ros-dev-boun

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
I personally think it's a bit "against" the philosophy of HALs, namely having a lightweight hardware abstraction layer code for different platforms. If you basically put all the HALs into one, then you obtain bloated stuff (which remains in memory for the whole life of the OS). Example: standard

[ros-dev] Question about commits with no commit log, or commits with no files but just the log, on Git.

2017-10-16 Thread Hermès BÉLUSCA - MAÏTO
‌Hello all, After having noticed https://github.com/reactos/reactos/commit/50ae5e7c5268222718174221366169e2b115b06a I am wondering whether it is possible to add mechanisms (like git pre-commit hooks) that check for, and prevent potential problematic commits like, commits without commit log, or

[ros-dev] GitHub Newbie Question

2017-10-10 Thread Hermès BÉLUSCA - MAÏTO
‌Hi all, I've a newbie question related to GitHub pull requests: How can one see whether commits pertaining to a pull request have both a valid full committer name and email set? So far I can only see the nicknames. Cheers, Hermes___ Ros-dev mailing

Re: [ros-dev] ReactOS Repository migrated to GitHub

2017-10-03 Thread Hermès BÉLUSCA-MAÏTO
Thank you very much Colin !! \o/ \o/ \o/ \o/ A little question, although: Where are our (experimental) branches now? :P Hermès > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck > Envoyé : mardi 3 octobre 2017 19:40 > À : ros-annou...@reac

Re: [ros-dev] Git Migration: The documentation, rossubsys and wallpapers directories

2017-09-08 Thread Hermès BÉLUSCA-MAÏTO
ow to just download the files without the history... (To be tested, although). H. > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Hermès > BÉLUSCA-MAÏTO > Envoyé : vendredi 8 septembre 2017 14:27 > À : 'ReactOS Development Lis

Re: [ros-dev] Git Migration: The documentation, rossubsys and wallpapers directories

2017-09-08 Thread Hermès BÉLUSCA-MAÏTO
Hi! > * Commits to "documentation" never had a relation to "reactos" commits, so > nothing is lost if we put that directory into a separate repo > "documentation.git" and remove all traces to it from the history of > "reactos.git". I'd go this way if there are no objections. > Yeah, I see that as

Re: [ros-dev] Enabling themes in 3rd stage

2017-07-31 Thread Hermès BÉLUSCA-MAÏTO
What about the « Whistler » - like theme ? ^^ H. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen Envoyé : lundi 31 juillet 2017 17:18 À : ReactOS Development List Objet : Re: [ros-dev] Enabling themes in 3rd stage I like this theme! Op 31 jul. 2017 16:44

Re: [ros-dev] Enabling themes in 3rd stage

2017-07-31 Thread Hermès BÉLUSCA-MAÏTO
Hi all, that’s good ! I would also prefer a page in 2nd-stage setup where we can choose whether we want to use “classic theme” (aka no theming), or any other theme we may have. Hermès. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de encoded Envoyé : lundi 31 juillet 2017 1

Re: [ros-dev] About the bootcd and livecd, and the 1st-stage GUI setup

2017-07-05 Thread Hermès BÉLUSCA-MAÏTO
s... -- opens a second-level menu with >- Text-mode installer > - Live boot without Ramdisk > - etc. > > > > On 4 July 2017 at 21:45, Hermès BÉLUSCA-MAÏTO wrote: > > > Hello everyone, > > > > > > > > One of the long-term pla

[ros-dev] About the bootcd and livecd, and the 1st-stage GUI setup

2017-07-04 Thread Hermès BÉLUSCA-MAÏTO
Hello everyone, One of the long-term plan for ReactOS was to have a graphical user-mode interface for the 1st-stage setup, similar to e.g. what may be found in newer versions of Windows (Vista+), as an alternative to our current 1st-stage setup in text-mode (note that I say “alternative”, not

Re: [ros-dev] "Note: LibreOffice 5.4 will be the last codeline to support Windows XP or Vista"

2017-06-29 Thread Hermès BÉLUSCA-MAÏTO
I’m wondering for which useless / fancy features they need Windows 7+ support only…. H. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Javier Agustìn Fernàndez Arroyo Envoyé : jeudi 29 juin 2017 15:48 À : ReactOS Development List Objet : [ros-dev] "Note: LibreOffice 5.

Re: [ros-dev] SVN url change?

2017-06-28 Thread Hermès BÉLUSCA-MAÏTO
: Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck Envoyé : mercredi 28 juin 2017 11:23 À : 'ReactOS Development List' Objet : Re: [ros-dev] SVN url change? Am 28.06.2017 um 04:01 schrieb Hermès BÉLUSCA-MAÏTO: > Today I noticed that our buildbots couldn’t connect to SVN to

[ros-dev] SVN url change?

2017-06-27 Thread Hermès BÉLUSCA-MAÏTO
Hello all, Today I noticed that our buildbots couldn’t connect to SVN to upload the commit changes, and therefore failed to build. Also I noticed that the usual SVN ViewVC address (which was previously https://svn.reactos.org/svn/reactos , for example) changed to https://svn.reactos.org/viewcvs

Re: [ros-dev] [ros-diffs] [hbelusca] 75008: [USETUP]: Introduce SetupDeleteFile() and SetupMoveFile() (in addition to the already-existing SetupCopyFile()) in order to implement moving / renaming exis

2017-06-12 Thread Hermès BÉLUSCA-MAÏTO
Yes, only the SetupMoveFile would need SEH2 (I took it from the kernel32 code, MoveFile(Ex) and associated Basep** function(s), which used SEH2). I agree, as it is, the SEH2 usage here is hackish (as I've redefined the SEH macros in filesup.h, because I didn't want to include SEH library in uset

Re: [ros-dev] [ros-diffs] [hbelusca] 74698: [USETUP]: Minor fixes & simplifications: - Remove a redundant NtClose call; - Return failure if NtQuerySymbolicLinkObject fails; - Use RTL_CONSTANT_STRING a

2017-05-31 Thread Hermès BÉLUSCA-MAÏTO
Hi Colin, But then, why do we have these "> * COPYRIGHT: See COPYING in the top level directory" lines in all our code headers then? Is it because COPYING is actually just the GPLv2 (which seems to be the case)? Would it then be preferable to add this in the main (or another) COPYING file

Re: [ros-dev] [ros-diffs] [hbelusca] 74621: [USETUP]: SetupLib: Add an ARC path to (and from) NT path resolver. It allows mapping between an ARC path as specified in freeldr.ini / boot.ini , to its co

2017-05-22 Thread Hermès BÉLUSCA-MAÏTO
Hi again, > isspace(0) is false so you don't need the *p check. Thanks, I was hesitating about this when I wrote this code. >> +KeyValue = wcstoul(p, (PWSTR*)&p, 10); >> +ASSERT(p); > This assert seems superfluous, you just dereferenced the pointer. Also, you > incremented it just abov

Re: [ros-dev] [ros-diffs] [hbelusca] 74619: [USETUP]: filesup module: - Add a NtPathToDiskPartComponents helper, that takes in input a fully qualified NT path to a file on hard disk, e.g.: \Device\Har

2017-05-22 Thread Hermès BÉLUSCA-MAÏTO
Hi, >> +if (_wcsnicmp(Path, L"\\Device\\Harddisk", 16) != 0) >> +{ >> +/* The NT path doesn't start with the prefix string, thus it cannot >> be a hard disk device path */ >> +DPRINT1("'%S' : Not a possible hard disk device.\n", NtPath); >> +return FALSE; >> +}

[ros-dev] A surprising epic win: Wolfram Mathematica on ReactOS

2017-05-21 Thread Hermès BÉLUSCA-MAÏTO
Hi all, I was pleasantly surprised to notice that the symbolic computation program « Wolfram Mathematica », in its version 8.0.4 (later versions are for Vista+ only), actually works quite pretty well on ReactOS (as of r74550): see the screen-capture at http://i.imgur.com/KegyW79.png . This sof

Re: [ros-dev] About the recent USETUP improvements in the branch

2017-05-21 Thread Hermès BÉLUSCA-MAÏTO
hical installer :) Am 18.05.2017 um 20:02 schrieb Hermès BÉLUSCA-MAÏTO: > P.S.: Using a 8x8 font for the installer quickly hurts the eyes (and it > has been like that since ages). It would be great to use a more readable > resolution / font size… Oh yes, I'm all for a good looking i

[ros-dev] About the recent USETUP improvements in the branch

2017-05-18 Thread Hermès BÉLUSCA-MAÏTO
Hi all, I’m writing a short mail to explain the recent USETUP improvements I’m doing in the https://svn.reactos.org/svn/reactos/branches/setup_improvements/base/setup/ branch. The aim is three-fold: - To improve multi-OSes / bootloaders detection and solve https://jira.reactos.org

Re: [ros-dev] [ros-diffs] [hbelusca] 74550: [USETUP]: Continue implementing the NT OS installation detector. What remains to be done here, besides cleaning up the code from temporary comments and DPRI

2017-05-16 Thread Hermès BÉLUSCA-MAÏTO
Thanks for your quick review, Thomas. >> +/*** >> +*wchar_t *wcsstr(string1, string2) - search for string2 in string1 >> +* (wide strings) > >Copypasta? Yes, from the CRT, where I then put in msconfig_new/stringutils.c and then copied it again there, as an implementation of search substrin

Re: [ros-dev] [ros-diffs] [hbelusca] 74550: [USETUP]: Continue implementing the NT OS installation detector. What remains to be done here, besides cleaning up the code from temporary comments and DPRI

2017-05-16 Thread Hermès BÉLUSCA-MAÏTO
Hehe yeah :D Just that since some people might complain we either break their installs / do not play "fair" with other companies products / etc... I prefer to play safe here :) -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : mardi

Re: [ros-dev] [ros-diffs] [ion] 74546: BL Library now works 100% in paging, protected mode. A picture is worth a thousand commits: http://i.imgur.com/Zx2nQ6x.jpg [BOOTLIB]: Add support for protocol op

2017-05-15 Thread Hermès BÉLUSCA-MAÏTO
What about using standard PE resources? Is it doable even in the EFI applications? Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : lundi 15 mai 2017 12:04 À : Alex Ionescu Cc : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-

Re: [ros-dev] [ros-diffs] [hbelusca] 69160: [EFISYS]: Add 'bcd_hive' as a dependency. [FATTEN]: Fix help message. Functions with no parameters are void. Remove an hardcoded array size.

2017-05-13 Thread Hermès BÉLUSCA-MAÏTO
_hive dependency. Best, Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : samedi 13 mai 2017 19:20 À : Hermès BÉLUSCA-MAÏTO Cc : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 69160: [EFISYS]: Add '

Re: [ros-dev] [ros-diffs] [hbelusca] 74528: Code simplifications.

2017-05-13 Thread Hermès BÉLUSCA-MAÏTO
Fixed in r74538. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : samedi 13 mai 2017 18:26 À : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 74528: Code simplifications. On 2017-05-13 18:13, hbelu...@svn.reactos.o

Re: [ros-dev] [ros-diffs] [hbelusca] 74493: [NTOS]: Capture the counted BaseDllName unicode string into a local NULL-terminated buffer before calling wcsrchr on it (actually I think it would be better

2017-05-07 Thread Hermès BÉLUSCA-MAÏTO
Hi! The assert is fixed (r74495). For ExAllocatePool, it would be better to change them all at once in this file. Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : dimanche 7 mai 2017 20:49 À : ros-dev@reactos.org Objet : Re:

Re: [ros-dev] [ros-diffs] [gadamopoulos] 74457: [UXTHEME] -Use GdiDrawStream in UXTHEME_DrawImageGlyph and UXTHEME_DrawImageBackground.

2017-05-03 Thread Hermès BÉLUSCA-MAÏTO
See my links in https://jira.reactos.org/browse/CORE-4420 for more details ;-) Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Peter Hater Envoyé : mercredi 3 mai 2017 20:23 À : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-diffs] [gadamopoulos]

Re: [ros-dev] Vgal USB patches

2017-04-16 Thread Hermès BÉLUSCA-MAÏTO
Hi Javier, Actually I don’t think you’ve found where these code reviews are taking place. They are here: https://code.reactos.org/cru/CR-109 https://code.reactos.org/cru/CR-110 https://code.reactos.org/cru/CR-111 and you can find there who’s currently reviewing them. By what Alexander

Re: [ros-dev] Vgal USB patches

2017-04-04 Thread Hermès BÉLUSCA-MAÏTO
4 avril 2017 18:16 À : ros-dev@reactos.org Objet : Re: [ros-dev] Vgal USB patches Am 04.04.2017 um 14:05 schrieb Hermès BÉLUSCA-MAÏTO: > Also, I confirm that, for whatever reason in VS2010, which doesn't have > inttypes.h, in its CRT headers, compilation might fail: here for me, for &

Re: [ros-dev] Vgal USB patches

2017-04-04 Thread Hermès BÉLUSCA-MAÏTO
em that he faced. He could not build proper VC bulds > after new ISO format was adopted. > https://pastebin.com/AtUqfGf9 > > 04.04.2017, 02:41, "Hermès BÉLUSCA-MAÏTO" : > > Hi ! > > A proper code review may be in order, where/how can we do that? > > > > R

Re: [ros-dev] Vgal USB patches

2017-04-03 Thread Hermès BÉLUSCA-MAÏTO
Hi ! A proper code review may be in order, where/how can we do that? Regards, Hermès BÉLUSCA - MAÏTO De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Alexander Rechitskiy Envoyé : mardi 4 avril 2017 01:18 À : ReactOS Development List Objet : [ros-dev] Vgal USB patches

Re: [ros-dev] Gsoc audio project mentor status

2017-03-30 Thread Hermès BÉLUSCA-MAÏTO
caches, etc…). This should be looked more carefully. Properly unloading registry hives is needed to implement e.g. user log-off (the corresponding user registry hive, so-called “user profile”, has to be unloaded at logoff; we currently have a “hack”, so to say, to make it work). Regards, He

Re: [ros-dev] Gsoc audio project mentor status

2017-03-29 Thread Hermès BÉLUSCA-MAÏTO
. Best, Hermès BÉLUSCA - MAÏTO De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pranay Pratyush Envoyé : mercredi 29 mars 2017 22:23 À : ReactOS Development List Objet : [ros-dev] Gsoc audio project mentor status Hi there, I am under the impression that no mentor can be

Re: [ros-dev] Opening up #reactos-dev to the public

2017-03-24 Thread Hermès BÉLUSCA-MAÏTO
I don’t approve the idea. The fact is that if the devs quit originally #reactos, it’s because it was generally too noisy, etc… . If we remove the moderation irc bit in #reactos-dev, you may expect the same phenomenon to occur in #reactos-dev too. De : Ros-dev [mailto:ros-dev-boun...@reactos.

Re: [ros-dev] [ros-diffs] [khornicek] 74209: [RAPPS] - Add a custom build of the Mesa 3D Graphics Library. This build contains mesa, gallium and llvmpipe. It provides an enormous performance boost ove

2017-03-20 Thread Hermès BÉLUSCA-MAÏTO
And another reason to make our SVN source tree structure modularized. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck Envoyé : lundi 20 mars 2017 23:05 À : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-diffs] [khornicek] 74209: [RAPPS] - Add

Re: [ros-dev] New ideas added to GSoC Ideas list

2017-03-16 Thread Hermès BÉLUSCA-MAÏTO
To be the most accurate, WoW16 is an addition to NTVDM. NTVDM alone provides 16-bit emulation plus DOS support. WoW16 adds on top of that, Win 3.1 support (which is also 16-bit). WoW16 is implemented using wow32.dll (the 32-bit part that interfaces directly with NTVDM), wowexec.exe (the correspo

Re: [ros-dev] New ideas added to GSoC Ideas list

2017-03-14 Thread Hermès BÉLUSCA-MAÏTO
I’m sorry but I should remind you that we *already* have *MANY* apps & dlls (not from Wine) where dialog layouts are already different for different locales, examples being for French and German languages (amongst others) where having adapted sizes for buttons, static text controls, … are mandat

Re: [ros-dev] New ideas added to GSoC Ideas list

2017-03-12 Thread Hermès BÉLUSCA-MAÏTO
Victor thought also about adding registry hive healing. Hermès. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck Envoyé : dimanche 12 mars 2017 17:27 À : 'ReactOS Development List' Objet : [ros-dev] New ideas added to GSoC Ideas list Hi all!

Re: [ros-dev] [ros-diffs] [hbelusca] 74068: [WS2_32] - Fix pointers verification in WSALookupServiceNextW and WSALookupServiceNextA; - In WSALookupServiceNextA: Perform extra checks to see whether we

2017-03-05 Thread Hermès BÉLUSCA-MAÏTO
Hi, thanks for your comments. The rest of the ws2_32 code continues to use Set/GetLastError even for dealing with the WSA* error codes, and the WSASet/GetLastError just call back the normal functions, so I would just keep using GetLastError here. Hermès -Message d'origine- De : Ros-dev

Re: [ros-dev] [ros-diffs] [hbelusca] 73895: [NTGDI]: Few fixes & hacks for NtGdiGetGlyphIndicesW, see CORE-12825: - (Fix) Check for integer count overflow (per Thomas suggestion), - (Hack#1) Signal th

2017-03-02 Thread Hermès BÉLUSCA-MAÏTO
Hi, I completely agree, and that's why I put in comment that INT_MIN stuff. Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Neo Love Envoyé : vendredi 3 mars 2017 01:26 À : ReactOS Development List Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 738

Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS

2017-02-22 Thread Hermès BÉLUSCA-MAÏTO
Hi ! Thanks for the notification James. To answer Giannis’ question, I was asking the status because I did a ~= 2 hour long testing in “real-life” conditions of Word yesterday to see how many bugs (visual or not) were existing. I’ve mainly played with different tools in the ribbon bar, modifie

Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS

2017-02-21 Thread Hermès BÉLUSCA-MAÏTO
Hi all, Before touching parts of win32ss (user32/gdi32/win32k) I would like to know what the status of different components are: - James, have you finished with your win32 class rewrite? What’s the status of it? Is there a bug report concerning this rewrite? - Does anybody e

Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS

2017-02-21 Thread Hermès BÉLUSCA-MAÏTO
...) 2010 on ReactOS May be it is better to temporarily add Samba itself to ReactOS? It is not that simple to install it for average user. I suggest add it at least as downloadable module, the same way we do with gecko 21.02.2017, 05:11, "Hermès BÉLUSCA-MAÏTO" : He recently (sin

Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS

2017-02-20 Thread Hermès BÉLUSCA-MAÏTO
actively working on NTLM? I thought that branch of his was pretty old. Might be something to consider a dev contract for. On Mon, Feb 20, 2017 at 7:59 PM, Hermès BÉLUSCA-MAÏTO wrote: Hello everyone, Today I was finally able to finish the installation of Office 2010 in ReactOS, using as a

[ros-dev] Office (Excel, Word...) 2010 on ReactOS

2017-02-20 Thread Hermès BÉLUSCA-MAÏTO
Hello everyone, Today I was finally able to finish the installation of Office 2010 in ReactOS, using as a temporary measure the Wine’s NTLM layer that calls into the ntlm_auth utility of Samba. This was done while Samuel is completing his NTLM implementation. As this wine layer is here running on

Re: [ros-dev] Microsoft switched to Git

2017-02-16 Thread Hermès BÉLUSCA-MAÏTO
Hi ! Here are some thoughts as an answer to Ziliang's mail: > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Zachary Gorden > Envoyé : jeudi 16 février 2017 23:03 > À : ReactOS Development List > Objet : Re: [ros-dev] Microsoft switched to Git > The fact that git has problems mai

Re: [ros-dev] JIRA/FishEye upgrade this weekend

2017-02-16 Thread Hermès BÉLUSCA-MAÏTO
Hi Colin, thank you for your feedback! Does this imply also rebuilding (and perhaps re-indexing again?) the FishEye cache? Best, Hermès. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck Envoyé : jeudi 16 février 2017 17:49 À : 'ReactOS Devel

Re: [ros-dev] Microsoft switched to Git

2017-02-15 Thread Hermès BÉLUSCA-MAÏTO
Because a « working solution » does not mean it is still optimal / efficient… De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Javier Agustìn Fernàndez Arroyo Envoyé : mercredi 15 février 2017 16:04 À : ReactOS Development List Objet : Re: [ros-dev] Microsoft switched to Git

Re: [ros-dev] Bootlogos for FOSDEM (was: "RE: FOSDEM 2017 - It's happening!")

2017-01-30 Thread Hermès BÉLUSCA-MAÏTO
Hi ! After this successful poll, the winner bootlogo is without doubt the (d) version :-) I have committed it here : https://svn.reactos.org/svn/reactos?view=revision &revision=73639 This is the file “1.bmp”. As the bootlo

Re: [ros-dev] FOSDEM 2017 - It's happening!

2017-01-25 Thread Hermès BÉLUSCA-MAÏTO
Hello all! Since this message is sent to the public mailing list, let me mention which programs I have in top of my head, that would be nice to have for the show (most of them are already in rapps, but it would be nice to retest them just to be sure ...) : - Foxit PDF Reader, - Notepad++ (6.9,

[ros-dev] Tr: Re: Ros-diffs Digest, Vol 150, Issue 29

2016-07-03 Thread Hermès BÉLUSCA - MAÏTO
Hi Eric, are you sure this will not break compatibility with WIn2k3 applications? For example by quickly googling I've noticed some people rely on this Index value for their Time Zone stuff. Example: https://www.experts-exchange.com/questions/24948382/How-to-get-Time-Zone-index-from-registry-i

[ros-dev] Spam attack, continuing... (episode 12345/infinity)

2016-05-04 Thread Hermès BÉLUSCA - MAÏTO
So, guys, ... We are yet again subject to a spam attack on the forums AND in the wiki (since yesterday for the latter), but nothing was done yet  !! https://reactos.org/forum/ https://reactos.org/wiki/Special:RecentChanges For the wiki, the abuse filter hasn't blocked everything !! Regards, He

Re: [ros-dev] Status Meeting (March 2016)

2016-03-30 Thread Hermès BÉLUSCA - MAÏTO
The point of using our own server is to be able to have our über-top-secret (xDD) meetings there, and be able to automatically log the stuff so that you can see it on some dedicated xxx.reactos.org server, the address of which I don't remember now on top of my head. Plus other features, maybe, that

[ros-dev] Spam, the irony

2016-03-26 Thread Hermès BÉLUSCA - MAÏTO
Hi all, I guess this post is spam : http://www.reactos.org/forum/viewtopic.php?f=2 &t=9752#p120604 Ironically placed inside the thread titled “Spam Bot Detection Guidelines” ^^ Cheers, Hermès. ___

Re: [ros-dev] Problems with debug log

2016-03-22 Thread Hermès BÉLUSCA - MAÏTO
MSVC builds use WinDBG, that is, the debugger is part in windbg, and part in the kernel, and they communicate through data packets that goes through some communication channel, for example the serial port. The same thing happens if you try to debug a debug-build version of the Windows kernel. By

Re: [ros-dev] Ros-diffs Digest, Vol 146, Issue 58

2016-03-19 Thread Hermès BÉLUSCA - MAÏTO
This is indeed an amazing feature, until you notice that you've tested already local build compilation (just before committing) and neither GCC nor MSVC detected any error, and only after commit you see that it breaks the build bots... Hermès. -Message d'origine- Date: Thu, 17 Mar 2016 07

[ros-dev] TR: ReactOs newbie. Help to get started with bug fixes.

2016-03-15 Thread Hermès BÉLUSCA - MAÏTO
, depending on your familiarity with one or any other proposals, or bring your own proposal (read also https://www.reactos.org/wiki/Google_Summer_of_Code_2016 for more details). Regards, Hermès BÉLUSCA - MAÏTO De : Rama Teja G [mailto:ramatej...@gmail.com] Envoyé : mardi 15 mars 2016

Re: [ros-dev] Build Crash Revision 70918

2016-03-05 Thread Hermès BÉLUSCA - MAÏTO
If I remember correctly, in pure VS C/C++ projects using precompiled headers (ie. with stdafx.h/stdafx.c (or cpp) ), when using #pragma once in stdafx.h, the compiler doesn’t fail. That’s why I’m surprised of seeing that problem with ROS. Hermès De : Ros-dev [mailto:ros-dev-boun...@reactos

Re: [ros-dev] Build Crash Revision 70918

2016-03-05 Thread Hermès BÉLUSCA - MAÏTO
Hi Amine, why haven't the build bots complained about the #pragma once? (and the more fundamental question: why does the #pragma once make compilation fail for *some* people?) Hermès. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Amine Khaldi Envoyé :

Re: [ros-dev] [ros-diffs] [hbelusca] 70869: [AUTOCHK][CHKDSK]: Minor fixes / formatting. Really add chkdsk to build. [FMIFS]: Quickly implement the chkdsk function, the same way as it is done for the

2016-03-03 Thread Hermès BÉLUSCA - MAÏTO
I wanted to add a proper '?' switch, but I've seen that if I do that, chkdsk in its current implementation runs afterwards a check (I noticed that after the commit that added the '?'). So I temporarily disabled it in this commit for further investigation (aka. modifying the ProcessCommandLine proce

[ros-dev] TR: [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Hermès BÉLUSCA - MAÏTO
(Message resent because the other one was automatically rejected because it was too large). -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Hermès BÉLUSCA - MAÏTO Envoyé : mercredi 2 mars 2016 10:14 À : 'ReactOS Development List' Objet

Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Hermès BÉLUSCA - MAÏTO
Thanks Pierre for your ideas. I will modify the message box to try to integrate those options. At the moment we are (in usetup) limited, so repairing the errors will be done later. The rest can be implemented easily. The fact is that the only error that happens as soon as you write files using R

[ros-dev] ReactOS SVN version naming

2016-02-29 Thread Hermès BÉLUSCA - MAÏTO
Hi guys, I would like to understand what’s the rationale behind changing the ReactOS trunk version from “0.4-SVN” to “0.5-SVN” (see revision 70818) whereas we have just started to release ROS 0.4.0 only? Thanks in advance for your explanations! Cheers, Hermès.

[ros-dev] About ReactOS "perception" by people

2016-02-17 Thread Hermès BÉLUSCA - MAÏTO
Hi all ! Please have a look at http://www.reactos.org/forum/viewtopic.php?f=2 &t=14713 , I think these two posts (at the time of writing this mail) show/remind few points about ReactOS that need to be more emphased/better explained in our web

Re: [ros-dev] [ros-diffs] [hbelusca] 70713: [WIN32SS] - Fix orthograph - Mention in the code that some stuff are hacks & need to be fixed. - Add parentheses around bit checks.

2016-02-13 Thread Hermès BÉLUSCA - MAÏTO
OK not a hack, but something that needs to be fixed asap. (btw you can see the problem when you have an app running and you kill explorer so that you don’t have any taskbar remaining. Now minimize your app à it completely disappear). H. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la

Re: [ros-dev] [ros-diffs] [hbelusca] 70707: [CMLIB]: Implement CmpFreeSecurityDescriptor. See r70609. CORE-10793 CORE-10796

2016-02-10 Thread Hermès BÉLUSCA - MAÏTO
Yes: When the key is initialized and a security block is added ,the refcount is set to 1 (see e.g. https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/tools/mkhive/cmi.c;h b=HEAD#l173 ), and then, it is increased when other keys use this security block and decreased when other keys are deleted

Re: [ros-dev] [ros-diffs] [hbelusca] 70674: [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" ti

2016-02-02 Thread Hermès BÉLUSCA - MAÏTO
I will have a look at this function when I'll have time. Regards, Hermès -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Alex Ionescu Envoyé : mardi 2 février 2016 06:38 À : ReactOS Development List Cc : Linda Wang Objet : Re: [ros-dev] [ros-diffs] [hbe

Re: [ros-dev] [ros-diffs] [cfinck] 70507: [BOOTVID] Change the Blue Screen Font hardcoded into bootvid.dll to the Open Source "Anonymous Pro" font, which makes a nice 8x13 font. Blue Screens now look

2016-01-07 Thread Hermès BÉLUSCA - MAÏTO
Hi ! It seems that your web-browser (as well as the Windows image preview, usually), likes to smooth the images, and this is what happens, indeed, and I agree this is quite problematic if e.g. you want to zoom on small portions of the images. Also, we also use now the Plan-9 font in the latest tru

Re: [ros-dev] [ros-diffs] [gedmurphy] 70408: [NTOSKRNL] - Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing - Don't hardcode the pointer size when checking the buffer s

2015-12-30 Thread Hermès BÉLUSCA - MAÏTO
it correctly now. -Message d'origine- De : Hermès BÉLUSCA - MAÏTO [mailto:hermes.belu...@sfr.fr] Envoyé : mercredi 30 décembre 2015 11:16 À : 'ReactOS Development List' Objet : RE: [ros-dev] [ros-diffs] [gedmurphy] 70408: [NTOSKRNL] - Raise the IRQL when enumerating dev

Re: [ros-dev] [ros-diffs] [gedmurphy] 70408: [NTOSKRNL] - Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing - Don't hardcode the pointer size when checking the buffer s

2015-12-30 Thread Hermès BÉLUSCA - MAÏTO
t; mentioned. > > I'm happy to use the spinlock (and would prefer to myself), but any > move towards NT6 normally results in an angry email, so I opted for > the 2k3 approach ;) > > Ged. > > > -----Original Message- > From: Ros-dev [mailto:ros-dev-b

Re: [ros-dev] [ros-diffs] [gedmurphy] 70408: [NTOSKRNL] - Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing - Don't hardcode the pointer size when checking the buffer s

2015-12-29 Thread Hermès BÉLUSCA - MAÏTO
Yes this should be a spinlock involved instead, for example the "LockQueueIoDatabaseLock" (queued) spinlock that we already use in other places in the code. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : mardi 29 décembre 2015 13:2

Re: [ros-dev] Something is wron again with getbuilds

2015-12-16 Thread Hermès BÉLUSCA - MAÏTO
Nothing seems wrong so far... De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Alexander Rechitskiy Envoyé : mercredi 16 décembre 2015 19:54 À : ReactOS Development List Objet : [ros-dev] Something is wron again with getbuilds Hi! htt

Re: [ros-dev] kbswitch update

2015-12-07 Thread Hermès BÉLUSCA - MAÏTO
Hi, my question is inline the previous mail. -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck Envoyé : lundi 7 décembre 2015 04:48 À : ros-dev@reactos.org Objet : Re: [ros-dev] kbswitch update > A proper per-application keyboard layout switch

  1   2   3   >