[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

> *One such functionality is to add component labels (aka "c:" labels) automatically by analyzing what part of sage codebase the PR branch touches.* This is #37373 . Temporarily this has been part of #37262

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I agree with what Vincent said in the other thread. Thus for decision (A1), we just turn the script off so that we could revive it in future for some other useful functionality. One such functionality is to add component labels (aka "c:" labels) automatically by analyzing what part of sage cod

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

Here a development infrastructure feature was designed and implemented by a new contributor. This rare engagement with the development infrastructure of the project is something that our community should welcome and encourage The feature was introduced through the normal process. At lease th

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Thursday, June 13, 2024 at 11:46:59 PM UTC-7 seb@gmail.com wrote: I think that regardless of questions about governance models, we should take objections from community members seriously if they find something annoying. Of course. Open source projects stand and fall with participation.

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I think that regardless of questions about governance models, we should take objections from community members seriously if they find something annoying. So why not offer them the possibility to set preferences for extensions to tools we have implemented ourselves? This has no impact on the goa

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

The vote is now https://groups.google.com/g/sage-devel/c/3PLZD-4UFIA/m/bRgiaa11AQAJ Although, again, the original adding of labels should have also had a vote... On Wednesday, June 12, 2024 at 11:05:16 AM UTC+9 Kwankyu Lee wrote: You may want to take a second look. This article does not presc

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

You may want to take a second look. This article does not prescribe one governance model. It describes several governance models. After reading it, a more informed discussion will be possible among those who care about questions of governance. Indeed, the article offers some useful terms. O

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Wednesday, May 15, 2024 at 1:47:48 AM UTC-7 Travis Scrimshaw wrote: On Tuesday, May 14, 2024 at 9:48:32 AM UTC+9 Matthias Koeppe wrote: Perhaps a good reference: https://www.redhat.com/en/blog/understanding-open-source-governance-models That's not relevant to how we do things. You could arg

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

Or instead you have a whitelist for those that want it. I think at least one of these changes (whitelist or blacklist) should just be done in the same general way that these labels were introduced: no vote and just do it. This really should have had a vote, or at least a notification on sage-de

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

*> How about having a voting for this issue? * Another possibility would be to have a blacklist (but I don't know where) that developers can sign up to if they want to be excluded from automations that apply to PRs. In this thread's example, a developer would exclude PRs that he himself author

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

*> (Note that only members of the Triage team can set the "needs review" label.)* See this comment in #35927 for a suggestion to solve this. Matthias Koeppe schrieb am Dienstag, 28. Mai 2024 um 21:35:26 UTC+2: > I'll ex

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Tuesday, May 28, 2024 at 12:19:42 PM UTC-7 Matthias Koeppe wrote: On Tuesday, May 28, 2024 at 1:24:17 AM UTC-7 Travis Scrimshaw wrote: Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 Thanks, I've let the author know in https://github.c

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I'll expand a little bit, in the hope to stimulate a constructive discussion. (A previous related thread: https://groups.google.com/g/sage-devel/c/sulCa-6EZRA/m/86jFAw9NAAAJ) There is a very serious, project-level concern: Is our project welcoming to new contributors? We tell contributors to g

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Tuesday, May 28, 2024 at 1:24:17 AM UTC-7 Travis Scrimshaw wrote: Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 Thanks, I've let the author know in https://github.com/sagemath/sage/pull/37262#issuecomment-2135699139 -- You receive

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I *very* strongly believe we should disable this automatically being added to PRs. How about having a voting for this issue? -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, s

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 I *very* strongly believe we should disable this automatically being added to PRs. Travis On Friday, May 10, 2024 at 3:21:57 PM UTC+9 seb@gmail.com wrote: > I must confess that I have no

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Friday, May 10, 2024 at 7:01:43 AM UTC-7 Dima Pasechnik wrote: It's also discouraging word, "minimal" I'm also not happy about the word "minimal", but simply because it's too close to "minor", which appears in priority labels. -- You received this message because you are subscribed to the

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Tuesday, May 14, 2024 at 9:48:32 AM UTC+9 Matthias Koeppe wrote: On Sunday, May 12, 2024 at 6:50:05 PM UTC-7 Travis Scrimshaw wrote: That model is not how we have worked as a community, nor do I think it is a productive way to run a smaller developer community such as ours. I'm not sure w

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Tue, May 14, 2024 at 1:48 AM Matthias Koeppe wrote: > > On Sunday, May 12, 2024 at 6:50:05 PM UTC-7 Travis Scrimshaw wrote: > > That model is not how we have worked as a community, nor do I think it is a > productive way to run a smaller developer community such as ours. > > > I'm not sure wha

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On Sunday, May 12, 2024 at 6:50:05 PM UTC-7 Travis Scrimshaw wrote: That model is not how we have worked as a community, nor do I think it is a productive way to run a smaller developer community such as ours. I'm not sure what your reference point may be for this description, but in my experi

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

That model is not how we have worked as a community, nor do I think it is a productive way to run a smaller developer community such as ours. Doing things that way gives me a "all animals are equal, but some animals are more equal than others" feeling. If you want to deploy things quickly, make

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

FWIW, I suggested to implement this feature in https://github.com/sagemath/sage/issues/37254; I'm thankful to Aman Moon for implementing this feature and Sebastian Oehms for his help with it. Obviously a metric such as the number of lines of changes is only a one-dimensional way to express the

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

On 9 May 2024 22:46:17 BST, Travis Scrimshaw wrote: >I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor >they serve no useful purpose as far as I can tell. To this point, they do >not reflect the difficulty of a review; in fact, they are at best >counterproductive to

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I must confess that I have not thought about the aspects of these labels that Travis points out, but I fully understand these concerns. If they are annoying for many developers, the feature can be easily disabled by removing corresponding variables from the repository. Vincent Delecroix schrie

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I fully agree with Travis. I do not see the added value of these additional tags. On Thu, 9 May 2024 at 23:46, Travis Scrimshaw wrote: > > I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor > they serve no useful purpose as far as I can tell. To this point, they do not

[sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor they serve no useful purpose as far as I can tell. To this point, they do not reflect the difficulty of a review; in fact, they are at best counterproductive to finding reviewers because it might deter people from revie