Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-22 Thread Anthony Scarpino
On Thu, 8 Oct 2020 00:13:37 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 939: >> >>> 937: // if the size of specified output buffer is less than >>> 938: // the length of the cipher text, then the current >>> 939

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-22 Thread Anthony Scarpino
On Fri, 9 Oct 2020 02:38:05 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 614: > >> 61

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-22 Thread Anthony Scarpino
On Mon, 12 Oct 2020 17:35:48 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 146: > >> 144: private

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-22 Thread Anthony Scarpino
On Mon, 12 Oct 2020 18:26:14 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 165: > >> 163: } >> 164

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-22 Thread Anthony Scarpino
On Mon, 12 Oct 2020 18:45:28 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 237: > >> 235:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-12 Thread Valerie Peng
On Thu, 8 Oct 2020 01:22:09 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 744: >> >>> 742: } else { >>> 743: return core.doFinal(input, output); >>> 744: } >> >> It seems this block is

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-12 Thread Valerie Peng
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-12 Thread Valerie Peng
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 03:58:38 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 621: > >> 61

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 00:48:42 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 550: > >> 54

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 03:20:40 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 635: > >> 63

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 01:01:47 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 595: > >> 59

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 01:04:26 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 593: > >> 59

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Valerie Peng
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Fri, 9 Oct 2020 00:42:57 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 545: > >> 54

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Valerie Peng
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Thu, 8 Oct 2020 01:08:44 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 658: >> >>> 656: BadPaddingException { >>> 657: return bufferCrypt(input, output, false); >>> 658: } >> >> Is the override of this method f

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Valerie Peng
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Thu, 8 Oct 2020 03:21:46 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 528: > >> 52

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Wed, 7 Oct 2020 20:56:28 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 1258: > >> 1256:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Wed, 7 Oct 2020 20:56:06 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 1253: > >> 1251:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-08 Thread Anthony Scarpino
On Wed, 7 Oct 2020 20:34:21 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 816: > >> 814: } >

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Anthony Scarpino
On Wed, 7 Oct 2020 19:42:11 GMT, Valerie Peng wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 664: >> >>> 662: * engineUpdate() and engineDoFinal(). >>> 663: */ >>> 664: private int bufferCrypt(ByteBuffer input, ByteBuffer output, >> >> It looks l

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Valerie Peng
On Thu, 8 Oct 2020 03:21:46 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Xuelei comments src/java.base/share/classes/com/sun/crypto/pr

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Anthony Scarpino
On Wed, 7 Oct 2020 16:29:32 GMT, Xue-Lei Andrew Fan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 947: > >> 945:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Valerie Peng
On Wed, 7 Oct 2020 16:17:38 GMT, Xue-Lei Andrew Fan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 664: > >> 662:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Anthony Scarpino
On Wed, 7 Oct 2020 22:38:21 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 939: > >> 937:

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

2020-10-07 Thread Anthony Scarpino
> 8253821: Improve ByteBuffer performance with GCM Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision: Xuelei comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/411/files - new: https://git.openjdk.java