Re: RFR: 8252842: Extend jmap to support parallel heap dump [v15]

2021-03-10 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: code clean - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files - new: https://git.openjdk.java.net/jdk/p

Re: RFR: 8259070: Add jcmd option to dump CDS [v3]

2021-03-10 Thread Yumin Qi
On Wed, 10 Mar 2021 04:18:29 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix white space in CDS.java > > src/hotspot/share/services/diagnosticCommand.cpp line 1124: > >> 1122: } >> 1123: Symbol* c

Re: RFR: 8259070: Add jcmd option to dump CDS [v4]

2021-03-10 Thread Yumin Qi
> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-10 Thread Chris Plummer
On Thu, 11 Mar 2021 00:20:35 GMT, Yasumasa Suenaga wrote: >> Most of subcommands in jhsdb supports to connect to debug server via >> `--connect` command line option, however `hsdb` and `clhsdb` do not accept >> it. >> >> Both HSDB and CLHSDB support to connect to debug server, so they should h

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-10 Thread Yasumasa Suenaga
On Thu, 11 Mar 2021 00:33:46 GMT, Chris Plummer wrote: > Yes, I understood that part. I just wanted to make sure, for example, that we > weren't previously supporting something like attach in clhsdb, and > that would be impacted by this, but I'm pretty sure clhsdb already prevents > doing tha

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-10 Thread Chris Plummer
On Thu, 11 Mar 2021 00:08:55 GMT, Yasumasa Suenaga wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CLHSDB.java line 157: >> >>> 155: } catch (NumberFormatException e) { >>> 156: // Attempt to connect to remote debug server >>> 157: debugS

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-10 Thread Yasumasa Suenaga
> Most of subcommands in jhsdb supports to connect to debug server via > `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. > > Both HSDB and CLHSDB support to connect to debug server, so they should have > capability to do it via command line option. > > I also file

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-10 Thread Yasumasa Suenaga
On Wed, 10 Mar 2021 21:46:50 GMT, Chris Plummer wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update testcase name > > test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbAttachToDebugServerWithCommandLine.ja

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb

2021-03-10 Thread Yasumasa Suenaga
On Wed, 10 Mar 2021 21:32:44 GMT, Chris Plummer wrote: >> Most of subcommands in jhsdb supports to connect to debug server via >> `--connect` command line option, however `hsdb` and `clhsdb` do not accept >> it. >> >> Both HSDB and CLHSDB support to connect to debug server, so they should have

Re: RFR: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"

2021-03-10 Thread Chris Plummer
On Wed, 10 Mar 2021 23:12:47 GMT, Alex Menkov wrote: > The fix updates the test to skip ThreadStartEvent/ThreadDeathEvent from other > threads test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIBase.java line 171: > 169: // Waiting for ThreadStart and ThreadDeath event we can get events > fro

RFR: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"

2021-03-10 Thread Alex Menkov
The fix updates the test to skip ThreadStartEvent/ThreadDeathEvent from other threads - Commit messages: - skip system thread start/death Changes: https://git.openjdk.java.net/jdk/pull/2927/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2927&range=00 Issue: https://

Integrated: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code

2021-03-10 Thread David Holmes
On Wed, 3 Mar 2021 05:15:48 GMT, David Holmes wrote: > ObjectMonitors can only be used by JavaThreads (modulo some interactions with > hashcodes and deflation) but we use "Thread*" almost everywhere mainly due to > use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685 is done). >

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb

2021-03-10 Thread Chris Plummer
On Wed, 10 Mar 2021 08:29:37 GMT, Yasumasa Suenaga wrote: > Most of subcommands in jhsdb supports to connect to debug server via > `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. > > Both HSDB and CLHSDB support to connect to debug server, so they should have > c

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb

2021-03-10 Thread Chris Plummer
On Wed, 10 Mar 2021 08:29:37 GMT, Yasumasa Suenaga wrote: > Most of subcommands in jhsdb supports to connect to debug server via > `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. > > Both HSDB and CLHSDB support to connect to debug server, so they should have > c

RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI

2021-03-10 Thread Daniel D . Daugherty
Add three tests from JDK-4413752 ported to JVM/TI: - RawMonitorEnter() with SuspendThread() - test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java - test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/libSuspendWithRawMonitorEnter.

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI

2021-03-10 Thread Daniel D . Daugherty
On Tue, 9 Mar 2021 21:08:54 GMT, Daniel D. Daugherty wrote: > Add three tests from JDK-4413752 ported to JVM/TI: > > - RawMonitorEnter() with SuspendThread() > - > test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java > - > test/hotspot/jtreg/se

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v10]

2021-03-10 Thread Lin Zang
On Tue, 23 Feb 2021 08:51:15 GMT, Ralf Schmelter wrote: >> Dear @plummercj, >> >> I have reconsidered the solution of “dumpheapext”, IMHO maybe the name is >> too specific, for example, if in future there is more arguments for >> `-histo`, we have to made another command called "inspectheapex

RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb

2021-03-10 Thread Yasumasa Suenaga
Most of subcommands in jhsdb supports to connect to debug server via `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. Both HSDB and CLHSDB support to connect to debug server, so they should have capability to do it via command line option. I also filed [CSR for thi

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v14]

2021-03-10 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: fix trailing white space issue - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files - new: https://git.op

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v13]

2021-03-10 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: reduce memory consumption and fix memory leak issue - Changes: - all: https://git.openjdk.java.net/jdk/pull/2261/files