Re: RFR: 8149790: NegativeArraySizeException with hprof

Hi, Could I get a Reviewer to take a look at this please? - Andreas On 2016-04-21 19:35, Andreas Eriksson wrote: On 2016-04-21 18:46, Erik Gahlin wrote: On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do

Re: RFR: 8149790: NegativeArraySizeException with hprof

On 2016-04-21 18:46, Erik Gahlin wrote: On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do you really need curly braces in the switch clauses? In JavaValueArray.java they were needed before my change but not

Re: RFR: 8149790: NegativeArraySizeException with hprof

'value' variable is a different type in each clause, I could refactor so that I could remove the curly braces, but I don't think it is worth the effort. - Andreas Erik On 2016-04-15 16:40, Andreas Eriksson wrote: Hi, Please review this test fix for 8149790: NegativeArraySize

RFR: 8149790: NegativeArraySizeException with hprof

Hi, Please review this test fix for 8149790: NegativeArraySizeException with hprof https://bugs.openjdk.java.net/browse/JDK-8149790 http://cr.openjdk.java.net/~aeriksso/8149790/webrev.00/ Changes are to the hprof verifier, which now will pass heap dump content around as JavaThing arrays inst

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Thanks Staffan! - Andreas On 2016-04-15 13:00, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 12 apr. 2016, at 18:05, Andreas Eriksson mailto:andreas.eriks...@oracle.com>> wrote: Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: A

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Thanks Serguei! - Andreas On 2016-04-12 20:57, serguei.spit...@oracle.com wrote: Hi Andreas, The fix looks good. Thanks, Serguei On 4/12/16 09:05, Andreas Eriksson wrote: Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Thanks Dmitry! - Andreas On 2016-04-12 18:07, Dmitry Samersoff wrote: Andreas, Looks good for me! -Dmitry On 2016-04-12 19:05, Andreas Eriksson wrote: Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump Bug

[8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump Bug: https://bugs.openjdk.java.net/browse/JDK-8153641 Webrev: http://cr.openjdk.java.net/~aeriksso/8153641/webrev.00/ The crash is because changes I did in JDK-81

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

being treated differently in HotSpot, but I don't remember the exact details... What was weird is that it only failed sometimes. I'll take a look tomorrow to see if I can find out why, but I probably wont spend too much time on it. Thanks, Andreas On 3/3/16 10:05 AM, Andreas Eri

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

03-03 17:05, Andreas Eriksson wrote: Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https://bugs.openjdk.java.net/browse/JDK-8151064 Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ Still not sure why it only

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

Thanks. - Andreas On 2016-03-03 15:35, Dmitry Samersoff wrote: Andreas, Looks good for me. -Dmitry On 2016-03-03 17:05, Andreas Eriksson wrote: Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https

RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https://bugs.openjdk.java.net/browse/JDK-8151064 Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ Still not sure why it only fails sometimes, but after this change th

Re: RFR (XS): 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

Thanks Dmitry. - Andreas On 2016-03-02 19:26, Dmitry Samersoff wrote: Looks good for me! On 2016-03-02 19:56, Andreas Eriksson wrote: Hi, Can I please have a review for this small test fix. Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF

Re: RFR (XS): 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

Hi, On 2016-03-02 19:10, Daniel D. Daugherty wrote: On 3/2/16 9:56 AM, Andreas Eriksson wrote: Hi, Can I please have a review for this small test fix. Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format https

RFR (XS): 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

Hi, Can I please have a review for this small test fix. Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format https://bugs.openjdk.java.net/browse/JDK-8150986 Webrev: http://cr.openjdk.java.net/~aeriksso/8150986/webr

Re: RFR: 8149743: JVM crash after debugger hotswap with lambdas

On 2016-02-23 16:54, Coleen Phillimore wrote: On 2/23/16 10:47 AM, Andreas Eriksson wrote: On 2016-02-23 10:22, Andreas Eriksson wrote: On 2016-02-23 00:53, Coleen Phillimore wrote: On 2/22/16 6:46 PM, Daniel D. Daugherty wrote: Just noticed that this thread did not include the

Re: RFR: 8149743: JVM crash after debugger hotswap with lambdas

On 2016-02-23 10:22, Andreas Eriksson wrote: On 2016-02-23 00:53, Coleen Phillimore wrote: On 2/22/16 6:46 PM, Daniel D. Daugherty wrote: Just noticed that this thread did not include the Serviceability aliases... JVM/TI belongs to the Serviceability team so... Dan On 2/22/16 4:44 PM

Re: RFR: 8149743: JVM crash after debugger hotswap with lambdas

tspot only test, but I'm not sure how to reproduce this without using jdb. - Andreas Thanks, Coleen Dan I linked an old bug to this, can you see if they are the same? Thanks, Coleen On 2/18/16 11:11 AM, Andreas Eriksson wrote: Hi, Please review this fix for JDK-8149743: JVM cras

Re: RFR: 8149743: JVM crash after debugger hotswap with lambdas

Thanks, Serguei Dan I linked an old bug to this, can you see if they are the same? Thanks, Coleen On 2/18/16 11:11 AM, Andreas Eriksson wrote: Hi, Please review this fix for JDK-8149743: JVM crash after debugger hotswap with lambdas https://bugs.openjdk.java.net/browse/

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

Thanks. On 2016-02-22 08:45, Dmitry Samersoff wrote: Andreas, 56 header 1.0.2 only now Besides that - Looks good for me! -Dmitry On 2016-02-16 16:55, Andreas Eriksson wrote: Hi, New webrev with support for non-segmented dumps removed: http://cr.openjdk.java.net/~aeriksso/8144732/webrev.01

Re: Fwd: Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Hi, Anyone with 8u Reviewer status who can take a look? - Andreas On 2016-02-10 19:01, Andreas Eriksson wrote: [Adding jdk8u-dev list] Hi, I believe I need an 8u Reviewer as well, since Dmitry is only committer for 8u? Could someone please take a look? This is type cleanup for dumping a

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

wrote: Andreas, On 2016-02-08 17:18, Andreas Eriksson wrote: Hi, On 2016-02-08 13:28, Dmitry Samersoff wrote: Andreas, Sorry for delay. Code changes looks good for me. But behavior of non-segmented dump is not clean for me (1074, if dump is not segmented than the size of the dump is always

Fwd: Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Wed, 10 Feb 2016 20:38:21 +0300 From: Dmitry Samersoff To: Andreas Eriksson , serviceability-dev@openjdk.java.net Andreas, Looks good for me! -Dmitry On 2016-01-28 20:36, Andreas Eriksson wrote: Hi, Please review this backport of JDK-8129419 <https://bugs.openjdk.java.net/browse/JDK-8

Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Thanks! - Andreas On 2016-02-10 18:38, Dmitry Samersoff wrote: Andreas, Looks good for me! -Dmitry On 2016-01-28 20:36, Andreas Eriksson wrote: Hi, Please review this backport of JDK-8129419 <https://bugs.openjdk.java.net/browse/JDK-8129419>. Hotspot webrev: http://cr.openjdk.ja

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

m with removing the dump_start assert though. Regards, Andreas -Dmitry On 2016-02-01 19:20, Andreas Eriksson wrote: Hi, Please review this fix for dumping of long arrays. Bug: 8144732: VM_HeapDumper hits assert with bad dump_len https://bugs.openjdk.java.net/browse/JDK-8144732 Webrev: http:/

RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

Hi, Please review this fix for dumping of long arrays. Bug: 8144732: VM_HeapDumper hits assert with bad dump_len https://bugs.openjdk.java.net/browse/JDK-8144732 Webrev: http://cr.openjdk.java.net/~aeriksso/8144732/webrev.00/ Problem: The hprof format uses an u4 as a record length field, but a

[8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Hi, Please review this backport of JDK-8129419 . Hotspot webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/ JDK webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/ There are three changes compar

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Thanks! On 2016-01-18 14:10, Dmitry Samersoff wrote: Andreas, Thumbs up! (Reviewed) -Dmitry On 2016-01-18 16:07, Andreas Eriksson wrote: On 2016-01-18 13:58, Dmitry Samersoff wrote: Andreas, On 2016-01-18 15:26, Andreas Eriksson wrote: I believe I then have to cast it to size_t at 496

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

On 2016-01-18 13:58, Dmitry Samersoff wrote: Andreas, On 2016-01-18 15:26, Andreas Eriksson wrote: I believe I then have to cast it to size_t at 496, 497 and 498? I hope not. I'm not sure how write works in regards to returning ssize_t vs a size_t length. It's a tricky part. T

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

t? - Andreas On 2016-01-18 13:11, Dmitry Samersoff wrote: Андреас, 481: It's better to declare n as ssize_t and remove cast at 488 Looks good for me! -Dmitry On 2016-01-18 14:42, Andreas Eriksson wrote: Hi, New webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.02/hotspot/

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

. Since heap dumping is done from the vm_thread (not a JavaThread) the assert crashed the VM. Regards, Andreas On 2016-01-13 13:39, Andreas Eriksson wrote: Hi, On 2015-12-29 21:27, Dmitry Samersoff wrote: Andreas, Great work. All but write_internal looks good for me (see below). HprofReader.java

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

If write() is interrupted by a signal after it successfully writes some data, it shall return the number of bytes written. [2] https://msdn.microsoft.com/en-us/library/1570wh78(v=vs.80).aspx -Dmitry On 2015-12-28 17:02, Andreas Eriksson wrote: Hi, Here is the webrev for type changes. T

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

. Thanks, Andreas On 2015-12-14 19:34, Andreas Eriksson wrote: Hi Dmitry, thanks for looking at this. On 2015-12-14 18:30, Dmitry Samersoff wrote: Andreas, Nice cleanup. Some generic comments below. 1. It would be excellent if you can split webrev into two parts, one part with types cleanup

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

ted heap dump while still having huge arrays. Not sure if this is worth taking into account, since it most likely would lead to other problems as well, and the flag is develop only, so it can't happen in product builds. What do you think would be best to do here? - Andreas -Dmitry On

RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

Hi, Please review this fix for dumping of long arrays, and general cleanup of types in heapDumper.cpp. Problem: At several places in heapDumper.cpp overflows could happen when dumping long arrays. Also the hprof format uses an u4 as a record length field, but arrays can be longer than that (

Re: RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

On 2015-11-04 08:31, David Holmes wrote: On 3/11/2015 9:10 PM, Andreas Eriksson wrote: On 2015-11-03 07:27, David Holmes wrote: Hi Andreas, On 31/10/2015 12:03 AM, Andreas Eriksson wrote: Hi, Please review this change to heap dump logic. Including runtime list, since this is related to

Re: RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

On 2015-11-03 07:27, David Holmes wrote: Hi Andreas, On 31/10/2015 12:03 AM, Andreas Eriksson wrote: Hi, Please review this change to heap dump logic. Including runtime list, since this is related to class loading. Bug: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify

RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

Hi, Please review this change to heap dump logic. Including runtime list, since this is related to class loading. Bug: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump https://bugs.openjdk.java.net/browse/JDK-8134030 Webrev: http://cr.openjdk.java.net/~aeriksso/8

RFR: JDK-8074696: Remote debugging session hangs for several minutes when calling findBootType

Hi, Please review this change to JDI to address a performance bottleneck in findBootType for high delay networks. Bug: 8074696: Remote debugging session hangs for several minutes when calling findBootType https://bugs.openjdk.java.net/browse/JDK-8074696 Webrev: http://cr.openjdk.java.net/~a

RFR: JDK-8074696: Remote debugging session hangs for several minutes

Hi, Please review this change to JDI/JDWP to address two performance bottlenecks for high delay networks. Bug: 8074696: Remote debugging session hangs for several minutes https://bugs.openjdk.java.net/browse/JDK-8074696 Webrev: http://cr.openjdk.java.net/~aeriksso/8074696/webrev.00/ This cha

Jdk8 backports of 6904403 and 8044364

Hi, Just a heads up that I'm backporting these fixes to jdk8: https://bugs.openjdk.java.net/browse/JDK-6904403: assert(f == k->has_finalizer(),"inconsistent has_finalizer") with debug VM https://bugs.openjdk.java.net/browse/JDK-8044364: [TESTBUG] runtime/RedefineFinalizer test fails on windows