Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes jpackage changes looks good. -

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Chris Plummer
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes `src/jdk.jdi/share/classes/com/sun/tools` c

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes @dfuch Could I get a review from you as wel

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert double quote as well > > src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java > line 75:

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl >> line 2: >> >>> 1: >>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="1252"> >> >> Why "de-de" was changed to "de

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert old translation. Fix lang codes - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote: >> Looks like translation is done on files before JDK-8293462 was integrated >> (before Sep 26). See >> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f8

Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions

2022-12-15 Thread David Holmes
On Thu, 15 Dec 2022 11:51:10 GMT, Serguei Spitsyn wrote: > Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS > transitions for all virtual threads only. It should also support disabling > transitions for any specific virtual thread as well. This will improve > scalability

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Joe Wang
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well The changes in the java.xml area look good to me. ---

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev wrote: >> I'm not sure for the decisions of change in punctuation and for the missing >> {1} as I didn't do the translation myself. Would this be better to be >> reverted? > > Looks like translation is done on files before JDK-8293462 was int

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties >> line 37: >> >>> 35: >>> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u7

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties >> line 82: >> >>> 80: >>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in >>> app-image-Verzeichnis ({0}) >>> 82: error.invalid

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_d

[jdk20] Integrated: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Daniel D . Daugherty
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889

Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Daniel D . Daugherty
On Thu, 15 Dec 2022 23:22:15 GMT, Leonid Mesnik wrote: >> A batch of trivial fixes to ProblemList tests: >> >> [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList >> gc/g1/TestVerifyGCType.java on linux and macosx >> [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889)

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Weijun Wang
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well src/java.base/share/classes/sun/security/tools/keytool

Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Daniel D . Daugherty
On Thu, 15 Dec 2022 23:19:51 GMT, Brian Burkhalter wrote: >> A batch of trivial fixes to ProblemList tests: >> >> [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList >> gc/g1/TestVerifyGCType.java on linux and macosx >> [JDK-8298889](https://bugs.openjdk.org/browse/JDK-829888

Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Brian Burkhalter
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889

Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Leonid Mesnik
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889

[jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Daniel D . Daugherty
A batch of trivial fixes to ProblemList tests: [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList gc/g1/TestVerifyGCType.java on linux and macosx [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux [

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back src/jdk.jpackage/share/classes/jdk/jpackage/interna

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Alexander Matveev
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well src/jdk.jpackage/windows/classes/jdk/jpackage/internal

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well Marked as reviewed by naoto (Reviewer). src/jdk.jdeps

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/

Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]

2022-12-15 Thread Doug Simon
On Thu, 15 Dec 2022 21:20:31 GMT, David Holmes wrote: >> This is a simple cleanup RFE to get rid of old-style C casts in relation to >> JavaThread. >> >> In many cases involving NULL/nullptr the cast could just be dropped. >> Sometimes a static cast is needed to disambiguate overloads. >> >>

Integrated: 8298241: Replace C-style casts with JavaThread::cast

2022-12-15 Thread David Holmes
On Wed, 14 Dec 2022 22:22:48 GMT, David Holmes wrote: > This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A coupl

Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]

2022-12-15 Thread David Holmes
On Thu, 15 Dec 2022 07:07:26 GMT, Stefan Karlsson wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed commented examle. > > Marked as reviewed by stefank (Reviewer). Thanks for the reviews @stefank and @sspitsy

Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]

2022-12-15 Thread David Holmes
> This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A couple of reinterpret_cast are needed when doing int/ptr conv

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back Thanks for the update, Damon. Looks good for this d

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties > line 134

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix https and changed URL back - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pu

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Removed trailing whitespace Changes requested by naoto (Reviewer). src/jdk.compil

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 26: >> >>> 24: # >>> 25: >>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >>> JMOD-Dateien auflisten >> >> `jlink.description` wa

RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions

2022-12-15 Thread Serguei Spitsyn
Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS transitions for all virtual threads only. It should also support disabling transitions for any specific virtual thread as well. This will improve scalability of the JVMTI functions operating on target virtual threads as the

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties >> line 188: >> >>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >>> 187: >>> 188: main.plugin.category=\u7C7B\u522B >> >> As Naoto pointed out, it looks l

Re: RFR: 8298701: Cleanup SA entries in ProblemList-zgc.txt.

2022-12-15 Thread Serguei Spitsyn
On Tue, 13 Dec 2022 22:34:06 GMT, Chris Plummer wrote: > The following ProblemList-zgc.txt entries need a lot of cleanup. > > serviceability/sa/ClhsdbCDSCore.java 8268722 > macosx-x64 > serviceability/sa/ClhsdbFindPC.java#xcomp-core8268722,8284045 >

Re: RFR: 8298241: Replace C-style casts with JavaThread::cast

2022-12-15 Thread Serguei Spitsyn
On Wed, 14 Dec 2022 22:22:48 GMT, David Holmes wrote: > This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A coupl