> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
On Tue, 14 Mar 2023 13:59:48 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Tue, 14 Mar 2023 20:20:41 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Tue, 14 Mar 2023 18:46:47 GMT, Roman Kennke wrote:
>> I've reviewed the changes in v23 and v24. Trying another
>> Mach5 Tier1 job set.
>
>> I've reviewed the changes in v23 and v24. Trying another Mach5 Tier1 job set.
>
> I just now pushed a simple change that changes the log message
> 'infl
On Wed, 15 Mar 2023 00:34:32 GMT, Alex Menkov wrote:
>> "else" part is a sub-process.
>> As far as I understand it SATestUtils.skipIfCannotAttach can be skipped for
>> "else", but it's needed for main process.
>
> Added comment.
> Left SATestUtils.skipIfCannotAttach as is (this is consistent wit
On Tue, 14 Mar 2023 18:52:39 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 14 Mar 2023 23:41:47 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 195:
>>
>>> 193: } else {
>>> 194: runTest(Long.parseLong(args[0]));
>>> 195: }
>>
>> Could use some comments here. Also, I think `SATestUtils.skip
On Tue, 14 Mar 2023 22:50:32 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 158:
>
>> 156: Long.toString(
> The change:
> - updates UniqueVtableTest to follow standard SA way - attach to target from
> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
> - updates several tests in the same directory to resolve NoClassDefFoundError
> failures; It's known JTReg issue that "@build"
On Tue, 14 Mar 2023 22:48:30 GMT, Chris Plummer wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClas
On Tue, 14 Mar 2023 22:49:07 GMT, Chris Plummer wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClas
On Tue, 14 Mar 2023 20:20:41 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Tue, 14 Mar 2023 23:07:13 GMT, Daniel D. Daugherty
wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>>
On Tue, 14 Mar 2023 22:05:44 GMT, Alex Menkov wrote:
> The change:
> - updates UniqueVtableTest to follow standard SA way - attach to target from
> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
> - updates several tests in the same directory to resolve NoClassDefFoundE
On Tue, 14 Mar 2023 22:05:44 GMT, Alex Menkov wrote:
> The change:
> - updates UniqueVtableTest to follow standard SA way - attach to target from
> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
> - updates several tests in the same directory to resolve NoClassDefFoundE
The change:
- updates UniqueVtableTest to follow standard SA way - attach to target from
subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
- updates several tests in the same directory to resolve NoClassDefFoundError
failures; It's known JTReg issue that "@build" actions fo
On Tue, 14 Mar 2023 03:23:05 GMT, Leonid Mesnik wrote:
> Field has been made volatile.
This pull request has now been integrated.
Changeset: cd41c69d
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/cd41c69d4484f900a89a71f1c9bab2bc2e383c1e
Stats: 1 line in 1 file cha
On Tue, 14 Mar 2023 15:10:04 GMT, Doug Simon wrote:
>> Access to internal modifiers is needed in
>> `HotSpotResolvedJavaFieldTest.testEquivalenceForInternalFields()`. I moved
>> the declaration of the method to `HotSpotResolvedJavaField`. Does this
>> change work for you?
>
> Just use reflecti
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
On Tue, 14 Mar 2023 19:52:01 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList a couple of tests:
>
> [JDK-8304172](https://bugs.openjdk.org/browse/JDK-8304172) ProblemList
> serviceability/sa/UniqueVtableTest.java
> [JDK-8304175](https://bugs.openjdk.org/browse/JDK-8304175) Probl
On Tue, 14 Mar 2023 20:00:30 GMT, Alexander Zvegintsev
wrote:
>> Trivial fixes to ProblemList a couple of tests:
>>
>> [JDK-8304172](https://bugs.openjdk.org/browse/JDK-8304172) ProblemList
>> serviceability/sa/UniqueVtableTest.java
>> [JDK-8304175](https://bugs.openjdk.org/browse/JDK-8304175)
On Tue, 14 Mar 2023 19:52:01 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList a couple of tests:
>
> [JDK-8304172](https://bugs.openjdk.org/browse/JDK-8304172) ProblemList
> serviceability/sa/UniqueVtableTest.java
> [JDK-8304175](https://bugs.openjdk.org/browse/JDK-8304175) Probl
Trivial fixes to ProblemList a couple of tests:
[JDK-8304172](https://bugs.openjdk.org/browse/JDK-8304172) ProblemList
serviceability/sa/UniqueVtableTest.java
[JDK-8304175](https://bugs.openjdk.org/browse/JDK-8304175) ProblemList
compiler/vectorapi/VectorLogicalOpIdentityTest.java on 2 platforms
On Tue, 14 Mar 2023 15:11:36 GMT, Doug Simon wrote:
>> Without this declaration, builds fail on Windows with this error:
>> `error C2375: 'c2v_getDeclaredFieldsInfo': redefinition; different linkage`
>
> Strange - thats not needed for other `JVMCIEnv` methods called from
> `jvmciCompilerToVM.cpp
On Tue, 14 Mar 2023 13:37:23 GMT, Frederic Parain wrote:
>> src/hotspot/share/jvmci/jvmciEnv.hpp line 149:
>>
>>> 147: };
>>> 148:
>>> 149: extern JNIEXPORT jobjectArray c2v_getDeclaredFieldsInfo(JNIEnv* env,
>>> jobject, jobject, jlong);
>>
>> What's the purpose of this declaration? I don't
On Tue, 14 Mar 2023 15:47:29 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 14 Mar 2023 18:41:59 GMT, Daniel D. Daugherty
wrote:
> I've reviewed the changes in v23 and v24. Trying another Mach5 Tier1 job set.
I just now pushed a simple change that changes the log message
'inflate(fast-locked)' to 'inflate(has_locker)' to make those tests happy.
-
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Tue, 14 Mar 2023 15:47:29 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 14 Mar 2023 18:16:36 GMT, Daniel D. Daugherty
wrote:
> I kicked off a round of Mach5 Tier1 testing last night. I got 133 SA test
> failures that are probably fixed by v24.
> runtime/logging/MonitorInflationTest.java also failed on all 5 configs tested
> in Tier1:
>
> ```
> java.lang.
On Tue, 14 Mar 2023 15:47:29 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Mon, 13 Mar 2023 15:55:27 GMT, Daniel Jeliński wrote:
>> This patch modifies the `getLastErrorString` method to return a `jstring`.
>> Thanks to that we can avoid unnecessary back and forth conversions between
>> Unicode and other charsets on Windows.
>>
>> Other changes include:
>> - the W
On Mon, 13 Mar 2023 15:55:27 GMT, Daniel Jeliński wrote:
>> This patch modifies the `getLastErrorString` method to return a `jstring`.
>> Thanks to that we can avoid unnecessary back and forth conversions between
>> Unicode and other charsets on Windows.
>>
>> Other changes include:
>> - the W
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
On Tue, 14 Mar 2023 09:20:54 GMT, Richard Reingruber wrote:
> @matias9927 can I ask you to merge master? There seem to be conflicts (at
> least I see a message "This branch has conflicts that must be resolved"). I'd
> like to give the change a spin in our CI testing. This requires that it can
On Fri, 6 Jan 2023 12:02:37 GMT, Kevin Walls wrote:
> Deprecate the Java Management Extension (JMX) Subject Delegation feature for
> removal in a future release.
>
> Given no known usage, there is no replacement feature for JMX Subject
> Delegation.
>
> CSR is https://bugs.openjdk.org/browse/
On Fri, 3 Mar 2023 11:46:49 GMT, Kevin Walls wrote:
>> Deprecate the Java Management Extension (JMX) Subject Delegation feature for
>> removal in a future release.
>>
>> Given no known usage, there is no replacement feature for JMX Subject
>> Delegation.
>>
>> CSR is https://bugs.openjdk.org/
On Tue, 14 Mar 2023 13:59:48 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Tue, 14 Mar 2023 13:12:31 GMT, Frederic Parain wrote:
>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java
>> line 48:
>>
>>> 46: * Returns VM internal flags associated with this field
>>> 47: */
>>> 48: int getInternalModifiers();
>>
>> We've never ex
On Fri, 3 Mar 2023 11:46:49 GMT, Kevin Walls wrote:
>> Deprecate the Java Management Extension (JMX) Subject Delegation feature for
>> removal in a future release.
>>
>> Given no known usage, there is no replacement feature for JMX Subject
>> Delegation.
>>
>> CSR is https://bugs.openjdk.org/
On Tue, 14 Mar 2023 13:18:40 GMT, Coleen Phillimore wrote:
> Ok, never mind, I saw s390 port but it doesn't seem to be in these changes (?)
It is not in these changes.
@offamitkumar is working on s390x. It is not yet finished though.
(I wasn't aware that putting the URL of this PR into a comment
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
On Mon, 13 Mar 2023 21:35:17 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/hotspot/share/jvmci/jvmciEnv.hpp line 149:
>
>> 147: };
>> 148:
>> 149: extern JNIE
On Mon, 13 Mar 2023 21:05:11 GMT, Coleen Phillimore wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Interpreter optimization and comments
>
> src/hotspot/cpu/x86/templateTable_x86.cpp line 2798:
>
>> 2796
On Mon, 13 Mar 2023 21:44:59 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 416:
>
>> 414: declare_constant(Field
On Mon, 13 Mar 2023 21:53:37 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java
> line 48:
>
On Mon, 13 Mar 2023 09:46:04 GMT, Andrew Dinn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/jfr/metadata/metadata.xml line 1182:
>
>> 1180: > description="The time the J
On Tue, 14 Mar 2023 06:01:05 GMT, David Holmes wrote:
> I've had a good look through now and have a better sense of the refactoring.
> Seems good.
>
>
>
> I'll wait for any tweaks before hitting the approve button though.
>
>
>
> Thanks
Thanks so much for taking a look. I realized that im
On Mon, 13 Mar 2023 09:49:39 GMT, Andrew Dinn wrote:
>> src/hotspot/share/prims/agentList.cpp line 64:
>>
>>> 62: void AgentList::add_xrun(const char* name, char* options, bool
>>> absolute_path) {
>>> 63: Agent* agent = new Agent(name, options, absolute_path);
>>> 64: agent->_is_xrun = tru
On Fri, 10 Mar 2023 06:57:46 GMT, David Holmes wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> handle multiple envs with same VMInit callback
>
> src/hotspot/share/prims/agent.cpp line 41:
>
>> 39: char* copy
On Mon, 13 Mar 2023 06:22:21 GMT, David Holmes wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/prims/agent.cpp line 34:
>
>> 32: }
>> 33:
>> 34: static const char* allocate_c
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Mon, 13 Mar 2023 20:02:45 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 9 Mar 2023 21:18:19 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Tue, 14 Mar 2023 02:43:41 GMT, liach wrote:
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM l
57 matches
Mail list logo
