On Thu, 16 Mar 2023 06:31:42 GMT, Roman Kennke wrote:
> > > Agreed. But I don't think "Thin locks" is an option as that was
> > > specifically an IBM locking implementation. Historically Hotspot's
> > > locking mechanism has internally been referred to as stack-locks, so I
> > > would suggest
On Thu, 16 Mar 2023 06:05:38 GMT, Thomas Stuefe wrote:
>
>
> > Agreed. But I don't think "Thin locks" is an option as that was
> > specifically an IBM locking implementation. Historically Hotspot's locking
> > mechanism has internally been referred to as stack-locks, so I would
> > suggest U
On Wed, 15 Mar 2023 19:40:33 GMT, Roman Kennke wrote:
>>> Would it be possible to open/send me the failing test that triggers
>>> vframeArray assert
>>> or extract a reproducer that you could publish?
>>
>> I have started an internal discussion at Oracle to see what it would take
>> to move tha
On Thu, 16 Mar 2023 05:45:29 GMT, David Holmes wrote:
> Agreed. But I don't think "Thin locks" is an option as that was specifically
> an IBM locking implementation. Historically Hotspot's locking mechanism has
> internally been referred to as stack-locks, so I would suggest
> UseNewStackLocks
On Wed, 15 Mar 2023 19:40:33 GMT, Roman Kennke wrote:
>>> Would it be possible to open/send me the failing test that triggers
>>> vframeArray assert
>>> or extract a reproducer that you could publish?
>>
>> I have started an internal discussion at Oracle to see what it would take
>> to move tha
This is needed for performance improvements in support of virtual threads.
The update includes the following:
1. Refactored the `VirtualThread` native methods:
`notifyJvmtiMountBegin` and `notifyJvmtiMountEnd` =>
`notifyJvmtiMount`
`notifyJvmtiUnmountBegin` and `notifyJvmtiUnmoun
On Wed, 15 Mar 2023 09:41:30 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 15 Mar 2023 09:41:30 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Wed, 15 Mar 2023 18:50:25 GMT, Serguei Spitsyn wrote:
> This looks pretty good. How did you test the fix? Does it never fail with
> your fix? Thanks, Serguei
I run test jobs for "serviceability/sa" 100 times on all platforms, no failures
(neither attach timeout nor NoClassDefFoundError)
--
On Wed, 15 Mar 2023 02:41:18 GMT, David Holmes wrote:
> Not sure removing the build directives was the right way to go. As per the
> jtreg tag guide:
>
> > A test that relies upon library classes should contain appropriate @build
> > directives to ensure that the classes will be compiled. It i
On Wed, 15 Mar 2023 19:14:09 GMT, Daniel D. Daugherty
wrote:
> > Would it be possible to open/send me the failing test that triggers
> > vframeArray assert
> > or extract a reproducer that you could publish?
>
> I have started an internal discussion at Oracle to see what it would take to
> mo
On Tue, 14 Mar 2023 12:26:16 GMT, Markus Grönlund wrote:
>> I've had a good look through now and have a better sense of the refactoring.
>> Seems good.
>>
>> I'll wait for any tweaks before hitting the approve button though.
>>
>> Thanks
>
>> I've had a good look through now and have a better
On Wed, 15 Mar 2023 09:36:25 GMT, Roman Kennke wrote:
> Would it be possible to open/send me the failing test that triggers
> vframeArray assert
> or extract a reproducer that you could publish?
I have started an internal discussion at Oracle to see what it would take
to move that test from clo
On Wed, 15 Mar 2023 18:45:00 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Wed, 15 Mar 2023 09:41:30 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 15 Mar 2023 00:34:00 GMT, Alex Menkov wrote:
>> The change:
>> - updates UniqueVtableTest to follow standard SA way - attach to target from
>> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess;
>> - updates several tests in the same directory to resolve
>> NoClassD
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
On Tue, 14 Mar 2023 17:01:20 GMT, Matias Saavedra Silva
wrote:
> > @matias9927 can I ask you to merge master? There seem to be conflicts (at
> > least I see a message "This branch has conflicts that must be resolved").
> > I'd like to give the change a spin in our CI testing. This requires tha
On Wed, 15 Mar 2023 15:41:17 GMT, Frederic Parain wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>>
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support readin
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Tue, 14 Mar 2023 15:39:39 GMT, Gui Cao wrote:
>> Matias Saavedra Silva has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains five
>> additional com
This PR converts Unicode sequences to UTF-8 native in .properties file.
(Excluding the Unicode space and tab sequence). The conversion was done using
native2ascii.
In addition, the build logic is adjusted to support reading in the .properties
files as UTF-8 during the conversion from .propertie
> Please review this change re-implementing the FieldInfo data structure.
>
> The FieldInfo array is an old data structure storing fields metadata. It has
> poor extension capabilities, a complex management code because of lack of
> strong typing and semantic overloading, and a poor memory effic
On Tue, 14 Mar 2023 23:29:17 GMT, Calvin Cheung wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> RISCV port update
>
> src/hotspot/share/interpreter/bootstrapInfo.cpp line 234:
>
>> 232: if (_indy_index
On Tue, 14 Mar 2023 01:25:01 GMT, Chris Plummer wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Field.java line 75:
>
>> 73:
On Wed, 15 Mar 2023 01:25:33 GMT, Daniel D. Daugherty
wrote:
> I did Mach5 Tier{1,2,3} on v25. Please see the bug report for the gory
> details:
>
> Tier1 - 1 known, unrelated failure Tier2 - 4 closed, unknown, related test
> failures Tier3 - 8 closed, unknown, related test failures; 2 open,
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Tue, 14 Mar 2023 18:46:47 GMT, Roman Kennke wrote:
>> I've reviewed the changes in v23 and v24. Trying another
>> Mach5 Tier1 job set.
>
>> I've reviewed the changes in v23 and v24. Trying another Mach5 Tier1 job set.
>
> I just now pushed a simple change that changes the log message
> 'infl
32 matches
Mail list logo
