Ryan,
One last request after all of the hard work you've put into this...
would you please document these new features on the Solr wiki? Thanks!
Erik
On Jan 29, 2007, at 3:53 PM, Ryan McKinley (JIRA) wrote:
[ https://issues.apache.org/jira/browse/SOLR-104?
page=com.atlassi
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468406
]
Ryan McKinley commented on SOLR-104:
Thanks Hoss!
> Update Plugins
> --
>
> Key: SOLR-
: No if we add streaming to the mix, anyone from anywhere can see any
: file on your system. (Assuming the example solrconfig.xml includes
: the dump handler) With multipart upload it is easy to upload an
: enormous .exe to solr. I think the potential problems opened up by
: streaming and multi-
BTW: i'll try to look at the newsest version of hte patch tonight.
: > - What should the expectations of
: >ContentStream.getInputStream().close() be? Should the Dispatcher
: >iterate over any Iterable streams when writing the output and try
: >to close them, ignoring any Exceptions?
: Hymm, this is awkward. I'm not quite sure what happened. But this is
Yonik inserted a phrase for this in my lexicon: Ghost in the Machine.
: > - I'm really not fond of having SolrParams.STREAM_TYPE. Can we please,
: >please leave it out for now and rely on on content-type detection?
:
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467787
]
Ryan McKinley commented on SOLR-104:
Ok, I just uploaded (hopefully) a final version. It takes care of (most)
ev
: We should have a good notice in the config warning people to have some
: security running before enabling streaming.
yeah ... you had me convinced of that before, but i'm leaning more
towards yonik's point now: Solr has a lot of inherient trust to anyone
that can hit it directly. if/when we a
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467755
]
Ryan McKinley commented on SOLR-104:
Hymm, this is awkward. I'm not quite sure what happened. But this is what I
On 1/25/07, Chris Hostetter <[EMAIL PROTECTED]> wrote:
Um... just for the record, some of these comments -- i'm not sure what
they are in reponse too :)
Someone on the lucene list had a tip about quoting in JIRA... they
composed their reply as a response to the email sent to the dev list,
then
: I'll comment on points i have answers or questions. The rest will go
: on the TODO list.
Um... just for the record, some of these comments -- i'm not sure what
they are in reponse too :)
: To trigger raw request reading you *must* have a parameter on the URL.
: This was my design in response
On 1/24/07, Ryan McKinley (JIRA) <[EMAIL PROTECTED]> wrote:
Ryan McKinley commented on SOLR-104:
the 2MB limit is set in solrconfig.xml
maybe 2MB is too small as the default, but i figured it shoudl be configurable.
Yeah, but I was lacking knowledge about the reasons behind a limit.
(poten
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467330
]
Ryan McKinley commented on SOLR-104:
Thanks for going through this!
I'll comment on points i have answers or ques
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467305
]
Hoss Man commented on SOLR-104:
---
Woot! ... i think we're really close to comiting this.
I made a hodgepodge list of com
: I'd like to hear from hoss though, since he was following along more
: than I was, esp at the start of that marathon thread.
FYI: I'm starting to look at this now.
i send this mail only because Ryan is so damn fast and I'd like to
encourage him to take a break and watch some TV or something so
: > ...It is harder to test things that rely on a container, but there are
: > many techniques to make it easier with mocks...
:
: FWIW, it's very easy to start Jetty in embedded mode from a Java
: class, this can be useful for testing.
I'm in favor of both of these things: it would be great if t
On 1/24/07, Erik Hatcher <[EMAIL PROTECTED]> wrote:
...It is harder to test things that rely on a container, but there are
many techniques to make it easier with mocks...
FWIW, it's very easy to start Jetty in embedded mode from a Java
class, this can be useful for testing.
Improving Solr's t
On Jan 24, 2007, at 1:01 AM, Yonik Seeley (JIRA) wrote:
Yonik Seeley commented on SOLR-104:
---
Oh, and where possible, it would be nice to have some unit tests.
Yes, please! Lots and lots of unit tests :)
I'm really enamored by code coverage analysis to poin
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466914
]
Ryan McKinley commented on SOLR-104:
If there are funny chars at the start of web.xml, it was an SVN error.
the 2M
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466913
]
Yonik Seeley commented on SOLR-104:
---
Oh, and where possible, it would be nice to have some unit tests.
Servlet relate
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466912
]
Yonik Seeley commented on SOLR-104:
---
Finally got a chance to review this... it's really great stuff Ryan!
Random que
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466277
]
Ryan McKinley commented on SOLR-104:
I just thought of something that will make Hoss' blod curl! I KNOW it
is a b
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466273
]
Ryan McKinley commented on SOLR-104:
I just updated DispatchFilter.path to implement most of our discussion on
sol
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465563
]
Ryan McKinley commented on SOLR-104:
removed getRequestParser() from Handler interface.
using ':' in the URL to sp
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465538
]
Ryan McKinley commented on SOLR-104:
I attached 'DispatchFilter.patch' This extracts some stuff from my previous
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464667
]
Ryan McKinley commented on SOLR-104:
I agree with points J.J's points 1-6. thanks
If one were to look at only one
Yonik Seeley (JIRA) wrote:
[ https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464655 ]
Yonik Seeley commented on SOLR-104:
---
I haven't had a chance to look at all this stuff yet,
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464655
]
Yonik Seeley commented on SOLR-104:
---
I haven't had a chance to look at all this stuff yet, but we should take care
t
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464654
]
J.J. Larrea commented on SOLR-104:
--
6. I may be going a little crazy with this soft-configuration concept, but
thinki
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464653
]
J.J. Larrea commented on SOLR-104:
--
I think this is a fantastic effort, so please take my comments and suggestions
fo
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464640
]
Ryan McKinley commented on SOLR-104:
I just upload a new version of HandlerRefactoring-DRAFT-SRC.zip
In addition t
[
https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464559
]
Ryan McKinley commented on SOLR-104:
I just uploaded: HandlerRefactoring-DRAFT-SRC.zip. It is not a patch, but it
31 matches
Mail list logo
