On 18.05.23 16:44, Juha Heinanen wrote:
> I guess I missed the clang-format discussion or did it happen?
> Fr example, I would have voted for
>
> SpaceBeforeParens: ControlStatements
First was quite some time ago, more than 5 years:
-
I guess I missed the clang-format discussion or did it happen?
Fr example, I would have voted for
SpaceBeforeParens: ControlStatements
-- Juha
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
-Original Message-
From: Daniel-Constantin Mierla
Sent: Donnerstag, 18. Mai 2023 13:45
To: Henning Westerholt ; Kamailio (SER) - Development Mailing
List
Subject: Re: [sr-dev] Re: clang-format changes
Hello,
I didn't complain about your commit, but about your attitude about what you
d in the other e-mail).
>
> Thank you,
>
> Henning
>
> -Original Message-
> From: Daniel-Constantin Mierla
> Sent: Donnerstag, 18. Mai 2023 13:29
> To: Kamailio (SER) - Development Mailing List ;
> Henning Westerholt
> Subject: Re: [sr-dev] Re: clang-forma
;
Henning Westerholt
Subject: Re: [sr-dev] Re: clang-format changes
Hello,
why do you complain in this case when you don't even give a chance for others
to review your commits pushed to modules you haven't authored, nor you maintain?
-
https://github.com/kamailio/kamailio/commit
Hello,
why do you complain in this case when you don't even give a chance for
others to review your commits pushed to modules you haven't authored,
nor you maintain?
-
https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539f7547d8c
So others have to do it, only you don't?
Hi,
On 18/5/23 12:39, Henning Westerholt wrote:
Hello,
the PR related to this proposal was merged quite fast, less then 24h after
creation. Why this was merged already, given that it affects all modules?
Well, that was only me. I discussed enforcing clang-format already in the past
[0] and
Hello,
the PR related to this proposal was merged quite fast, less then 24h after
creation. Why this was merged already, given that it affects all modules?
I have nothing against this change, but it would have been polite to give it a
bit more time for feedback from other module authors,
On 17/5/23 18:23, Daniel-Constantin Mierla wrote:
For quite some time, there is a .clang-format file in the root for
kamailio sources folder:
- https://github.com/kamailio/kamailio/blob/master/.clang-format
That's the one used so far for the files formatted in the past,
expecting it is the
On 17.05.23 17:22, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>> I am for it, maybe the next major release will be bumped to 6.0, so
>> going with clang formatting would be good because makes the readability
>> better.
> Which style?
Daniel-Constantin Mierla writes:
> I am for it, maybe the next major release will be bumped to 6.0, so
> going with clang formatting would be good because makes the readability
> better.
Which style? https://clang.llvm.org/docs/ClangFormatStyleOptions.html
supports many:
LLVM A style complying
Hello,
I am for it, maybe the next major release will be bumped to 6.0, so
going with clang formatting would be good because makes the readability
better.
Cheers,
Daniel
On 17.05.23 16:01, Victor Seva wrote:
> Hi,
>
> I'm thinking we should start enforcing clang-format in order to have a
>
12 matches
Mail list logo
