[SSSD] [PATCH] Add dummy credentials to an empty ccache file

2009-12-08 Thread Sumit Bose
Hi, this patch is the first step to solve #304. It adds some more information into an empty ticket. I think this is as much we can do to make krb5-auth-dialog happy, because krb5-auth-dialog overwrites the client principal found in the ccache with its own data in ka_parse_name(). This data is

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-08 Thread Martin Nagy
On Mon, 2009-12-07 at 20:03 +0100, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/2009 03:07 PM, Martin Nagy wrote: I think we should just push these patches (after the review is done) and then disable them in the build configure system like Stephen did for

Re: [SSSD] failover feature documentation

2009-12-08 Thread Jenny Galipeau
David O'Brien wrote: Jenny Galipeau wrote: Simo Sorce wrote: On Mon, 2009-12-07 at 09:08 -0500, Jenny Galipeau wrote: Hi: The failover feature and configuration parameters do not seem to documented anywhere. Am I missing something? Not yet documented

Re: [SSSD] [PATCH] two fixes for the upgrade/changeconf script

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2009 04:49 PM, Jakub Hrozek wrote: On 12/07/2009 10:00 PM, Jakub Hrozek wrote: [PATCH 1/2] Handle spaces in config parser Fixes: #301 Per discussion on #freeipa, the code now allows an arbitrary number of spaces around the equal sign.

[SSSD] [PATCH] dhash: change API to be more talloc friendly

2009-12-08 Thread Simo Sorce
Minor changes so we can pass down a memory context when using talloc. Simo. -- Simo Sorce * Red Hat, Inc * New York From 5a60c422892c34d782db372b4aba3ca4446d042f Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Tue, 8 Dec 2009 11:06:42 -0500 Subject: [PATCH] Change dhash API to

Re: [SSSD] [PATCH] dhash: change API to be more talloc friendly

2009-12-08 Thread Sumit Bose
On Tue, Dec 08, 2009 at 11:08:07AM -0500, Simo Sorce wrote: Minor changes so we can pass down a memory context when using talloc. Simo. applies, compiles and all test succeeded ACK bye, Sumit -- Simo Sorce * Red Hat, Inc * New York ___

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Simo Sorce
On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference between hash_lookup+hash_delete and hash_remove is one less lookup, if

Re: [SSSD] [PATCH] Add dummy credentials to an empty ccache file

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 06:25 AM, Sumit Bose wrote: Hi, this patch is the first step to solve #304. It adds some more information into an empty ticket. I think this is as much we can do to make krb5-auth-dialog happy, because krb5-auth-dialog overwrites

Re: [SSSD] [PATCH] two fixes for the upgrade/changeconf script

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 09:57 AM, Stephen Gallagher wrote: On 12/07/2009 04:49 PM, Jakub Hrozek wrote: On 12/07/2009 10:00 PM, Jakub Hrozek wrote: [PATCH 1/2] Handle spaces in config parser Fixes: #301 Per discussion on #freeipa, the code now allows an

Re: [SSSD] [PATCHES] Fix several warnings/potential bugs

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 11:41 AM, Simo Sorce wrote: On Tue, 2009-12-08 at 11:27 -0500, Stephen Gallagher wrote: Patch 0001: We weren't checking that the asprintf was successfully allocating memory. I converted it to talloc_asprintf() for uniformity as

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Dmitri Pal
Simo Sorce wrote: On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference between hash_lookup+hash_delete and

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread John Dennis
On 12/08/2009 12:35 PM, Dmitri Pal wrote: Simo Sorce wrote: On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 12:43 -0500, John Dennis wrote: I think Simo's suggestion of using the delete callback in these cases is the best idea. If you allow returning values from the delete operation you have the potential for inconsistencies. How do you know if value returned is still

[SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Simo Sorce
A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to the delete callback. Simo. -- Simo Sorce * Red Hat, Inc * New York From cc3ae4d6d1733e9c315be48790768c5ba5d80571 Mon Sep 17 00:00:00 2001

[SSSD] [PATCH] Run dhash tests with 'make check'

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 SSIA - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using

[SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-08 Thread transifex
Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | master by ruigo rui.gouv...@gmail.com Please, visit Transifex at http://www.transifex.net/projects/p/sssd/c/master/ in order to see the component page. Thank you, Transifex # SOME

Re: [SSSD] [PATCH] Run dhash tests with 'make check'

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 13:09 -0500, Stephen Gallagher wrote: SSIA ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] dhash: change API to be more talloc friendly

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 11:20 AM, Sumit Bose wrote: On Tue, Dec 08, 2009 at 11:08:07AM -0500, Simo Sorce wrote: Minor changes so we can pass down a memory context when using talloc. Simo. applies, compiles and all test succeeded ACK bye, Sumit

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread John Dennis
On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to the delete callback. Simo. Am I missing something? This doesn't address Dmitri's issue. -- John

[SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-08 Thread transifex
Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | master by beckerde domingobec...@gmail.com Please, visit Transifex at http://www.transifex.net/projects/p/sssd/c/master/ in order to see the component page. Thank you, Transifex #

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to the delete callback. Simo. Am I

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 02:20 PM, Martin Nagy wrote: Unfortunately, that still doesn't solve the issue. These functions are surprisingly difficult to get right. The way the code is now, you don't link the list items. I also just noticed that we don't handle

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Dmitri Pal
Simo Sorce wrote: On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to the delete

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 13:58 -0500, Dmitri Pal wrote: Simo Sorce wrote: On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the

[SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-08 Thread transifex
Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | master by beckerde domingobec...@gmail.com Please, visit Transifex at http://www.transifex.net/projects/p/sssd/c/master/ in order to see the component page. Thank you, Transifex #

Re: [SSSD] [PATCHES] New translations

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 02:02 PM, Stephen Gallagher wrote: Ack to the Transifex submissions made. The attached patches will apply in our repository. Adding updated Spanish translation patch, as the server-side portion was also just submitted. - --

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-08 Thread Martin Nagy
On Tue, 2009-12-08 at 19:53 +0100, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 02:20 PM, Martin Nagy wrote: Unfortunately, that still doesn't solve the issue. These functions are surprisingly difficult to get right. The way the code is now, you don't

[SSSD] [PATCH] Do not start with provider=files

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #233 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAksetVIACgkQHsardTLnvCXY4QCaAzOoTWiVk8FYsxrBZ+kmWLZz 0QwAn2rh5hL4VnL3a6E3s2pjSzaKEkwl =1tmE

[SSSD] [PATCH] Reduce code duplication between the LDAP child and the Kerberos child

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #294 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkserpAACgkQHsardTLnvCXA+ACgmb2QDZ7B6etM17qNJLDoOE8i dJ8AoOAxCLAtgbiu10ubhLKkIhNKlly+ =Cgj2

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to the delete callback. Simo. Am I

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread John Dennis
On 12/08/2009 02:14 PM, Simo Sorce wrote: On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single hash entry. Pass in a private pointer so the caller can pass whatever private context to

Re: [SSSD] failover feature documentation

2009-12-08 Thread David O'Brien
Jenny Galipeau wrote: David O'Brien wrote: Jenny Galipeau wrote: Simo Sorce wrote: On Mon, 2009-12-07 at 09:08 -0500, Jenny Galipeau wrote: Hi: The failover feature and configuration parameters do not seem to documented anywhere. Am I missing something?

Re: [SSSD] [PATCHES] Two patches related to SSSDDomain.remove_provider()

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2009 11:04 PM, Stephen Gallagher wrote: Patch 0001: remove_provider() really doesn't need the provider name (ldap, krb5, etc.) specified in order to remove it. This patch eliminates that argument to the function. ACK Good change to the

[SSSD] [PATCHES] Fixes for SSSDConfig API

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patch 0001: Adds SSSDDomain.set_name() function to change the name of a domain. Patch 0002: Fixes the broken SSSDConfig.set() command. Previously it had a net zero effect when attempting to overwrite an existing option. Now it will properly replace

Re: [SSSD] [PATCHES] Fixes for SSSDConfig API

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/09/2009 04:57 AM, Stephen Gallagher wrote: Patch 0001: Adds SSSDDomain.set_name() function to change the name of a domain. This patch also resets the verbosity of TestRunner, it would perhaps be better to split it into a separate patch.

Re: [SSSD] [PATCHES] Fixes for SSSDConfig API

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 11:27 PM, Jakub Hrozek wrote: On 12/09/2009 04:57 AM, Stephen Gallagher wrote: Patch 0001: Adds SSSDDomain.set_name() function to change the name of a domain. This patch also resets the verbosity of TestRunner, it would perhaps

Re: [SSSD] [PATCHES] Fixes for SSSDConfig API

2009-12-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/09/2009 05:29 AM, Stephen Gallagher wrote: On 12/08/2009 11:27 PM, Jakub Hrozek wrote: On 12/09/2009 04:57 AM, Stephen Gallagher wrote: Patch 0001: Adds SSSDDomain.set_name() function to change the name of a domain. This patch also

[SSSD] How to add multiple groups?

2009-12-08 Thread David O'Brien
I'm guessing you can't use sss_groupadd to add 1 group at a time: # sss_groupadd GroupD GroupE didn't produce any errors (on stdout anyway) but neither did it create GroupE. Using a comma-separated list produced slightly different results: # sss_groupadd GroupF,GroupE Transaction error. Could

Re: [SSSD] [PATCH] Do not start with provider=files

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 03:21 PM, Jakub Hrozek wrote: Fixes: #233 At some point in the future, I'd like to be able to tie the check for providers into the sssd.api.conf file so we can just check whether it's recognized, rather than special-casing like this.

Re: [SSSD] [PATCH] Run dhash tests with 'make check'

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 01:14 PM, Simo Sorce wrote: On Tue, 2009-12-08 at 13:09 -0500, Stephen Gallagher wrote: SSIA ACK Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among

Re: [SSSD] [PATCHES] New translations

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 02:26 PM, Stephen Gallagher wrote: On 12/08/2009 02:02 PM, Stephen Gallagher wrote: Ack to the Transifex submissions made. The attached patches will apply in our repository. Adding updated Spanish translation patch, as the

Re: [SSSD] [PATCHES] Two patches related to SSSDDomain.remove_provider()

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 10:48 PM, Jakub Hrozek wrote: On 12/07/2009 11:04 PM, Stephen Gallagher wrote: Patch 0001: remove_provider() really doesn't need the provider name (ldap, krb5, etc.) specified in order to remove it. This patch eliminates that

Re: [SSSD] [PATCH] Do not start with provider=files

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 11:42 PM, Stephen Gallagher wrote: On 12/08/2009 03:21 PM, Jakub Hrozek wrote: Fixes: #233 At some point in the future, I'd like to be able to tie the check for providers into the sssd.api.conf file so we can just check whether

Re: [SSSD] [PATCH] dhash: add private pointer for delete callback

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 04:09 PM, John Dennis wrote: On 12/08/2009 02:14 PM, Simo Sorce wrote: On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote: On 12/08/2009 01:08 PM, Simo Sorce wrote: A delete callback may need to get information beyond the single