[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#47][-Changes requested] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-dev

[SSSD] [sssd PR#34][+Changes requested] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Actually, sorry, one more Coverity warning: ``` Error: FORWARD_NULL (CWE-476): sssd-1.14.2/src/responder/common/cache_req/cache_req_search.c:105: var_compar

[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#47][comment] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host jhrozek commented: """ let's try again.. """ See the full comment at https://github.com/SSSD/

[SSSD] [sssd PR#48][+Changes requested] sssctl: Flags for commadn initialization

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization jhrozek commented: """ On Fri, Oct 14, 2016 at 08:03:20AM -0700, mzidek-rh wrote: > I see the comment did not get forwarded to the devel list, so pasting again: > > > So

[SSSD] [sssd PR#13][+Pushed] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed jhrozek commented: """ master: e0903f41922721edf292a9f7e6605a4519db53a1 eaf44bc07dda469a20be07d46737d93f518e2047 """ See the full comment at h

[SSSD] [sssd PR#13][closed] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13 _

[SSSD] [sssd PR#13][-Accepted] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization jhrozek commented: """ I don't know how to unstuck this PR except providing some ideas * SSS_TOOL_FLAG_NOCONF * SSS_TOOL_FLAG_STATIC * SSS_TOOL_FLAG_CONFPARSE_FALSE "&q

[SSSD] [sssd PR#53][+Changes requested] Fixes in the config API related to secrets responder

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#34][+Accepted] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#34][-Changes requested] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Thank you, ACK. I sent the patch to CI and I will push the patch when CI finishes. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ On Wed, Oct 19, 2016 at 02:48:57AM -0700, Jakub Hrozek wrote: > Thank you, ACK. I sent the patch to CI and I will push the patch when CI > finishes.

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ On Wed, Oct 19, 2016 at 03:07:28AM -0700, fidencio wrote: > @jhrozek I'm removing "Changes requested" label as the last patc

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-254876611

[SSSD] [sssd PR#34][closed] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Author: pbrezina Title: #34: cache_req: move from switch to plugins Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/34/head:pr34 git checkout pr34 ___

[SSSD] [sssd PR#34][+Pushed] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Pushed in ef39016..e083a6b """ See the full comment at https://github.com/SSSD/sssd/pull/34#issuecomment-255036044

[SSSD] [sssd PR#34][-Accepted] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ before the patch: ``` [jhrozek@client] sssd $ [] getent netgroup ngr1 ngr1 (-,user1,ipa.test) [jhrozek@client] sssd $ [] geten

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 01:40:15AM -0700, lslebodn wrote: > On (20/10/16 01:21), Jakub Hrozek wrote: > >before the patch: > >``` > >[jhrozek@cl

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 02:55:12AM -0700, lslebodn wrote: > On (20/10/16 02:20), Jakub Hrozek wrote: > >On Thu, Oct 20, 2016 at 01:40:15AM -0700, lslebodn

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 05:04:20AM -0700, mzidek-rh wrote: > And yes, there are differences between plain LDAP and IPA providers. The > netgroup code is com

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Hmm, looks like github ate my mail, so let's paste the comment again (and sorry if it arrives twice). Coverity detected some warnings: ``` Err

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ Additionally, if there is some link to MSDN explaining what the OID is, it would be nice to add that link """ See the full comment at

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/66#issuecomment-256084328 ___ sssd-de

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thanks for the changes, at least with the previous version all the tests with the domain-local groups were working for me and the internal ad_fore

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ Bump. Could anyone review this patch, please? """ See the full comment at h

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ On Wed, Oct 19, 2016 at 02:45:02AM -0700, sumit-bose wrote: > This set of patches should solve https://fedorahosted.org/sssd/ticket/3206. To >

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/62#issuecomment-256572973 _

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ The documentation now looks correct, I just wonder why did you remove the example paragraph in the last iteration of the patch? IMO it would be useful

[SSSD] [sssd PR#49][+Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscr

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thank you, this version reads better to me and still works fine (adding and removing the global group as well..) So far ACK, I will push the patc

[SSSD] [sssd PR#57][+Accepted] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks jhrozek commented: """ On Tue, Oct 25, 2016 at 09:28:27AM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -1104,7 +1104,6 @@ bool sss_krb5_

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Thu, Oct 27, 2016 at 03:56:21AM -0700, Pavel Březina wrote: > pbrezina requested changes on this pull request. > > Hi, there is one

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/05/summary.html Coverity also didn't find any errors. For some reason, re-running just the tests th

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ On Thu, Oct 27, 2016 at 08:48:46AM -0700, taupehat wrote: > @jhrozek I did not intend to remove anything from the last iteration. It's >

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ I reviewed the use of `case_preserve` in the code and I think we use it correctly for formatting output or for interacting with external compo

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ * master: * cbee11e..2569984 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ sssd-1-4: ec1829d..c1f3b29 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#57][-Accepted] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Umm sorry, the ranges are not so nice, let's list the commits * master: * 25699846bd1c9f8bb513b6271eb4366ab682fbd2 * 49d3f0a487d55571b2bd

[SSSD] [sssd PR#57][+Pushed] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#57][closed] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Author: sumit-bose Title: #57: LDAP/AD: resolve domain local groups for remote users Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/57/head:pr57 git checkout pr57 __

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations jhrozek commented: """ I wonder if @fweimer thinks it's worth merging the patch if the issue in https://bugzilla.redhat.com/show_bug.cgi

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Sorry for the delay in reviewing. I tried: ``` [secrets/foo] [secrets/123] ``` as an invalid test and sssd noticed them as invalid. It also didn'

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#49][-Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscr

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ Hi, thank you for the review and the time on the phone. I pushed new patches where the first one just

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Tue, Nov 01, 2016 at 01:46:31AM -0700, celestian wrote: > To @pbrezina and @jhrozek > > I introduced new attribute ```sudoU

[SSSD] [sssd PR#62][+Changes requested] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Thank you for the patch, I started the review and so far I would like to ask for compilation warnings to be fixed: ``` /home/remote/jhrozek/devel/sssd/s

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Additionally, it looks like the reason CI failed is a valgrind issue in one of the tests: ``` [ RUN ] test_filter_response ==19061== Conditional jump or

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Tue, Nov 01, 2016 at 05:36:40AM -0700, celestian wrote: > There is another important question from discussion in #39. We would like to

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ btw except from the warnings and the valgrind issue, the code seems to work fine. I tested with sudo -i and then kinit, before the patch: ``` -sh-4.3$ sudo -iu admin

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Additionally, do you think we should open a ticket to track potentially adding sudo -i to the list by default? """ See the full comment at https:

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ Thank you for the review, I (hopefully :-)) adressed all the comments and pushed new patches. "

[SSSD] [sssd PR#49][-Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscr

[SSSD] [sssd PR#62][-Changes requested] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Thank you, the patches still work and Coverity didn't find anything either. ACK """ See the full comment at https://github.com/SSSD/

[SSSD] [sssd PR#62][+Accepted] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#68][+Changes requested] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider jhrozek commented: """ Thank you for the patch. I checked it by inspecting the values from ad_opts.c and krb5_opts.c and ldap_opts.c with vimdiff. I only have two questions:

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ Thank you for the patch. I wonder if you were actually able to reproduce the bug? If so, can you help me reproduce it locally? """ See the full comment at https:

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/16/summary.html """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ * sssd-1-14: * 74711db46029415cc9590bb0e3f9cc662dac1d0c * 0157678081e299660105c753f2d2ac2081960bca """ See the full comment at https://github.com/

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ @sumit-bose the patches do not apply cleanly on top of the sssd-1-13 branch, it looks like there is a conflict in the INI rules code. Could you please push patches f

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ * master: * ce43f710c9638fbbeae077559cd7514370a10c0c * c8fe1d922b254aa92e74f428135ada3c8bde87a1 """ See the full comment at https://github.com/

[SSSD] [sssd PR#62][closed] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Author: sumit-bose Title: #62: PAM: add pam_response_filter option Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/62/head:pr62 git checkout pr62

[SSSD] [sssd PR#62][-Accepted] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ thank you, pushed to sssd-1-13: sssd-1-13: * 5cbea81f6019d4c6acc94b8cec0b955d1767430b * 27e38ce07c3f2bb9682e2219ac2ac78e855d43b5 """ See the full

[SSSD] [sssd PR#62][+Pushed] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider jhrozek commented: """ On Wed, Nov 02, 2016 at 06:18:57AM -0700, Justin Stephenson wrote: > Thanks for your comments Jakub, please see below: > > 1) Yes, I wi

[SSSD] [sssd PR#49][-Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][+Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ (Sorry about adding and removing the label, I misread that CI needs to finish) ""&qu

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ https://fedorahosted.org/sssd/ticket/3230 """ See the full comment at https://github

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ master: e5a984093ad7921c83da75272cede2b0e52ba2d6 24d8c85fae253f988165c112af2081

[SSSD] [sssd PR#49][+Pushed] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#60][closed] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Author: taupehat Title: #60: Document ad_access_filter search for nested groups Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/60/head:pr60 git checkout pr60 ___

[SSSD] [sssd PR#60][-Accepted] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahost

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ master: cf5357ae83cc9fe2240038b8bdccec2cb98991fc sssd-1-14: e1c2aead482cd4bf83a7fe5e68630a981389e82b If any of the maintainers think we should apply th

[SSSD] [sssd PR#49][-Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][closed] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#60][+Pushed] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ Setting changes requested to rework the patch to only include the sudoUser and not sudoUserAlias """ See the full comment at

[SSSD] [sssd PR#43][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ Setting changes requested to rework the patch to only include the sudoUser and not sudoUserAlias """ See the full comment at htt

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ Oops sorry I accidentally replied to list instead of commenting in the PR. Let me paste my commend again here: Because in responders, we shou

<    1   2   3   4   5   6   7   8   9   10   >