Re:

Hello Anton I like the latest version of this fix! It looks good to me. Thanks alexp On 6/21/2016 20:55, Anton Litvinov wrote: Hello Sergey and Semyon, Sergey, thank you for review of this fix. In the 1st version of the fix I decided to return "null", because at least one implementation of

Re: [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

Hello Mikhail This version looks good to me Thanks alexp Hi Sergey, you are right, it's easier to check classloader for null before to add it to hashtable: http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.01/src/java.desktop/share/classes/javax/swing/JEditorPane.java.udiff.html On 6

Re: [9] Review request for 8157322: Several typos in javadoc

Hello Dmitry Looks just great! Thanks alexp On 5/19/2016 13:35, dmitry markov wrote: Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8157322 webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/ Fixed several typos in cl

Re: [9] Review request for 8136998: JComboBox prevents wheel mouse scrolling of JScrollPane

Looks great! Thanks alexp On 5/18/2016 14:55, Alexey Ivanov wrote: Hi Alex, It makes sense, thanks. Updated webrev: http://cr.openjdk.java.net/~aivanov/8136998/jdk9/webrev.01/ Regards, Alexey On 17.05.2016 20:18, Alexander Potochkin wrote: Hello Alexey The scrollerMouseWheelListener

Re: [9] Review request for 8136998: JComboBox prevents wheel mouse scrolling of JScrollPane

Hello Alexey The scrollerMouseWheelListener field is only initialized in the installScrollerListeners() method which is called from the protected configureScroller(). So if a customer UI delegate overrides configureScroller() method, the scrollerMouseWheelListener may not be initialized. Coul

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

Hello Semyon Alexander, I just double-checked the jdk9 code. See this public synchronized void waitForIdle() { checkNotDispatchThread(); SunToolkit.flushPendingEvents(); ((SunToolkit) Toolkit.getDefaultToolkit()).realSync(); } it calls both flushPendingEvents()

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

Hello I just checked the code in JDK9 and found that it still syncs only with the EDT and completely ignores the toolkit thread. I cannot agree. Robot uses native SunToolkit.syncNativeQueue() to syncs it with the native event queue. Robot.waitForIdle() doesn't use SunToolkit.syncNativeQueue(

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

Hello > You use Thread.sleep and critical sections in the test. Why not to use AWT robot's waitForIdle() ? waitForIdle() never really worked back in JDK7. I just checked the code in JDK9 and found that it still syncs only with the EDT and completely ignores the toolkit thread. So I don't r

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

Hello Mikhail Looks great! Thanks alexp On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.05/

Re: CFV: New Swing Group Member: Semyon Sadetsky

Vote: yes On 3/21/2016 09:01, Alexander Scherbatiy wrote: I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race condition improvement, Undo

Re: [9] Review Request: 8147994 [macosx] JScrollPane jitters up/down during trackpad scrolling on MacOS/Aqua

Hello Sergey The fix looks good. Please commit it to the repo soon! Thanks a lot alexp On 2/29/2016 18:14, Sergey Bylokhov wrote: On 29.02.16 13:24, Alexey Ivanov wrote: Hi Sergey, The fix looks good. Could you please make the frame disappear when the test completes? Yes, the new version

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

. In case the impact caused by this change has caused some definitive regressions, please mention them so they can be addressed. Thank you. With Regards, Avik Niyogi On 25-Feb-2016, at 6:45 pm, Alexander Potochkin <mailto:alexander.potoch...@oracle.com>> wrote: Hello Avik AquaT

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik AquaTruncatingTabbedPaneLayout has a lot of code which is specific for the AquaTabbedPaneUI. I don't think setting the layout manager from the base class is the right solution here. If there is a problem with minimum size it should be fixed inside the AquaTabbedPaneUI Thanks ale

Re:

Hello Semyon The fix looks good. Thanks alexp On 9/8/2015 23:57, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8134828 webrev: http://cr.openjdk.java.net/~ssadetsky/8134828/webrev.00/ This is a regression from the 8041642 which introd

Re: [9] Review Request: 6368321 MetalRootPaneUI calls to deprecated code

Looks good. (although a bit scary:-)) Thanks alexp Hello. Please review the fix for jdk9. I do not plan to backport it to jdk8. Usage of deprecated methods(xxxMenuBar()) were removed as suggested in the bug comments. The fix is a part of https://bugs.openjdk.java.net/browse/JDK-8066622 effor

Re: [9] request for review: 8073001: Java's system LnF on OS X: editable JComboBoxes are being rendered incorrectly

Hello Andrew Looks good! Thanks alexp On 4/28/2015 5:56 PM, Andrew Brygin wrote: Hello Alexander, suggested way also works fine. Please take a look to updated fix: http://cr.openjdk.java.net/~bae/8073001/9/webrev.01/ Thanks, Andrew On 4/27/2015 5:13 PM, Alexander Potochkin wrote: Hello

Re: [9] request for review: 8073001: Java's system LnF on OS X: editable JComboBoxes are being rendered incorrectly

Hello Andrew Can we update the existing focusListener class created in AquaComboBoxUI.createFocusListener() method and add there if (arrowButton != null) { arrowButton.repaint(); } to re use the methods configure/unconfigureEditor methods from the base class? Thanks alexp

Re: [9] Review request for 8074956: ArrayIndexOutOfBoundsException in javax.swing.text.html.parser.ContentModel.first()

Hello Alexey Looks good! Thanks alexp On 4/13/2015 4:34 PM, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8074956 webrev: http://cr.openjdk.java.net/~aivanov/8074956/jdk9/webrev.00/ Description: Implementation of

Re: [9] Review request for 8072900: Mouse events are captured by the wrong menu in OS X

Hello Anton Looks good! Thanks alexp On 3/5/2015 8:19 PM, Anton Nashatyrev wrote: Hi Sergey, thanks for review! I've fixed the test as you suggested (renamed, using Robot, test for all LAFs). Please take a look ta the new version: http://cr.openjdk.java.net/~anashaty/8072900/9/web

Re: [9] Review request for JDK-7170310: ScrollBar doesn't become active when tabs are created more than frame size

Hello Alexey The fix looks good Thanks alexp On 10/9/2014 4:07 PM, Alexey Ivanov wrote: Hello Swing team, A small update to the test: I explicitly set look-and-feel to MetalLookAndFeel. Updated webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/ Thanks, Alexey. On 08.10.

Re: [9] Review request for 8058120: Rendering / caret errors with HTMLDocument

Hello Dmitry Looks good! Thanks alexp On 10/9/2014 12:08 PM, dmitry markov wrote: I ran related JCK and regression tests and did not observe any failures. Thanks, Dmitry On 08/10/2014 16:04, Alexander Scherbatiy wrote: The fix looks good to me. Could you also test the fix with the JCK

[9] Review request for JDK-8054543 Setting a border on a JLayer causes an Exceptions

Hello Please review the fix the the following RFE: https://bugs.openjdk.java.net/browse/JDK-8054543 JLayer.setBorder() method is implemented to constantly throw an IllegalArgumentException for every parameter except null. It breaks some of the third party libraries which set borders for a comp

Re: CFV: New Swing Group Member: Alexander Zvegintsev

Vote: yes alexp On 9/8/2014 5:56 PM, Alexander Scherbatiy wrote: I hereby nominate Alexander Zvegintsev (OpenJDK user name: azvegint) to Membership in the Swing Group. Alexander has contributed some changes in Swing, which are a part of JDK 9. Here is the list of fixes: http://hg.openjdk

Re: [9] Review request for 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

looks good Thanks alexp On 9/9/2014 1:53 PM, dmitry markov wrote: Hi Alexandr, I have added updateAfterChange() method as you suggested. New version is located at http://cr.openjdk.java.net/~dmarkov/8048110/jdk9/webrev.03/ Thanks, Dmitry On 08/09/2014 14:44, Alexander Scherbatiy wrote: On

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

The fix looks fine Thanks alexp On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JD

Re: Review request for 8042835: unexpected mnemonic in JFileChooser

Looks good! Thanks alexp On 8/11/2014 11:39 AM, artem malinko wrote: Hello again. Could somebody else join to the review please? On 8/7/2014 6:21 PM, artem malinko wrote: Thank you, Alexandr. > The link to the webrev points to the 8047288 fix instead of 8042835 Sorry, some weird copy and pas

Re: [9] Review request for 8044371: setOneTouchExpandable functionality of JSplitPane will reduce vertical Scrollbar

Hello Anton Looks good alexp On 6/24/2014 8:31 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8044371/9/webrev.00/ bug: https://bugs.openjdk.java.net/bro

[9] Review request for JDK-8041982 Use of animated icon in JLayer causes CPU spin

Hello Please review the fix the the following RFE: https://bugs.openjdk.java.net/browse/JDK-8041982 JLayer/LayerUI classes don't currently allow to override the imageUpate() method to control the specific cases involved animated gif images. The proposed API change provides the required API fo

Re: [9] Review request for JDK-8046239: Build failure in 9-client on all non-Windows platforms

Hello Alexey The fix looks good for me Thanks! alexp On 6/9/2014 5:19 PM, Alexey Ivanov wrote: Hi Petr, Anthony, AWT and Swing teams, Could you please review the following webrev for JDK-8046239 to fix build failure: http://cr.openjdk.java.net/~aivanov/8046239/jdk9/webrev.01/ The build fai

Re: [9] Review request for 8041725: Nimbus JList selection colors persist across L&F changes

Hello Anton Looks good! Thanks alexp On 5/15/2014 1:06 PM, Anton Litvinov wrote: Hello, Could you please review the following fix for the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8041725 Webrev: http://cr.openjdk.java.net/~alitvinov/8041725/jdk9/webrev.00 The bug consists in the f

Re: [9] Review request for 8032874: ArrayIndexOutOfBoundsException in JTable while clearing data in JTable

Looks good Thanks alexp On 4/15/2014 3:30 PM, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 4/15/2014 11:13 AM, dmitry markov wrote: On 14/04/2014 17:06, Alexander Scherbatiy wrote: On 4/14/2014 4:33 PM, dmitry markov wrote: Alexandr, Please find my a

Re: [9] Review Request: JDK-8032878: Editable combos in table do not behave as expected

27;if' with the call to component.processKeyBinding. It works this way too, and code duplication is eliminated. Thank you for your suggestion, Alex: The code is cleaner. Regards, Alexey. On 20.03.2014 14:43, Alexander Potochkin wrote: Hello Alexey Please add /** * {@inheritDoc}

Re: [9] Review Request: JDK-8032878: Editable combos in table do not behave as expected

Hello Alexey Please add /** * {@inheritDoc} */ to the overridden protected method. Could you also try to callprocessKeyBinding on the editor component to avoid copy/paste the action processing code Thanks alexp On 3/20/2014 10:18 AM, Alexey Ivanov wrote: Reminder. Could you please

Re: [9] Review request for 7094099: DropDown List of JComboBox detached

Hello Anton Looks good to me! Thanks alexp On 2/14/2014 7:27 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/7094099/9/webrev.00/ bug: https://bugs.openj

Re: [9] Review request: 8028616 Htmleditorkit parser doesn't handle leading slash (/)

looks good Thanks alexp On 1/13/2014 2:23 PM, dmitry markov wrote: Hello Alexandr, Thank you for the review. I updated the test as you suggested. Please find new version here - http://cr.openjdk.java.net/~dmarkov/8028616/jdk9/webrev.01/ Thanks, Dmitry On 10/01/2014 17:12, Alexander Scherb

Re: Code review request: 8026929: remove accelerators from policytool resources

Hello Leif Okay, I approve Thanks alexp On 10/22/2013 8:12 PM, Leif Samuelsson wrote: Hi Alexander, On 2013-10-22 04:25, Alexander Potochkin wrote: Hello Leif There was a special logic for keyStrokes on MacOS inPolicyTool.addMenuItem(), could you make sure that the new code correctly set

Re: Code review request: 8026929: remove accelerators from policytool resources

Hello Leif There was a special logic for keyStrokes on MacOS inPolicyTool.addMenuItem(), could you make sure that the new code correctly set keyStrokes on MacOS? Thanks alexp Hi All, This is a small additional fix to PolicyTool to move the default accelerators for File->New/Open/Save from th

Re: Code review request: 7025699: Policy Tool is not accessible by keyboard

I/O to a worker thread. All other operations are event driven and therefore occur directly on the EDT. Leif On 2013-10-15 09:56, alexander potochkin wrote: Hello Well, performing I/O or other blocking operations on EDT can only freeze the app's GUI for the period of blocking. If devel

Re: Code review request: 7025699: Policy Tool is not accessible by keyboard

Hello Well, performing I/O or other blocking operations on EDT can only freeze the app's GUI for the period of blocking. If developers/users are OK with that, this is fine with me too. I don't think an I/O blocking operation on EDT is acceptable. It can freeze the whole application and giv

Re: [8] Review request for CR 8015601 [TEST_BUG] [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X

Hello Mikhail Looks good for me Thanks alexp On 9/13/2013 5:14 PM, mikhail cherkasov wrote: Hi Alexander, There's new version http://cr.openjdk.java.net/~mcherkas/8015601/webrev.01/ Thank you for your remarks. Thanks, Mikhail. O

Re: [8] Review request for 8024395: Improve fix for line break calculations

Hello Dmitry Looks good Thanks alexp On 9/10/2013 5:53 PM, dmitry markov wrote: You are right. I corrected the fix. The webrev is located at http://cr.openjdk.java.net/~dmarkov/8024395/jdk8/webrev.02/ Thanks, Dmitry On 10/09/2013 17:04, Alexander Scherbatiy wrote: On 9/10/2013 4:40 PM, dmit

Re: [8] Review request for 8023392: Swing text components printed with spaces between chars

Hello Anton Looks good alexp Hello, here is the new webrev (including manual regression test and proposed changes): http://cr.openjdk.java.net/~dmarkov/8023392/webrev.01/ . Could you please review it? Thanks! Anton. On 26.08

Re: [8] Review request for 8023474: First mousepress doesn't start editing in JTree

Hello Dmitry The fix looks good to me as well I should say that the final version is much better than the first one, thank you Anthony for the thorough review! alexp On 8/23/2013 4:18 PM, dmitry markov wrote: Hi Anthony, Thank you for your comments. I changed the fix based on your suggestio

Result: New Swing Group Member: Artem Ananiev

Voting for Artem Ananiev to the Swing group membership[1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. alexp [1] http://mail.openjdk.java.net/pipermail/swing-dev/2013-June/002800.html

CFV: New Swing Group Member: Artem Ananiev

/AWT area for JDK7 and JDK8. Votes are due by Jul 9, 2013. Only current Members of the Swing Group [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thanks Alexander Potochkin [1] http://openjdk.java.net/census#swing [2] http://openjdk.java.net

Re: [8] Review request for 8016534: javax/swing/text/View/8014863/bug8014863.java failed

Hello Dmitry Looks fine Thanks alexp Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016534 webrev: http://cr.openjdk.java.net/~dmarkov/8016534/webrev.00/ The fix adds a calculation of the frame's width which is based on the font metrics for

Re: [8] Review request for 8015853: java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo

Hello Dmitry Looks good! Thanks alexp Hi, Sergey, I removed the tags, as you requested. Please find new webrev at: http://cr.openjdk.java.net/~dmarkov/8015853/webrev.01/ Thanks, Dmitry On 06/06/2013 14:10, Sergey Bylokhov wrote: Hi, Dmitry. 24 * @test 25 * @bug 8015853 26 * @su

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Hello Dmitry looks good! Thanks alexp On 6/3/2013 4:09 PM, dmitry markov wrote: Hi Alexandr, I have just tested the fix. The tests are passed. Thanks, Dmitry On 03/06/2013 13:39, Alexander Scherbatiy wrote: Could you test your fix with the Notepad and Stylepad demos and run the regres

Re: [8] Review request for 7151823: The test incorrectly recognizing OS

Looks good! Thanks alexp On 6/2/2013 1:30 PM, Anton Litvinov wrote: Hello, Please review the following fix for the bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823 Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00 The bug consists in the fact that a regress

Re: [8] Review request for 6337518: Null Arrow Button Throws Exception in BasicComboBoxUI

e test was moved to "test/javax/swing/JComboBox" directory. Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.01 Thanks much for changing the test! Looks great now, approved alexp Thank you, Anton On 5/31/2013 9:14 PM, Alexander Potochkin wrote: Hello Anton The fix an

Re: [8] Review request for 6337518: Null Arrow Button Throws Exception in BasicComboBoxUI

Hello Anton The fix and the test look good, only a minor comment It is a common practice to name the new Swing tests like this: /ComponenetName/bugNumber/bugNumber.java I think it makes sense to follow the known pattern, so could you rename**NPEOnInstallComponentsTest folder to "6337518" by th

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Hello Dmitry Looks good! alexp On 5/31/2013 12:53 PM, dmitry markov wrote: Hello, Please review the back-port of the fix for 8014863 to jdk7u. The changes are the same. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863 webrev for jdk7u-dev: http://cr.openjdk.java.net/~vkarna

Re: [8] Review request for 6436314: Vector could be created with appropriate size in DefaultComboBoxModel

Hello Vlad Looks good! Thanks alexp On 5/31/2013 3:21 PM, Vladislav Karnaukhov wrote: Hello, could you please review the fix for 6436314? bug: http://bugs.sun.com/view_bug.do?bug_id=6436314 webrev: http://cr.openjdk.java.net/~vkarnauk/6436314/webrev.00/ The fix is trivial. It's not feasible

Re: [8] Review request for 7068740: If you wrap a JTable in a JLayer you can't use the page up and page down cmds

Hello Vlad Looks good Thanks alexp On 5/30/2013 5:04 PM, Vladislav Karnaukhov wrote: Yes, I found another occurrence of this code. Please consider the new version: http://cr.openjdk.java.net/~vkarnauk/7068740/webrev.01/ Regards, - Vlad On 5/30/2013 04:01 PM, Alexander Scherbatiy wrote:

Re: [8] Review request for 8014863 Line break calculations in Java 7 are incorrect.

Hello Dmitry Looks good ! Thanks alexp On 5/27/2013 6:09 PM, dmitry markov wrote: Hi Alexander, I have changed the fix according to your comments: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863 webrev: http://cr.openjdk.java.net/~vkarnauk/8014863/webrev.01/ The metho

Re: [8] Review request for 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

Looks good Thanks alexp On 22.04.2013 14:48, mikhail cherkasov wrote: Hello all, javadoc was added: http://cr.openjdk.java.net/~mcherkas/8012004/webrev.01/ Thanks, Mikhail. On 19.04.2013 15:59, mikhail cherkasov wrote: Hello All

Re: [7uX] Review request for 8009221: [macosx] Two closed/javax/swing regression tests fail on MacOSX

Hello Vlad Looks good for me as well Thanks alexp On 3/28/2013 2:33 PM, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 3/28/2013 2:13 PM, Vladislav Karnaukhov wrote: Hello, please review a fix/backport for 8009221 into jdk7. The fix was approved and in

Re: [8] Review request for 8009221 [macosx] Two closed/javax/swing regression tests fail on MacOSX.

Hello Alexander Looks good! Thanks alexp Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009221 webrev: http://cr.openjdk.java.net/~alexsch/8009221/webrev.00 The tests are adopted to use Ctrl+Alt mnemonic key combination on Mac OS X and moved

Re: [8] Review request for 6877495 JTextField and JTextArea does not support supplementary characters

Hello Alexander I checked the code again, there is no need to send it to 2D-dev, so just approved Thanks much alexp Hello Mikhail From the Swing point of view it looks good, I approve. However I would recommend sending the fix to 2D alias as well, since they know much more about UTF. Than

Re: [8] Review request for 6877495 JTextField and JTextArea does not support supplementary characters

Hello Mikhail From the Swing point of view it looks good, I approve. However I would recommend sending the fix to 2D alias as well, since they know much more about UTF. Thanks alexp Hi Everyone, This is just friendly reminder about this review request. Thanks, Mikhail. On 20.02.2013 19:29

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

so looks good for me as well Thanks alexp On 2/13/2013 5:58 PM, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 2/12/2013 4:42 PM, Vladislav Karnaukhov wrote: Hello, please review a little face-lifting and refactoring: http://cr.openjdk.java.net/~vkarnau

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

also good for me Thanks! alexp On 2/8/2013 5:23 PM, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 2/8/2013 4:20 PM, Vladislav Karnaukhov wrote: I agree. By reverting changes in BasicComboBoxUI.getNextIndex, we can be sure that the fix won't affect defaul

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Hello Alexander - key == PAGE_UP / (key == PAGE_DOWN) Are ui.listBox.getSelectedIndex() and comboBox.getSelectedIndex() the same when the "ComboBox.noActionOnKeyNavigation" property is unset? If so, only the ui.listBox.getSelectedIndex() can be used for both cases. - key == HIDE I w

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Hello Vlad Hello, please review a new version of the fix: http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.02/ Support for VK_PAGE_DOWN/VK_PAGE_UP and VK_HOME/VK_END keys was added; test routine was altered accordingly. nice catch approved Thanks alexp Regards, - Vlad

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

1/16/2013 05:45 PM, Alexander Potochkin wrote: Hello Vlad The fix overall looks good, however there are some comments: it is better to use UIManager.getBoolean() in this case, it will enable you to skip the null check in the test you should use SunToolkit.realSync() instead of sleep() (please

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Hello Vlad The fix overall looks good, however there are some comments: it is better to use UIManager.getBoolean() in this case, it will enable you to skip the null check in the test you should use SunToolkit.realSync() instead of sleep() (please also call realSync in the very beginning of the

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

Hello Anthony Hi Anton, This fix seems to resolve the test failure, but not the bug itself. Do you think it makes sense to investigate why the Mac OS X L&F isn't serializable, and perhaps make it serializable so that the test passes w/o any modifications? Let me answer this question. It i

Re: [7] Review request for 7123767 Wrong tooltip location in Multi-Monitor configurations

Hello Vlad The fix looks good to me as well (remember, you need 2 reviewers for 7u) Thanks alexp On 9/12/2012 6:54 PM, Pavel Porvatov wrote: Hi Vladislav, The fix looks good for me. See also comments below Hello Pavel, all, I've reverted some of the changes, please find new webrev here: ht

Result: New Swing Group Member: Alexander Scherbatiy

The vote for Alexander Scherbatiy [1] is now closed. Yes: 1 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Alexander Potochkin [1] http://mail.openjdk.java.net/pipermail/swing-dev/2011-November/001839.html

Re: CFV: New Swing group Lead: Pavel Porvatov

| Vote: yes Welcome Pavel, you are the best candidate for this position Thanks alexp | Hi, Swing group, as many of you know, Alexander Potochkin, who has been a Swing group Lead for last several years, has moved to another position at Oracle. Although he is still involved to Swing

Re: [7] Review request for 7093156: NLS: Please change the mnemonic assignment system to avoid translation issue (Swing files)

Hello Alexander This is the new webrev with the fixed comments in the property files. http://cr.openjdk.java.net/~alexsch/7093156/webrev7.01/ The *.properties files are different in the JDK7 and JDK8 because for example the JDK8 version of basic.properties file contains 2 extra

Re: Request review for 7129742 : Unable to view focus in Non-Editable TextArea

I think this modification should not bring side effect. On Mon, Mar 12, 2012 at 1:27 AM, Alexander Potochkin <mailto:alexander.potoch...@oracle.com>> wrote: Hello Sean Could you give more details about your changes in XTextFieldPeer? Thanks alexp Hi all,

Re: Request review for 7129742 : Unable to view focus in Non-Editable TextArea

Hello Sean Could you give more details about your changes in XTextFieldPeer? Thanks alexp Hi all, I updated the patch to as suggested and simplified the testcase . Would anyone like to take a look again ? Thanks. The webrev is at : http://cr.openjdk.java.net/~zhouyx/7129742/webrev.04/

Re: Miglayout

Hello Frans There are a lot of great Swing components and there are also a list of good reasons why not to include them to the JDK: 1. Once a component is in JDK it becomes "frozen", it can't be updated as quick as it used to be, because the JDK updates don't go out every month. 2. Most of th

Re: JSplitPane / heavyweight vs. lightweight components

Hello Christopher I wish we could have turned it on by default, but it caused regressions in the users' code so we made it optional to preserve the backward compatibility User's code is broken whenever it is not on and native components are used. It is hard to figure out this property. When I u

Re: JSplitPane / heavyweight vs. lightweight components

Hello Christopher Does this means there is going to be some work in JDK 8 so that the smart invalidation becomes the default? I think Swing folks could elaborate on the current status of the issues. I wish we could have turned it on by default, but it caused regressions in the users' code so

CFV: New Swing Group Member: Alexander Scherbatiy

the*Swing* Group [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. *Thanks Alexander Potochkin* [1] http://openjdk.java.net/census#swing [2] http://openjdk.java.net/groups/#member-vote|

Re: Painting a JComponent without clipping children

juin 2011, at 16:13, Alexander Potochkin wrote: Hello Herve I don't really get it why you need to avoid setting the clip, but anyway the following may be interesting to you http://www.pbjar.org/blogs/jxlayer/jxlayer40/ Piet is transforming Swing components using JXLayer component Tha

Re: Painting a JComponent without clipping children

clip wouldn't hurt you If you control the painting hierarchy you can also try overriding paint() method of every child component and reset clip there However may the hack you found is only way to make what you need Thanks alexp Regards, Herve Sent from my iPad On 3 juin 2011, at 16:13,

Re: Painting a JComponent without clipping children

Hello Herve I don't really get it why you need to avoid setting the clip, but anyway the following may be interesting to you http://www.pbjar.org/blogs/jxlayer/jxlayer40/ Piet is transforming Swing components using JXLayer component Thanks alexp (reposted from awt-dev list, I picked up the wr

Re: How to resolve image tearing

you should use, please make your mind yourself :-) Thanks alexp Thanks and Best Regards, xmly At 2011-05-31 21:39:09??"Alexander Potochkin" wrote: >Hello Ximalaya >> Thank you all, good conclusion to JDK users, :) > >A small follow-up from me: > >JComponent.re

Re: Fwd: JDK 8 Mercurial forests available

Hello Artem Hi, AWT and Swing teams, some time ago I proposed merging AWT and Swing forests for JDK8, which would make the integration into the master a bit easier. If there are no objections, I will forward the proposal to Mark. I've no objections, go ahead! Thanks alexp Thanks, Artem

Re: How to resolve image tearing

Hello Ximalaya Thank you all, good conclusion to JDK users, :) A small follow-up from me: JComponent.repaint() indeed called getLocationOnScreen() for a short period of time in JDK 7 but it was fixed in b132, the bug's number is 6993171 JDK 6 has never have it Let me know if there are any

Re: How to resolve image tearing

Hello Ximalaya Hi Artem, Nice to get your quick reply. It's really a surprise "JComponent.repaint() is no longer thread safe". Regarding question 1, I ever looked into JDK source code, it seems JComponent.paint only takes care of lw sub-components. We didn't change JComponent.repaint() to mak

Re: NPE: JComponent.paintComponent in 6u25, 7b140

t I didn't save stack trace for all threads. Martin Stack trace AWT-EventQueue-0@2851, priority=6, in group 'main', status: 'RUNNING' at javax.swing.JComponent.paintComponent(JComponent.java:755) - Original Message - From: "Alexander Potochkin&

Re: NPE: JComponent.paintComponent in 6u25, 7b140

Hello I guess there is a threading problem in the code, Janda, could you override the paintComponent() method of the component where the exception is thrown and make sure that it is called on the Event Dispatching Thread? System.out.println("SwingUtilities.isEventDispatchThread() = "+SwingUt

hg: jdk7/swing/jdk: 7036148: NullPointerException with null JMenu name

Changeset: d353dcff4f14 Author:alexp Date: 2011-04-15 21:36 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d353dcff4f14 7036148: NullPointerException with null JMenu name Reviewed-by: rupashka ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JMenuItem

hg: jdk7/swing/jdk: 2 new changesets

Changeset: 707f3c6e66af Author:alexp Date: 2011-03-24 17:00 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/707f3c6e66af 6735285: "Zero" x,y springs passed to SpringLayout.Constraints constructor are not returned from getters Reviewed-by: rupashka ! src/share/classes/java

swing-dev@openjdk.java.net

Changeset: 91a590306e02 Author:alexp Date: 2011-04-22 20:54 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/91a590306e02 7036871: Some JCK interactive JSplitPane tests that test continuous layout fail with Nimbus L&F Reviewed-by: rupashka ! src/share/classes/javax/swing/J

hg: jdk7/swing/jdk: 6985329: 9 classes in swing.plaf contains words inappropriate for public spec - about some compiler bug

Changeset: 71e769dc8cf6 Author:alexp Date: 2011-04-15 21:26 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/71e769dc8cf6 6985329: 9 classes in swing.plaf contains words inappropriate for public spec - about some compiler bug Reviewed-by: rupashka ! src/share/classes/javax

hg: jdk7/swing/jdk: 2 new changesets

Changeset: d6afc2ca81cc Author:alexp Date: 2011-04-15 20:50 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d6afc2ca81cc 7032903: javax/swing/JComponent/6989617/bug6989617.java test fails against jdk7 Reviewed-by: rupashka ! test/javax/swing/JComponent/6989617/bug6989617.j

swing-dev@openjdk.java.net

Changeset: 39a71949f1a4 Author:alexp Date: 2011-04-04 21:37 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/39a71949f1a4 7032791: TableCellRenderer.getTableCellRendererComponent() doesn't accept null JTable with GTK+ L&F Reviewed-by: rupashka ! src/share/classes/javax/swi

Re: Should disable item be navigable?

Hello Charles On 03/28/2011 10:46 PM, Alexander Potochkin wrote: Hello Charles Hi guys, Are there some spec about the navigable? Should disable item be navigable? I have notice, in the src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java, line 1000

hg: jdk7/swing/jdk: 7027486: JPopupMenu doesn't take window shape into account

Changeset: 9024198193ce Author:alexp Date: 2011-03-29 21:02 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/9024198193ce 7027486: JPopupMenu doesn't take window shape into account Reviewed-by: rupashka ! src/share/classes/javax/swing/PopupFactory.java

Re: Should disable item be navigable?

Hello Charles Hi guys, Are there some spec about the navigable? Should disable item be navigable? I have notice, in the src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java, line 1000: "MenuItem.disabledAreNavigable", Boolean.TRUE, Should it to be FALSE as default? It

Re: Accessibility tools for JDK

Hello Lakshmi Hi, I have a bunch of fixes targeting better accessibility for the Swing components in Java. Before I contribute them, I would like to know if the OpenJDK community recommends any particular tool for validating these changes OR if there are any guidelines put down by the commun

hg: jdk7/swing/jdk: 2 new changesets

Changeset: 7dfcf271b73b Author:alexp Date: 2011-03-03 18:23 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7dfcf271b73b 6653511: JComponent.safelyGetGraphics() may sometimes return null Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java Changeset: e4ca

hg: jdk7/swing/jdk: 6826074: JScrollPane does not revalidate the component hierarchy after scrolling

Changeset: e390ce4509c6 Author:alexp Date: 2011-02-28 18:20 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e390ce4509c6 6826074: JScrollPane does not revalidate the component hierarchy after scrolling Reviewed-by: anthony ! src/share/classes/javax/swing/DefaultDesktopMana

hg: jdk7/swing/jdk: 6474153: LookAndFeel.makeKeyBindings(...) doesn't ignore last element in keyBindingList with odd size

Changeset: a93bb05d00fd Author:alexp Date: 2011-02-18 19:21 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/a93bb05d00fd 6474153: LookAndFeel.makeKeyBindings(...) doesn't ignore last element in keyBindingList with odd size Reviewed-by: rupashka ! src/share/classes/javax/s

hg: jdk7/swing/jdk: 6956842: BasicTreeUI.getPreferredSize(JComp c) is delegated to getPreferredSize(c, true) not (c, false)

Changeset: 82f7b8f6b174 Author:alexp Date: 2011-02-15 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/82f7b8f6b174 6956842: BasicTreeUI.getPreferredSize(JComp c) is delegated to getPreferredSize(c, true) not (c, false) Reviewed-by: rupashka ! src/share/classes/javax

  1   2   3   >