Re: C code generator and much improved contraction logic

2010-07-27 Thread Toon Verstraelen
On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 The ability to create code that loops over array arguments is much

Re: C code generator and much improved contraction logic

2010-07-27 Thread Toon Verstraelen
On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: The code is also on github: http://github.com/jegerjensen/sympy/tree/codegen_C2 I have two failing tests on my system. __

fortran code generator reviewing

2010-07-10 Thread Toon Verstraelen
Hi, I've been looking into the fcode and codegen implementation. Sorry for the delay. First of all: I'm really happy with the work being done. I wish I could dedicate more time to the reviewing. I have a few small patches, but consider them as suggestions. (See attachments.)

Re: Issue 1411 Patch

2010-04-15 Thread Toon Verstraelen
On 04/15/2010 07:57 AM, Matt Curry wrote: Yea, I'll attach the patch in this email (in both zipped and non-zipped versions). I've just reviewed it. The patch is good and the tests run fine. It is pushed in. Thanks. Toon -- You received this message because you are subscribed to the Google

[sympy] failing doctest in current master

2010-04-15 Thread Toon Verstraelen
Hi, I get this failing doctest: ** File /mnt/data/toon/unief/research/code/work/sympy/doc/src/modules/polynomials.txt, line 216, in polynomials.txt Failed example: solve_poly_system([y**2 - x**3 + 1, y*x], x, y)

Re: Issue 1411 Patch

2010-04-14 Thread Toon Verstraelen
Hi Matt, Thanks for the patch. Could you send patches as attachments? Line wrapping messes up the patches. It is even better to compress them with gzip to prevent mail clients from messing things up. cheers, Toon On 04/15/2010 07:03 AM, Matt Curry wrote: Hello everyone, this is my first

Re: [sympy] Action verbs in sympy: user interface

2010-03-31 Thread Toon Verstraelen
Ondrej Certik wrote: When adding these duplicate methods, we should also copy the docstring automatically, so that it is well documented at one place and the other methods just copy it somehow. That should be easy: class Foo(object): def some_method(self, x): doc pass

Re: [sympy] Re: docstring conventions that play well with sphinx

2010-03-28 Thread Toon Verstraelen
Vinzent Steinberg wrote: On Mar 27, 7:00 pm, Toon Verstraelen toon.verstrae...@ugent.be wrote: OK, thanks. I'll do that. (Apparently the docstrings of the mpmath functions are not visible in the html generated by Sphinx, but I'll see how it looks like once I try it.) That surprises me

issue 1356

2010-03-27 Thread Toon Verstraelen
Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 cheers, Toon -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group, send email to

Re: issue 1356

2010-03-27 Thread Toon Verstraelen
Priit Laes wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would be more pythonic if it returns ValueError instead of TypeError when

Re: issue 1356

2010-03-27 Thread Toon Verstraelen
Ondrej Certik wrote: On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes plaes...@gmail.com wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would

[sympy] docstring conventions that play well with sphinx

2010-03-27 Thread Toon Verstraelen
Hello, I would like to update the docstrings for the printer module somewhere in the future, but there does not seem to be a real consensus or convention on how to format docstrings in SymPy. Especially formatting the arguments of functions and methods is done in many different ways. I've

Re: [sympy] Re: docstring conventions that play well with sphinx

2010-03-27 Thread Toon Verstraelen
Ondrej Certik wrote: On Sat, Mar 27, 2010 at 7:44 AM, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: I like mpmath's format: **Arguments** *arg1* description *arg2* description Note that each docstring must (should) contain examples of usage of the function. I

Re: new patches

2010-03-25 Thread Toon Verstraelen
Ondrej Certik wrote: On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer asmeu...@gmail.com wrote: I am testing your branch now. I also left some comments on your github. Does the test_sage patch require sage to test? If it does, I won't be able to review that one, as I don't have sage

Re: [PATCH] initial fcode implementation

2010-03-25 Thread Toon Verstraelen
On Fri, Mar 19, 2010 at 12:58 PM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Thanks alot! Vinzent Steinberg wrote: The patch looks fine to me, however I'm not familiar with fortran. But no one objected so far, so I pushed it in, thanks. Vinzent 2010/2/24 Toon Verstraelen toon.verstrae

Re: [PATCH] initial fcode implementation

2010-03-25 Thread Toon Verstraelen
Ondrej Certik wrote: On Thu, Mar 25, 2010 at 12:13 AM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Right now only f77. f95 is one of the future options I'm thinkng of. Feel free to open a ticket, but I won't forget it anyway. It is mainly a matter of proper line wrapping. Yes. f77

Re: Fixed all but one audit warnings in printing

2010-03-21 Thread Toon Verstraelen
Ondrej Certik wrote: On Fri, Mar 19, 2010 at 11:36 PM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Hi, There is one warning remaining about a method in the pretty printing code that does not seem to be used anymore. I'm not sure how to handle it. The rest was trivial to fix. The patch

Re: [sympy] Re: solve with floating point coefficients

2010-03-21 Thread Toon Verstraelen
Vinzent Steinberg wrote: On 20 Mrz., 22:50, Ondrej Certik ond...@certik.cz wrote: On Sat, Mar 20, 2010 at 2:47 PM, Ondrej Certik ond...@certik.cz wrote: Thanks Aaron! It may be, that the new polynomials can't handle floating point numbers (for some algorithmic reasons), in which case imho we

Fixed all but one audit warnings in printing

2010-03-20 Thread Toon Verstraelen
. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en. From f743e4dd491b0b58de71241adf129e7f4ae6d7d1 Mon Sep 17 00:00:00 2001 From: Toon Verstraelen toon.verstrae...@ugent.be Date

Re: fix atan2() in sage

2010-03-20 Thread Toon Verstraelen
Ondrej Certik wrote: On Fri, Mar 19, 2010 at 7:01 PM, Ondrej Certik ond...@certik.cz wrote: Hi, please review my 2 patches in pu branch at github: * ee232d5 (HEAD, github/pu, pu) atan2(y, x) can now be converted to/from Sage * 17806ba test_sage: Use S() instead of sympify() please review

Re: [PATCH] initial fcode implementation

2010-03-19 Thread Toon Verstraelen
Thanks alot! Vinzent Steinberg wrote: The patch looks fine to me, however I'm not familiar with fortran. But no one objected so far, so I pushed it in, thanks. Vinzent 2010/2/24 Toon Verstraelen toon.verstrae...@gmail.com: --- doc/src/modules/printing.txt | 96 +++ sympy

[PATCH] initial fcode implementation

2010-02-24 Thread Toon Verstraelen
--- doc/src/modules/printing.txt | 96 +++ sympy/__init__.py |2 +- sympy/printing/__init__.py |1 + sympy/printing/fcode.py| 326 sympy/printing/tests/test_fcode.py | 217

Re: [sympy] Re: Boolean operators and C++ code generation

2010-02-16 Thread Toon Verstraelen
. -- Dr. ir. Toon Verstraelen Center for Molecular Modeling Ghent University Technologiepark 903, B9052 Zwijnaarde Belgium Tel: +32 9 264 65 56 E-mail: toon.verstrae...@ugent.be http://molmod.UGent.be/ http://molmod.UGent.be/code/ -- You received this message because you are subscribed

[sympy] tiny patches

2009-07-17 Thread Toon Verstraelen
=1534 -- Dr. ir. Toon Verstraelen Center for Molecular Modeling Ghent University Proeftuinstraat 86 B9000 Gent Belgium Tel: +32 9 264 65 56 E-mail: toon.verstrae...@ugent.be http://molmod.UGent.be/ http://molmod.UGent.be/code/ --~--~-~--~~~---~--~~ You received

[sympy] Re: Question about cse() (common subexpression elimination)

2009-07-16 Thread Toon Verstraelen
Christophe wrote: FIRST QUESTION So why [(x0, log(x))] is not simply (x0, log(x)) ? Same question for [x0*(1 + x0)*cos(y) + x0**2] ? That is how cse works. It stands for common subexpression elimination. You are probably using it in way that is more specific that the general

[sympy] Re: Finding factor in a product

2009-07-16 Thread Toon Verstraelen
Christophe wrote: Hello, suppose that we have the following expression : (x**2+1)*(log(x+4)-7) I would like to know that is a product and to have : (x**2+1) and (log(x+4)-7). You need to play a little with the args attribute. Try this y = (x**2+1)*(log(x+4)-7)

[sympy] Re: plan for the next month

2009-07-16 Thread Toon Verstraelen
Ondrej Certik wrote: The absolute number one priority is: * merge Fabian's assumptions branch and get rid of the old assumptions if we didn't manage nothing else, we have to manage this, it's very, very important. Although, I'm not so familiar with the internals of the new assumption

[sympy] Re: refactoring Mul and Add classes

2009-07-11 Thread Toon Verstraelen
Ondrej Certik wrote: On Fri, Jul 10, 2009 at 11:03 PM, Aaron S. Meurerasmeu...@gmail.com wrote: Also, if anyone wants to give it a shot implementing it, that would be awesome too. Here is some code I just wrote: git pull git://github.com/certik/sympyx.git cd sympyx git checkout -b

[sympy] Re: request for review: fcode

2009-07-06 Thread Toon Verstraelen
Andy Ray Terrel wrote: * fcode function should move to something like the following signature (expr, *args, **kws) and look up the keywords, it gets too many optional keywords as is. Are there convenient ways to check the validity of *args and **kwargs? The code to process *arg and **kwargs

[sympy] Re: labels in issue tracker

2009-07-04 Thread Toon Verstraelen
Aaron S. Meurer wrote: Also, we were discussing this on IRC the other day, and you may have to be a project member to access this functionality. Ok. I don't feel an urgent need to become a project member. :) (I'm not inclined to have a certain status in general.) But probably anyone

[sympy] Re: On SymPy documentation

2009-07-01 Thread Toon Verstraelen
Roberto Nobrega wrote: As we discussed on IRC, I propose: - GoogleCode: Burn it. Except for FrontPage, Downloads, etc. - Sphinx: Only for Tutorial, User Guide and Modules Reference. - MediaWiki: Everything else. Including: Patches tutorial, GSoC info, Development tips, Bibliographical

[sympy] Re: Sympy documentation day

2009-07-01 Thread Toon Verstraelen
Luke wrote: The goal of the documentation day will to get people working together at the same time to update docstrings, work on Wiki pages, and write example pieces of code that clearly demonstrate how to use one or more cool Sympy features. My (humble) contribution to the doc day can be

[sympy] Re: git updating of local files

2009-06-27 Thread Toon Verstraelen
This should reset all changes in your local directory. Use with care. git reset --hard smichr wrote: Hello, I'm looking at a git quick reference but can't figure out how to do the following. Can someone give me a hand? How can I just make sure that what I have in my local directory is

[sympy] Re: who still uses python2.4

2009-06-27 Thread Toon Verstraelen
Ondrej Certik wrote: What do you think? For most home users, there is probably no problem to drop support for 2.4. I'm not sure about computing centra. Upgrading the entire OS of a clusters is quite a job. On our university cluster, the default is 2.4.3, but 2.5.4 is available through

[sympy] Re: extending ccode

2009-06-26 Thread Toon Verstraelen
Vinzent Steinberg wrote: On Jun 25, 8:33 am, Toon Verstraelen toon.verstrae...@ugent.be wrote: In [15]: ccode(integrate(sin(x)/x,x)) Out[15]: Integral(sin(x)/x, x) This should always raise an exception. Such a thing is never ever going to be compilable. We could use a library (maybe

[sympy] extending ccode

2009-06-25 Thread Toon Verstraelen
Hi, I realized that it was probably not a good idea to ask the questions below in the issue tracker. Sorry for cross-posting. (http://code.google.com/p/sympy/issues/detail?id=1487) I have some questions/ideas about extending ccode (or fcode for Fortran). Any comments would be helpful to get

[sympy] Re: Sympy documentation day

2009-06-25 Thread Toon Verstraelen
Aaron S. Meurer wrote: I think one thing we need to do is go through and spellcheck and grammar check (for those of us who are native english speakers) all of the documentation, and maybe the comments too. I know I see errors all of the time, and most people probably do not use a

[PATCH] Initial codegen implementation.

2009-06-08 Thread Toon Verstraelen
--- sympy/test_external/test_codegen_c_cc.py | 145 + sympy/utilities/codegen.py | 347 ++ sympy/utilities/tests/test_codegen.py| 54 + 3 files changed, 546 insertions(+), 0 deletions(-) create mode 100644

Initial codegen implementation

2009-06-08 Thread Toon Verstraelen
, double y, double z) { return z*(x + y); } The codegen function is based a more complex api with more possibilities. More info can be found as comments and the doc strings. Any comments are appreciated. (coding style, typo's, code design, milestones, ...) cheers, Toon -- ir. Toon

[sympy] Re: codegen: tests that generate output files

2009-06-08 Thread Toon Verstraelen
Aaron S. Meurer wrote: Do you think we would need to run a configure [0] script for this? I am not highly familiar with this, but it seems that any time I download come C that needs to be compiled (i.e., an open source software package), it uses configure and make to ensure that it

[sympy] codegen: tests that generate output files

2009-06-05 Thread Toon Verstraelen
? cheers, Toon -- ir. Toon Verstraelen Center for Molecular Modeling Ghent University Proeftuinstraat 86 B9000 Gent Belgium Tel: +32 9 264 65 56 E-mail: toon.verstrae...@ugent.be http://molmod.UGent.be/ http://molmod.UGent.be/code/ --~--~-~--~~~---~--~~ You

[sympy] Re: codegen: tests that generate output files

2009-06-05 Thread Toon Verstraelen
Ondrej Certik wrote: On Fri, Jun 5, 2009 at 9:59 AM, Ondrej Certikond...@certik.cz wrote: Hi Toon! On Fri, Jun 5, 2009 at 8:09 AM, Toon Verstraelentoon.verstrae...@ugent.be wrote: Hello, I'm writing a very initial version of a code generator. I would like to add proper tests for the

[sympy] Re: cse experiments (with C/Fortran code generator in mind)

2009-04-30 Thread Toon Verstraelen
Ondrej Certik wrote: I suggest you first hack on the C code generation that you need. I am sure if you work on this in a general way, Luke will help out too, as he needs it in pydy too. And I'll help too, since this is something that is needed. As to fixing the issues #1399 and #1400 in

[sympy] Re: cse experiments (with C/Fortran code generator in mind)

2009-04-30 Thread Toon Verstraelen
Neal Becker wrote: On Wednesday 29 April 2009, Toon Verstraelen wrote: ... The cse routine generates subexpressions that are only used once such as x2, x4, x5 and x6. I would suggest to change this, because this unnecessarily increases the number of local variables used in the C routine