Updates:
Summary: expand(power_base=True) is too aggressive
Comment #2 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This behavior is comes from expand_pow_base upon which separatevars
depends, so it's
not intri
Comment #3 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I don't know why that one doesn't work, when separatevars can do it. That
is another issue (issue 1767).
I agree to put an assumptions argument in power_base.
Comment #4 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
By the way, how would you structure the assumptions argument to expand.
Should there be an
ignore_assumptions=True argument, or should there be separate hints
Updates:
Labels: NeedsReview
Comment #5 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
OK, smichr's branch 1766 at github has patches for this issue and issue
1767 for review.
regarding comment 3: making assumpt
Comment #6 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Here is a slightly modified example that shows that even Maple ignores
assumptions on ODEs (Maple is usually a real stickler when it
comes to assumptions):
> d
Updates:
Cc: smichr
Comment #7 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Issue 1767 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of
Comment #8 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Looks fine to me.
Only '...=[]' should have more whitespaces and maybe there should be a flag
to
overwrite the assumptions. Or dsolve() could try to a
Comment #9 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Issue 1759 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you
Updates:
Cc: asmeurer
Comment #10 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This commit has been updated. I no longer see the ...=[] that you were
referring to,
Vinzent. Maybe I changed it in the editing pro
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #11 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
A doctest fails. Should be trivial to fix.
___ sympy.simplify.simplify.fract
Comment #12 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Otherwise the patch looks fine.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred thi
Comment #13 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
The ODE change is fine.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #14 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Forced update fixing doctest is available again in the same branch, 1766.
--
You received this message beca
Comment #15 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Thanks, looks fine now. Only the 'if not funcs: return' line seems
pointless to me,
as it does not work apparently.
Do you think this should still go
Updates:
Cc: Vinzent.Steinberg
Comment #16 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
The change to separate had one of the power flags False and it should be
true. This
is being fixed, tests re-run and a tes
Comment #17 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
ok, these changes have been made and the revision is in the forced update
of smichr's
branch 1766 at github.
--
You received this message because you are listed
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #18 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Regarding the changes to test_nth_linear_constant_coeff_homogeneous, what
caused the change, for example
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is now blocking issue 1782.
See http://code.google.com/p/sympy/issues/detail?id=1782
--
You received this message because you are listed in the owner
or CC fields of this issue, o
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #19 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
OK, this is ready to look at: commit 1766 in smichr's 1766 branch at github.
Laws regarding power rules are
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is now blocking issue 1745.
See http://code.google.com/p/sympy/issues/detail?id=1745
--
You received this message because you are listed in the owner
or CC fields of this issue, o
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #20 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Wow, you accumulated a great amount of changes in your 1766 branch! I
ignored the 2
'' c
Comment #21 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I think things might be easier if exp(x) just returned E**x, the same way
that sqrt(x) is just a shortcut to
x**(1/2). It would probably require a bit of w
Comment #22 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I would *love* to see this change...there's a lot of code that is written
as a work
around for this dichotomy (exp(x) being a function instead of a power). Not
Comment #23 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
We need also stuff like .rewrite(exp), but this should not be a problem.
--
You received this message because you are listed in the owner
or CC field
Comment #24 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I went ahead and made issue 1799 for this.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred
Comment #25 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
ok, tests now pass after changes to 1795
1789 has been made into two commits which can be squashed for the repo
a test has been added for 1772
Still working o
Comment #26 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
1795 has been cleaned up and a print in the tests removed.
--
You received this message because you are listed in the owner
or CC fields of this issue, or becau
Comment #27 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Regarding comments:
<<<1778:I think we don't need decimal here and we could use
mpmath, but that's not really important. >>>
Do you mean to not use Decimal
Comment #28 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Thanks! Sorry, but I still get failures. :)
1785: The comment above 'def _maxfac' could be a docstring, same for _info,
but leave
it as it is if yo
Comment #29 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Concerning expand(): I don't think you will often use slightly modified
defaults. But
only a single expansion method is often used. You could also i
Comment #30 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
pythontidy purports to be a PEP8 tool, but it makes a lot of strange
changes and would have to be modified I
think.
I too would like to know the reason for
Comment #31 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
And I'm still of the opinion that the hints should be in or near the
function they apply to (expand), not buried
away in the manager itself.
--
You receive
Comment #32 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I don't find "assert cls(0.9) is S.Zero" in my branch...could you clarify?
I did (after sending) see some of the other failures and have corrected
those, I
b
Comment #33 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
About private stuff in namespace: I would just document it (docstrings),
and don't
make it private if it could be useful to others. If you are not s
Comment #34 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I get [-(4*log(7) + 5*LambertW(-7*2**(4/5)*6**(1/5)*log(7)/10))/(3*log(7))]
Yours is nicer in that it pulled a 2 form the 6 to make the 2**(4/5) become
2 and
Comment #35 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
If the whole branch is going to applied at once, I don't think it is that
big of an issue if a test fails on an
intermediate commit. It is important, howeve
Comment #36 on issue 1766 by ronan.l...@gmail.com: expand(power_base=True)
is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
1785 and 1789 (after squashing) seem polished enough, so I've pushed them
in.
Damn! It fails on the buildbots due to a 32-bit vs 64-bit issue.
Comment #37 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I'm not sure who should make the change, but if you just
put '.replace('L','')' at
the end of the print statement that should take care of it since there is
Comment #38 on issue 1766 by ronan.l...@gmail.com: expand(power_base=True)
is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
There's also a problem with the -Qnew buildbot (true division enabled by
default): it
returns "[350, 3958281543] stot = 1 pmax = 1319427181.0".
Comment #39 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
There are 2 new commits with memo 1789 added to branch 1766. If you squash
those into
the others, does that fix the problem?
--
You received this message bec
Comment #40 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Once committed to sympy master we can't squash anymore without breaking
things.
However, the two fixes look fine, feel free to push them in.
--
Y
Comment #41 on issue 1766 by ronan.l...@gmail.com: expand(power_base=True)
is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Thanks, it's in, and it works on all buildbots. I still don't understand
why there's
an 'L' (it should appear only in the repr of a long, not in
Comment #42 on issue 1766 by ronan.l...@gmail.com: expand(power_base=True)
is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
1770 could be better but is clearly an improvement so I've pushed it in
(after
reapplying the changes from issue 1800, and correcting a semantic
Comment #44 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I moved the comment about 1772 to issue 1772 and made the changes which are
hopefully
more in the expected direction.
1794 and 1795 have been merged with mas
Updates:
Labels: NeedsReview
Comment #45 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I think I am seeing the light at the end of the tunnel...this has been a
pandora's
box of an issue. Here's where things s
Comment #46 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Maybe you could split your huge branch? I can't cherry-pick your newest
commit, and
for the branch I still get the failing test...
--
You received
Comment #47 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
As for seperatevars((exp(2*x)-exp(2*y))/(exp(x)-exp(y)) == exp(x) +
exp(y)), that isn't really separated, unless we want to have it do
additive separation to
Comment #48 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Vinzent, everything has been split up. I'm not sure how much commenting you
want on
everything or how close you want the tests to the place where the change w
Comment #49 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Here is a patch that fixes the test for real. (I don't know why the
comparison fails,
but this patch works and should be a more elegant solution.)
Comment #50 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
sy...@googlecode.com wrote:
Comment #49 on issue 1766 by Vinzent.Steinberg:
expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/deta
Comment #51 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
hmmm...it worked interactively but is failing the test suite...I'll post
when it's
working again.
--
You received this message because you are listed in the
Comment #52 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
ok, I've adjusted powsimp to handle this. There are now 2 squashable tsolve
commits.
:wq
^ :-) I've been doing too many commits
--
You received this mess
Comment #53 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
The test passes for me now, however there is still a print statement
left. :)
BTW: http://vimperator.org/ ;)
--
You received this message because
Comment #54 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
it's fixed (again)
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjus
Comment #55 on issue 1766 by mattpap: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
BTW: http://vimperator.org/ ;)
I installed vimperator about a year ago. Now I can't imagine using firefox
without it.
--
You received this message becaus
Comment #56 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
There is a failing doctest (easy to fix):
_ sympy.solvers.solvers.tsolve
_
File "/home/one/src/symp
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is now blocking issue 1835.
See http://code.google.com/p/sympy/issues/detail?id=1835
--
You received this message because you are listed in the owner
or CC fields of this issue,
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is now blocking issue 1836.
See http://code.google.com/p/sympy/issues/detail?id=1836
--
You received this message because you are listed in the owner
or CC fields of this issue,
Comment #57 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I got these failures on your branch:
___ sympy/geometry/tests/test_geometry.py:test_line
File "/home/one/src/sympy/s
Comment #58 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I should get the quartz branch separated from 1766...for now I've commented
that line
out. Regarding the geometry, I don't have a failure there--double check
Comment #59 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I'm getting failures for the 1766 branch. Actually it hangs somewhere when
your try
to run the tests:
[...]
sympy/solvers/tests/test_numeric.py[1]
Comment #60 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Issue 1909 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because y
Comment #61 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Issue 1911 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starre
Comment #62 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
I can't reproduce this here. Is it a 64-bit issue? If you can't print out
what
expression are being obtained that don't pass the test perhaps I can write
the
Comment #63 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Now I'm only getting 2 failures:
_ sympy/core/tests/test_expand.py:test_expand_mul_mult
_
File "/home/one/src/sympy/symp
Comment #64 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
It's seems to be an infinite loop doing dense poly arithmetic.
--
You received this message because you are listed in the owner
or CC fields of this
Comment #65 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
what commit are you testing?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You
Comment #66 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
The whole 1766 branch, as of now commit
e0bd00408b6dd5baf77211d268a40f6d0efe7a7a.
--
You received this message because you are listed in the owner
Comment #67 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
All tests now pass here. There are a couple of doctests to sort out,
however. But I'd
rather have the other commits that have been pulled out (and will be pull
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is no longer blocking issue 1836.
See http://code.google.com/p/sympy/issues/detail?id=1836
--
You received this message because you are listed in the owner
or CC fields of this is
Updates:
Labels: smichr
Comment #68 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
(No comment was entered for this change.)
--
You received this message because you are subscribed to the Google Groups
"sympy
Issue 1766: expand(power_base=True) is too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
This issue is no longer blocking issue 1835.
See http://code.google.com/p/sympy/issues/detail?id=1835
--
You received this message because you are listed in the owner
or CC fields of this is
Updates:
Labels: -NeedsBetterPatch
Comment #69 on issue 1766 by smi...@gmail.com: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
https://github.com/sympy/sympy/pull/306
All tests pass when I use the force=True option in risch (which I t
Comment #70 on issue 1766 by asmeurer: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Probably. I think that expand() was actually originally put there to just
to multiplicative expansion, but the other expansions make other stuff
work, I w
74 matches
Mail list logo
