Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-03 Thread Cj Malone
I'm sure there will be edge cases where this bot gives us wrong data,
but I think overall this will make OSM data better.


Thank you for taking the time to improve OSM.

CJ


___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-03 Thread Cj Malone
I'm sure there will be edge cases where this bot gives us wrong data,
but I think overall this will make OSM data better.


Thank you for taking the time to improve OSM.

CJ



___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Mateusz Konieczny via talk



Nov 2, 2023, 15:05 by a...@pigsonthewing.org.uk:

> On Wed, 1 Nov 2023 at 22:42, Mateusz Konieczny via talk
>  wrote:
>
>>
>> I proposed some time ago to fix some surface values.
>>
>
> I support this in general, but the following may be worthy of further
> consideration:
>
>> surface = U → surface = unpaved
>>
>
> Are we sure this is what is meant?
>
pretty sure, turns out that failed autocomplete is commons
feel free to research remaining cases, if there is any noticeable amount of
paved surfaces there I will drop it

>> surface = unhewn_cobblestones → surface = unhewn_cobblestone
>>
>
> How is this different from surface = cobblestone ?
>
See https://wiki.openstreetmap.org/wiki/Tag:surface%3Dcobblestone
and
https://wiki.openstreetmap.org/wiki/Tag:surface%3Dunhewn_cobblestone
>> surface = a → surface = asphalt
>>
>> surface = AS → surface = asphalt
>>
>> surface = ea → surface = earth
>>
>
> Are we sure these are what is meant?
>
>
>> surface = unpavedNo → surface = unpaved
>>
>
> Are we sure that this does not mean "not unpaved", i.e. "paved"
>
see surface=U comment, in this cases I checked decent sample of cases

>> there are also many low-use values with one or two or three extra bogus 
>> characters, for example
>> surface = artificial_turf22 → surface = artificial_turf
>>
>> would be also OK to migrate them without listing them
>> for review here and just add them to replace list later?
>>
>
> OK by me.
>
:)

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Andy Mabbett
On Wed, 1 Nov 2023 at 22:42, Mateusz Konieczny via talk
 wrote:
>
> I proposed some time ago to fix some surface values.

I support this in general, but the following may be worthy of further
consideration:

> surface = U → surface = unpaved

Are we sure this is what is meant?

> surface = unhewn_cobblestones → surface = unhewn_cobblestone

How is this different from surface = cobblestone ?

> surface = a → surface = asphalt

> surface = AS → surface = asphalt

> surface = ea → surface = earth

Are we sure these are what is meant?

> surface = unpavedNo → surface = unpaved

Are we sure that this does not mean "not unpaved", i.e. "paved"

> there are also many low-use values with one or two or three extra bogus 
> characters, for example
> surface = artificial_turf22 → surface = artificial_turf
>
> would be also OK to migrate them without listing them
> for review here and just add them to replace list later?

OK by me.


-- 
Andy Mabbett
@pigsonthewing
http://pigsonthewing.org.uk

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Mateusz Konieczny via talk
I will review this list.

Rare obvious values I will just retag.
Some may appear in future proposal.
Some are proposed in this one (holz)
Some are too complex (pflastersteine) and I will rather create notes for them
as it can be not only sett
https://community.openstreetmap.org/t/proposed-bot-edit-automatic-replacement-of-surface-values-where-it-is-safe/105361/5
Nov 2, 2023, 08:11 by md...@xs4all.nl:

> I have a few suggestions too:
>  
> verdichtet => compacted
> straatstenenc => paving_stones
> bestraat => paving_stones
> niet-bestraat => unpaved
> niet-bestraat2 => unpaved
> niet-bestraat33 => unpaved
> щебеночное_покрытие => gravel
> no_paved => unpaved
> concreteas => concrete
> Pflastersteine => sett
> pflastersteine => sett
> Bosbodem => dirt
> klinkers => sett
> sans_revêtement => unpaved
> schotter => gravel
> Turf => turf
> holz => wood
> грунт => dirt
> terre_battue => gravel
> плитка => paving_stones
> pavingstones => paving_stones
> não_pavimentado => unpaved
> Waldboden => ground (literally forest soil)
> permukaan tanah dan Beton means ground and concrete
>  
> And I want to point attention to surface=앿
> https://www.openstreetmap.org/way/1185643877
> Seems someone is adding this in Taiwan a lot. I think it means unpaved.
>  
>
>> Op 01-11-2023 23:42 CET schreef Mateusz Konieczny via talk 
>> :
>>  
>>  
>> I proposed some time ago to fix some surface values.
>>  
>> Edit is documented at
>> https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fixing_malformed_surface_tags
>>  
>> I propose to expand this by fixing also values listed below.
>>  
>> Please comment if any of proposed replacements are dubious in any way and 
>> do not qualify for a replacement with an automated edit.
>>  
>> Please also comment if you checked values proposed to be edited and they 
>> seem fine!
>>  
>> Edit will affect around 2200 objects.
>>  
>> It is preferable to use standard tag values where possible,
>> and in many cases unusual values can be migrated without any data loss.
>> The list below is supposed to contain only such cases.
>>  
>> If anyone wants I can help them to find affected objects or present listing 
>> of
>> edits which added this tags or list people who added this values onto 
>> currently
>> tagged osm objects.
>>  
>> Samples of this values were tested. I also asked for review at >> 
>> https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419
>>  
>> Tried to use them as detectors of bogus data, neither were really useful for 
>> this purpose.
>> We have many better ways to find OSM data requiring human review.
>>  
>> So I am proposing following changes
>>  
>> tags with highest use, among ones that will be retagged
>> surface = astroturf with 297 uses
>> surface = timber with 122 uses
>> surface = paving with 179 uses
>> surface = U with 82 uses
>> surface = enrobé with 276 uses
>> surface = terre with 383 uses
>>  
>>  
>> surface = astroturf → surface = artificial_turf
>> surface = timber → surface = wood (see >> 
>> https://www.openstreetmap.org/changeset/66866027>>  >> 
>> https://www.openstreetmap.org/changeset/126078123>>  >> 
>> https://www.openstreetmap.org/changeset/126078123>>  >> 
>> https://www.openstreetmap.org/changeset/68461319>>  >> 
>> https://www.openstreetmap.org/changeset/69445813>>  >> 
>> https://www.openstreetmap.org/changeset/57280475>>  >> 
>> https://www.openstreetmap.org/changeset/126800407>>  )
>> surface = DIRT → surface = dirt
>> surface = paving → surface = paved
>> surface = U → surface = unpaved
>>  
>> French from >> 
>> https://lists.openstreetmap.org/pipermail/talk/2023-April/088164.html
>> review at >> 
>> https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419
>>  
>> surface = enrobé → surface = asphalt
>> surface = béton_bitumineux → surface = asphalt
>> surface = béton_bitumimeux → surface = asphalt
>> surface = bitumen → surface = asphalt
>> surface = enrobes → surface = asphalt
>> surface = bitume → surface = asphalt
>> surface = goudronné → surface = asphalt
>> surface = gourdon → surface = asphalt
>> surface = plastique → surface = plastic
>> surface = banc_de_sable → surface = sand
>> surface = terre → surface = earth
>> surface = Terre → surface = earth
>> surface = terre_boue → surface = mud
>> surface = terre_humide → surface = mud
>> surface = terre,_boue → surface = mud
>> surface = graviers → surface = gravel
>> surface = tere → surface = earth
>> surface = terre2 → surface = earth
>> surface = caoutchouc → surface = rubber
>> surface = bois → surface = wood
>> surface = béton_désactivé → surface = concrete
>> surface = terre_batue → surface = clay
>> surface = pavés → surface = paved
>> surface = carrelage → surface = tiles
>> surface = pelouse_et_terre → surface = grass;ground
>> surface = terre_touvenant → surface = ground
>> surface = terre;herbe → surface = ground;grass

Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Mateusz Konieczny via talk



Nov 2, 2023, 10:06 by marc_m...@mailo.com:

> Hello,
>
> Le 01.11.23 à 23:42, Mateusz Konieczny via talk a écrit :
>
>> French from 
>> https://lists.openstreetmap.org/pipermail/talk/2023-April/088164.html
>>
>
> wouldn't it be a good idea to make the changes you've already agreed
> to first? because this is the 3rd time we've reviewed the list.
> or you can make a request separating the new values from the old ones
>
https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct 
requires changes to be reviewed at talk mailing list

I also posted French words on French forum to give people not active
on English forums to review French words.

I also posted on community forum as many are present there - no
entries were added compared to that posting.

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Maarten Deen

> Op 02-11-2023 09:57 CET schreef Marc_marc :
> Le 02.11.23 à 08:09, Maarten Deen a écrit :
> > terre_battue => gravel
> 
> this one is wrong, the correct fix was already in the previous list
> terre_battue clay for tennis pitch, earth for others

Ah, in dutch we call that gravel as well. I see in english it is called a clay 
pitch. I just assumed because gravel is an english term it was called that in 
english too.

Maarten

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Marc_marc

Hello,

Le 01.11.23 à 23:42, Mateusz Konieczny via talk a écrit :

French from 
https://lists.openstreetmap.org/pipermail/talk/2023-April/088164.html


wouldn't it be a good idea to make the changes you've already agreed
to first? because this is the 3rd time we've reviewed the list.
or you can make a request separating the new values from the old ones

Le 02.11.23 à 08:09, Maarten Deen a écrit :

terre_battue => gravel


this one is wrong, the correct fix was already in the previous list
terre_battue clay for tennis pitch, earth for others

Regards,
Marc



___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-02 Thread Maarten Deen
I have a few suggestions too:
 
verdichtet => compacted
straatstenenc => paving_stones
bestraat => paving_stones
niet-bestraat => unpaved
niet-bestraat2 => unpaved
niet-bestraat33 => unpaved
щебеночное_покрытие => gravel
no_paved => unpaved
concreteas => concrete
Pflastersteine => sett
pflastersteine => sett
Bosbodem => dirt
klinkers => sett
sans_revêtement => unpaved
schotter => gravel
Turf => turf
holz => wood
грунт => dirt
terre_battue => gravel
плитка => paving_stones
pavingstones => paving_stones
não_pavimentado => unpaved
Waldboden => ground (literally forest soil)
permukaan tanah dan Beton means ground and concrete
 
And I want to point attention to surface=앿
https://www.openstreetmap.org/way/1185643877
Seems someone is adding this in Taiwan a lot. I think it means unpaved.
 

> Op 01-11-2023 23:42 CET schreef Mateusz Konieczny via talk 
> :
>  
>  
> I proposed some time ago to fix some surface values.
>  
> Edit is documented at
> https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fixing_malformed_surface_tags
>  
> I propose to expand this by fixing also values listed below.
>  
> Please comment if any of proposed replacements are dubious in any way and 
> do not qualify for a replacement with an automated edit.
>  
> Please also comment if you checked values proposed to be edited and they seem 
> fine!
>  
> Edit will affect around 2200 objects.
>  
> It is preferable to use standard tag values where possible,
> and in many cases unusual values can be migrated without any data loss.
> The list below is supposed to contain only such cases.
>  
> If anyone wants I can help them to find affected objects or present listing of
> edits which added this tags or list people who added this values onto 
> currently
> tagged osm objects.
>  
> Samples of this values were tested. I also asked for review at 
> https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419
>  
> Tried to use them as detectors of bogus data, neither were really useful for 
> this purpose.
> We have many better ways to find OSM data requiring human review.
>  
> So I am proposing following changes
>  
> tags with highest use, among ones that will be retagged
> surface = astroturf with 297 uses
> surface = timber with 122 uses
> surface = paving with 179 uses
> surface = U with 82 uses
> surface = enrobé with 276 uses
> surface = terre with 383 uses
>  
>  
> surface = astroturf → surface = artificial_turf
> surface = timber → surface = wood (see 
> https://www.openstreetmap.org/changeset/66866027 
> https://www.openstreetmap.org/changeset/126078123 
> https://www.openstreetmap.org/changeset/126078123 
> https://www.openstreetmap.org/changeset/68461319 
> https://www.openstreetmap.org/changeset/69445813 
> https://www.openstreetmap.org/changeset/57280475 
> https://www.openstreetmap.org/changeset/126800407 )
> surface = DIRT → surface = dirt
> surface = paving → surface = paved
> surface = U → surface = unpaved
>  
> French from 
> https://lists.openstreetmap.org/pipermail/talk/2023-April/088164.html
> review at 
> https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419
>  
> surface = enrobé → surface = asphalt
> surface = béton_bitumineux → surface = asphalt
> surface = béton_bitumimeux → surface = asphalt
> surface = bitumen → surface = asphalt
> surface = enrobes → surface = asphalt
> surface = bitume → surface = asphalt
> surface = goudronné → surface = asphalt
> surface = gourdon → surface = asphalt
> surface = plastique → surface = plastic
> surface = banc_de_sable → surface = sand
> surface = terre → surface = earth
> surface = Terre → surface = earth
> surface = terre_boue → surface = mud
> surface = terre_humide → surface = mud
> surface = terre,_boue → surface = mud
> surface = graviers → surface = gravel
> surface = tere → surface = earth
> surface = terre2 → surface = earth
> surface = caoutchouc → surface = rubber
> surface = bois → surface = wood
> surface = béton_désactivé → surface = concrete
> surface = terre_batue → surface = clay
> surface = pavés → surface = paved
> surface = carrelage → surface = tiles
> surface = pelouse_et_terre → surface = grass;ground
> surface = terre_touvenant → surface = ground
> surface = terre;herbe → surface = ground;grass
> surface = terre_naturelle,_argileuse → surface = ground
> surface = gravier → surface = gravel
> surface = gazon_synthétique → surface = artificial_turf
> surface = béton → surface = concrete
> surface = ciment → surface = concrete
> surface = herbe → surface = grass
> surface = gazon → surface = grass
> surface = herb → surface = grass
> surface = herbe_naturel → surface = grass
> surface = pelouse → surface = grass
> surface = pelouse_naturelle → surface = grass
> surface = terre_et_rochers → surface = ground;rock
> surface = béton_bois → surface = concrete;wood
> surface = terre,_cailloux → surface = 

[OSM-talk] Proposed bot edit: automatic replacement of surface values where it is safe

2023-11-01 Thread Mateusz Konieczny via talk
I proposed some time ago to fix some surface values.

Edit is documented at
https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fixing_malformed_surface_tags

I propose to expand this by fixing also values listed below.

Please comment if any of proposed replacements are dubious in any way and 
do not qualify for a replacement with an automated edit.

Please also comment if you checked values proposed to be edited and they seem 
fine!

Edit will affect around 2200 objects.

It is preferable to use standard tag values where possible,
and in many cases unusual values can be migrated without any data loss.
The list below is supposed to contain only such cases.

If anyone wants I can help them to find affected objects or present listing of
edits which added this tags or list people who added this values onto currently
tagged osm objects.

Samples of this values were tested. I also asked for review at 
https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419

Tried to use them as detectors of bogus data, neither were really useful for 
this purpose.
We have many better ways to find OSM data requiring human review.

So I am proposing following changes

tags with highest use, among ones that will be retagged
surface = astroturf with 297 uses
surface = timber with 122 uses
surface = paving with 179 uses
surface = U with 82 uses
surface = enrobé with 276 uses
surface = terre with 383 uses


surface = astroturf → surface = artificial_turf
surface = timber → surface = wood (see 
https://www.openstreetmap.org/changeset/66866027 
https://www.openstreetmap.org/changeset/126078123 
https://www.openstreetmap.org/changeset/126078123 
https://www.openstreetmap.org/changeset/68461319 
https://www.openstreetmap.org/changeset/69445813 
https://www.openstreetmap.org/changeset/57280475 
https://www.openstreetmap.org/changeset/126800407 )
surface = DIRT → surface = dirt
surface = paving → surface = paved
surface = U → surface = unpaved

French from 
https://lists.openstreetmap.org/pipermail/talk/2023-April/088164.html
review at 
https://forum.openstreetmap.fr/t/review-requested-before-proposing-bot-edit-for-automated-fixing-of-surface-values/18419

surface = enrobé → surface = asphalt
surface = béton_bitumineux → surface = asphalt
surface = béton_bitumimeux → surface = asphalt
surface = bitumen → surface = asphalt
surface = enrobes → surface = asphalt
surface = bitume → surface = asphalt
surface = goudronné → surface = asphalt
surface = gourdon → surface = asphalt
surface = plastique → surface = plastic
surface = banc_de_sable → surface = sand
surface = terre → surface = earth
surface = Terre → surface = earth
surface = terre_boue → surface = mud
surface = terre_humide → surface = mud
surface = terre,_boue → surface = mud
surface = graviers → surface = gravel
surface = tere → surface = earth
surface = terre2 → surface = earth
surface = caoutchouc → surface = rubber
surface = bois → surface = wood
surface = béton_désactivé → surface = concrete
surface = terre_batue → surface = clay
surface = pavés → surface = paved
surface = carrelage → surface = tiles
surface = pelouse_et_terre → surface = grass;ground
surface = terre_touvenant → surface = ground
surface = terre;herbe → surface = ground;grass
surface = terre_naturelle,_argileuse → surface = ground
surface = gravier → surface = gravel
surface = gazon_synthétique → surface = artificial_turf
surface = béton → surface = concrete
surface = ciment → surface = concrete
surface = herbe → surface = grass
surface = gazon → surface = grass
surface = herb → surface = grass
surface = herbe_naturel → surface = grass
surface = pelouse → surface = grass
surface = pelouse_naturelle → surface = grass
surface = terre_et_rochers → surface = ground;rock
surface = béton_bois → surface = concrete;wood
surface = terre,_cailloux → surface = ground;gravel
surface = terre_et_herbe → surface = earth;grass
surface = herbe_et_sable → surface = grass;sand
surface = sable_et_terre → surface = sand;earth
surface = terre_et_sable → surface = earth;sand
surface = terre_cailloux → surface = ground;gravel
surface = terre_goudrons → surface = ground;asphalt
surface = terre_goudron → surface = ground;asphalt
surface = terre_pierres → surface = ground;gravel
surface = terre_et_pierre → surface = ground;gravel
surface = terr_et_pierre → surface = ground;gravel
surface = terre/sable → surface = ground;sand
surface = terre_et_pierres → surface = ground;gravel
surface = Herbe_et_cailloux → surface = grass;gravel
surface = terre_et_gravier → surface = ground;gravel
surface = gravillons,_béton → surface = gravel;concrete
surface = graviers_et_terre → surface = gravel;ground
surface = sable → surface = sand
surface = Sable → surface = sand
surface = cailloux → surface = gravel
surface = pierre → surface = gravel
surface = gravier0 → surface = gravel

surface = asphalt_on_concrete_sub-base → surface = asphalt