Fwd: New Defects reported by Coverity Scan for Das U-Boot

2021-08-16 Thread Heinrich Schuchardt
Hello Tom, I suggest to mark these as invalid: CID 338485 CID 338490 CID 338489 Best regards Heinrich Forwarded Message Subject: New Defects reported by Coverity Scan for Das U-Boot Date: Mon, 16 Aug 2021 18:33:23 + (UTC) From: scan-ad...@coverity.com To:

[PATCH 1/1] kwbimage: check return value of image_get_csk_index

2021-08-16 Thread Heinrich Schuchardt
image_get_csk_index() may return -1 in case of an error. Don't use this value as index. This resolves Coverity CID 338488 Memory - illegal accesses (NEGATIVE_RETURNS) Signed-off-by: Heinrich Schuchardt --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] kwbimage: check fopen() return value

2021-08-16 Thread Heinrich Schuchardt
Always check the return value of fopen(). This resolves Coverity CID 338491: Null pointer dereferences (NULL_RETURNS) Signed-off-by: Heinrich Schuchardt --- tools/kwbimage.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

Re: [RFC] imx8mm-evk: Generate a bootable flash.bin again

2021-08-16 Thread Heiko Schocher
Hello Fabio, On 16.08.21 17:21, Fabio Estevam wrote: > After the convesion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch > to use binman to pack images"), it is necessary to flash both flash.bin and > u-boot.itb to get a bootable system. Prior to this commit, only flash.bin > was needed.

Re: [PATCH v8 1/5] spi: rockchip_sfc: add support for Rockchip SFC

2021-08-16 Thread Chris Morgan
On Mon, Aug 16, 2021 at 09:00:59PM +0800, Jon Lin wrote: > > On 2021/8/14 0:48, Chris Morgan wrote: > > On Fri, Aug 13, 2021 at 09:53:03AM +0800, Jon Lin wrote: > > > Here is the point, Can you take a try. > > > > > > diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c > > >

[PATCH 15/15] update CAAM MAINTAINER

2021-08-16 Thread Gaurav Jain
Signed-off-by: Gaurav Jain --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 776ff703b9..bd689fc1a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1254,3 +1254,10 @@ T: git https://source.denx.de/u-boot/u-boot.git F:

[PATCH 14/15] PPC: Enable Job ring driver model in U-Boot

2021-08-16 Thread Gaurav Jain
removed sec_init() call and CONFIG_FSL_CAAM from defconfig. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- arch/powerpc/cpu/mpc85xx/Kconfig | 44 +++ arch/powerpc/cpu/mpc85xx/cpu_init.c | 20 ++--

[PATCH 13/15] PPC: crypto: Add crypto node in device tree

2021-08-16 Thread Gaurav Jain
device tree imported from linux kernel. c500bee1c5b2 (tag: v5.14-rc4) Linux 5.14-rc4 Signed-off-by: Gaurav Jain --- arch/powerpc/dts/p2041si-post.dtsi | 1 + arch/powerpc/dts/p3041si-post.dtsi | 1 + arch/powerpc/dts/p4080si-post.dtsi | 1 + arch/powerpc/dts/p5040si-post.dtsi | 1 +

[PATCH 12/15] Layerscape: Enable Job ring driver model in U-Boot.

2021-08-16 Thread Gaurav Jain
LS(1021/1012/1028/1043/1046/1088/2088), LX2160, LX2162 platforms are enabled with JR driver model. removed sec_init() call from board files. removed CONFIG_FSL_CAAM from defconfig files. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain ---

[PATCH 11/15] Layerscape: crypto: Add crypto node in device tree

2021-08-16 Thread Gaurav Jain
LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree Signed-off-by: Gaurav Jain --- arch/arm/dts/fsl-ls1012a.dtsi | 46 ++- arch/arm/dts/fsl-ls1028a.dtsi | 41 ++- arch/arm/dts/fsl-ls1043a.dtsi | 45

[PATCH 10/15] crypto/fsl: Fix kick_trng

2021-08-16 Thread Gaurav Jain
From: Ye Li fix hwrng performance issue in kernel. Signed-off-by: Ye Li Acked-by: Gaurav Jain > --- drivers/crypto/fsl/jr.c | 109 ++-- include/fsl_sec.h | 1 + 2 files changed, 94 insertions(+), 16 deletions(-) diff --git a/drivers/crypto/fsl/jr.c

[PATCH 09/15] crypto/fsl: i.MX8: Enable Job ring driver model in SPL and U-Boot.

2021-08-16 Thread Gaurav Jain
i.MX8(QM/QXP) - added support for JR driver model. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Signed-off-by: Horia Geantă --- arch/arm/Kconfig | 3 +++ arch/arm/include/asm/arch-imx8/imx-regs.h | 5 -

[PATCH 08/15] i.MX8: crypto: Add crypto node in device tree

2021-08-16 Thread Gaurav Jain
i.MX8(QM/QXP) - updated device tree for supporting DM in SPL. disabled use of JR1 in SPL and uboot, as JR1 is reserved for SECO FW. Signed-off-by: Gaurav Jain --- arch/arm/dts/fsl-imx8dx.dtsi | 61 +++- arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 34 -

[PATCH 07/15] i.MX7ULP: Enable Job ring driver model in U-Boot.

2021-08-16 Thread Gaurav Jain
added crypto node in device tree. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- arch/arm/Kconfig | 2 +- arch/arm/dts/imx7ulp.dtsi| 24 arch/arm/mach-imx/mx7ulp/Kconfig | 4

[PATCH 06/15] i.MX7: Enable Job ring driver model in U-Boot.

2021-08-16 Thread Gaurav Jain
i.MX7D - added support for JR driver model. removed sec_init() call, sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- arch/arm/Kconfig | 2 +- arch/arm/mach-imx/mx7/Kconfig | 3 +++ arch/arm/mach-imx/mx7/soc.c | 15

[PATCH 05/15] i.MX6: Enable Job ring driver model in U-Boot.

2021-08-16 Thread Gaurav Jain
i.MX6(SX/UL) - added support for JR driver model. removed sec_init() call, sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- arch/arm/mach-imx/mx6/Kconfig | 8 arch/arm/mach-imx/mx6/soc.c | 15 +++ 2 files

[PATCH 04/15] crypto/fsl: i.MX8M: Enable Job ring driver model in SPL and U-Boot.

2021-08-16 Thread Gaurav Jain
i.MX8MM/MN/MP/MQ - added support for JR driver model. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- arch/arm/Kconfig | 2 +- arch/arm/include/asm/arch-imx8m/imx-regs.h | 1 +

[PATCH 03/15] i.MX8M: crypto: updated device tree for supporting DM in SPL

2021-08-16 Thread Gaurav Jain
disabled use of JR0 in SPL and uboot, as JR0 is reserved for secure boot. Signed-off-by: Gaurav Jain --- arch/arm/dts/imx8mm-evk-u-boot.dtsi | 18 +- arch/arm/dts/imx8mm.dtsi | 1 + arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 18 +-

[PATCH 02/15] crypto/fsl: Add CAAM support for bkek, random number generation

2021-08-16 Thread Gaurav Jain
added api and descriptor for blob key encryption key(bkek) generation. added api for random number generation. Signed-off-by: Gaurav Jain Signed-off-by: Ji Luo --- drivers/crypto/fsl/desc.h | 5 +++ drivers/crypto/fsl/fsl_blob.c | 82 +++

[PATCH 01/15] crypto/fsl: Add support for CAAM Job ring driver model

2021-08-16 Thread Gaurav Jain
added device tree support for job ring driver. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain --- cmd/Kconfig | 1 + drivers/crypto/fsl/Kconfig | 7 + drivers/crypto/fsl/Makefile | 2 + drivers/crypto/fsl/jr.c |

[PATCH] imx8mm-cl-iot-gate: Split the defconfigs

2021-08-16 Thread Fabio Estevam
Currently imx8mm-cl-iot-gate_defconfig fails to produce a working boot binary due to the lack of fip.bin: BINMAN all Image 'main-section' is missing external blobs and is non-functional: blob-ext Some images are invalid To make the build process more consistent with the other i.MX8M targers,

Re: [PATCH v8 1/5] spi: rockchip_sfc: add support for Rockchip SFC

2021-08-16 Thread Jon Lin
On 2021/8/16 23:22, Chris Morgan wrote: On Mon, Aug 16, 2021 at 09:00:59PM +0800, Jon Lin wrote: On 2021/8/14 0:48, Chris Morgan wrote: On Fri, Aug 13, 2021 at 09:53:03AM +0800, Jon Lin wrote: Here is the point, Can you take a try. diff --git a/drivers/spi/rockchip_sfc.c

[PATCH 2/3] spi: rockchip_sfc: Using read_poll

2021-08-16 Thread Jon Lin
Using read_poll logic. Signed-off-by: Jon Lin --- drivers/spi/rockchip_sfc.c | 67 -- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c index 2028b28e26..33c5344c70 100644 ---

[PATCH 3/3] rockchip: px30: Change sfc node to match upstream linux proposed

2021-08-16 Thread Jon Lin
TX single line is more compatible for corresponding board Signed-off-by: Jon Lin --- arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi | 2 +- arch/arm/dts/rk3326-odroid-go2.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi

[PATCH 1/3] spi: rockchip_sfc: Impletment set_speed logic

2021-08-16 Thread Jon Lin
Set clock related processing into set_speed logic. And Optimize printing format. Signed-off-by: Jon Lin --- drivers/spi/rockchip_sfc.c | 83 ++ 1 file changed, 40 insertions(+), 43 deletions(-) diff --git a/drivers/spi/rockchip_sfc.c

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-16 Thread Paul Liu
Hi Fabio, It looks good to me. Thanks a lot. BTW. mbedtls version might not always work. In my local directory the mbedtls commit is bd21b18a1faa08705ac6d9980794c181e645f53a. Which is a commit in the development branch. Based on Tom's correction I'll write more detailed steps. Yours, Paul On

Re: [PATCH 0/3] common: Add fdt network helper

2021-08-16 Thread Tony Dinh
Hi Simon, On Sun, Aug 15, 2021 at 2:27 PM Tony Dinh wrote: > > Hi Simon, > > On Sun, Aug 15, 2021 at 7:10 AM Simon Glass wrote: > > > > Hi Tony, > > > > On Thu, 5 Aug 2021 at 22:49, Tony Dinh wrote: > > > > > > > > > At the moment, there is no common fdt helper function specific to > > >

Pull request, u-boot-tegra/master

2021-08-16 Thread Tom Warren
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. The following changes since commit a0da2dda4ed9d0aee5265e9cd8876734f9f80e09: Prepare v2021.10-rc2 (2021-08-16 14:18:45 -0400) are available in the git repository at:

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-16 Thread Fabio Estevam
Hi Paul, On Mon, Aug 16, 2021 at 6:09 PM Fabio Estevam wrote: > What about having two defconfigs for this board? > > imx8mm-cl-iot-gate_defconfig for the regular users. This one can be > simply be built by > following the README I wrote and it matches the way used on other > i.MX8MM boards. > >

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-16 Thread Tom Rini
On Mon, Aug 16, 2021 at 06:09:34PM -0300, Fabio Estevam wrote: > Hi Paul, > > On Sun, Aug 15, 2021 at 4:27 PM Paul Liu wrote: > > > No. I think they actually use fip.bin but just not upstreamed yet. Please > > see the "Firmware version" in the list. For Compulab we are using mainline > >

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-16 Thread Fabio Estevam
Hi Paul, On Sun, Aug 15, 2021 at 4:27 PM Paul Liu wrote: > No. I think they actually use fip.bin but just not upstreamed yet. Please > see the "Firmware version" in the list. For Compulab we are using mainline > U-boot. But for imx8mm-evk it is NXP released firmware. > > And yes we do use

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Tom Rini
On Mon, Aug 16, 2021 at 10:15:49PM +0200, Pali Rohár wrote: > + Stefan and Marek > > On Monday 16 August 2021 15:57:26 Tom Rini wrote: > > Hey all, > > > > Can people please take a look? I can mark as intentional anything that > > really is intentional, thanks. > > Hello Tom! > > These

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Pali Rohár
+ Stefan and Marek On Monday 16 August 2021 15:57:26 Tom Rini wrote: > Hey all, > > Can people please take a look? I can mark as intentional anything that > really is intentional, thanks. Hello Tom! These kwbimage issues look to be a real issues. But I do not think that anybody touched these

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Tom Rini
Hey all, Can people please take a look? I can mark as intentional anything that really is intentional, thanks. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 16 Aug 2021 18:33:32 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects

Re: [PATCH 1/1] doc: rename Freescale to NXP

2021-08-16 Thread Tom Rini
On Mon, Aug 16, 2021 at 08:25:51AM +0200, Heinrich Schuchardt wrote: > Freescale Semiconductor, Inc. was merged into NXP Semiconductors in 2015. > > Signed-off-by: Heinrich Schuchardt [snip] > --- a/doc/board/freescale/index.rst > +++ b/doc/board/nxp/index.rst > @@ -1,7 +1,7 @@ > ..

[ANN] U-Boot v2021.10-rc2 released

2021-08-16 Thread Tom Rini
Hey all, So, whoops. It's a week later than release day should be because my reminders were off by a week. With that, here's v2021.10-rc2. I don't think it's really bigger than it should otherwise be, all things considered. One thing I'm working through currently is migrating some of the I2C

Re: [PULL] Pull request for u-boot master / v2021.10 = u-boot-stm32-20210816

2021-08-16 Thread Tom Rini
On Mon, Aug 16, 2021 at 01:42:14PM +0200, Patrice CHOTARD wrote: > Hi Tom > > Please pull the STM32 related patches for u-boot/master, v2021.10: > u-boot-stm32-20210816 > > CI status : > https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/8728 > > Thank

Re: [PATCH u-boot-mvebu v2 4/4] arm: mvebu: turris_omnia: disable MCU watchdog in board_late_init()

2021-08-16 Thread Pali Rohár
On Monday 16 August 2021 15:19:40 Marek Behún wrote: > Disable MCU watchdog in board_late_init() instead of board_init(), so > that it is disabled after U-Boot enables SOC watchdog instead of before. > This way there is no window when the board is vulnerable. > > Signed-off-by: Marek Behún

Re: [PATCH u-boot-mvebu v2 3/4] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Pali Rohár
On Monday 16 August 2021 15:19:39 Marek Behún wrote: > When booting over UART, sending U-Boot proper may take too much time and > MCU watchdog will reset the board before U-Boot proper is loaded. > > Better disable MCU watchdog in SPL when booting over UART. > > Signed-off-by: Marek Behún

Re: [PATCH 1/1] doc: rename Freescale to NXP

2021-08-16 Thread Heinrich Schuchardt
On 8/16/21 3:32 PM, Fabio Estevam wrote: Hi Stefano, On Mon, Aug 16, 2021 at 9:34 AM Stefano Babic wrote: Hi Heinrich, On 16.08.21 08:25, Heinrich Schuchardt wrote: Freescale Semiconductor, Inc. was merged into NXP Semiconductors in 2015. Signed-off-by: Heinrich Schuchardt --- Ok,

Re: [PATCH u-boot-mvebu v2 2/4] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro

2021-08-16 Thread Pali Rohár
On Monday 16 August 2021 15:19:38 Marek Behún wrote: > We do not need to guard code in board_init() and board_late_init() > functions with the CONFIG_SPL_BUILD macro, since these functions are not > called in SPL. > > Signed-off-by: Marek Behún Reviewed-by: Pali Rohár > --- >

Re: [PATCH u-boot-mvebu v2 1/4] arm: mvebu: Move get_boot_device() to cpu.c and make visible

2021-08-16 Thread Pali Rohár
On Monday 16 August 2021 15:19:37 Marek Behún wrote: > Move the function get_boot_device() from spl.c to cpu.c. > > Make it visible, so that it may be used from other files. > > Signed-off-by: Marek Behún Reviewed-by: Pali Rohár > --- > arch/arm/mach-mvebu/cpu.c | 60

[PATCH 1/1] doc: move doc/board/st/st.rst

2021-08-16 Thread Heinrich Schuchardt
'make htmldocs' does not use file doc/board/st/st.rst because the name matches the directory name. Let's rename it to st-dt.rst. Signed-off-by: Heinrich Schuchardt --- doc/board/st/index.rst | 2 +- doc/board/st/{st.rst => st-dt.rst} | 0 2 files changed, 1 insertion(+), 1

[RFC] imx8mm-evk: Generate a bootable flash.bin again

2021-08-16 Thread Fabio Estevam
After the convesion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed. Such new requirement breaks existing distro mechanisms to

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-08-16 Thread Fabio Estevam
Hi Frieder, On Mon, Aug 16, 2021 at 11:18 AM Frieder Schrempf wrote: > > If you prepare a patch I would prefer to have separate names for the SPL > > image and the final concatenated image. So we don't overwrite the SPL image > > and can still use it on its own if needed. > > But rather than

Re: [PATCH] tools: k3_fit_atf: Fix DM binary FIT load addresses

2021-08-16 Thread Suman Anna
On 8/14/21 1:49 AM, Suman Anna wrote: > The DM binary runs on the MCU R5F Core0 after R5 SPL on J721E and J7200 > SoCs. The binary is built alongside the TFA, OPTEE and A72 SPL binaries > and included in the tispl.bin FIT image. The R5 SPL loads the DM binary > at 0xA00 address, based on the

Re: [PATCH 3/5] arm: mach-k3: Add note to auto-generated files

2021-08-16 Thread Suman Anna
Hi Dave, On 8/11/21 12:12 AM, Lokesh Vutla wrote: > > > On 11/08/21 1:19 am, Dave Gerlach wrote: >> Add a note to the automatically generated clk-data and dev-data files >> for j721e and j7200 to indicate that they are in fact auto-generated and >> should not be hand edited. >> >>

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-08-16 Thread Frieder Schrempf
On 16.08.21 16:09, Frieder Schrempf wrote: > Hi Fabio, > > On 16.08.21 15:56, Fabio Estevam wrote: >> Hi Heiko, >> >> On Mon, Aug 16, 2021 at 7:27 AM Heiko Schocher wrote: >> >>> I am not a binman expert, but may you try to add in your u-boot.dtsi >>> in your "binman" node at the end: >>> >>>

Re: [PATCH v1 2/5] toradex: configblock: fix interactive mode it handling

2021-08-16 Thread Fabio Estevam
Hi Marcel, On Mon, Aug 16, 2021 at 10:53 AM Marcel Ziswiler wrote: > I am not exactly sure as to what exactly you are referring to here concerning > validity of such tags. I believe > we are not the only company (e.g. NXP themselves included) using this to > refer to our internal ticketing

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-08-16 Thread Frieder Schrempf
Hi Fabio, On 16.08.21 15:56, Fabio Estevam wrote: > Hi Heiko, > > On Mon, Aug 16, 2021 at 7:27 AM Heiko Schocher wrote: > >> I am not a binman expert, but may you try to add in your u-boot.dtsi >> in your "binman" node at the end: >> >> imx-boot { >> filename =

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-08-16 Thread Fabio Estevam
Hi Heiko, On Mon, Aug 16, 2021 at 7:27 AM Heiko Schocher wrote: > I am not a binman expert, but may you try to add in your u-boot.dtsi > in your "binman" node at the end: > > imx-boot { > filename = "imx-boot.bin"; > pad-byte = <0x00>; > >

Re: [PATCH v1 2/5] toradex: configblock: fix interactive mode it handling

2021-08-16 Thread Marcel Ziswiler
Hi Fabio On Mon, 2021-08-16 at 10:27 -0300, Fabio Estevam wrote: > Hi Marcel, > > On Mon, Aug 16, 2021 at 10:13 AM Marcel Ziswiler wrote: > > > > From: Denys Drozdov > > > > Restore "Is the module an IT version? [y/N]" for "cfgblock create" > > interactive mode command, which was leading to

Re: [PATCH 1/1] doc: rename Freescale to NXP

2021-08-16 Thread Fabio Estevam
Hi Stefano, On Mon, Aug 16, 2021 at 9:34 AM Stefano Babic wrote: > > Hi Heinrich, > > On 16.08.21 08:25, Heinrich Schuchardt wrote: > > Freescale Semiconductor, Inc. was merged into NXP Semiconductors in 2015. > > > > Signed-off-by: Heinrich Schuchardt > > --- > > Ok, but what we do with the

Re: [PATCH 3/5] arm: mach-k3: Add note to auto-generated files

2021-08-16 Thread Dave Gerlach
Hi, On 8/11/21 12:12 AM, Lokesh Vutla wrote: > > > On 11/08/21 1:19 am, Dave Gerlach wrote: >> Add a note to the automatically generated clk-data and dev-data files >> for j721e and j7200 to indicate that they are in fact auto-generated and >> should not be hand edited. >> >> Signed-off-by:

Re: [PATCH v1 2/5] toradex: configblock: fix interactive mode it handling

2021-08-16 Thread Fabio Estevam
Hi Marcel, On Mon, Aug 16, 2021 at 10:13 AM Marcel Ziswiler wrote: > > From: Denys Drozdov > > Restore "Is the module an IT version? [y/N]" for "cfgblock create" > interactive mode command, which was leading to invalid detection > of 0051 Colibri iMX8DX 1GB WB module; > > Fixes: a5b5ad4d859b

[PATCH u-boot-mvebu v2 4/4] arm: mvebu: turris_omnia: disable MCU watchdog in board_late_init()

2021-08-16 Thread Marek Behún
Disable MCU watchdog in board_late_init() instead of board_init(), so that it is disabled after U-Boot enables SOC watchdog instead of before. This way there is no window when the board is vulnerable. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 10 +- 1

[PATCH u-boot-mvebu v2 1/4] arm: mvebu: Move get_boot_device() to cpu.c and make visible

2021-08-16 Thread Marek Behún
Move the function get_boot_device() from spl.c to cpu.c. Make it visible, so that it may be used from other files. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/cpu.c | 60 arch/arm/mach-mvebu/include/mach/cpu.h | 2 + arch/arm/mach-mvebu/spl.c

[PATCH u-boot-mvebu v2 3/4] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
When booting over UART, sending U-Boot proper may take too much time and MCU watchdog will reset the board before U-Boot proper is loaded. Better disable MCU watchdog in SPL when booting over UART. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 17 -

[PATCH u-boot-mvebu v2 2/4] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro

2021-08-16 Thread Marek Behún
We do not need to guard code in board_init() and board_late_init() functions with the CONFIG_SPL_BUILD macro, since these functions are not called in SPL. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH u-boot-mvebu v2 0/4] turris_omnia: Disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
Hello Stefan, while debugging Omnia, when sending U-Boot over UART, some USB-TTY controllers are too slow and Omnia's MCU watchdog resets the board before U-Boot proper is sent. This patch series changes Omnia board code so that when booting via UART, we disable MCU watchdog in SPL, prior

[PATCH v1 5/5] colibri-imx6ull: add emmc variant

2021-08-16 Thread Marcel Ziswiler
From: Max Krummenacher Add code to build the eMMC variant of the Colibri iMX6ULL, i.e. the 'Colibri iMX6ULL 1GB' which has a eMMC instead of the raw NAND used on other SKUs. Related-to: ELB-4056, ELB-4057 Signed-off-by: Max Krummenacher Signed-off-by: Marcel Ziswiler ---

[PATCH v1 0/5] board: toradex: prepare and add colibri imx6ull 1gb (emmc) support

2021-08-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Some preparatory steps concerning tdx-cfg-block including a fix for the interactive mode IT handling and adding them new SKUs and then adding initial support for the Toradex Colibri iMX6ULL 1GB (eMMC) V1.1A module. They are now strapped to boot from eFuses which are factory

[PATCH v1 4/5] colibri-imx6ull: imximage.cfg: integrate new 1GiB RAM variant

2021-08-16 Thread Marcel Ziswiler
From: Philippe Schenker Integrate new Toradex SKU 0062 Colibri iMX6ULL 1GB IT. This commit basically adjusts three parameters of the RAM settings: Increase density from 4Gb to 8Gb Increase ROW address from 15 to 16 Increase tRFC (refresh command time) from 260 to 350 This timing is valid for

[PATCH v1 3/5] toradex: tdx-cfg-block: add new i.mx 6ull and 8m plus skus

2021-08-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Add new i.MX 6ULL and 8M Plus SKUs to ConfigBlock handling: 0062: Colibri iMX6ULL 1GB IT (eMMC) 0063: Verdin iMX8M Plus Quad 4GB IT 0064: Verdin iMX8M Plus Quad 2GB Wi-Fi / BT IT 0065: Verdin iMX8M Plus QuadLite 1GB IT 0066: Verdin iMX8M Plus Quad 8GB Wi-Fi / BT

[PATCH v1 2/5] toradex: configblock: fix interactive mode it handling

2021-08-16 Thread Marcel Ziswiler
From: Denys Drozdov Restore "Is the module an IT version? [y/N]" for "cfgblock create" interactive mode command, which was leading to invalid detection of 0051 Colibri iMX8DX 1GB WB module; Fixes: a5b5ad4d859b ("toradex: tdx-cfg-clock: add new i.mx 8m mini/plus skus") Related-to: ELB-3482

[PATCH v1 1/5] toradex: take over maintainership

2021-08-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Also take over maintainership of remaining Toradex SoMs as Oleksandr has left our company. Signed-off-by: Marcel Ziswiler CC: Oleksandr Suvorov --- board/toradex/apalis-imx8x/MAINTAINERS| 2 +- board/toradex/apalis_imx6/MAINTAINERS | 2 +-

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Stefan Roese
On 16.08.21 15:11, Marek Behún wrote: On Mon, 16 Aug 2021 15:07:33 +0200 Stefan Roese wrote: So the MCU watchdog is some kind of very early WD and only used until the SoC WD is used / enabled? Yes, this is how it was first thought of for Omnia. Looking at the MCU code it seems that the

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
On Mon, 16 Aug 2021 15:07:33 +0200 Stefan Roese wrote: > So the MCU watchdog is some kind of very early WD and only used until > the SoC WD is used / enabled? Yes, this is how it was first thought of for Omnia. Looking at the MCU code it seems that the watchdog can be started again after being

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Stefan Roese
On 16.08.21 15:01, Marek Behún wrote: On Mon, 16 Aug 2021 14:50:15 +0200 Stefan Roese wrote: - disable_mcu_watchdog(); + /* +* If not booting from UART, MCU watchdog was not disabled in SPL, +* disable it now. +*/ + if (get_boot_device() !=

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
On Mon, 16 Aug 2021 14:50:15 +0200 Stefan Roese wrote: > > - disable_mcu_watchdog(); > > + /* > > +* If not booting from UART, MCU watchdog was not disabled > > in SPL, > > +* disable it now. > > +*/ > > + if (get_boot_device() != BOOT_DEVICE_UART) > > +

Re: [PATCH v8 1/5] spi: rockchip_sfc: add support for Rockchip SFC

2021-08-16 Thread Jon Lin
On 2021/8/14 0:48, Chris Morgan wrote: On Fri, Aug 13, 2021 at 09:53:03AM +0800, Jon Lin wrote: Here is the point, Can you take a try. diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c index 8173724ecd..33c5344c70 100644 --- a/drivers/spi/rockchip_sfc.c +++

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Stefan Roese
Hi Marek, On 16.08.21 14:27, Marek Behún wrote: When booting over UART, sending U-Boot proper may take too much time and MCU watchdog will reset the board before U-Boot proper is loaded. Better disable MCU watchdog in SPL when booting over UART. Signed-off-by: Marek Behún ---

Re: [PATCH 1/1] doc: rename Freescale to NXP

2021-08-16 Thread Stefano Babic
Hi Heinrich, On 16.08.21 08:25, Heinrich Schuchardt wrote: Freescale Semiconductor, Inc. was merged into NXP Semiconductors in 2015. Signed-off-by: Heinrich Schuchardt --- Ok, but what we do with the Freescale that all around ? You change docs for boards, but boards are in

[PATCH u-boot-mvebu 2/3] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro

2021-08-16 Thread Marek Behún
We do not need to guard code in board_init() and board_late_init() functions with the CONFIG_SPL_BUILD macro, since these functions are not called in SPL. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
When booting over UART, sending U-Boot proper may take too much time and MCU watchdog will reset the board before U-Boot proper is loaded. Better disable MCU watchdog in SPL when booting over UART. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 17 -

[PATCH u-boot-mvebu 1/3] arm: mvebu: Move get_boot_device() to cpu.c and make visible

2021-08-16 Thread Marek Behún
Move the function get_boot_device() from spl.c to cpu.c. Make it visible, so that it may be used from other files. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/cpu.c | 60 arch/arm/mach-mvebu/include/mach/cpu.h | 2 + arch/arm/mach-mvebu/spl.c

[PATCH u-boot-mvebu 0/3] turris_omnia: Disable MCU watchdog in SPL when booting over UART

2021-08-16 Thread Marek Behún
Hello Stefan, while debugging Omnia, when sending U-Boot over UART, some USB-TTY controllers are too slow and Omnia's MCU watchdog resets the board before U-Boot proper is sent. This patch series changes Omnia board code so that when booting via UART, we disable MCU watchdog in SPL, prior

[PATCH v2 4/5] board: sama5d2_xplained: Get dram size and base from device tree

2021-08-16 Thread Clément Léger
In order to make it more flexible and allow modifying the base address of DRAM without recompiling U-Boot, use memory node from device tree with fdtdec functions. Signed-off-by: Clément Léger --- board/atmel/sama5d2_xplained/sama5d2_xplained.c | 11 +++ 1 file changed, 7 insertions(+),

[PATCH v2 2/5] board: sama5d27_som1_ek: Modify load addresses

2021-08-16 Thread Clément Léger
When using OP-TEE, address range [0x2000 - 0x2200] is reserved. This modification allows to have a system which always work even when OP-TEE is present. Signed-off-by: Clément Léger --- include/configs/sama5d27_som1_ek.h | 12 1 file changed, 4 insertions(+), 8 deletions(-)

[PATCH v2 3/5] ARM: dts: at91: sama5d2_xplained: Add memory node in devicetree

2021-08-16 Thread Clément Léger
sama5d2_xplained DRAM detection code will be modified to use device tree instead of hardcoded addresses. In order to prepare that, add the memory node to at91-sama5d2_xplained.dts. Signed-off-by: Clément Léger --- arch/arm/dts/at91-sama5d2_xplained.dts | 4 1 file changed, 4 insertions(+)

[PATCH v2 5/5] board: sama5d2_xplained: Modify load addresses

2021-08-16 Thread Clément Léger
When using OP-TEE, address range [0x2000 - 0x2200] is reserved. This modification allows to have a system which always work even when OP-TEE is present. Signed-off-by: Clément Léger --- include/configs/sama5d2_xplained.h | 24 ++-- 1 file changed, 10 insertions(+),

[PATCH v2 1/5] board: sama5d27_som1_ek: Get dram size and base from device tree

2021-08-16 Thread Clément Léger
In order to make it more flexible and allow modifying the base address of DRAM without recompiling U-Boot, use memory node from device tree with fdtdec functions. Signed-off-by: Clément Léger --- board/atmel/sama5d27_som1_ek/sama5d27_som1_ek.c | 12 1 file changed, 8 insertions(+),

[PATCH v2 0/5] Use device tree to get DRAM for sama5d27_som1_ek/sama5d2_xplained

2021-08-16 Thread Clément Léger
Loading U-Boot after OP-TEE requires to move the base address of the DRAM and reduce its size. Indeed, OP-TEE will be loaded at start of DRAM for these platforms and this DRAM will be secured and thus not accessible to U-Boot. Currently, addresses are hardcoded in board configs. This series adds

[PULL] Pull request for u-boot master / v2021.10 = u-boot-stm32-20210816

2021-08-16 Thread Patrice CHOTARD
Hi Tom Please pull the STM32 related patches for u-boot/master, v2021.10: u-boot-stm32-20210816 CI status : https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/8728 Thanks Patrice Highlights: - Handle TF-A boot

Re: [Uboot-stm32] [PATCH] clk: stm32mp1: add support of BSEC clock

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 8/2/21 1:42 PM, Patrice CHOTARD wrote: > Hi Patrick > > On 7/16/21 10:10 AM, Patrick Delaunay wrote: >> Add the support of the BSEC clock used by the STM32MP misc driver >> since the commit 622c956cada0 ("stm32mp: bsec: manage clock when present >> in device tree") even if this

Re: [PATCH v3 5/5] stm32mp1: stm32prog: remove stm32prog_get_tee_partitions with FIP

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 7/26/21 11:21 AM, Patrick Delaunay wrote: > The MTD tee partitions used to save the OP-TEE binary are needed when > TF-A doesn't use the FIP container to load binaries. > > This patch puts under CONFIG_STM32MP15x_STM32IMAGE flag the associated > code in U-Boot binary and prepare

Re: [PATCH v3 4/5] doc: st: stm32mp1: Add FIP support for trusted boot

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 7/26/21 11:21 AM, Patrick Delaunay wrote: > TF-A for STM32MP15 now supports the FIP: it is a packaging format which > includes the secure monitor, u-boot-nodtb.bin and u-boot.dtb > > This FIP file is loaded by FSBL = TF-A BL2. > > This patch updates the board documentation to use

Re: [PATCH v3 3/5] arm: stm32mp: add defconfig for trusted boot with FIP

2021-08-16 Thread Patrice CHOTARD
HI Patrick On 7/26/21 11:21 AM, Patrick Delaunay wrote: > Add TF-A FIP support for trusted boot on STM32MP15x, > when STM32MP15x_STM32IMAGE is not activated. > > With FIP support the SSBL partition is named "fip" and its size is 4MB, > so the ENV partition name in device tree (for SD card or

Re: [PATCH v3 2/5] arm: stm32mp: handle the OP-TEE nodes in DT with FIP support

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 7/26/21 11:21 AM, Patrick Delaunay wrote: > With FIP support in TF-A (when CONFIG_STM32MP15x_STM32IMAGE > is not activated), the DT nodes needed by OP-TEE are added by OP-TEE > firmware in U-Boot device tree, present in FIP. > > These nodes are only required in trusted boot, when

Re: [PATCH v3 1/5] arm: stm32mp: add config for STM32IMAGE support

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 7/26/21 11:21 AM, Patrick Delaunay wrote: > By default for trusted boot with TF-A, U-Boot (u-boot-nodtb) > is located in FIP container with its device tree and with > the secure monitor (provided by TF-A or OP-TEE). > The FIP file is loaded by TF-A BL2 and each components is >

Re: [Uboot-stm32] [PATCH] arm: dts: stm32mp15: alignment with v5.14

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 8/2/21 2:41 PM, Patrice CHOTARD wrote: > Hi Patrick > > On 7/27/21 12:15 PM, Patrick Delaunay wrote: >> Device tree alignment with Linux kernel v5.14-rc3 >> - ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15 >> - ARM: dts: stm32: Configure qspi's mdma transfer

Re: [PATCH] ARM: Prevent the compiler from using NEON registers

2021-08-16 Thread Andre Przywara
On Sun, 15 Aug 2021 22:14:37 -0500 Samuel Holland wrote: Hi, in general I think the patch makes sense, and we should use that option since we also specify -msoft-float. > For ARMv8-A, NEON is standard, It should be noted that the ARMv8-A architecture itself treats FP and AdvSIMD as optional,

Re: [PATCH 5/5] test: dm: Add test for ECDSA UCLASS support

2021-08-16 Thread Patrice CHOTARD
Hi Alexandru On 7/30/21 11:53 AM, Patrick DELAUNAY wrote: > Hi, > > On 7/29/21 6:47 PM, Alexandru Gagniuc wrote: >> This test verifies that ECDSA_UCLASS is implemented, and that >> ecdsa_verify() works as expected. The definition of "expected" is >> "does not find a device, and returns -ENODEV".

Re: [PATCH 4/5] Kconfig: FIT_SIGNATURE should not select RSA_VERIFY

2021-08-16 Thread Patrice CHOTARD
Hi Alexandru On 7/30/21 11:52 AM, Patrick DELAUNAY wrote: > Hi, > > On 7/29/21 6:47 PM, Alexandru Gagniuc wrote: >> FIT signatures can now be implemented with ECDSA. The assumption that >> all FIT images are signed with RSA is no longer valid. Thus, instead >> of 'select'ing RSA, only 'imply'

Re: [PATCH 3/5] arm: stm32mp1: Implement ECDSA signature verification

2021-08-16 Thread Patrice CHOTARD
Hi Alexandru On 7/30/21 11:51 AM, Patrick DELAUNAY wrote: > Hi, > > On 7/29/21 6:47 PM, Alexandru Gagniuc wrote: >> The STM32MP ROM provides several service. One of them is the ability >> to verify ecdsa256 signatures. Hook the ROM API into the ECDSA uclass. >> >> Signed-off-by: Alexandru

Re: [PATCH 1/5] dm: crypto: Define UCLASS API for ECDSA signature verification

2021-08-16 Thread Patrice CHOTARD
Hi Alexandru On 7/30/21 11:47 AM, Patrick DELAUNAY wrote: > Hi Alexandru, > > On 7/29/21 6:47 PM, Alexandru Gagniuc wrote: >> Define a UCLASS API for verifying ECDSA signatures. Unlike >> UCLASS_MOD_EXP, which focuses strictly on modular exponentiation, >> the ECDSA class focuses on

Re: [Uboot-stm32] [PATCH] stm32mp: correctly handle board_get_usable_ram_top(0)

2021-08-16 Thread Patrice CHOTARD
Hi Patrick On 8/16/21 9:26 AM, Patrice CHOTARD wrote: > Hi Patrick > > On 7/26/21 11:55 AM, Patrick Delaunay wrote: >> The function board_get_usable_ram_top can to called after relocation >> with total_size = 0 to get the uppermost pointer that is valid to access >> in U-Boot. >> >> When

Re: [PATCH] ARM: dts: stm32: Reduce DHCOR SPI NOR frequency to 50 MHz

2021-08-16 Thread Patrice CHOTARD
Hi Marek On 8/9/21 2:33 PM, Patrice CHOTARD wrote: > Hi Marek > > On 8/9/21 2:06 PM, Marek Vasut wrote: >> The SPI NOR is a bit further away from the SoC on DHCOR than on DHCOM, >> which causes additional signal delay. At 108 MHz, this delay triggers >> a sporadic issue where the first bit of RX

Re: [PATCH] ARM: stm32: Set environment sector size to 4k on DHSOM

2021-08-16 Thread Patrice CHOTARD
Hi Marek On 8/9/21 2:36 PM, Patrice CHOTARD wrote: > Hi Marek > > On 8/9/21 2:08 PM, Marek Vasut wrote: >> The DHSOM SPI NOR is using 4k erase blocks, make use of it >> and define the default environment sector size to 4k. >> >> Signed-off-by: Marek Vasut >> Cc: Patrice Chotard >> Cc: Patrick

[PATCH 7/7] imx8mp_evk: Enable the DWC EQoS iMX driver

2021-08-16 Thread Ye Li
Enable the EQoS i.MX driver in defconfig, also enable the PHYLIB to facilitate the case that only has FEC enabled. Signed-off-by: Ye Li --- configs/imx8mp_evk_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig index

  1   2   >