Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread Ilias Apalodimas
On Mon, Feb 14, 2022 at 03:36:06PM +0900, AKASHI Takahiro wrote: > On Mon, Feb 14, 2022 at 08:18:03AM +0200, Ilias Apalodimas wrote: > > On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > > > Ilias, > > > > > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread AKASHI Takahiro
On Mon, Feb 14, 2022 at 08:18:03AM +0200, Ilias Apalodimas wrote: > On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > > Ilias, > > > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > > The previous patch is changing U-Boot's behavior wrt certificate based > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread Ilias Apalodimas
On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > Ilias, > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > The previous patch is changing U-Boot's behavior wrt certificate based > > binary authentication. Specifically an image who's digest of a > > certifi

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-13 Thread Sughosh Ganu
hi Takahiro, On Mon, 14 Feb 2022 at 08:54, AKASHI Takahiro wrote: > > Sughosh, > > On Thu, Feb 10, 2022 at 03:40:00PM +0530, Sughosh Ganu wrote: > > On Thu, 10 Feb 2022 at 13:28, AKASHI Takahiro > > wrote: > > > > > > On Thu, Feb 10, 2022 at 12:48:13PM +0530, Sughosh Ganu wrote: > > > > hi Takah

Re: [PATCH v4 05/11] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-02-13 Thread AKASHI Takahiro
Sughosh, On Thu, Feb 10, 2022 at 03:40:00PM +0530, Sughosh Ganu wrote: > On Thu, 10 Feb 2022 at 13:28, AKASHI Takahiro > wrote: > > > > On Thu, Feb 10, 2022 at 12:48:13PM +0530, Sughosh Ganu wrote: > > > hi Takahiro, > > > > > > On Thu, 10 Feb 2022 at 08:18, AKASHI Takahiro > > > wrote: > > > >

Re: [PATCH] usb: ehci-omap: Drop dead code

2022-02-13 Thread Marek Vasut
On 2/14/22 01:05, Adam Ford wrote: On Sat, Feb 12, 2022 at 8:26 AM Adam Ford wrote: omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init is only called by the probe function, so it can be static to that function. Remove both from the header along with some additional checking fo

Re: [PATCH 3/3] efi_loader: add menu-driven UEFI Boot Variable maintenance

2022-02-13 Thread Masahisa Kojima
, On Sun, 13 Feb 2022 at 18:58, Heinrich Schuchardt wrote: > > On 2/10/22 08:05, Masahisa Kojima wrote: > > This commit adds the menu-driven UEFI Boot Variable maintenance. > > User can add and delete the Boot variable, and update the > > BootOrder variable through menu operation. > > > > S

RE: [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary

2022-02-13 Thread Bough Chen
Hi Fabio, Can you help test these 3 patches on imx6qdl-pico board or imx7s board on your side to double check whether these patches enlarge the total boot time? Best Regards Bough Chen > -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: 2022年2月14日 5:53 > To: Bough Ch

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-13 Thread Masami Hiramatsu
Hi Takahiro, 2022年2月14日(月) 10:06 AKASHI Takahiro : > > On Sun, Feb 13, 2022 at 11:17:37AM +0100, Heinrich Schuchardt wrote: > > On 2/13/22 10:01, Heinrich Schuchardt wrote: > > > On 2/3/22 10:23, Masami Hiramatsu wrote: > > > > Add a cold reset soon after processing capsule update on disk. > > > >

Re: [PATCH v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model

2022-02-13 Thread AKASHI Takahiro
Heinrich, On Thu, Feb 10, 2022 at 04:20:11PM +0100, Heinrich Schuchardt wrote: > On 2/10/22 09:11, AKASHI Takahiro wrote: > > Background: > > === > > The purpose of this patch is to reignite the discussion about how UEFI > > subystem would best be integrated into U-Boot driver model. > > I

Re: [PATCH 1/3] efi_loader: add menu-driven boot device selection

2022-02-13 Thread Masahisa Kojima
On Sun, 13 Feb 2022 at 19:11, Heinrich Schuchardt wrote: > > On 2/10/22 08:05, Masahisa Kojima wrote: > > This patch enables the menu-driven boot device selection. > > User can select the Boot included in BootOrder variable. > > > > If user quits thie menu, or the selected Boot fails to bo

Re: [PATCH 2/3] lib/charset: add u16_strcat() function

2022-02-13 Thread Masahisa Kojima
Hi Heinrich, On Sun, 13 Feb 2022 at 19:12, Heinrich Schuchardt wrote: > > On 2/10/22 08:05, Masahisa Kojima wrote: > > Provide u16 string version of strcat(). > > > > Signed-off-by: Masahisa Kojima > > Please, provide a test in test/unicode_ut.c. Yes, I will add. > > --- > > include/charset.

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread AKASHI Takahiro
Ilias, On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary authentication. Specifically an image who's digest of a > certificate is found in dbx is now rejected. Fix the test accordingly > and add ano

Re: [PATCH 22/24] rockchip: Support building the all output files in binman

2022-02-13 Thread Peter Geis
On Thu, Feb 10, 2022 at 2:32 PM Peter Geis wrote: > > On Thu, Feb 10, 2022 at 1:58 PM Simon Glass wrote: > > > > Hi Peter, > > > > On Thu, 10 Feb 2022 at 08:04, Peter Geis wrote: > > > > > > On Tue, Feb 8, 2022 at 1:54 PM Simon Glass wrote: > > > > > > > > > > Good Morning, > > > > > > > Add th

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-13 Thread Andrew Jeffery
Hi Alex, thanks for taking a look at the patch. On Sun, 13 Feb 2022, at 05:25, Alex G. wrote: > On 1/30/22 21:41, Andrew Jeffery wrote: >> Some platform designs include support for disabling secure-boot via a >> jumper on the board. Sometimes this control can be separate from the >> mechanism enab

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Please see below. On Sun, Feb 13, 2022 at 4:21 PM Pali Rohár wrote: > > On Sunday 13 February 2022 16:08:51 Tony Dinh wrote: > > Hi Pali, > > > > On Sun, Feb 13, 2022 at 3:42 PM Pali Rohár wrote: > > > > > > On Sunday 13 February 2022 15:24:46 Tony Dinh wrote: > > > > Hi Pali, > > > >

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-13 Thread AKASHI Takahiro
On Sun, Feb 13, 2022 at 11:17:37AM +0100, Heinrich Schuchardt wrote: > On 2/13/22 10:01, Heinrich Schuchardt wrote: > > On 2/3/22 10:23, Masami Hiramatsu wrote: > > > Add a cold reset soon after processing capsule update on disk. > > > This is required in UEFI specification 2.9 Section 8.5.5 > > >

Re: [PATCH v11 2/9] tools: mkeficapsule: add firmware image signing

2022-02-13 Thread AKASHI Takahiro
Heinrich, On Fri, Feb 11, 2022 at 08:16:34PM +0100, Heinrich Schuchardt wrote: > On 2/9/22 11:10, AKASHI Takahiro wrote: > > With this enhancement, mkeficapsule will be able to sign a capsule > > file when it is created. A signature added will be used later > > in the verification at FMP's SetImag

Re: [PATCH v11 5/9] test/py: efi_capsule: add image authentication test

2022-02-13 Thread AKASHI Takahiro
Heinrich, On Fri, Feb 11, 2022 at 08:25:15PM +0100, Heinrich Schuchardt wrote: > On 2/9/22 11:10, AKASHI Takahiro wrote: > > Add a couple of test cases against capsule image authentication > > for capsule-on-disk, where only a signed capsule file with the verified > > signature will be applied to

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Sunday 13 February 2022 16:08:51 Tony Dinh wrote: > Hi Pali, > > On Sun, Feb 13, 2022 at 3:42 PM Pali Rohár wrote: > > > > On Sunday 13 February 2022 15:24:46 Tony Dinh wrote: > > > Hi Pali, > > > > > > Looks different, but the BootROM did not start the image. Please see > > > the log below. >

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, On Sun, Feb 13, 2022 at 3:42 PM Pali Rohár wrote: > > On Sunday 13 February 2022 15:24:46 Tony Dinh wrote: > > Hi Pali, > > > > Looks different, but the BootROM did not start the image. Please see > > the log below. > > > > On Sun, Feb 13, 2022 at 2:48 PM Pali Rohár wrote: > > > > > > O

Re: [PATCH] usb: ehci-omap: Drop dead code

2022-02-13 Thread Adam Ford
On Sat, Feb 12, 2022 at 8:26 AM Adam Ford wrote: > > omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init > is only called by the probe function, so it can be static to that > function. Remove both from the header along with some additional > checking for DM_USB. > If it's not too

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Sunday 13 February 2022 15:24:46 Tony Dinh wrote: > Hi Pali, > > Looks different, but the BootROM did not start the image. Please see > the log below. > > On Sun, Feb 13, 2022 at 2:48 PM Pali Rohár wrote: > > > > On Sunday 13 February 2022 14:45:07 Tony Dinh wrote: > > > Hi Pali, > > > > > >

[PATCH 2/2] ARM: imx: imx8mn-ddr4-evk: Add ethernet support

2022-02-13 Thread Marek Vasut
Add support for ethernet on the imx8mn-ddr4-evk. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/dts/imx8mn-evk.dtsi| 1 + board/freescale/imx8mn_evk/imx8mn_evk.c | 41 +++-- configs/imx8mn_ddr4_evk_defconfig | 8

[PATCH 1/2] ARM: imx: imx8mn-ddr4-evk: Fix boot from SD card

2022-02-13 Thread Marek Vasut
Enable missing config options to make the board boot from SD card. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- configs/imx8mn_evk_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/imx8mn_evk_defconfig b/configs/imx8mn_evk_defconf

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Looks different, but the BootROM did not start the image. Please see the log below. On Sun, Feb 13, 2022 at 2:48 PM Pali Rohár wrote: > > On Sunday 13 February 2022 14:45:07 Tony Dinh wrote: > > Hi Pali, > > > > Some compile errors, please see below. > > > > On Sun, Feb 13, 2022 at 8:16

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Sunday 13 February 2022 14:45:07 Tony Dinh wrote: > Hi Pali, > > Some compile errors, please see below. > > On Sun, Feb 13, 2022 at 8:16 AM Pali Rohár wrote: > > > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > > *** Run kwboot > > > > > > # kwboot -t -p -B 115200 /dev/ttyUSB0

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Some compile errors, please see below. On Sun, Feb 13, 2022 at 8:16 AM Pali Rohár wrote: > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > *** Run kwboot > > > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > > Patching image boot signature to UART > > A

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, On Sun, Feb 13, 2022 at 1:33 PM Marek Behún wrote: > > On Sun, 13 Feb 2022 22:23:10 +0100 > Pali Rohár wrote: > > > > In that case the whole ternary operator can be dropped, i.e. instead of > > > ((hdr->ext > 1) ? (hdr->ext * 0x20) : 0) > > > you can have > > > ((hdr->ext - 1) * 0x2

Re: [PATCH 3/3] mmc: fsl_esdhc_imx: correct the actual card clock

2022-02-13 Thread Marek Vasut
On 2/11/22 12:16, haibo.c...@nxp.com wrote: From: Haibo Chen The original code logic can not show the correct card clock, and also has one risk when the div is 0. Because there is div -=1 before. So move the operation before div -=1, and also involve ddr_pre_div to get the correct value. Rev

Re: [PATCH 2/3] mmc: fsl_esdhc_imx: remove redundant ARCH_MXC

2022-02-13 Thread Marek Vasut
On 2/11/22 12:16, haibo.c...@nxp.com wrote: From: Haibo Chen Now original fsl_esdhc.c are split as fsl_esdhc.c and fsl_esdhc_imx.c. fsl_esdhc_imx.c only cover i.MX SoC. So ARCH_MXC is redundant. Reviewed-by: Marek Vasut

Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary

2022-02-13 Thread Marek Vasut
On 2/11/22 12:16, haibo.c...@nxp.com wrote: Hi, [...] @@ -897,6 +900,11 @@ static int fsl_esdhc_execute_tuning(struct udevice *dev, uint32_t opcode) esdhc_stop_tuning(mmc); + /* change to default setting, let host control the card clock */ + esdhc_clrbits32(®s->vendorspec, VEN

Re: [PATCH] Revert "mmc: fsl_esdhc_imx: add wait_dat0() support"

2022-02-13 Thread Marek Vasut
On 2/7/22 08:59, Bough Chen wrote: -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: 2022年1月29日 1:37 To: Jaehoon Chung ; u-boot@lists.denx.de Cc: sba...@denx.de; Bough Chen ; Igor Opaniuk ; Peng Fan Subject: Re: [PATCH] Revert "mmc: fsl_esdhc_imx: add wait_dat0() suppor

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Marek Behún
On Sun, 13 Feb 2022 22:23:10 +0100 Pali Rohár wrote: > > In that case the whole ternary operator can be dropped, i.e. instead of > > ((hdr->ext > 1) ? (hdr->ext * 0x20) : 0) > > you can have > > ((hdr->ext - 1) * 0x20) > > if I interpret this correctly. > > No, it cannot be dropped, with c

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Sunday 13 February 2022 22:15:09 Marek Behún wrote: > On Sun, 13 Feb 2022 20:41:08 +0100 > Pali Rohár wrote: > > > On Sunday 13 February 2022 17:16:42 Pali Rohár wrote: > > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > > > *** Run kwboot > > > > > > > > # kwboot -t -p -B 115

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Marek Behún
On Sun, 13 Feb 2022 20:41:08 +0100 Pali Rohár wrote: > On Sunday 13 February 2022 17:16:42 Pali Rohár wrote: > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > > *** Run kwboot > > > > > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > > > Patching image boot si

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Sunday 13 February 2022 17:16:42 Pali Rohár wrote: > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > *** Run kwboot > > > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > > Patching image boot signature to UART > > Aligning image header to Xmodem block size > > Wa

[PATCH 3/3 v2] board: axy17lte: get board usable - add bootcmd and docs

2022-02-13 Thread Dzmitry Sankouski
U-boot is intended to replace linux kernel in android boot image(ABL), and it's FIT payload to replace initramfs file. The boot process is similar to boot image with linux: - android bootloader (ABL) unpacks android boot image - ABL sets `linux,initrd-start property` in chosen node in unpacked FDT

[PATCH 2/3 v3] board: starqltechn: get board usable - add bootcmd and docs

2022-02-13 Thread Dzmitry Sankouski
U-boot is intended to replace linux kernel in android boot image(ABL), and it's FIT payload to replace initramfs file. The boot process is similar to boot image with linux: - android bootloader (ABL) unpacks android boot image - ABL sets `linux,initrd-start property` in chosen node in unpacked FDT

[PATCH 1/3 v3] arm: init: save previous bootloader data

2022-02-13 Thread Dzmitry Sankouski
When u-boot is used as a chain-loaded bootloader (replacing OS kernel), previous bootloader leaves data in RAM, that can be reused. For example, on recent arm linux system, when chainloading u-boot, there are initramfs and fdt in RAM prepared for OS booting. Initramfs may be modified to store u-bo

[PATCH 0/3] save prev bootloader data, when u-boot chainloaded

2022-02-13 Thread Dzmitry Sankouski
When u-boot is used as a chain-loaded bootloader (replacing OS kernel), previous bootloader leaves data in RAM, that can be reused. For example, on recent arm linux system, when chainloading u-boot, there are initramfs and fdt in RAM prepared for OS booting. Initramfs may be modified to store u-bo

[PATCH] arm: dts: k3-j7200: Fix up MAIN R5FSS cluster mode back to Split-mode

2022-02-13 Thread Suman Anna
The default U-Boot environment variables and design are all set up for the MAIN R5FSS cluster to be in Split-mode. This is the setting used when the dts nodes were originally added in v2021.01 U-Boot and the dt nodes are synched with the kernel binding property names in commit 468ec2f3ef8f ("remote

[PATCH] arm: sunxi: dram: restore previous value in DRAM

2022-02-13 Thread Andrei Lalaev
It's better to restore previous value at offset because otherwise the function can corrupt memory reserved by Linux (e.g. ramoops). Signed-off-by: Andrei Lalaev --- arch/arm/mach-sunxi/dram_helpers.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/arm/mac

Re: Problem IMX8MN booting legacy kernel and mipi display

2022-02-13 Thread Adam Ford
On Sun, Feb 13, 2022 at 10:27 AM Michael Nazzareno Trimarchi wrote: > > Hi Adam > > On Sun, Feb 13, 2022 at 5:03 PM Adam Ford wrote: > > > > On Sat, Feb 12, 2022 at 1:27 PM Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi Tim > > > > > > You are using the imx8mm. I have problems on imx8mn.

Re: Problem IMX8MN booting legacy kernel and mipi display

2022-02-13 Thread Michael Nazzareno Trimarchi
Hi Adam On Sun, Feb 13, 2022 at 5:03 PM Adam Ford wrote: > > On Sat, Feb 12, 2022 at 1:27 PM Michael Nazzareno Trimarchi > wrote: > > > > Hi Tim > > > > You are using the imx8mm. I have problems on imx8mn. It's like some > > part is not implemented. Time to time power domain timeout if I > > ena

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > *** Run kwboot > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > Patching image boot signature to UART > Aligning image header to Xmodem block size > Waiting 2s and flushing tty > Sending boot image header (512 bytes)...

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Pali Rohár
On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > *** Run kwboot > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > Patching image boot signature to UART > Aligning image header to Xmodem block size > Waiting 2s and flushing tty > Sending boot image header (512 bytes)...

Re: Problem IMX8MN booting legacy kernel and mipi display

2022-02-13 Thread Adam Ford
On Sat, Feb 12, 2022 at 1:27 PM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > You are using the imx8mm. I have problems on imx8mn. It's like some > part is not implemented. Time to time power domain timeout if I > enabled > mipi pipeline If you're using ATF from its mainline branch, it likely

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-13 Thread Heinrich Schuchardt
On 2/13/22 10:01, Heinrich Schuchardt wrote: On 2/3/22 10:23, Masami Hiramatsu wrote: Add a cold reset soon after processing capsule update on disk. This is required in UEFI specification 2.9 Section 8.5.5 "Delivery of Capsules via file on Mass Storage device" as; In all cases that a capsu

Re: [PATCH 2/3] lib/charset: add u16_strcat() function

2022-02-13 Thread Heinrich Schuchardt
On 2/10/22 08:05, Masahisa Kojima wrote: Provide u16 string version of strcat(). Signed-off-by: Masahisa Kojima Please, provide a test in test/unicode_ut.c. --- include/charset.h | 13 + lib/charset.c | 12 2 files changed, 25 insertions(+) diff --git a/incl

Re: [PATCH 1/3] efi_loader: add menu-driven boot device selection

2022-02-13 Thread Heinrich Schuchardt
On 2/10/22 08:05, Masahisa Kojima wrote: This patch enables the menu-driven boot device selection. User can select the Boot included in BootOrder variable. If user quits thie menu, or the selected Boot fails to boot, efi bootmgr continues to boot in accordance with BootOrder variable. S

Re: [PATCH 3/3] efi_loader: add menu-driven UEFI Boot Variable maintenance

2022-02-13 Thread Heinrich Schuchardt
On 2/10/22 08:05, Masahisa Kojima wrote: This commit adds the menu-driven UEFI Boot Variable maintenance. User can add and delete the Boot variable, and update the BootOrder variable through menu operation. Signed-off-by: Masahisa Kojima --- lib/efi_loader/efi_bootmgr.c | 720

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-13 Thread Heinrich Schuchardt
On 2/3/22 10:23, Masami Hiramatsu wrote: Add a cold reset soon after processing capsule update on disk. This is required in UEFI specification 2.9 Section 8.5.5 "Delivery of Capsules via file on Mass Storage device" as; In all cases that a capsule is identified for processing the system is

Re: [PATCH v4 1/2] efi_loader: use efi_update_capsule_firmware() for capsule on disk

2022-02-13 Thread Heinrich Schuchardt
On 2/3/22 10:23, Masami Hiramatsu wrote: Since the efi_update_capsule() represents the UpdateCapsule() runtime service, it has to handle the capsule flags and update ESRT. However the capsule-on-disk doesn't need to care about such things. Thus, the capsule-on-disk should use the efi_capsule_upd

[PATCH 4/7] microblaze: exception: fix return address for delay slot exceptions

2022-02-13 Thread Ovidiu Panait
According to the MicroBlaze reference manual (xilinx2021.2/ug984/page-37): """ If an exception is caused by an instruction in a delay slot (that is, ESR[DS]=1), the exception handler should return execution to the address stored in BTR instead of the normal exception return address stored in R17. "

[PATCH 2/7] microblaze: exception: migrate MICROBLAZE_V5 to Kconfig

2022-02-13 Thread Ovidiu Panait
Also, rename it to XILINX_MICROBLAZE0_DELAY_SLOT_EXCEP, since it only covers delay slot exception support. Signed-off-by: Ovidiu Panait --- arch/microblaze/cpu/exception.c | 2 +- board/xilinx/microblaze-generic/Kconfig | 9 + include/configs/microblaze-generic.h| 3 --- 3 f

[PATCH 6/7] microblaze: exception: fix unaligned data access register mask

2022-02-13 Thread Ovidiu Panait
The correct mask for getting the source/destination register from ESR in the case of an unaligned access exception is 0x3E0. With this change, a dummy unaligned store produces the expected info: """ >> swi r5, r0, 0x111 ... Hardware exception at 0x111 address Unaligned data access exception Un

[PATCH 7/7] microblaze: exception: drop user exception support

2022-02-13 Thread Ovidiu Panait
A user exception is triggered by inserting a bralid/brki jump to "C_BASE_VECTORS+0x8" in the software flow. Because u-boot microblaze code does not deal with MMU-related features such as user-mode/privileged-mode separation, there are no code sequences that call into the user exception handler. It

[PATCH 3/7] microblaze: exception: fix delay slot exception handling

2022-02-13 Thread Ovidiu Panait
The switch statement in _hw_exception_handler() only covers the rightmost 5 bits that encode the exception cause: switch (state & 0x1f) { ... } For this reason, the "0x1000" case will never be reached, because the 13th bit was zeroed out. To fix this, move delay slot exception handling before the

[PATCH 5/7] microblaze: exception: move unaligned access printfs inside switch case

2022-02-13 Thread Ovidiu Panait
The unaligned access messages are only valid in the case of an unaligned data access exception. Do not print them for other types of hw exceptions. Signed-off-by: Ovidiu Panait --- arch/microblaze/cpu/exception.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mi

[PATCH 1/7] microblaze: exception: move privileged instruction exception out of v5 ifdef

2022-02-13 Thread Ovidiu Panait
The privileged instruction exception seems to have been introduced in microblaze v7.00 along with MMU support, so having it wrapped in MICROBLAZE_v5 ifdefs seems incorrect. Move it out of the ifdef, since all recent microblaze versions support it. Signed-off-by: Ovidiu Panait --- arch/microblaz