Pull request: u-boot-rockchip-20240718

2024-07-18 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - Add boards: rk3328: Radxa ROCK Pi E v3; rk3588s: FriendlyElec NanoPi R6C/S; - Remove board: Theobroma Systems RK3368 Lion; - Add rk3588 pcie support; - Misc updates for board and config; CI:

Re: Pull request: u-boot-rockchip-20240614

2024-07-18 Thread Kever Yang
Hi Quentin, On 2024/7/18 16:03, Quentin Schulz wrote: Hi Kever, On 7/18/24 5:52 AM, Kever Yang wrote: Hi Tom, Please pull the fixex for rockchip platform: - pmic fix for rk8xx; - pinctrl fix for rk3188/rv1126/rk3588; - mkimage fix for rockcihp "-l" option; I think this is a mi

Pull request: u-boot-rockchip-20240614

2024-07-17 Thread Kever Yang
Hi Tom, Please pull the fixex for rockchip platform: - pmic fix for rk8xx; - pinctrl fix for rk3188/rv1126/rk3588; - mkimage fix for rockcihp "-l" option; CI: https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/pipelines/2 Thanks, - Kever The following changes since commit

Re: [PATCH v3 3/3] configs: rockchip: imply OF_LIBFDT_OVERLAY for rk3308 and rk3328

2024-07-17 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3: - add missing separator in commit message Changes in v2: - none --- arch/arm/mach-rockchip/Kconfig | 2 ++ configs/evb-rk3308_defconfig | 1 - configs/roc-cc-rk3308_defconfig| 1 - configs/rock-pi-s-rk3308_defconfig | 1 - 4

Re: [PATCH v2 3/5] board: rock5b-rk3588: add USB-C controller support

2024-07-17 Thread Kever Yang
Hi Sebastian, On 2024/6/5 00:33, Sebastian Reichel wrote: Enable support for the fusb302 USB Type-C controller. This will do early USB PD (power deliver) negotiation, which must happen within 5 seconds after the USB-C connector has plugged in according to the specification. It takes almost 5

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-07-17 Thread Kever Yang
Hi Quentin, On 2024/7/16 10:17, Kever Yang wrote: On 2024/6/20 18:24, Quentin Schulz wrote: From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't

Re: [PATCH v2 1/3] configs: rockchip: reduce diff for rk3308, rk3328, rk3399, rk3568, and rk3588

2024-07-16 Thread Kever Yang
Hi Naoki, On 2024/6/18 17:53, FUKAUMI Naoki wrote: this is cosmetic change. no functional change is intended. - remove redundant white spaces - replace white spaces with tab - align position of last letter/word - sort lines in CFG_EXTRA_ENV_SETTINGS - add comment after #endif Signed-off-by:

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-07-16 Thread Kever Yang
U-Boot pre-reloc as required for RK3399 Puma. Fixes: 100f489f58a6 ("rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC") Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-u-boot.dtsi | 5 + 1 file changed, 5 inser

Re: [PATCH] arm: rockchip: using generic capsule update mechanism

2024-07-16 Thread Kever Yang
Hi WeiZhao, On 2024/5/8 19:16, Weizhao Ouyang wrote: Currently Rockchip's capsule update mechanism only accepts capsules in form of a mmc partition, but a generic capsule update mechanism should be used to satisfy the universal requirements. First of all, the capsule update source code can stay

Re: [PATCH v2 2/5] phy: rockchip: naneng-combphy: Introduce PHY-IDs to fix RK3588 muxing

2024-07-16 Thread Kever Yang
ignal from comb PHY on RK3588") Signed-off-by: Sebastian Kropatsch Reviewed-by: Kever Yang Thanks, - Kever --- .../rockchip/phy-rockchip-naneng-combphy.c| 49 ++- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip

Re: [PATCH 9/9] rockchip: gpio: Add gpio-ranges props

2024-07-16 Thread Kever Yang
is used with get_gpio_mux(). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Cc: Johan Jonker --- arch/arm/dts/rk3036-u-boot.dtsi | 12 arch/arm/dts/rk3066a-u-boot.dtsi | 3 +-- arch/arm/dts/rk3128-u-boot.dtsi | 16 arch/arm/dts

Re: [PATCH 8/9] pinctrl: rockchip: Add pinmux status related ops

2024-07-16 Thread Kever Yang
-a cmd. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- .../pinctrl/rockchip/pinctrl-rockchip-core.c | 50 ++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c b/drivers/pinctrl/

Re: [PATCH 7/9] gpio: rockchip: Use pinctrl pin offset to get_gpio_mux()

2024-07-16 Thread Kever Yang
to 32. However, for gpio0 on RK3288 only 24 pins are used meaning the pinctrl pin offset start at pin 24 for gpio1. Use DIV_ROUND_UP to get the 32 pin aligned bank num. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/gpio/rk_gpio.c | 17 ++--- 1

Re: [PATCH 6/9] gpio: rockchip: Get pinctrl device from gpio-ranges prop

2024-07-16 Thread Kever Yang
On 2024/5/12 20:16, Jonas Karlman wrote: Get pinctrl device from gpio-ranges phandle when the property exists, fallback to get the first pinctrl device. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/gpio/rk_gpio.c | 27 +++ 1

Re: [PATCH 5/9] pinctrl: rockchip: Update get_gpio_mux() ops

2024-07-16 Thread Kever Yang
refer to the same pinctrl pin. Also add verify_config() of banknum and index to avoid an out of range access of the pin_banks array, i.e. with gpio6 on rk3066a. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- The pin_to_mux() helper will be used in the get_pin_muxing

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-07-16 Thread Kever Yang
Hi Alex, Jonas, On 2024/5/23 03:46, Alex Bee wrote: Am 22.05.24 um 18:20 schrieb Jonas Karlman: On 2024-05-22 16:18, Alex Bee wrote: Am 13.05.24 um 01:22 schrieb Jonas Karlman: On 2024-05-13 00:34, Alex Bee wrote: Am 12.05.24 um 23:37 schrieb Jonas Karlman: Hi Alex, On 2024-05-12 21:49,

Re: [PATCH] rockchip: add support for Radxa ROCK Pi E v3.0

2024-07-15 Thread Kever Yang
e.dtb" because v3.0 and prior are compatible. Suggested-by: Jonas Karlman Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- ...dtsi => rk3328-rock-pi-e-base-u-boot.dtsi} | 1 - arch/arm/dts/rk3328-rock-pi-e-u-boot.dtsi | 47 + arch/arm/dts/rk3328-r

Re: [PATCH RFC v2 01/23] rockchip: RK3328: Read the reset cause from clock reset unit for RK3328 SoC

2024-07-15 Thread Kever Yang
Hi Anand, On 2024/5/31 22:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RK3328 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon I thing one signature is enough for you, right? --- arch/arm/include/asm/arch-rockchip/cru.h | 2

Re: [PATCH] phy: rockchip: inno-hdmi: Fix missing readl base addr

2024-07-15 Thread Kever Yang
Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c index 3bb1a254ff..

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-07-15 Thread Kever Yang
website. This product is therefore unmaintained and it would be disingenuous to say the opposite, so drop support for RK3368 Lion. If you're a user of Lion, feel free to revert this patch or contact our sales/support department. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks

Re: [PATCH next 1/2] rockchip: theobroma-systems: migrate git URLs to HTTPS

2024-07-15 Thread Kever Yang
terminal settings, this also makes it possible to open the link from it. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/jaguar_rk3588/MAINTAINERS | 2 +- board/theobroma-systems/puma_rk3399/MAINTAINERS | 2 +- board/theobroma-systems

Re: [PATCH next v2] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

2024-07-15 Thread Kever Yang
it safe and make it 30s so that hopefully all links that should be detected are. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - rebase on next - use Kconfig symbol instead of constant in include/configs/ - Link to v1: https://lore.kernel.org/r

Re: [PATCH v2 2/3] configs: rockchip: sync ENV_MEM_LAYOUT_SETTINGS for rk3308, rk3328, and rk3399

2024-07-15 Thread Kever Yang
On 2024/6/18 17:53, FUKAUMI Naoki wrote: - add support for compressed kernel for rk3308 - prepare support for fdtoverlay for rk3328 tested on ROCK Pi S 256MB, ROCK Pi E 2GB, and ROCK Pi 4A 4GB with linux-next-20240613 defconfig kernel. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang

Re: [PATCH v2 1/3] configs: rockchip: reduce diff for rk3308, rk3328, rk3399, rk3568, and rk3588

2024-07-15 Thread Kever Yang
Naoki Reviewed-by: Kever Yang Thanks, - Kever Changes in v2: - rewrite whole commit message --- include/configs/rk3308_common.h | 26 ++--- include/configs/rk3328_common.h | 28 +++ include/configs/rk3399_common.h | 40

Re: [PATCH] rockchip: include cru_rk3588.h and define rockchip_cru for RK3588

2024-07-15 Thread Kever Yang
_st) { | ~~~^ ./arch/arm/include/asm/arch-rockchip/clock.h:181:8: note: forward declaration of 'struct rockchip_cru' 181 | struct rockchip_cru; |^ 1 error generated. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/cr

Re: [PATCH next 1/4] rockchip: ringneck-px30: disable broken USB gadget

2024-07-15 Thread Kever Yang
Hi Quentin, On 2024/6/14 19:04, Quentin Schulz wrote: From: Quentin Schulz USB gadget simply doesn't work right now on PX30. Tested on PX30 EVB and PX30 Ringneck with Linux mainline and Rockchip 5.10 Linux as well as U-Boot. Do you mean for both U-Boot and kernel, including mainline version

Re: [PATCH next 3/3] rockchip: ringneck-px30: enable IO domain

2024-07-15 Thread Kever Yang
On 2024/6/15 00:54, Quentin Schulz wrote: From: Quentin Schulz Enable the IO domain on Ringneck. Based on the current HW design, this should do nothing else than making sure vccio6 iodomain is controlled by the GRF and not GPIO0B6. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang

Re: [PATCH next 2/3] rockchip: io-domain: add support for PX30

2024-07-15 Thread Kever Yang
state of all supplies that have been configured. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/misc/rockchip-io-domain.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/drivers/misc/rockchip-io-domain.c b

Re: [PATCH next 1/3] rockchip: px30: bind sub-nodes for GRF (syscon)

2024-07-15 Thread Kever Yang
tin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/px30/syscon_px30.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-rockchip/px30/syscon_px30.c b/arch/arm/mach-rockchip/px30/syscon_px30.c index c9de57493d8..893a5234baa 100644 --- a/arch/arm/mach-roc

Re: [PATCH next 3/4] rockchip: px30: imply ARMV8_CRYPTO

2024-07-15 Thread Kever Yang
gister-descriptions/aarch64-system-registers/cpu-extended-control-register--el1?lang=en Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-ro

Re: [PATCH next 4/4] rockchip: puma-rk3399: add button support

2024-07-15 Thread Kever Yang
On 2024/6/14 19:04, Quentin Schulz wrote: From: Quentin Schulz The Haikou Devkit exposes 4 buttons over GPIO so let's enable their support so their status can be queried from the `button` command from the CLI. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH next 2/4] rockchip: ringneck-px30: enable FIT verification in SPL

2024-07-15 Thread Kever Yang
On 2024/6/14 19:04, Quentin Schulz wrote: From: Quentin Schulz This enables FIT verification in SPL for its payload (bl31, u-boot.itb, ...). This makes PX30 Ringneck match what happens on other Theobroma boards. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH RFC v2 22/23] sysreset: rockchip: use fst reset for ARM64 SOC

2024-07-15 Thread Kever Yang
On 2024/6/1 00:44, Jonas Karlman wrote: Hi Anand and Kever, On 2024-05-31 16:18, Anand Moon wrote: From: Kever Yang Rockchip ARM64 SOC will change cpu entry, only fst reset can reset it. What is this trying to fix? And what SoCs is affected? Both fst and snd softreset are available

Re: [PATCH 3/3] rockchip: tiger-rk3588: add PCIe support

2024-07-15 Thread Kever Yang
/dp/B07RZZ3TJG). Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/tiger-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/tiger-rk3588_defconfig b/configs/tiger-rk3588_defconfig index 8fcdd063a3d..8eb1027e449 100644

Re: [PATCH 2/3] rockchip: jaguar-rk3588: add PCIe M.2 M-KEY NVMe support

2024-07-15 Thread Kever Yang
/controllers in the DT, which I'm not too fond of. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/jaguar-rk3588_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/jaguar-rk3588_defconfig b/configs/jaguar-rk3588_defconfig index 36bf34d97c8

Re: [PATCH 1/3] arm64: dts: rockchip: add PCIe3 support on rk3588-jaguar

2024-07-15 Thread Kever Yang
-by: Heiko Stuebner Reviewed-by: Quentin Schulz Link: https://lore.kernel.org/r/20240423074956.2622318-1-he...@sntech.de Signed-off-by: Heiko Stuebner Reviewed-by: Kever Yang Thanks, - Kever [ upstream commit: 0ec7e1096332bc2b9bc881c21cfd234058f747b3 ] (cherry picked from commit

Re: [PATCH 4/4] phy: rockchip: snps-pcie3: Fix clearing PHP_GRF_PCIESEL_CON bits

2024-07-15 Thread Kever Yang
from the upstream Linux commit by Sebastian Reichel: 55491a5fa163 ("phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits") Fixes: 50e54e80679b ("phy: rockchip: snps-pcie3: Add support for RK3588") Signed-off-by: Sebastian Kropatsch Reviewed-by: Kever Ya

Re: [PATCH 3/4] phy: rockchip: snps-pcie3: Fix bifurcation for RK3588

2024-07-15 Thread Kever Yang
: fix bifurcation on rk3588") Fixes: 50e54e80679b ("phy: rockchip: snps-pcie3: Add support for RK3588") Signed-off-by: Sebastian Kropatsch Reviewed-by: Kever Yang Thanks, - Kever --- .../phy/rockchip/phy-rockchip-snps-pcie3.c| 24 +++ 1 file changed, 8 inserti

Re: [PATCH 2/4] phy: rockchip: snps-pcie3: Fix "rockchip" spelling

2024-07-15 Thread Kever Yang
On 2024/7/15 05:23, Sebastian Kropatsch wrote: Several identifiers use "rochchip" instead of "rockchip". Fix this by replacing every instance of "rochchip" with "rockchip". Signed-off-by: Sebastian Kropatsch Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 1/4] phy: rockchip: naneng-combphy: Fix "rockchip" spelling

2024-07-15 Thread Kever Yang
On 2024/7/15 05:23, Sebastian Kropatsch wrote: Replace "rochchip" by "rockchip" in two instances. Signed-off-by: Sebastian Kropatsch Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 4 ++-- 1 file changed, 2 insert

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-21 Thread Kever Yang
Hi Simon, On 2024/6/21 22:57, Simon Glass wrote: Hi Jonas, On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether

Pull request: u-boot-rockchip-next-20240615

2024-06-15 Thread Kever Yang
Hi Tom, Please pull the updates for next on rockchip platform: - New board: Theobroma Systems SOM-RK3588-Q7 Tiger, ArmSoM Sige7 Rk3588; - PX30 dts migrate to OF_UPSTREAM; - Some other update on board or config; CI: https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/pipelines/21113

Pull request: u-boot-rockchip-20240614

2024-06-15 Thread Kever Yang
Hi Tom, Please pull the fixex for rockchip platform: - pmic fix for rk8xx; - pinctrl fix for rk3188/rv1126/rk3588; - mkimage fix for rockcihp "-l" option; CI: https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/pipelines/2 Thanks, - Kever The following changes since commit

Re: [PATCH 2/2] rockchip: puma-rk3399: get closer to other Theobroma defconfigs

2024-06-14 Thread Kever Yang
: - erofs - gpio - squashfs that could be useful and are also found in Jaguar and Tiger defconfigs. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/puma-rk3399_defconfig | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/configs

Re: [PATCH 1/2] rockchip: ringneck-px30: get closer to other Theobroma defconfigs

2024-06-14 Thread Kever Yang
: - boot/bootd - erofs - gpio - iminfo - imxtract - itest - pmic - regulator - sleep - squashfs that could be useful and are also found in Jaguar and Tiger defconfigs. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/ringneck-px30_defconfig | 16

Re: [PATCH next v2 8/8] rockchip: px30/rk3326: migrate to OF_UPSTREAM

2024-06-14 Thread Kever Yang
Black Edition uses this dcdc regulator for WiFi, so let's just move it to the -u-boot.dtsi to play it safe. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 8 - arch/arm/dts/px30-engicam-common.dtsi

Re: [PATCH] rockchip: mkimage: fix mkimage -l for header v1

2024-06-14 Thread Kever Yang
by handling the empty string the same way as for NULL. Without this, the only way to get some information out of mkimage -l is to provide "-n rk3399" for example, which isn't documented in the usage of the tool. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever -

Re: [PATCH 3/9] pinctrl: rockchip: rk3588: Fix support for rockchip_get_mux()

2024-06-14 Thread Kever Yang
Hi Jonas, On 2024/6/7 18:27, Kever Yang wrote: On 2024/5/12 20:16, Jonas Karlman wrote: GPIO IOMUX control is located at PMU2_IOC or BUS_IOC offset on RK3588. Based on Linux commit fdc33eba11c5 ("pinctrl/rockchip: add rk3588 support"). Compared to the Linux commit, this includ

Re: [PATCH next v3 8/8] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-06-14 Thread Kever Yang
compliant JavaCard environment The support is added for Tiger on Haikou devkit, similarly to RK3399 Puma and PX30 Ringneck. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Tested-by: Heiko Stuebner Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi

Re: [PATCH next v3 3/8] arm64: dts: rockchip: correct gpio_pwrctrl1 typos on rk3588(s) boards

2024-06-14 Thread Kever Yang
of these boards (obviously). Please test if it's needed. Signed-off-by: Jing Luo Link: https://lore.kernel.org/r/20240420130355.639406-1-jing@jing.rocks Signed-off-by: Heiko Stuebner Reviewed-by: Kever Yang Thanks, - Kever [ upstream commit: d7f2039e5321636069baa77ef2f1e5d22cb69a88 ] (cherry picked

Re: [PATCH v2 2/2] board: rockchip: Add FriendlyElec NanoPi R6S

2024-06-14 Thread Kever Yang
Kropatsch Reviewed-by: Kever Yang Thanks, - Kever --- The R6S is very similar to the R6C, the major difference being that instead of the M.2 NVMe socket on the R6C, the R6S has a second RTL8125BG Ethernet chip, which uses the same PCIe lanes that the R6C uses for its M.2 socket. Other minor d

Re: [PATCH v2 1/2] board: rockchip: Add FriendlyElec NanoPi R6C

2024-06-14 Thread Kever Yang
: Add support for NanoPi R6C") Signed-off-by: Sebastian Kropatsch Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- Changes v1 -> v2: - Add missing 'S' to 'RK3588S' symbols - Add similar board NanoPi R6S (new patch) - Collect r-b tag from Quentin Schulz for patch 1

Re: [PATCH 0/9] rockchip: pinctrl: Minor fixes and add support for pinmux status cmd

2024-06-07 Thread Kever Yang
Hi Jonas,     Could you spit this patch in two part, one with fixes only, which I can merge it for master directly, and another part for new feature and together with "Add gpio request" for next? Thanks, - Kever On 2024/5/12 20:16, Jonas Karlman wrote: This series includes some minor

Re: [PATCH 4/9] pinctrl: rockchip: Use syscon_regmap_lookup_by_phandle()

2024-06-07 Thread Kever Yang
On 2024/5/12 20:16, Jonas Karlman wrote: Use syscon_regmap_lookup_by_phandle() to simplify the code. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- .../pinctrl/rockchip/pinctrl-rockchip-core.c | 39 ++- 1 file changed, 12 insertions(+), 27

Re: [PATCH 3/9] pinctrl: rockchip: rk3588: Fix support for rockchip_get_mux()

2024-06-07 Thread Kever Yang
correctly. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- The fix to report correct iomux for GPIO0_B4-D7 will be sent to Linux. --- .../pinctrl/rockchip/pinctrl-rockchip-core.c | 24 ++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/9] pinctrl: rockchip: rv1126: Fix support for IOMUX_L_SOURCE_PMU flag

2024-06-07 Thread Kever Yang
("pinctrl: rockchip: Add RV1126 pinctrl support"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/rockch

Re: [PATCH 1/9] pinctrl: rockchip: rk3188: Fix support for IOMUX_GPIO_ONLY flag

2024-06-07 Thread Kever Yang
first half of rk3188-bank0 correctly"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Based on the old Linux commit and TRM it looks like GPIO0_B0-B7 should also be flagged as IOMUX_GPIO_ONLY. --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 2 +- 1 file

Re: [PATCH 3/4] rockchip: rk3568-rock-3a: Drop PCIe reset-gpios workaround

2024-06-07 Thread Kever Yang
Hi Jonas, On 2024/5/11 19:28, Jonas Karlman wrote: The GPIO2_D6 pin is changed to use func-4 using pcie30x2m1_pins during probe of pcie3x2. This cause the device to lock-up when pci driver use the reset-gpios unless the pin is first changed to use gpio pinmux. The reset-gpio for PCIe is for

Re: [PATCH next v2 2/6] rockchip: rk3399-puma: remove default value from defconfig

2024-06-06 Thread Kever Yang
On 2024/6/5 23:56, Quentin Schulz wrote: From: Quentin Schulz CONFIG_ENV_OFFSET already defaults to 0x3F8000, however it is stored in lowercase hexdigits instead of uppercase like in the defconfig. No change in behavior intended. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang

Re: [PATCH next v2 3/6] rockchip: rk3399-puma: remove unnecessary simple-bin:fit:offset override

2024-06-06 Thread Kever Yang
-boot.dtsi is SPL_PAD_TO, so let's remove this override. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi b/arch/arm/

Re: [PATCH next v2 4/6] rockchip: px30-ringneck: Update SPL_PAD_TO Kconfig option

2024-06-06 Thread Kever Yang
-bin:fit:offset since SPL_PAD_TO matches with the current formula. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/px30-ringneck-haikou-u-boot.dtsi | 8 configs/ringneck-px30_defconfig | 2 +- 2 files changed, 1 insertion(+), 9 deletions

Re: [PATCH next v2 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-06 Thread Kever Yang
(RK3399 Puma) and RK809 (PX30 Ringneck). Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/pmic/rk8xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c index 12ff26a0855

Re: [PATCH next v2 6/6] rockchip: ringneck-px30: fix TPL_MAX_SIZE

2024-06-06 Thread Kever Yang
is actually checked and useful. Fixes: c925be73a0a8 ("rockchip: add support for PX30 Ringneck SoM on Haikou Devkit") Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/ringneck-px30_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/config

Re: [PATCH next v2 1/6] rockchip: jaguar-rk3588: use default env size for Rockchip on MMC

2024-06-06 Thread Kever Yang
. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/jaguar-rk3588_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/jaguar-rk3588_defconfig b/configs/jaguar-rk3588_defconfig index b69cf4cd057..36bf34d97c8 100644 --- a/configs/jaguar

Re: [PATCH v4 10/10] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-06-06 Thread Kever Yang
Type-C Size: 92mm x 62mm Kernel commit: 81c828a67c78 (arm64: dts: rockchip: Add ArmSom Sige7 board) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v4: - Pick all commits of rk3588s.dtsi and rk3588.dtsi from v6.10-rc1-dts - Remove obsolete USB3 DRD nodes

Re: [PATCH v4 09/10] rockchip: rk3588: Remove USB3 DRD nodes in u-boot.dtsi

2024-06-06 Thread Kever Yang
On 2024/5/29 01:04, Jianfeng Liu wrote: After we sync USB3 DRD nodes from v6.10-rc1, these obsolete nodes can be removed. Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) arch/arm/dts/rk3588-u-boot.dtsi | 74

Re: [PATCH v4 08/10] arm64: dts: rockchip: Add ArmSom Sige7 board

2024-06-06 Thread Kever Yang
://lore.kernel.org/r/20240420034300.176920-4-liujianfeng1...@gmail.com Signed-off-by: Heiko Stuebner [ upstream commit: 81c828a67c78bb03ea75819c417c93c7f3d637b5 ] (cherry picked from commit d427a11542bcf5364a5260280e077f0a2e030dcb) Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1

Re: [PATCH v4 07/10] arm64: dts: rockchip: add rk3588 pcie and php IOMMUs

2024-06-06 Thread Kever Yang
commit: cd81d3a0695cc54ad6ac0ef4bbb67a7c8f55d592 ] (cherry picked from commit ea9a34aa0d786cbf4b87f1ba528e69b07219738f) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip/rk3588s.dtsi | 24 1

Re: [PATCH v4 06/10] arm64: dts: rockchip: add USB3 DRD controllers on rk3588

2024-06-06 Thread Kever Yang
commit: 33f393a2a990e16f56931ca708295f31d2b44415 ] (cherry picked from commit c7ed588e14f7dd04a92fb55f12680f94c7b14edf) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip/rk3588.dtsi | 20 ++ dts

Re: [PATCH v4 05/10] arm64: dts: rockchip: add USBDP phys on rk3588

2024-06-06 Thread Kever Yang
: e18e5e8188f2671abf63abe7db5f21555705130f ] (cherry picked from commit 5110caca9865718616cf7093ed4a9a1bc54780db) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip/rk3588.dtsi | 52 dts/upstream/src

Re: [PATCH v4 04/10] arm64: dts: rockchip: reorder usb2phy properties for rk3588

2024-06-06 Thread Kever Yang
-by: Heiko Stuebner [ upstream commit: abe68e0ca71dddce0e5419e35507cb464d61870d ] (cherry picked from commit f6835a60a8a28ff14ffb3dd80c99ce1c137d06c5) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip/rk3588s.dtsi

Re: [PATCH v4 03/10] arm64: dts: rockchip: fix usb2phy nodename for rk3588

2024-06-06 Thread Kever Yang
-by: Heiko Stuebner [ upstream commit: 4e07a95f7402de092cd71b2cb96c69f85c98f251 ] (cherry picked from commit 5a3e4638492497ae81b9bd4a8627f4727e312ccc) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip

Re: [PATCH v4 01/10] arm64: dts: rockchip: Add rk3588 GPU node

2024-06-06 Thread Kever Yang
Signed-off-by: Heiko Stuebner [ upstream commit: 6fca4edb93d335f29f81e484936f38a5eed6a9b1 ] (cherry picked from commit 3cd15354ea0c8668812bc0b3a4136606c10803e9) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream/src/arm64/rockchip

Re: [PATCH v4 02/10] arm64: dts: rockchip: Fix ordering of nodes on rk3588s

2024-06-06 Thread Kever Yang
-didi.deb...@cknow.org Signed-off-by: Heiko Stuebner [ upstream commit: cbb97fe18e299ece1c0074924c630de6a19b320f ] (cherry picked from commit bbf7c16f2f1208b96349f6f6648b69cfaa1a482b) Signed-off-by: Jianfeng Liu Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) dts/upstream

Re: [PATCH 3/3] regulator: rk8xx: clarify operator precedence

2024-06-06 Thread Kever Yang
On 2024/6/5 17:33, Quentin Schulz wrote: From: Quentin Schulz My linter complains that the order isn't clear enough so let's put parentheses around the ternary condition to make it happy. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power

Re: [PATCH 2/3] regulator: rk8xx: pass pmic udevice instead of regulator to all internal functions

2024-06-06 Thread Kever Yang
On 2024/6/5 17:33, Quentin Schulz wrote: From: Quentin Schulz For the sake of consistency, make all internal (starting with _) functions expect a pmic udevice instead of a regulator udevice. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power

Re: [PATCH 1/3] regulator: rk8xx: fix incorrect device used for _ldo_[sg]et_suspend_value

2024-06-06 Thread Kever Yang
. To avoid further confusion, let's rename the argument to pmic instead of dev, highlighting which kind of device we expect as argument. Fixes: f047e4ab9762 ("regulator: rk8xx: add indirection level for some ldo callbacks") Reported-by: Simon Glass Signed-off-by: Quentin Schulz Reviewed-by:

Pull request: u-boot-rockchip-20240525

2024-05-24 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - new board: rk3566 Powkiddy X55, rk3588s Indiedroid Nova; - rv1126 migrate to OF_UPSTREAM; - Fix for px30 ringneck board; - Fix for rk3588 SPLL clock init; CI: https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/pipelines/20844

Re: [PATCH V4] board: rockchip: Add Indiedroid Nova

2024-05-24 Thread Kever Yang
56mm (Raspberry Pi Form Factor) Kernel commit: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board") Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- Changes since V3: - Corrected another typo in the MAINTAINERS file. I think I got them all

Re: [PATCH V3] board: rockchip: Add Indiedroid Nova

2024-05-24 Thread Kever Yang
Hi Tom,     This new boards has MAINTAINERS file, but the CI reports: WARNING: no maintainers for 'nova-rk3588s' Could you give advice for this? Thanks, - Kever On 2024/5/21 23:33, Chris Morgan wrote: From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid.

Re: [PATCH 09/10] rockchip: evb-px30: do not remove pinctrl nodes from SPL DTB

2024-05-22 Thread Kever Yang
On 2024/5/22 01:40, Quentin Schulz wrote: From: Quentin Schulz In order to be able to properly mux UART on PX30 EVB, the pinmux needs to be done at runtime, so let's not remove the pinctrl nodes from the SPL DTB. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 10/10] rockchip: evb-px30: make UART5 the debug UART

2024-05-22 Thread Kever Yang
On 2024/5/22 01:40, Quentin Schulz wrote: From: Quentin Schulz In the Device Tree, UART5 is the system UART, but in the defconfig it currently is UART2. Let's sync the two by making the defconfig use UART5 as well. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 08/10] rockchip: px30: make UART pinmux accessible to TPL/SPL DTB

2024-05-22 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/px30-u-boot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/px30-u-boot.dtsi b/arch/arm/dts/px30-u-boot.dtsi index 046da022ffe..59fa9f43a97 100644 --- a/arch/arm/dts/px30-u-boot.dtsi +++ b/arch

Re: [PATCH 07/10] rockchip: px30-core-*: Use common bss and stack addresses

2024-05-22 Thread Kever Yang
-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/px30-core-ctouch2-of10-px30_defconfig | 18 +++--- configs/px30-core-ctouch2-px30_defconfig | 18 +++--- configs/px30-core-edimm2.2-px30_defconfig | 18 +++--- 3 files

Re: [PATCH 06/10] rockchip: odroid-go2: Use common bss and stack addresses

2024-05-22 Thread Kever Yang
-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/odroid-go2_defconfig | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig index 3c1abb83ed9..f4c9b02e12f 100644

Re: [PATCH 04/10] rockchip: evb-px30: Use common bss and stack addresses

2024-05-22 Thread Kever Yang
-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-px30_defconfig | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/configs/evb-px30_defconfig b/configs/evb-px30_defconfig index 73a3c6120e0..50ce1d7a9f3 100644 --- a/configs

Re: [PATCH 03/10] rockchip: ringneck_px30: Use common bss and stack addresses

2024-05-22 Thread Kever Yang
-reloc allocation pool (8 times bigger now). The memory layout in SPL and U-Boot proper now match the other SoCs' using ROCKCHIP_COMMON_STACK_ADDR. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/ringneck-px30_defconfig | 18 +++--- 1 file

Re: [PATCH 05/10] rockchip: firefly-px30: Use common bss and stack addresses

2024-05-22 Thread Kever Yang
-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/firefly-px30_defconfig | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/configs/firefly-px30_defconfig b/configs/firefly-px30_defconfig index 0a14b393667..063e4211fb7 100644

Re: [PATCH 02/10] rockchip: Use common bss and stack addresses on PX30

2024-05-22 Thread Kever Yang
ays a nice thing. Additionally, this will make it easier to fix U-Boot proper pre-reloc running out of memory on PX30 in a subsequent commit. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/px30/Kconfig | 5 - 1 file changed, 4 insertions(+),

Re: [PATCH 01/10] rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level

2024-05-22 Thread Kever Yang
to. Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/px30/Kconfig | 3 +++ configs/evb-px30_defconfig| 1 - configs/firefly-px30_defconfig| 1 - configs/odroid-go2_defconfig | 1

Re: [PATCH 1/2 V2] Revert "board: rockchip: Add early ADC button detect for RGxx3"

2024-05-22 Thread Kever Yang
On 2024/5/21 23:45, Chris Morgan wrote: From: Chris Morgan This reverts commit 41a60d0e5cef54a59596a58940fa7c9cf071034b. On some of the supported devices the adc detect code always returns that the button has been pushed, and as a result the device will not boot normally. Have you check

Re: [PATCH 2/2 V2] board: rockchip: rgxx3: Use sdmmc0 as first device

2024-05-22 Thread Kever Yang
present with a valid fit signature. The expectation is that this will protect from the very unlikely chance we have a valid FIT signature on the eMMC but the U-Boot stage fails for some other reason. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566

Re: [PATCH 1/2 V2] Revert "board: rockchip: Add early ADC button detect for RGxx3"

2024-05-22 Thread Kever Yang
-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c | 64 -- 1 file changed, 64 deletions(-) diff --git a/board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c b/board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c index 099eea60c3..5c57b902d1

Re: [PATCH v2] clk: rockchip: rk3588: Set SPLL frequency during SPL stage

2024-05-22 Thread Kever Yang
588-rock5b and rk3588-tiger by reading back the PLL rate and also observing working DSI output with this change. Fixes: 6737771600d4 ("rockchip: rk3588: Add support for sdmmc clocks in SPL") Suggested-by: Andy Yan Signed-off-by: Heiko Stuebner Cc: Jonas Karlman Cc: Quentin Schulz Rev

Re: [PATCH V3] board: rockchip: Add Indiedroid Nova

2024-05-22 Thread Kever Yang
56mm (Raspberry Pi Form Factor) Kernel commit: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board") Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- Changes since V2: - Corrected typo in the MAINTAINERS file. - Removed OF_UPSTREAM since

Re: [PATCH V4] board: rockchip: add Powkiddy X55

2024-05-22 Thread Kever Yang
kiddy X55") Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- Changes since V3: - Removed sdmmc1 from the SPL-> U-Boot path, as long as we have sdmmc0 we should be okay with recovery options. - Removed OF_UPSTREAM since that's now set across the board f

Re: [PATCH v2] rockchip: rv1126: Migrate to OF_UPSTREAM

2024-05-11 Thread Kever Yang
designed to provide a Smart Home Hub. Cc: Tim Lunn Cc: Jagan Teki Signed-off-by: Anand Moon Reviewed-by: Kever Yang Thanks, - Kever --- v2: remove the dt-bindings for clock and power fix the typo in commit message Tested on neu2 board. --- arch/arm/dts/Makefile

Re: [PATCH 41/81] misc: Remove and add needed includes

2024-05-09 Thread Kever Yang
On 2024/5/2 09:30, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Reviewed-by: Kever Yang Thanks, - Kever --- Cc: Tom Rini Cc: Simon Glass Cc: Sean Anderson Cc: Eugen Hristev Cc: Mario Six Cc: Philipp

Re: [PATCH] rockchip: rv1108: Remove unneeded local rv1108-cru.h

2024-05-09 Thread Kever Yang
-by: Jonas Karlman Signed-off-by: Fabio Estevam Reviewed-by: Kever Yang Thanks, - Kever --- include/dt-bindings/clock/rv1108-cru.h | 356 - 1 file changed, 356 deletions(-) delete mode 100644 include/dt-bindings/clock/rv1108-cru.h diff --git a/include/dt-bindings/clock

Re: [PATCH 74/81] video: Remove and add needed includes

2024-05-09 Thread Kever Yang
On 2024/5/2 09:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Reviewed-by: Kever Yang Thanks, - Kever --- Cc: Anatolij Gustschin Cc: Tom Rini Cc: Matthias Brugger Cc: Peter Robinson Cc: Liviu Dudau

  1   2   3   4   5   6   7   8   9   10   >