Re: [PATCH 33/40] drivers: spi: Remove duplicate newlines

2024-07-22 Thread Michal Simek
xdr; /* 0x20 */ }; - /* zynq spi platform data */ struct zynq_spi_plat { struct zynq_spi_regs *regs; Reviewed-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Micr

Re: [PATCH 12/40] drivers: fpga: Remove duplicate newlines

2024-07-22 Thread Michal Simek
rn ret_val; } - /* - */ static int spartan3_ss_load(xilinx_desc *desc, const void *buf, size_t bsize) Reviewed-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xili

Re: [PATCH 24/37] board: opalkelly: Remove duplicate newlines

2024-07-22 Thread Michal Simek
ps7_post_config(void) { return ps7_config(ps7_post_config_3_0); Reviewed-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq

Re: [PATCH 37/37] board: xilinx: Remove duplicate newlines

2024-07-22 Thread Michal Simek
unsigned long *ps7_mio_init_data = ps7_mio_init_data_3_0; Reviewed-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and

[PATCH] arm64: zynqmp: dts: Add rts delay property for rs485 mode on KD240

2024-07-18 Thread Michal Simek
fe minimum value for reliable operation at a baud rate of 9600. Signed-off-by: Manikanta Guntupalli Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sck-kd-g-revA.dtso | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/zynqmp-sck-kd-g-revA.dtso b/arch/arm/dts/zynqmp-sck-kd-g

Re: [v2] zlib: Fix big performance regression

2024-07-17 Thread Michal Simek
by: Christophe Leroy --- Given that in master we now have Michal's series un-reverted, I have collapsed Christophe's series down to a patch that is just fixing the performance issues, while not regressing other platforms. Cc: Michal Simek --- lib/zlib/inffast.c | 51 -

[PATCH] efi_loader: Fix typo in EFI_RT_VOLATILE_STORE description

2024-07-16 Thread Michal Simek
Fix typo in EFI_RT_VOLATILE_STORE description. Fixes: c28d32f946f0 ("efi_loader: conditionally enable SetvariableRT") Signed-off-by: Michal Simek --- lib/efi_loader/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kco

[PATCH] arm64: xilinx: Describe TPM reset for Kria CCs

2024-07-16 Thread Michal Simek
Describe carrier card TPM reset behavior and show message about it on boot console to let users know what to expect from it. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp_kria.env | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/board/xilinx/zynqmp

Re: [PATCH 33/45] microblaze: Remove duplicate newlines

2024-07-16 Thread Michal Simek
4 > > diff --git a/arch/microblaze/include/asm/system.h > b/arch/microblaze/include/asm/system.h > index 050a8b40763..4e31206436d 100644 > --- a/arch/microblaze/include/asm/system.h > +++ b/arch/microblaze/include/asm/system.h > @@ -40,7 +40,6 @@ extern void *switch_thread (struct thread_stru

[PATCH] arm64: versal: Remove undocumented cadence,qspi compatible

2024-07-15 Thread Michal Simek
Compatible string is not the part of dt-schema and also not used by U-Boot or Linux that's why remove it completely. Signed-off-by: Michal Simek --- arch/arm/dts/versal-mini-ospi.dtsi | 2 +- arch/arm/dts/versal-net-mini-ospi.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH] arm64: versal-net: Align node names with dt-schema

2024-07-15 Thread Michal Simek
dt-schema is forcing some rules for node names that's why align them with it. Labels are not changing that's why this change is not breaking any other board specific DTSes. Signed-off-by: Michal Simek --- arch/arm/dts/versal-net-mini-emmc.dts | 4 ++-- arch/arm/dts/versal-net-mini-ospi.dtsi

[PATCH] arm64: zynqmp: Add resets property for UART nodes

2024-07-15 Thread Michal Simek
From: Manikanta Guntupalli Add resets property for UART0 and UART1 nodes Signed-off-by: Manikanta Guntupalli Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi index 34f592c1a85f

Re: [PATCH 0/7] Add the USB5744 hub driver as per new DT binding

2024-07-15 Thread Michal Simek
-) > > -- > 2.17.1 > Can someone please take a look at this patchset? I am fine with 6/7 and 7/7. Acked-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze

Re: [PATCH v2] amd: Enable the NFS command for Versal Gen 2

2024-07-12 Thread Michal Simek
On 7/11/24 18:57, Prasad Kummari wrote: Enabled the default utilization of the NFS command on Versal Gen 2 platform to facilitate booting images through the network using the NFS protocol Signed-off-by: Prasad Kummari --- Changes in v2: - corrected commit description.

Re: [PATCH] config: Enable the config CONFIG_MMC_SPEED_MODE_SET

2024-07-11 Thread Michal Simek
On 7/8/24 11:17, Venkatesh Yadav Abbarapu wrote: Enable setting speed mode using mmc dev commands. The speed mode is provided as the last argument in these commands (ex: mmc dev 0 0 10) and is indicated using the index from enum bus_mode in include/mmc.h. A speed mode can be set if it is

Re: [PATCH 0/4] Add mini configuration support for versal2

2024-07-11 Thread Michal Simek
On 6/19/24 09:17, Venkatesh Yadav Abbarapu wrote: Adding the basic mini u-boot configuration changes for qspi, ospi and emmc. Branch:next Venkatesh Yadav Abbarapu (4): arm64: versal2: Add support for mini configuration arm64: Add versal2 mini qspi support arm64: Add versal2 mini

Re: [PATCH 0/2] env_spi: support overriding spi dev from board code

2024-07-11 Thread Michal Simek
On 6/14/24 14:48, Venkatesh Yadav Abbarapu wrote: This enables boards to choose where to/from the environment should be saved/loaded either QSPI or OSPI based on the bootmode. Venkatesh Yadav Abbarapu (2): env_spi: support overriding spi dev from board code xilinx: versal-net: Handle

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-07-11 Thread Michal Simek
On 6/17/24 06:18, Prasad Kummari wrote: Add support for ISSI 128MB flash IS25LP01GG. This part supports 4byte opcodes. It also supports dual and quad read. Signed-off-by: Prasad Kummari --- drivers/mtd/spi/spi-nor-ids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] arm64: versal2: Remove UARTLITE from defconfig

2024-07-11 Thread Michal Simek
On 6/18/24 15:20, Michal Simek wrote: UARTLITE can be used as console but none is testing it that's why removing it not to pop up there. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs

Re: [PATCH] clk: zynqmp: Add set_rate support for display clocks

2024-07-11 Thread Michal Simek
On 7/11/24 10:29, Venkatesh Yadav Abbarapu wrote: If "assigned-clock-rates" property is included in the device tree, display driver probe is getting failed, as dp_video_ref till dp_stc_ref clocks are missing from set rate function, adding them to fix the probe failure. Signed-off-by:

Re: [PATCH] amd: Enable the NFS command for Versal2

2024-07-11 Thread Michal Simek
please use official Versal Gen 2 On 7/9/24 13:51, Prasad Kummari wrote: Enabled the default utilization of the NFS command on Versal2 Versal Gen 2 Thanks, Michal

Re: [PATCH] xilinx: Enable the NFS command for zynqmp_kria

2024-07-09 Thread Michal Simek
On 7/9/24 06:22, Prasad Kummari wrote: Enabled the default utilization of the NFS command on ZynqMP Kria platforms to facilitate booting images through the network using the NFS protocol. Signed-off-by: Prasad Kummari --- configs/xilinx_zynqmp_kria_defconfig | 1 + 1 file changed, 1

Re: Warnings with xilinx_zynqmp_virt

2024-07-08 Thread Michal Simek
Hi Simon, On 7/2/24 17:51, Simon Glass wrote: Hi Michal, I am seeing errors when building xilinx_zynqmp_virt: Can't set hash 'value' property for 'hash' node(FDT_ERR_NOSPACE) Can't set hash value for 'hash' hash node in 'fdt_35' image node Can't add verification data for node 'fdt_35' () The

Re: [PATCH] Revert "zlib: Port fix for CVE-2016-9841 to U-Boot"

2024-07-08 Thread Michal Simek
On 6/27/24 17:49, Tom Rini wrote: In commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") Michal brings in (correctly) the upstream fix for CVE-2016-9841. However, when upstream was fixing this issue they also removed a necessary optimization for some CPU classes as part of

Re: [PATCH v7 3/4] use fdt_kaslrseed function to de-duplicate code

2024-06-20 Thread Michal Simek
of the kernel). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Reviewed-by: Simon Glass Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass

Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-06-20 Thread Michal Simek
Hi, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform specific

Re: [PATCH] cmd: Make use of U_BOOT_LONGHELP when missing

2024-06-19 Thread Michal Simek
diff --git a/cmd/scmi.c b/cmd/scmi.c > index 664062c4eff5..cfbca63e1644 100644 > --- a/cmd/scmi.c > +++ b/cmd/scmi.c > @@ -369,7 +369,7 @@ static int do_scmi(struct cmd_tbl *cmdtp, int flag, > return cp->cmd(cmdtp, flag, argc, argv); > } > > -static char scmi_hel

Re: [PATCH] amd: versal2: Use U_BOOT_LONGHELP macro

2024-06-18 Thread Michal Simek
On 6/18/24 16:18, Tom Rini wrote: On Tue, Jun 18, 2024 at 03:16:38PM +0200, Michal Simek wrote: It is defined as __maybe_unused variable which fix issue when long help is disabled. Signed-off-by: Michal Simek --- board/amd/versal2/cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH] arm64: versal2: Remove UARTLITE from defconfig

2024-06-18 Thread Michal Simek
UARTLITE can be used as console but none is testing it that's why removing it not to pop up there. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/amd_versal2_virt_defconfig b/configs/amd_versal2_virt_defconfig

[PATCH] amd: versal2: Use U_BOOT_LONGHELP macro

2024-06-18 Thread Michal Simek
It is defined as __maybe_unused variable which fix issue when long help is disabled. Signed-off-by: Michal Simek --- board/amd/versal2/cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/board/amd/versal2/cmds.c b/board/amd/versal2/cmds.c index fbd99918a7f4

[GIT PULL] xilinx patches for v2024.10-rc1

2024-06-17 Thread Michal Simek
init function arm64: zynq(mp): Rename spl_board_init() to spl_soc_init() xilinx: zynqmp: Enable reset_cpu() in SPL Michal Simek (11): xilinx: zynqmp: Clean up xilinx_zynqmp.h xilinx: Enable NVMEM framework for all platforms arm64: zynqmp: Update rproc node arm64

Re: [PATCH] xilinx: Enable NVMEM framework for all platforms

2024-06-17 Thread Michal Simek
čt 11. 4. 2024 v 8:04 odesílatel Michal Simek napsal: > > Boards which have for example MAC address in eeprom but not in Xilinx > format (legacy or FRU) could reference it via nvmem cells. > For example: > > { > nvmem-cells = <>; > n

Re: [PATCH] xilinx: Enable FF-A for all our arm64 SoCs

2024-06-17 Thread Michal Simek
út 11. 6. 2024 v 13:07 odesílatel Michal Simek napsal: > > Enable FFA_TRANSPORT which also enable FFA command. > > Signed-off-by: Michal Simek > --- > > configs/amd_versal2_virt_defconfig | 1 + > configs/xilinx_versal_net_virt_defconfig | 1 + > configs/x

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-17 Thread Michal Simek
On 6/17/24 15:31, Dragan Simic wrote: Hello Michal, On 2024-06-17 15:26, Michal Simek wrote: On 6/17/24 08:28, Dhruva Gole wrote: On Jun 17, 2024 at 09:48:42 +0530, Prasad Kummari wrote: Add support for ISSI 128MB flash IS25LP01GG. This part Can we have the datasheet link for this part

Re: [PATCH] xilinx: versal-net: Add env redund offset

2024-06-17 Thread Michal Simek
On 6/14/24 14:51, Venkatesh Yadav Abbarapu wrote: ENV_OFFSET_REDUND config is by default set to 0 for flashes. Saving the env variables is overwriting data at 0 offset, which is wrong. So add default redund env offset ENV_OFFSET_REDUND at 0x7F0 for Versal NET platform. Signed-off-by:

Re: [PATCH] gpio: Add proper dependency on ZYNQMP_FIRMWARE

2024-06-17 Thread Michal Simek
On 6/6/24 16:44, Michal Simek wrote: ZYNQMP_FIRMWARE can be disabled and driver depends on it that's why record this dependency via Kconfig. Signed-off-by: Michal Simek --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b

Re: [PATCH] arm64: zynqmp: Align #address/size-cells with node

2024-06-17 Thread Michal Simek
On 6/6/24 16:35, Michal Simek wrote: zynqmp-mini-nand wasn't aligned with dt binding that's why fix it. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-mini-nand.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/zynqmp-mini-nand.dts b/arch/arm

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-17 Thread Michal Simek
On 6/17/24 08:28, Dhruva Gole wrote: On Jun 17, 2024 at 09:48:42 +0530, Prasad Kummari wrote: Add support for ISSI 128MB flash IS25LP01GG. This part Can we have the datasheet link for this part? I am assuming it's this? https://www.issi.com/WW/pdf/25LP-WP01GG.pdf Problem with links is

Re: [PATCH v2 0/1] xilinx: Add option to load environment from outside of

2024-06-14 Thread Michal Simek
On 6/12/24 17:49, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 17:32 +0200, Michal Simek wrote: On 6/12/24 17:11, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 16:47 +0200, Michal Simek wrote: On 6/12/24 15:57, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 15:42 +0200

Re: [PATCH v2 0/1] xilinx: Add option to load environment from outside of

2024-06-12 Thread Michal Simek
On 6/12/24 17:11, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 16:47 +0200, Michal Simek wrote: On 6/12/24 15:57, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 15:42 +0200, Michal Simek wrote: Hi Vasileios, út 4. 6. 2024 v 15:21 odesílatel Vasileios Amoiridis napsal: From

Re: [PATCH v2 0/1] xilinx: Add option to load environment from outside of

2024-06-12 Thread Michal Simek
On 6/12/24 15:57, Vasileios Amoiridis wrote: On Wed, 2024-06-12 at 15:42 +0200, Michal Simek wrote: Hi Vasileios, út 4. 6. 2024 v 15:21 odesílatel Vasileios Amoiridis napsal: From: Vasileios Amoiridis Changes in v2:     - Remove duplication of custom hardcoded env_locations[] code

Re: [PATCH v2 0/1] xilinx: Add option to load environment from outside of

2024-06-12 Thread Michal Simek
T. There is options/u-boot node where location of variables should be described and this should replace env_get_location(). It is a lot of work that's why I think second solution is more reasonable for you which is simply create new Kconfig symbol to disable board env_get_location() implementation.

Re: [PATCH 0/4] arm64: versal2: Add support for new AMD Versal Gen 2 SoC

2024-06-11 Thread Michal Simek
On 5/29/24 16:47, Michal Simek wrote: Hi, I am sending patches for adding initial support for new AMD Versal Gen 2 SoC. If you want to find out more information please take a look at this page: https://www.amd.com/en/products/adaptive-socs-and-fpgas/versal.html Thanks, Michal Michal Simek

[PATCH] xilinx: Enable FF-A for all our arm64 SoCs

2024-06-11 Thread Michal Simek
Enable FFA_TRANSPORT which also enable FFA command. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 1 + configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + configs

Re: [PATCH v3 0/1] Enable reset_cpu() in SPL for ZynqMP

2024-06-11 Thread Michal Simek
On 6/7/24 11:26, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series enables the CPU reset in the SPL for ZynqMP based platforms. This only works if CONFIG_SYSRESET is disabled. This is usually the case since the the regular sysreset requires bl31 firmware to be loaded in

Re: [PATCH v3 1/1] arm64: zynqmp: Enable usb3 for k24 som

2024-06-11 Thread Michal Simek
On 6/4/24 10:38, Neal Frager wrote: This patch corrects the mio and pll configuration registers for using usb3 on the kd240 starter kit. Without this patch, the usb3 to sd card bridge does not initialize correctly and u-boot is unable to find the OS located on the kd240 starter kit sd card.

Re: [PATCH] arm64: zynqmp: Setup multiboot register to 0

2024-06-11 Thread Michal Simek
On 6/3/24 15:09, Michal Simek wrote: On Kria when board starts from Image A or Image B partition multiboot register is already setup to that location. When reset command is called board is issuing soft reset which start SW at already used location (offset of multiboot * 32k). But board should

Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-06-07 Thread Michal Simek
On 5/24/24 12:07, Ilias Apalodimas wrote: Hi Michal On Fri, 24 May 2024 at 12:45, Michal Simek wrote: Hi Ilias, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information

Re: [PATCH 1/3] xilinx: Enable SMBIOS command

2024-06-07 Thread Michal Simek
On 4/26/24 15:38, Michal Simek wrote: It is good to be aware what information is shared via smbios interface that's why enable it by default. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs

Re: [PATCH] arm64: zynqmp: Update rproc node

2024-06-07 Thread Michal Simek
On 5/30/24 12:39, Michal Simek wrote: remoteproc node should be updated to be aligned with the latest dt-schema. Signed-off-by: Michal Simek --- Once we push all dts to Linux we can change to OF_UPSTREAM but till that time we need to keep DTSes in sync. --- arch/arm/dts/zynqmp.dtsi

Re: [PATCH v2 1/1] xilinx: zynqmp: Enable reset_cpu() in SPL

2024-06-06 Thread Michal Simek
On 6/4/24 15:59, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This commit enables SPL to reset the CPU via PMU-firmware. The usual reset mechanism requires bl31 to be loaded which may not be the case in SPL. Signed-off-by: Lukas Funke --- Changes in v2: - Drop 2/2 since

[PATCH] gpio: Add proper dependency on ZYNQMP_FIRMWARE

2024-06-06 Thread Michal Simek
ZYNQMP_FIRMWARE can be disabled and driver depends on it that's why record this dependency via Kconfig. Signed-off-by: Michal Simek --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index b050585389bb

[PATCH] arm64: zynqmp: Align #address/size-cells with node

2024-06-06 Thread Michal Simek
zynqmp-mini-nand wasn't aligned with dt binding that's why fix it. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-mini-nand.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/zynqmp-mini-nand.dts b/arch/arm/dts/zynqmp-mini-nand.dts index 5889d436edb8

Re: [PATCH v3 7/7] drivers: misc: Add driver to access ZynqMP efuses

2024-06-06 Thread Michal Simek
(CONFIG_ZYNQMP_EFUSE) += zynqmp_efuse.o diff --git a/drivers/misc/zynqmp_efuse.c b/drivers/misc/zynqmp_efuse.c new file mode 100644 index 000..d12de7494d2 --- /dev/null +++ b/drivers/misc/zynqmp_efuse.c @@ -0,0 +1,360 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * (C) Copyright 2014 - 2015 Xil

Re: [PATCH v3 5/7] soc: xilinx: zynqmp: Use zynqmp_pm_get_chipid() to get chip revision

2024-06-06 Thread Michal Simek
ode, - idcode2); + u32 idcode2 = version >> ZYNQMP_CSU_VERSION_EMPTY_SHIFT; + + dev_dbg(dev, "IDCODE: 0x%0x, IDCODE2: 0x%0x\n", idcode, idcode2); ret = soc_xilinx_zynqmp_detect_machine(dev, idcode, idcode2); if (r

Re: [PATCH v3 4/7] soc: xilinx: versal-net: Use zynqmp_pm_get_chipid() to get chip revision

2024-06-06 Thread Michal Simek
load[2]); + priv->revision = FIELD_GET(PS_VERSION_MASK, version); return 0; } Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v3 6/7] firmware: zynqmp: Add support to access efuses

2024-06-06 Thread Michal Simek
int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id); int zynqmp_mmio_read(const u32 address, u32 *value); int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value); Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v3 3/7] soc: xilinx: versal: Use zynqmp_pm_get_chipid() to get chip revision

2024-06-06 Thread Michal Simek
On 6/4/24 16:27, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Use common zynqmp_pm_get_chipid() function to get the chip revision Signed-off-by: Lukas Funke --- (no changes since v1) drivers/soc/soc_xilinx_versal.c | 13 ++--- 1 file changed, 6 insertions(+), 7

Re: [PATCH v3 2/7] configs: zynqmp_virt: Enable CMD_FUSE and ZYNQMP_EFUSE

2024-06-06 Thread Michal Simek
On 6/4/24 16:27, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Enable CMD_FUSE and ZYNQMP_EFUSE in order to be able to write ZyqnMP eFuses from within the bootloader. Signed-off-by: Lukas Funke --- (no changes since v1) configs/xilinx_zynqmp_kria_defconfig | 2 ++ 1 file

Re: [PATCH v3 1/7] configs: zynqmp_kria: Enable CMD_FUSE and ZYNQMP_EFUSE

2024-06-06 Thread Michal Simek
On 6/4/24 16:27, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Enable CMD_FUSE and ZYNQMP_EFUSE in order to be able to write ZyqnMP eFuses from within the bootloader for Kria SoM. Signed-off-by: Lukas Funke --- (no changes since v1) configs/xilinx_zynqmp_virt_defconfig | 2

Re: [PATCH v2 0/1] xilinx: Add option to load environment from outside of

2024-06-06 Thread Michal Simek
On 6/3/24 18:47, Vasileios Amoiridis wrote: From: Vasileios Amoiridis Changes in v2: - Remove duplication of custom hardcoded env_locations[] code. - Add implementation with general arch_env_get_location(op, prio) v1:

Re: [PATCH 7/7] arm64: zynqmp: Update the usb5744 hub node as per binding

2024-06-06 Thread Michal Simek
On 6/5/24 12:02, Venkatesh Yadav Abbarapu wrote: Updating the usb5744 hub node as per the latest upstream DT binding https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ tree/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml?h=v6.8.8 Signed-off-by: Venkatesh Yadav

Re: [PATCH] cmd: fwu: Also print information about size

2024-06-06 Thread Michal Simek
On 6/5/24 17:09, Ilias Apalodimas wrote: On Wed, 5 Jun 2024 at 17:58, Michal Simek wrote: It is useful when structure is also used for saving vendor data covered by CRC32. Signed-off-by: Michal Simek --- cmd/fwu_mdata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd

[PATCH v2] cmd: fwu: Also print information about size

2024-06-06 Thread Michal Simek
It is useful when structure is also used for saving vendor data covered by CRC32. Signed-off-by: Michal Simek --- Changes in v2: - print it only in mdata v2 version cmd/fwu_mdata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c index 6d91935b9b54

[PATCH] cmd: fwu: Also print information about size

2024-06-05 Thread Michal Simek
It is useful when structure is also used for saving vendor data covered by CRC32. Signed-off-by: Michal Simek --- cmd/fwu_mdata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c index 3c8be576ac7a..9c048d69a131 100644 --- a/cmd/fwu_mdata.c +++ b/cmd

[RFC PATCH] cmd: fwu: Dump custom fields from mdata structure

2024-06-05 Thread Michal Simek
The commit cb9ae40a16f0 ("tools: mkfwumdata: add logic to append vendor data to the FWU metadata") added support for adding vendor data to mdata structure but it is not visible anywhere that's why extend fwu command to dump it. Signed-off-by: Michal Simek --- I am using this for

Re: [PATCH 2/2] xilinx: zynqmp: Enable reset_cpu() in SPL

2024-06-04 Thread Michal Simek
On 6/4/24 11:12, Lukas Funke wrote: On 03.06.2024 17:08, Michal Simek wrote: On 6/3/24 16:50, Lukas Funke wrote: On 03.06.2024 16:32, Michal Simek wrote: On 6/3/24 15:34, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This commit enables SPL to reset the CPU via PMU

Re: [PATCH 2/2] xilinx: zynqmp: Enable reset_cpu() in SPL

2024-06-03 Thread Michal Simek
On 6/3/24 16:50, Lukas Funke wrote: On 03.06.2024 16:32, Michal Simek wrote: On 6/3/24 15:34, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This commit enables SPL to reset the CPU via PMU-firmware. The usual reset mechanism requires bl31 to be loaded which may

Re: [PATCH 2/2] xilinx: zynqmp: Enable reset_cpu() in SPL

2024-06-03 Thread Michal Simek
On 6/3/24 15:34, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This commit enables SPL to reset the CPU via PMU-firmware. The usual reset mechanism requires bl31 to be loaded which may not be the case in SPL. Signed-off-by: Lukas Funke --- board/xilinx/zynqmp/zynqmp.c | 9

Re: [PATCH 1/2] arm64: zynqmp: Add 'SPL_ZYNQMP_FIRMWARE' to Kconfig

2024-06-03 Thread Michal Simek
On 6/3/24 15:34, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke In order to make CONFIG_IS_ENABLED() work with 'ZYNQMP_FIRMWARE' introduce an additional Kconfig 'SPL_ZYNQMP_FIRMWARE' which is selected if and only if ZYNQMP_FIRMWARE is enabled. Driver are adapted such that they

[PATCH] arm64: zynqmp: Setup multiboot register to 0

2024-06-03 Thread Michal Simek
(start of QSPI) and call early bootloader every reboot that's why clear multiboot register to 0 by default to go that route all the time. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp_kria.env | 1 + 1 file changed, 1 insertion(+) diff --git a/board/xilinx/zynqmp/zynqmp_kria.env b

Re: [PATCH] xilinx: Add option to load environment from outside of boot media

2024-05-31 Thread Michal Simek
On 5/31/24 12:09, Vasileios Amoiridis wrote: Currently, if the environment is not in the current boot media, the env_get_location() is returning ENVL_UNKNOWN or ENVL_NOWHERE which is not true (i.e booting from FLASH with environment in eMMC). This commit adds an extra check to find the

Re: [PATCH v3 05/25] md5: Remove md5 non-watchdog API

2024-05-31 Thread Michal Simek
((u8 *)start_addr, len, [0], MD5_DEF_CHUNK_SZ); if (!memcmp(checksum, calchecksum, MD5_CHECKSUM_SIZE)) return 0; Reviewed-by: Michal Simek # zynq M

Re: [PATCH] arm64: zynqmp: Update rproc node

2024-05-31 Thread Michal Simek
On 5/31/24 00:16, Tanmay Shah wrote: On 5/30/24 5:39 AM, Michal Simek wrote: remoteproc node should be updated to be aligned with the latest dt-schema. Signed-off-by: Michal Simek --- Once we push all dts to Linux we can change to OF_UPSTREAM but till that time we need to keep DTSes

Re: [PATCH 0/4] arm64: versal2: Add support for new AMD Versal Gen 2 SoC

2024-05-30 Thread Michal Simek
On 5/30/24 16:08, Tom Rini wrote: On Thu, May 30, 2024 at 08:04:07AM +0200, Michal Simek wrote: Hi Tom, On 5/29/24 18:13, Tom Rini wrote: On Wed, May 29, 2024 at 04:47:57PM +0200, Michal Simek wrote: Hi, I am sending patches for adding initial support for new AMD Versal Gen 2 SoC

Re: [PATCH 0/4] arm64: versal2: Add support for new AMD Versal Gen 2 SoC

2024-05-30 Thread Michal Simek
Hi Tom, On 5/29/24 18:13, Tom Rini wrote: On Wed, May 29, 2024 at 04:47:57PM +0200, Michal Simek wrote: Hi, I am sending patches for adding initial support for new AMD Versal Gen 2 SoC. If you want to find out more information please take a look at this page: https://www.amd.com/en/products

Re: [PATCH v3 0/2] Introduce spl_soc_init() for SoC specific initialization

2024-05-30 Thread Michal Simek
Hi, pá 3. 5. 2024 v 8:10 odesílatel Lukas Funke napsal: > > Hi Michal, > > On 10.04.2024 09:06, Michal Simek wrote: > > Hi, > > > > On 4/8/24 14:59, Michal Simek wrote: > >> > >> > >> On 3/27/24 13:11, lukas.funke-...@weidmueller.com wr

[PATCH] arm64: zynqmp: Update rproc node

2024-05-30 Thread Michal Simek
remoteproc node should be updated to be aligned with the latest dt-schema. Signed-off-by: Michal Simek --- Once we push all dts to Linux we can change to OF_UPSTREAM but till that time we need to keep DTSes in sync. --- arch/arm/dts/zynqmp.dtsi | 67

[PATCH] efi_loader: Fix capsule_esl.dtsi.in comment style

2024-05-30 Thread Michal Simek
Comment is not kernel-doc format that's why don't label it like that and also fix indentation to have proper multiline comment. Signed-off-by: Michal Simek --- lib/efi_loader/capsule_esl.dtsi.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader

[PATCH 1/4] arm64: versal2: Add support for AMD Versal Gen 2

2024-05-29 Thread Michal Simek
Add support for AMD Versal Gen 2. SoC is based on Cortex-a78ae 4 cluster/2 cpu core each. A lot of IPs are shared with previous families. There are couple of new IP blocks where the most interesting from user point of view is UFS. Signed-off-by: Michal Simek --- arch/arm/Kconfig

[PATCH 0/4] arm64: versal2: Add support for new AMD Versal Gen 2 SoC

2024-05-29 Thread Michal Simek
Hi, I am sending patches for adding initial support for new AMD Versal Gen 2 SoC. If you want to find out more information please take a look at this page: https://www.amd.com/en/products/adaptive-socs-and-fpgas/versal.html Thanks, Michal Michal Simek (4): arm64: versal2: Add support for AMD

Re: [RFC PATCH v1 1/1] mmc: zynq_sdhci: Only evaluate card-stable signal if card was detected

2024-05-29 Thread Michal Simek
On 4/24/24 10:23, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke On ZynqMp there seems to be a dependency between the card-stable bit and the card-detect bit. The card-stable bit is set *if and only if* the card-detect bit was set before, indicating that the signal was stable and

[PATCH 4/4] spi: versal2: Enable spi drivers for Versal Gen 2

2024-05-29 Thread Michal Simek
Enable and update OSPI/QSPI/GQSPI drivers to support Versal Gen 2 SoCs. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 4 +++- drivers/spi/Kconfig| 2 +- drivers/spi/cadence_qspi.c | 3 ++- drivers/spi/zynqmp_gqspi.c | 6 -- 4 files

[PATCH 3/4] mmc: versal2: Update zynq_sdhci driver to support AMD Versal Gen 2

2024-05-29 Thread Michal Simek
Enable tap delay programming for new SoC and also enable it via defconfig. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 2 ++ drivers/mmc/zynq_sdhci.c | 22 ++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/configs

[PATCH 2/4] soc: versal2: Add SoC driver for AMD Versal Gen 2

2024-05-29 Thread Michal Simek
Communication is happening via firmware interface (SMC) or via direct register reading if firmware driver is not available. Also enable it via defconfig. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 1 + drivers/soc/Kconfig| 8 drivers/soc

Re: [PATCH v2 2/2] drivers: misc: Add driver to access ZynqMP efuses

2024-05-29 Thread Michal Simek
use.c @@ -0,0 +1,324 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * (C) Copyright 2014 - 2015 Xilinx, Inc. + * Michal Simek + * + * (C) Copyright 2024 Weidmueller Interface GmbH + * Lukas Funke + */ + +#include +#include +#include +#include +#include +#include +#include +

Re: [PATCH v2 0/2] Add eFuse access for ZynqMP

2024-05-29 Thread Michal Simek
On 5/15/24 14:41, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series adds a driver to read and write ZynqMP eFuses [1]. The driver can be accessed by the 'fuse read' and 'fuse write' commands Example: => fuse read 0 0xc 3 Reading bank 0: Word 0x000c: 3cb16685

Re: [PATCH v2 1/2] firmware: zynqmp: Add support to access efuses

2024-05-29 Thread Michal Simek
On 5/15/24 14:41, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Add functions to access efuses through PMU firmware interface. Signed-off-by: Lukas Funke --- (no changes since v1) drivers/firmware/firmware-zynqmp.c | 31 ++

Re: [PATCH] xilinx: versal: Do not prioritize boot device if driver is not enabled

2024-05-29 Thread Michal Simek
On 5/10/24 08:22, Michal Simek wrote: From: Venkatesh Yadav Abbarapu SOC can boot out of the device which is not accessible from APU and running this is detected as a warning, as the device is not accessible.For example getting below warning when the boot mode is OSPI and OSPI

Re: [PATCH ] mtd: spi-nor: Add SPI_NOR_OCTAL_READ flag for mx66uw2g345gx0 flash part

2024-05-29 Thread Michal Simek
On 5/8/24 07:27, Prasad Kummari wrote: Added SPI_NOR_OCTAL_READ flag for Macronix mx66uw2g345gx0 2Gb(256MB) NOR Flash memory has been added. Initial testing was conducted on the I fixed this commit message. Versal NET board using SDR mode, which included basic erase, write, and read-back

Re: [PATCH v2] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-29 Thread Michal Simek
On 5/29/24 12:01, Kory Maincent wrote: Once the environment was saved, the current multiboot image information became unreachable. When dealing with firmware updates, this information is necessary alongside the saved environment to know the booted image. Move the multiboot environment set

Re: [PATCH] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-29 Thread Michal Simek
On 5/28/24 17:11, Kory Maincent wrote: On Tue, 28 May 2024 16:53:42 +0200 Michal Simek wrote: On 5/28/24 16:36, Kory Maincent wrote: Once the environment was saved, we could not retrieve information about nit: use imperative mood. Ah indeed. the multiboot image used. When dealing

Re: [PATCH] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-28 Thread Michal Simek
On 5/28/24 16:36, Kory Maincent wrote: Once the environment was saved, we could not retrieve information about nit: use imperative mood. the multiboot image used. When dealing with firmware updates, this information is necessary alongside the saved environment. what exactly are you

Re: [PATCH v4] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-27 Thread Michal Simek
). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass Cc: Patrick Delaunay Cc: Patrice

Re: [PATCH] xilinx: Add option to load environment from outside of boot media

2024-05-27 Thread Michal Simek
On 5/22/24 19:47, Vasileios Amoiridis wrote: From: Vasileios Amoiridis Currently, if the environment is not in the current boot media, the env_get_location() is returning ENVL_UNKNOWN or ENVL_NOWHERE which is not true (i.e booting from FLASH with environment in eMMC). This commit adds an

Re: [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support

2024-05-24 Thread Michal Simek
On 5/7/24 17:48, Tom Rini wrote: On Tue, May 07, 2024 at 04:15:14AM +, Abbarapu, Venkatesh wrote: + Tom Rini Do you have any comments for this series? Seems likely fine. Jagan, do you have time to put this in a PR for -next? Thanks. No reaction for quite a long time. Can you take

Re: [PATCH v3 00/20] FWU: Add support for FWU metadata version 2

2024-05-24 Thread Michal Simek
deletions(-) create mode 100644 lib/fwu_updates/fwu_v1.c create mode 100644 lib/fwu_updates/fwu_v2.c I tested it on Kria and I can't see any issue that's why Tested-by: Michal Simek Thanks, Michal

Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-05-24 Thread Michal Simek
Hi Ilias, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform

Re: [PATCH v3] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-22 Thread Michal Simek
st 22. 5. 2024 v 17:19 odesílatel Tim Harvey napsal: > > On Wed, May 22, 2024 at 12:47 AM Michal Simek wrote: > > > > > > > > On 5/21/24 22:59, Tim Harvey wrote: > > > If RANDOMIZE_BASE is enabled in the Linux kernel instructing it to > > > randomi

Re: [PATCH v3] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-22 Thread Michal Simek
). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass Cc: Patrick Delaunay Cc: Patrice

  1   2   3   4   5   6   7   8   9   10   >