Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-28 Thread Bill Barker
"Christopher Schultz" wrote in message news:4ae758a0.5050...@christopherschultz.net... > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Bill, > > On 10/26/2009 9:44 PM, Bill Barker wrote: >> "Christopher Schultz" wrote in message >>> On the other hand, shouldn't the JSP compiler pass-throu

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-27 Thread Konstantin Kolinko
2009/10/27 Pete McNeil : > > IMO allowing for the XML comments _seems_ like a good idea. > 2009/10/26 Christopher Schultz : > On the other hand, shouldn't the JSP compiler pass-through everything > except for directives? HTML is a common enough use case for JSP that > SGML comments ought to be tol

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-27 Thread Pete McNeil
Christopher Schultz wrote: I think the JSP specification has a little multiple-personality disorder when it comes to XML-looking-syntax versus actual XML syntax. It's unfortunate, since it can really confuse people. My $0.03 "be strict in what you produce, be forgiving in what you receiv

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-27 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bill, On 10/26/2009 9:44 PM, Bill Barker wrote: > "Christopher Schultz" wrote in message >> On the other hand, shouldn't the JSP compiler pass-through everything >> except for directives? HTML is a common enough use case for JSP that >> SGML comment

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Bill Barker
"Christopher Schultz" wrote in message news:4ae5cabb.7070...@christopherschultz.net... > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Konstantin, > >> Those are NOT comments. The JSP comments are <%-- --%>. >> >> I think that if you switch to XML syntax for JSP pages (using jspx >> files

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Konstantin, > Those are NOT comments. The JSP comments are <%-- --%>. > > I think that if you switch to XML syntax for JSP pages (using jspx > files instead of jsp), those will be treated as XML comments and > properly ignored. Apologies for not thi

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Pete McNeil
Konstantin Kolinko wrote: This looks like a bug in the code that reads the JSP: comments ought to be tolerated and ignored. Would you be willing to: Those are NOT comments. The JSP comments are <%-- --%>. I think that if you switch to XML syntax for JSP pages (using jspx files instead

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Pete McNeil
Christopher Schultz wrote: This does work: This looks like a bug in the code that reads the JSP: comments ought to be tolerated and ignored. Would you be willing to: 1. Log a bug against Tomcat in bugzilla 2. produce a short test case (th

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Konstantin Kolinko
2009/10/26 Christopher Schultz : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Pete, > > On 10/24/2009 4:20 PM, Pete McNeil wrote: >> This doesn't work / causes the error: >> >>         >>                 >>                 >>                 >>         >> >> This does work: >> >>         >

Re: Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pete, On 10/24/2009 4:20 PM, Pete McNeil wrote: > This doesn't work / causes the error: > > > > > > > > This does work: > > > > > > Thi

Expecting "jsp:param" - Porting resin jsp pages to tomcat, dreamweaver editable sections / comments

2009-10-24 Thread Pete McNeil
For the benefit of anyone else moving a jsp site from resin to tomcat: If you get this error: org.apache.jasper.JasperException: /products/index.jsp(53,2) Expecting "jsp:param" standard action with "name" and "value" attributes The problem is likely that an editable section is cutting through