Reviewers: Sven Panne,
Description:
Disable concurrent OSR.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/208263011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/flag-definitions.h
Index:
lgtm
https://codereview.chromium.org/208263011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r20172 (tree was closed).
https://codereview.chromium.org/208263011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20172
Author: yang...@chromium.org
Date: Mon Mar 24 07:44:50 2014 UTC
Log: Disable concurrent OSR.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/208263011
http://code.google.com/p/v8/source/detail?r=20172
Modified:
lgtm
https://codereview.chromium.org/209533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/21 15:17:57, dcarney wrote:
On 2014/03/21 12:27:34, Yang wrote:
On 2014/03/21 12:26:54, Yang wrote:
On 2014/03/21 09:52:22, Yang wrote:
LGTM.
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
Reviewers: Jakob,
Message:
PTAL
Description:
Fix options for calling push-to-trunk script.
BUG=
TBR=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/209833002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -4 lines):
M
Committed patchset #1 manually as r20173 (presubmit successful).
https://codereview.chromium.org/209833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20173
Author: machenb...@chromium.org
Date: Mon Mar 24 08:03:15 2014 UTC
Log: Fix options for calling push-to-trunk script.
BUG=
TBR=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/209833002
http://code.google.com/p/v8/source/detail?r=20173
Modified:
Reviewers: Michael Starzinger,
Description:
Fix DebugEvaluate for generators.
R=mstarzin...@chromium.org
BUG=v8:3225
LOG=N
Please review this at https://codereview.chromium.org/207153004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+79, -24 lines):
M
Revision: 20175
Author: machenb...@chromium.org
Date: Mon Mar 24 08:13:18 2014 UTC
Log: Tagging version 3.25.23
http://code.google.com/p/v8/source/detail?r=20175
Added:
/tags/3.25.23
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 20176
Author: dcar...@chromium.org
Date: Mon Mar 24 08:17:06 2014 UTC
Log: Do stack checks while pushing locals
R=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/207543003
http://code.google.com/p/v8/source/detail?r=20176
Modified:
Committed patchset #8 manually as r20176 (presubmit successful).
https://codereview.chromium.org/207543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20177 (presubmit successful).
https://codereview.chromium.org/203443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20177
Author: yang...@chromium.org
Date: Mon Mar 24 08:22:24 2014 UTC
Log: Refactor inlined typed array runtime functions.
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/203443002
http://code.google.com/p/v8/source/detail?r=20177
Modified:
On 2014/03/21 11:42:00, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/208063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Message:
ptal
Description:
add setaccessorproperty to object
R=svenpa...@chromium.org
BUG=v8:2964
Please review this at https://codereview.chromium.org/209853002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -21 lines):
M
PTAL (sorry, I had to rebase again)
https://codereview.chromium.org/150813004/diff/21/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/150813004/diff/21/src/hydrogen.cc#newcode8466
src/hydrogen.cc:8466: static HandleMap TypedArrayMap(Isolate* isolate,
On
On 2014/03/21 11:29:51, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/208033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/209853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #3 manually as r20178 (presubmit successful).
https://codereview.chromium.org/209853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20178
Author: dcar...@chromium.org
Date: Mon Mar 24 08:41:59 2014 UTC
Log: add setaccessorproperty to object
R=svenpa...@chromium.org
LOG=N
BUG=v8:2964
Review URL: https://codereview.chromium.org/209853002
http://code.google.com/p/v8/source/detail?r=20178
Modified:
Updates:
Status: Fixed
Comment #3 on issue 2964 by dcar...@chromium.org: SetAccessorProperty is
not available on Object
http://code.google.com/p/v8/issues/detail?id=2964
fixed in https://codereview.chromium.org/209853002/
--
You received this message because this project is
Updates:
Status: Fixed
Comment #20 on issue 3205 by dcar...@chromium.org: Too many variables
limit prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
(No comment was entered for this change.)
--
You received this message because this
Reviewers: Jakob, Yang, ulan, yurys, Benedikt Meurer,
Message:
This CL is to enable x64 build of v8. Please review!
Description:
Enable x64 build
BUG=
Please review this at https://codereview.chromium.org/209323004/
SVN Base: https://github.com/v8/v8.git@master
Affected files (+31, -2
Committed patchset #1 manually as r20179 (presubmit successful).
https://codereview.chromium.org/208263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20179
Author: yang...@chromium.org
Date: Mon Mar 24 08:47:45 2014 UTC
Log: Remove Failure::OutOfMemory propagation and
V8::IgnoreOutOfMemoryException.
R=dcar...@chromium.org
BUG=v8:3060
LOG=Y
Review URL: https://codereview.chromium.org/208263002
Committed patchset #1 manually as r20180 (presubmit successful).
https://codereview.chromium.org/208033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20180
Author: ish...@chromium.org
Date: Mon Mar 24 08:48:36 2014 UTC
Log: Builtin helper function EnsureJSArrayWithWritableFastElements()
handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/208033002
On 2014/03/24 08:40:13, kennyluck wrote:
The CQ bit was checked by mailto:kanghao@alibaba-inc.com
Meh. I am not sure what I did (git cl set-commit) was sensible. If you need
to
stop it, please help!
https://codereview.chromium.org/209533002/
--
--
v8-dev mailing list
Here are some comments (but I didn't yet look at all the code in detail).
https://codereview.chromium.org/160073006/diff/380001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/160073006/diff/380001/src/parser.cc#newcode3141
src/parser.cc:3141: if (expression == NULL)
Committed patchset #1 manually as r20181 (presubmit successful).
https://codereview.chromium.org/208063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20181
Author: ish...@chromium.org
Date: Mon Mar 24 09:06:04 2014 UTC
Log: Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/208063002
http://code.google.com/p/v8/source/detail?r=20181
Modified:
Hmm, one more comment... what am I missing? I thought arrow funcs are just
syntactic sugar and they won't have any impact beyond the Parser, i.e., the
parser would produce the same ast in these cases:
(foo, bar) = { baz }
function(foo, bar) { baz }
but this CL doesn't seem like it...
Revision: 20182
Author: rmcil...@chromium.org
Date: Mon Mar 24 09:09:49 2014 UTC
Log: Remove an unused isolate_ field from BacktrackStack.
Found by Nico Weber with -Wunused-private-field
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/208613002
Committed patchset #1 manually as r20182 (presubmit successful).
https://codereview.chromium.org/208613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Description:
Revert Remove Failure::OutOfMemory propagation and
V8::IgnoreOutOfMemoryException.
This reverts r20179.
TBR=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/201573007/
SVN Base:
Committed patchset #1 manually as r20183 (tree was closed).
https://codereview.chromium.org/201573007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/209833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20183
Author: yang...@chromium.org
Date: Mon Mar 24 09:17:18 2014 UTC
Log: Revert Remove Failure::OutOfMemory propagation and
V8::IgnoreOutOfMemoryException.
This reverts r20179.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/201573007
lgtm
https://codereview.chromium.org/201573007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/24 09:06:47, marja wrote:
Hmm, one more comment... what am I missing? I thought arrow funcs are just
syntactic sugar and they won't have any impact beyond the Parser, i.e.,
the
parser would produce the same ast in these cases:
(foo, bar) = { baz }
function(foo, bar) { baz }
but
The implementation is looking OK and I couldn't spot any bugs in the
lockstep
synchronization. However we are talking about a synchronization mechanism
that
involves four semaphores, one mutex and one atomic variable. This is
impossible
to audit. That poses two concrete concerns about this
On 2014/03/24 09:21:06, rossberg wrote:
On 2014/03/24 09:06:47, marja wrote:
Hmm, one more comment... what am I missing? I thought arrow funcs are
just
syntactic sugar and they won't have any impact beyond the Parser, i.e.,
the
parser would produce the same ast in these cases:
(foo,
LGTM, I'll land.
https://codereview.chromium.org/202083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2014/03/24 09:21:31, Michael Starzinger wrote:
The implementation is looking OK and I couldn't spot any bugs in the
lockstep
synchronization. However we are talking about a synchronization mechanism
that
involves four semaphores, one mutex and one atomic variable. This is
impossible
to
Reviewers: dcarney,
Message:
Please take a look. The second patch set is the fix.
Description:
Reland Remove Failure::OutOfMemory propagation and
V8::IgnoreOutOfMemoryException.
Please review this at https://codereview.chromium.org/209903003/
SVN Base:
Reviewers: Benedikt Meurer, ulan,
Description:
ARM64: optimize call immediate
BUG=
R=u...@chromium.org, bmeu...@chromium.org
Please review this at https://codereview.chromium.org/209923002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+45, -41 lines):
M
Reviewers: Yang,
Message:
PTAL
Description:
FastElementsAccessor::SetLengthWithoutNormalize() handlified.
Please review this at https://codereview.chromium.org/208313012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+43, -26 lines):
M src/elements.cc
On 2014/03/24 09:33:32, Yang wrote:
Please take a look. The second patch set is the fix.
lgtm
https://codereview.chromium.org/209903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Reviewers: Benedikt Meurer, ulan,
Description:
ARM64: push/pop registers in stubs for safepoints
BUG=
R=u...@chromium.org, bmeu...@chromium.org
Please review this at https://codereview.chromium.org/209933003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
First round.
https://codereview.chromium.org/196103004/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/196103004/diff/20001/include/v8.h#newcode2001
include/v8.h:2001: // Create a symbol. If data is not NULL, it will be
used as a print name.
nit: Comment is
Revision: 20184
Author: yang...@chromium.org
Date: Mon Mar 24 10:07:15 2014 UTC
Log: Reland Remove Failure::OutOfMemory propagation and
V8::IgnoreOutOfMemoryException.
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/209903003
Committed patchset #2 manually as r20184 (presubmit successful).
https://codereview.chromium.org/209903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #3 manually as r20185 (presubmit successful).
https://codereview.chromium.org/202083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20185
Author: jkumme...@chromium.org
Date: Mon Mar 24 10:18:27 2014 UTC
Log: [ia32/x64] Smaller instruction to check NaN
substract 1 and test for overflow
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/202083002
Patch from Weiliang Lin
Reviewers: arv, Michael Starzinger,
Description:
Spec adjustments for well-known symbols
R=mstarzin...@chromium.org, a...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/208423013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+40, -23
https://codereview.chromium.org/207153004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/207153004/diff/1/src/runtime.cc#newcode11427
src/runtime.cc:11427: if (scope_info-ContextSlotIndex(*name, mode,
init_flag) != -1) {
I am little bit confused here. For
On 2014/03/22 17:15:49, arv wrote:
I'm not sure that we should install Symbol.x if we do not support x,
where x
is
a certain feature. For example, one might expect us to support @@create
because
we have Symbol.create. I think adding these once we support the feature
would
allow code to
Some more comments. Getting there. I especially like the fullcodegen
cleanup.
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js
File src/symbol.js (right):
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js#newcode68
src/symbol.js:68: if (!('internal' in registry)) {
On 2014/03/22 17:15:49, arv wrote:
Maybe this could have been
if
Reviewers: danno, dcarney, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Do stack checks while pushing locals.
Port r20176 (a1bfd83)
BUG=
Please review this at https://codereview.chromium.org/208323010/
SVN Base: git://github.com/paul99/v8m-rb.git@gbl
Affected files (+40, -18 lines):
Reviewers: Yang,
Message:
As discussed.
Description:
Delete mjsunit/string-oom-slow-* tests.
They are too slow, and there is no feasible way to speed them up.
Please review this at https://codereview.chromium.org/205553005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
https://codereview.chromium.org/208423013/diff/1/src/symbol.js
File src/symbol.js (right):
https://codereview.chromium.org/208423013/diff/1/src/symbol.js#newcode138
src/symbol.js:138: var attr = READ_ONLY | DONT_DELETE | DONT_ENUM;
With these attributes you should now be able to use the
On 2014/03/24 10:33:45, Jakob wrote:
As discussed.
lgtm.
https://codereview.chromium.org/205553005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20186 (presubmit successful).
https://codereview.chromium.org/205553005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20186
Author: jkumme...@chromium.org
Date: Mon Mar 24 10:37:16 2014 UTC
Log: Delete mjsunit/string-oom-slow-* tests.
They are too slow, and there is no feasible way to speed them up.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/205553005
On 2014/03/24 10:24:28, Michael Starzinger wrote:
https://codereview.chromium.org/207153004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/207153004/diff/1/src/runtime.cc#newcode11427
src/runtime.cc:11427: if (scope_info-ContextSlotIndex(*name, mode,
Revision: 20187
Author: svenpa...@chromium.org
Date: Mon Mar 24 10:41:33 2014 UTC
Log: Revert A64: Now that we have veneers, fix a couple of branches
to directly jump to their target.
This reverts commit r20169, it heavily regresses a Mozilla test:
make -j32 arm64.release.check
Reviewers: ulan,
Message:
Committed patchset #1 manually as r20187 (presubmit successful).
Description:
Revert A64: Now that we have veneers, fix a couple of branches to directly
jump
to their target.
This reverts commit r20169, it heavily regresses a Mozilla test:
make -j32
LGTM.
https://codereview.chromium.org/208073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with a nit.
https://codereview.chromium.org/207153004/diff/30001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/207153004/diff/30001/src/runtime.cc#newcode11443
src/runtime.cc:11443: Runtime::SetObjectProperty(
nit: Should fit into one line again now.
LGTM, note that I changed the CL description to show that this CL is Android
specific.
https://codereview.chromium.org/209323004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: jochen,
Message:
PTAL
Description:
ARM64: update the path to android_stlport_libs.
BUG=
Please review this at https://codereview.chromium.org/209383007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M build/android.gypi
Index:
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h
File src/arm64/lithium-codegen-arm64.h (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385
src/arm64/lithium-codegen-arm64.h:385:
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h
File src/arm64/lithium-codegen-arm64.h (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385
src/arm64/lithium-codegen-arm64.h:385:
A few more comments. Would be nice to have that hydrogen code split up a
little
bit, given that it's so branchy, and there's not so much shared code.
https://codereview.chromium.org/150813004/diff/220001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h
File src/arm64/lithium-codegen-arm64.h (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385
src/arm64/lithium-codegen-arm64.h:385:
Updates:
Owner: baptiste...@arm.com
Cc: jacob.bram...@arm.com
Comment #4 on issue 3226 by jacob.bram...@arm.com:
cctest/test-assembler-a64/fmadd_fmsub_float_nans fails when building with
clang
http://code.google.com/p/v8/issues/detail?id=3226
Baptiste is working on this.
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h
File src/arm64/lithium-codegen-arm64.h (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385
src/arm64/lithium-codegen-arm64.h:385:
Reviewers: ulan,
Message:
ulan, ptal
Description:
PreParser cleanup: no need to track with-ness of scopees.
Historically, we used to track the with-ness of a scope differently; not
creating a with scope, but setting a property on the scope (see
https://codereview.chromium.org/5166006 ). For
lgtm
https://codereview.chromium.org/209863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #19 on issue 3060 by clearscr...@gmail.com: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
Would it not be possible to throw an exception in that case as well?
--
You received this message because this project
Comment #20 on issue 3060 by yang...@chromium.org: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
Well, in that case it's not even possible to allocate an exception any
longer.
--
You received this message because
lgtm
https://codereview.chromium.org/209383007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/209873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/24 12:03:28, kennyluck wrote:
The CQ bit was unchecked by mailto:kanghao@alibaba-inc.com
Meh. I guess commit queue just doesn't work for non-committers (but it
doesn't
give me any notice..). rossberg, can you land this for me?
https://codereview.chromium.org/209533002/
lgtm
https://codereview.chromium.org/197513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Message:
Committed patchset #2 manually as r20188 (presubmit successful).
Description:
Fix component build some more.
Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This
fixes
the new ones created by it. V8_INLINEing these funcs makes sense anyway.
Revision: 20188
Author: ma...@chromium.org
Date: Mon Mar 24 12:13:58 2014 UTC
Log: Fix component build some more.
Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This
fixes
the new ones created by it. V8_INLINEing these funcs makes sense anyway.
In addition,
Committed patchset #2 manually as r20189 (presubmit successful).
https://codereview.chromium.org/209863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20189
Author: ma...@chromium.org
Date: Mon Mar 24 12:16:09 2014 UTC
Log: PreParser cleanup: no need to track with-ness of scopes.
Historically, we used to track the with-ness of a scope differently; not
creating a with scope, but setting a property on the scope (see
LGTM with comments.
https://codereview.chromium.org/207613004/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/207613004/diff/1/src/builtins.cc#newcode957
src/builtins.cc:957: // This is the slow path. We are going to move the
elemetns to the left
nit:
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h
File src/arm64/lithium-codegen-arm64.h (right):
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385
src/arm64/lithium-codegen-arm64.h:385:
Reviewers: jarin,
Message:
PTAL
Description:
Change auto-roll to auto-push for automatic trunk pushes.
The current script is only performing automatic pushes to trunk. This
prepares
for adding an auto-roll script that actually rolls to Chromium.
This also removes the v8-status updates,
Reviewers: rossberg,
Message:
rossberg, ptal of this embarrassing cl, and then we'll pretend this never
happened, k? :)
Description:
Follow up to r20125 (enabling tests).
These tests were never meant to be disabled.
R=rossb...@chromium.org
BUG=
Please review this at
Reviewers: yannguo_chromium.org,
Message:
PTAL
Description:
Refactor optimized in hydrogen only runtime functions.
This splits all runtime function into 3 categories:
1) RUNTIME: implemented in runtime and called from both full and optimized
code.
2) INLINE: inlined in both full and
https://codereview.chromium.org/209923002/diff/1/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/209923002/diff/1/src/arm64/macro-assembler-arm64.cc#newcode2027
src/arm64/macro-assembler-arm64.cc:2027: // Addresses are 48 bits
Updates:
Status: Fixed
Comment #4 on issue 3228 by ma...@chromium.org: Windows DLL build broken on
trunk
http://code.google.com/p/v8/issues/detail?id=3228
Afaics this works now; the latest successful win component build is
lgtm
https://codereview.chromium.org/209953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 241 matches
Mail list logo
