Revision: 20745
Author: yang...@chromium.org
Date: Tue Apr 15 06:54:56 2014 UTC
Log: Reland "Handlify GetDeclaredAccessorProperty."
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/236613006
http://code.google.com/p/v8/source/detail?r=20745
Modified:
/branches/bleedi
Committed patchset #1 manually as r20745 (presubmit successful).
https://codereview.chromium.org/236613006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/236613006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
TL;DR: No, the global proxy is rebound to a new global object after
navigation,
and we need to ensure that existing references outside of that context
persist
properly. Hence the identity has to stay the same.
The global proxy is the unique object representing a window. When a window
navigate
Découvrez Artiste du Monde
Problèmes d'affichage ? Affichez cette newsletter dans votre navigateur. (
http://culturalspaceworld.com/artistedumonde/?email_id=9&user_id=139553&urlpassed=W3ZpZXdfaW5fYnJvd3Nlcl9saW5rXQ%3D%3D&controller=stats&action=analyse&wysija-page=1&wysijap=subscriptions
)
Lancem
Hi All,
Just want to know a little info in Wether TaskQueue or EventQueue which
handles all the events asynchronously is Unbounded or bounded?
if unbounded then do we have any flow control in place.
thanks
vikas
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
lgtm from my end, but of course I'm no v8 OWNER; looking forward to what
Michael
and/or Andreas have to say.
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16122
src/ob
Revision: 20744
Author: machenb...@chromium.org
Date: Tue Apr 15 01:05:45 2014 UTC
Log: Tagging version 3.26.15
http://code.google.com/p/v8/source/detail?r=20744
Added:
/tags/3.26.15
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
The mips parts LGTM. PTAL at the rest...
https://codereview.chromium.org/228943009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc#newcode1295
src/bootstrapper.cc:1295: if (FLAG_harmony_collections) {
On 2014/04/14 22:46:38, adamk wrote:
Can you
Revision: 20742
Author: machenb...@chromium.org
Date: Tue Apr 15 00:05:16 2014 UTC
Log: Tagging version 3.26.14
http://code.google.com/p/v8/source/detail?r=20742
Added:
/tags/3.26.14
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Revision: 20741
Author: machenb...@chromium.org
Date: Tue Apr 15 00:04:44 2014 UTC
Log: Version 3.26.14 (based on bleeding_edge revision r20713)
Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detail?r=20741
Modified:
/trunk/ChangeLog
/tru
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc#newcode1295
src/bootstrapper.cc:1295: if (FLAG_harmony_collections) {
Can you move those map constructions up to her
Michael, Andreas,
I've been working with Adam on this over the last week. I think it is ready
for
review now.
Thanks.
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
PTAL
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode15918
src/objects.cc:15918: Object* undefined =
table->GetHeap()->undefined_value();
On 2014/04/14 21:25:54, adamk wro
Comment #3 on issue 3268 by frkoe...@google.com: Problem loading website
when using ARM64 simulator
http://code.google.com/p/v8/issues/detail?id=3268
Syncing past r20658 to top fixed it. But syncing to r20658 is still
broken. Have not bisected what fixed my problem, or if it was just
in
https://codereview.chromium.org/236143002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/1/src/objects.cc#newcode16090
src/objects.cc:16090: return factory->CreateIteratorResultObject(value,
false);
On 2014/04/14 19:51:49, arv wrote:
On 2014/04
https://codereview.chromium.org/236143002/diff/60001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/236143002/diff/60001/src/factory.cc#newcode2003
src/factory.cc:2003: JSObject::SetProperty(result, value_string(),
value, NONE, SLOPPY).Assert();
I think you can skip
Needs moar Handles.
Basically, in a function that does allocation, it's a Bad Idea to not use
Handles, because any of your raw Object* stored on the stack might get
relocated.
That's why I asked you add DisallowHeapAllocation to the places where you
loop
over the linked list. Another option in
Revision: 20740
Author: ad...@chromium.org
Date: Mon Apr 14 20:52:20 2014 UTC
Log: Remove unnecessary %UnwrapGlobalProxy calls from object-observe.js
The intent of these calls was to properly key the WeakMap get/set calls
on the underlying global object, not the proxy, since that is th
Committed patchset #1 manually as r20740 (presubmit successful).
https://codereview.chromium.org/234143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/11 09:50:43, Toon Verwaest wrote:
This patch LGTM (arg, we manually unwrapped the proxy!?).
Thanks for the quick review (and yeah, I don't have any idea why we did
that;
youthful indiscretion, I suppose).
What you are saying regarding the identity hash sounds wrong to me. That
b
I'll look into changing things to use static next
https://codereview.chromium.org/236143002/diff/1/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/236143002/diff/1/src/collection.js#newcode130
src/collection.js:130: if (typeof f !== 'function') {
On 2014/04/14
Comment #2 on issue 3268 by frkoe...@google.com: Problem loading website
when using ARM64 simulator
http://code.google.com/p/v8/issues/detail?id=3268
Looks like the version I was using was prior to 20658. I'm not seeing this
on bleeding_edge at anymore. But I don't think that this was the
Revision: 20739
Author: yang...@chromium.org
Date: Mon Apr 14 19:38:29 2014 UTC
Log: Reland "Handlify DebugLookupResultValue."
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/237013003
http://code.google.com/p/v8/source/detail?r=20739
Modified:
/branches/bleeding_ed
Committed patchset #2 manually as r20739 (presubmit successful).
https://codereview.chromium.org/237013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #2 manually as r20738 (presubmit successful).
https://codereview.chromium.org/236823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20738
Author: yang...@chromium.org
Date: Mon Apr 14 19:37:51 2014 UTC
Log: Reland "Handlify Runtime::InitializeIntrinsicFunctionNames."
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/236823003
http://code.google.com/p/v8/source/detail?r=20738
Modifie
Revision: 20737
Author: yang...@chromium.org
Date: Mon Apr 14 19:34:32 2014 UTC
Log: Export [Dis]allowJavascriptExecutionScope
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/236833009
http://code.google.com/p/v8/source/detail?r=20737
Modified:
/branches/bleeding_
Committed patchset #1 manually as r20737 (presubmit successful).
https://codereview.chromium.org/236833009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Mostly looking good. I think there might be an edge case with the final
element
in an iteration. And you've got some more handlification work. Other than
that,
I like the look of it!
https://codereview.chromium.org/236143002/diff/1/src/collection.js
File src/collection.js (right):
https://c
On 2014/04/14 18:00:25, Yang wrote:
On 2014/04/14 17:59:35, Yang wrote:
> On 2014/04/14 17:59:03, Yang wrote:
> > On 2014/04/14 17:57:16, D Cronin wrote:
> > > We need this capability in chrome to ensure we don't trigger JS when
> logging.
> > lgtm.
>
> I'll land this for you the next opportunity
On 2014/04/14 17:59:35, Yang wrote:
On 2014/04/14 17:59:03, Yang wrote:
> On 2014/04/14 17:57:16, D Cronin wrote:
> > We need this capability in chrome to ensure we don't trigger JS when
logging.
> lgtm.
I'll land this for you the next opportunity I get.
CQ doesnt really work for V8
https:/
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/rdevlin.cro...@chromium.org/236833009/1
https://codereview.chromium.org/236833009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subs
On 2014/04/14 17:59:03, Yang wrote:
On 2014/04/14 17:57:16, D Cronin wrote:
> We need this capability in chrome to ensure we don't trigger JS when
logging.
lgtm.
I'll land this for you the next opportunity I get.
https://codereview.chromium.org/236833009/
--
--
v8-dev mailing list
v8-dev@go
On 2014/04/14 17:57:16, D Cronin wrote:
We need this capability in chrome to ensure we don't trigger JS when
logging.
lgtm.
https://codereview.chromium.org/236833009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Reviewers: Yang,
Message:
We need this capability in chrome to ensure we don't trigger JS when
logging.
Description:
Export [Dis]allowJavascriptExecutionScope
Please review this at https://codereview.chromium.org/236833009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Aff
Reviewers: mvstanton,
Message:
This just removes two of the bogus occurrences of Object.isSealed checks in
our
built-ins. In these two instances we behave correctly now that the array.js
file
is in strict mode. The "snafu" with the other built-ins will be addressed
later
once we can do it
Reviewers: Michael Starzinger,
Message:
ptal
Description:
Refactor ParseFunctionLiteral.
It was a pretty monstrous 500 line function.
Please review this at https://codereview.chromium.org/237243003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+168, -129 li
Revision: 20736
Author: verwa...@chromium.org
Date: Mon Apr 14 16:21:38 2014 UTC
Log: Initial steps for moving code onto Map
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/237143004
http://code.google.com/p/v8/source/detail?r=20736
Modified:
/branches/bleedin
Committed patchset #1 manually as r20736 (presubmit successful).
https://codereview.chromium.org/237143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
As discussed offline, I don't really want to pollute all our code with ,
isolate, especially when it's not measurable.
I'm going to leave as is.
https://codereview.chromium.org/237143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received t
lgtm with nits:
https://codereview.chromium.org/237143004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4423
src/objects.cc:4423: Isolate* isolate = cache->GetIsolate();
While we are here: lets get isolate only once in
Committed patchset #2 manually as r20735 (presubmit successful).
https://codereview.chromium.org/236983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20735
Author: mstarzin...@chromium.org
Date: Mon Apr 14 16:05:19 2014 UTC
Log: Handlify Heap::AllocateJSArrayStorage and friends.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/236983002
http://code.google.com/p/v8/source/detail?r=20735
Modified:
/branc
Revision: 20734
Author: ish...@chromium.org
Date: Mon Apr 14 15:56:57 2014 UTC
Log: Reland "HashTable::Shrink() handlified and derived template
parameter added to HashTable hierarchy."
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/227423004
http://code.google.c
Committed patchset #2 manually as r20734 (presubmit successful).
https://codereview.chromium.org/227423004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Initial steps for moving code onto Map
BUG=
Please review this at https://codereview.chromium.org/237143004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+28, -52 lines):
M src/objects.h
M src/objects.
Revision: 20733
Author: rossb...@chromium.org
Date: Mon Apr 14 15:35:36 2014 UTC
Log: Re-reland "More tests for Union & Intersect"
R=ja...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/237143002
http://code.google.com/p/v8/source/detail?r=20733
Modified:
/branches/bl
Committed patchset #2 manually as r20733 (presubmit successful).
https://codereview.chromium.org/237143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
You could consider reviewing this... ;)
https://codereview.chromium.org/228263005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this grou
On 2014/04/14 15:04:44, Igor Sheludko wrote:
PTAL. The fix is in patch set 2. I'll handlify StringTable and make its
methods
static in a next CL.
lgtm.
https://codereview.chromium.org/227423004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
lgtm
https://codereview.chromium.org/237013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
PTAL. The fix is in patch set 2. I'll handlify StringTable and make its
methods
static in a next CL.
Description:
Reland "HashTable::Shrink() handlified and derived template parameter added
to
HashTable hierarchy."
Please review this at https://codereview.chromiu
Reviewers: jarin,
Description:
Reland "Handlify GetDeclaredAccessorProperty."
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/236613006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+37, -41 lines):
M src/objects.cc
Index: src/o
lgtm
https://codereview.chromium.org/237143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
second patch set includes fix.
Description:
Reland "Handlify DebugLookupResultValue."
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/237013003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+45, -68 lines
Reviewers: jarin,
Message:
Fixes handlification of tests (see patch set 2 for diff with original CL).
Description:
Re-reland "More tests for Union & Intersect"
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/237143002/
SVN Base: https://v8.googlecode.com/svn/b
Reviewers: jarin,
Description:
Revert "Handlify GetDeclaredAccessorProperty."
This reverts r20721.
TBR=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/234623004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+41, -37 lines):
M
Committed patchset #1 manually as r20732 (tree was closed).
https://codereview.chromium.org/237093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 20732
Author: yang...@chromium.org
Date: Mon Apr 14 14:34:37 2014 UTC
Log: Revert "Handlify DebugLookupResultValue."
This reverts r20729.
TBR=ja...@chromium.org
Review URL: https://codereview.chromium.org/237093003
http://code.google.com/p/v8/source/detail?r=20732
Modified
Reviewers: jarin,
Description:
Revert "Handlify DebugLookupResultValue."
This reverts r20729.
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/237093003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+68, -45 lines):
M src/objects.
Revision: 20731
Author: yang...@chromium.org
Date: Mon Apr 14 14:31:38 2014 UTC
Log: Revert "Handlify GetDeclaredAccessorProperty."
This reverts r20721.
TBR=ja...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/234623004
http://code.google.com/p/v8/source/detail?r=20731
Committed patchset #1 manually as r20731 (tree was closed).
https://codereview.chromium.org/234623004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
LGTM (rubber-stamped).
https://codereview.chromium.org/236823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
Reviewers: Jakob,
Message:
Hi Jakob,
I'd like to undo the change I made some time ago to include the target
architecture in the names of the v8 targets; I've since fixed the
gyp-android
backend to not require this any more, and it makes it difficult to write
downstream Android modules that de
LGTM.
https://codereview.chromium.org/236633006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 20730
Author: yang...@chromium.org
Date: Mon Apr 14 14:03:20 2014 UTC
Log: Allow allocation and GC in access check callbacks.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/234913003
http://code.google.com/p/v8/source/detail?r=20730
Modified:
/branches/b
Committed patchset #3 manually as r20730 (presubmit successful).
https://codereview.chromium.org/234913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20729
Author: yang...@chromium.org
Date: Mon Apr 14 14:00:35 2014 UTC
Log: Handlify DebugLookupResultValue.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/236683003
http://code.google.com/p/v8/source/detail?r=20729
Modified:
/branches/bleeding_edge/src/obj
Committed patchset #2 manually as r20729 (presubmit successful).
https://codereview.chromium.org/236683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/14 13:53:19, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/236983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
Reviewers: Yang,
Description:
Handlify Heap::AllocateJSArrayStorage and friends.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/236983002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+52, -97 lines):
M src/factory.h
M src/fa
Reviewers: Michael Starzinger,
Message:
Committed patchset #2 manually as r20728 (presubmit successful).
Description:
Don't run tests that rely on compaction when compaction is turned off.
BUG=
R=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=20728
Please rev
Revision: 20728
Author: hpa...@chromium.org
Date: Mon Apr 14 13:52:41 2014 UTC
Log: Don't run tests that rely on compaction when compaction is turned
off.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/236203010
http://code.google.com/p/v8/source/detail
LGTM.
https://codereview.chromium.org/236203010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 20727
Author: joc...@chromium.org
Date: Mon Apr 14 13:38:16 2014 UTC
Log: Clean up default-platform gyp defines
The files that are excluded do not exist at that location, so the rule
is not effective.
We'll first want to move the platform stuff into a separate library, so
I'
Committed patchset #1 manually as r20727 (presubmit successful).
https://codereview.chromium.org/237053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/237053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Description:
Clean up default-platform gyp defines
The files that are excluded do not exist at that location, so the rule
is not effective.
We'll first want to move the platform stuff into a separate library, so
I'm just removing those lines for now
BUG=v8:3015
R=dcar...@ch
Reviewers: Michael Starzinger,
Message:
One doesn't simply jump to a function in the arguments adaptor
trampoline. :)
We need to put the return address into the stack. Otherwise, the frame is
off by
one word, and the stack frame iterator gets confused.
The fix is in diff between patch set
Revision: 20726
Author: ish...@chromium.org
Date: Mon Apr 14 13:25:16 2014 UTC
Log: Revert "Reland "HashTable::Shrink() handlified and derived
template parameter added to HashTable hierarchy.""
This reverts r20724.
TBR=ja...@chromium.org
Review URL: https://codereview.chromium.org
Reviewers: jarin,
Message:
Committed patchset #1 manually as r20726 (presubmit successful).
Description:
Revert "Reland "HashTable::Shrink() handlified and derived template
parameter
added to HashTable hierarchy.""
This reverts r20724.
TBR=ja...@chromium.org
Committed: https://code.google.
lgtm
https://codereview.chromium.org/236683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/236683003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/236683003/diff/1/src/runtime.cc#newcode10747
src/runtime.cc:10747: // Fall through;
On 2014/04/14 11:25:25, ulan wrote:
"break" would be easier to read than "fall through
Reviewers: Yang,
Message:
Hi Yang, here are builtins. It's mostly a change to the function macro.
PTAL,
--Michael
Description:
Handlify built-ins.
Please review this at https://codereview.chromium.org/225713003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Update CheckBothSmi, CheckInteger32ValidSmiValue,
CheckUInteger32ValidSmiValue,
SmiAddConstant, SmiNot, AddSmiField and Test to support x32 port.
Please review this at https://codereview.chromium.org/236723004/
SVN Base: https://v8.googl
Revision: 20725
Author: rmcil...@chromium.org
Date: Mon Apr 14 12:50:24 2014 UTC
Log: Fix initial FPSCR state in ARM simulator
Rounding mode should be round-to-nearest by default, and NaN mode bit
should be 0, like in a real ARM system.
BUG=3253
LOG=N
R=rmcil...@chromium.org
Review U
Revision: 20724
Author: ish...@chromium.org
Date: Mon Apr 14 12:50:04 2014 UTC
Log: Reland "HashTable::Shrink() handlified and derived template
parameter added to HashTable hierarchy."
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/235643002
http://code.google.c
Committed patchset #1 manually as r20725 (presubmit successful).
https://codereview.chromium.org/235893005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #2 manually as r20724 (presubmit successful).
https://codereview.chromium.org/235643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/14 12:00:00, oetuaho-nv wrote:
Spun off from https://codereview.chromium.org/230473005/
lgtm. Thanks.
https://codereview.chromium.org/235893005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are su
lgtm.
https://codereview.chromium.org/236983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/234913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/04/14 12:15:20, ulan wrote:
On 2014/04/14 12:09:42, Alexandre Rames wrote:
Do you know how this affects octane/regexp benchmark?
Good point. This shows a ~8% performance penalty, so maybe it is better not
to
push it.
I note that I should profile the regexp benchmark once we have '
Status: Accepted
Owner: yang...@chromium.org
CC: rossb...@chromium.org
Labels: Type-Bug Priority-Low
New issue 3270 by yang...@chromium.org: Debugger and proxies.
http://code.google.com/p/v8/issues/detail?id=3270
Proxies are in many parts not compatible with the debugger. Example:
// Flags: --h
On 2014/04/14 12:09:42, Alexandre Rames wrote:
Do you know how this affects octane/regexp benchmark?
https://codereview.chromium.org/236163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to th
Reviewers: ulan, jochen,
Description:
Reland "A64: Now that we have veneers, fix a couple of branches to directly
jump
to their target."
This was reverted by revision 20187.
make -j45 arm64.release.check TESTFLAGS=--time
TESTJOBS=mozilla/js1_5/Regress/regress-280769-2
Without the patch:
--
On 2014/04/14 12:01:45, ulan wrote:
On 2014/04/14 11:58:31, ulan wrote:
> Committed patchset #2 manually as r20723 (presubmit successful).
> Yep, I think so. I can't give an lgtm that will help you though.
This is strange, but I was able to land. :) Looks like the presubmit is
not
checking
1 - 100 of 180 matches
Mail list logo
