[v8-dev] Re: Disable running some instruction selector test on unsupported backends. (issue 515793002 by chunyang....@intel.com)

2014-08-28 Thread jarin
lgtm https://codereview.chromium.org/515793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert Remove C++11-ism, until all bots support it. (issue 512123002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
PTAL https://codereview.chromium.org/512123002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] [v8] r23472 committed - Revert Remove C++11-ism, until all bots support it....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23472 Author: machenb...@chromium.org Date: Thu Aug 28 06:56:00 2014 UTC Log: Revert Remove C++11-ism, until all bots support it. This reverts commit r23463 as by now shouldn't be a syntax error anymore in chromium. TBR=vogelh...@chromium.org, svenpa...@chromium.org

[v8-dev] Re: Revert Remove C++11-ism, until all bots support it. (issue 512123002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Committed patchset #1 (id:1) manually as 23472 (presubmit successful). https://codereview.chromium.org/512123002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Reland Enable C++11 tests on windows. (issue 511113002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Committed patchset #1 (id:1) manually as 23473 (presubmit successful). https://codereview.chromium.org/53002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Reland Enable C++11 tests on windows. (issue 511113002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
PTAL https://codereview.chromium.org/53002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] [v8] r23473 committed - Reland Enable C++11 tests on windows....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23473 Author: machenb...@chromium.org Date: Thu Aug 28 07:01:56 2014 UTC Log: Reland Enable C++11 tests on windows. TBR=svenpa...@chromium.org BUG=400033 LOG=n Review URL: https://codereview.chromium.org/53002 https://code.google.com/p/v8/source/detail?r=23473

[v8-dev] Re: Sub-minor-key-ify four HydrogenCodeStubs. (issue 513653003 by yang...@chromium.org)

2014-08-28 Thread yangguo
Committed patchset #1 manually as 23474 (presubmit successful). https://codereview.chromium.org/513653003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23474 committed - Sub-minor-key-ify four HydrogenCodeStubs....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23474 Author: yang...@chromium.org Date: Thu Aug 28 07:02:53 2014 UTC Log: Sub-minor-key-ify four HydrogenCodeStubs. - FastNewContextStub - FastCloneShallowArrayStub - ToBooleanStub - ElementsTransitionAndStoreStub. R=mvstan...@chromium.org Review URL:

[v8-dev] [v8] r23475 committed - Version 3.29.24 (based on bleeding_edge revision r23472)...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23475 Author: machenb...@chromium.org Date: Thu Aug 28 07:03:22 2014 UTC Log: Version 3.29.24 (based on bleeding_edge revision r23472) Tweaks to generate XP-compatible .exes (Chromium issue 407517). Performance and stability improvements on all platforms.

[v8-dev] [v8] r23476 committed - Tagging version 3.29.24

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23476 Author: machenb...@chromium.org Date: Thu Aug 28 07:04:13 2014 UTC Log: Tagging version 3.29.24 https://code.google.com/p/v8/source/detail?r=23476 Added: /tags/3.29.24 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Sub-minor-key-ify seven HydrogenCodeStubs. (issue 511853002 by yang...@chromium.org)

2014-08-28 Thread yangguo
Committed patchset #1 manually as 23477 (presubmit successful). https://codereview.chromium.org/511853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23477 committed - Sub-minor-key-ify seven HydrogenCodeStubs....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23477 Author: yang...@chromium.org Date: Thu Aug 28 07:12:16 2014 UTC Log: Sub-minor-key-ify seven HydrogenCodeStubs. - FastCloneShallowObjectStub - StringAddStub - LoadFastElementStub - StoreFastElementStub - TransitionElementsKindStub - ArrayConstructorStubBase -

[v8-dev] Re: Port fdlibm implementation for Math.sinh. (issue 488003005 by yang...@chromium.org)

2014-08-28 Thread yangguo
https://codereview.chromium.org/488003005/diff/40001/test/mjsunit/es6/math-hyperbolic.js File test/mjsunit/es6/math-hyperbolic.js (right): https://codereview.chromium.org/488003005/diff/40001/test/mjsunit/es6/math-hyperbolic.js#newcode162 test/mjsunit/es6/math-hyperbolic.js:162:

[v8-dev] [v8] r23478 committed - Fix disassembly redirection from stdout into a file....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23478 Author: svenpa...@chromium.org Date: Thu Aug 28 07:30:58 2014 UTC Log: Fix disassembly redirection from stdout into a file. Pass \n, \r and \t through OStream without escaping. BUG= R=svenpa...@chromium.org Review URL: https://codereview.chromium.org/458533002 Patch

[v8-dev] Re: Fix disassembly redirection from stdout into a file. (issue 458533002 by vego...@google.com)

2014-08-28 Thread svenpanne
Committed patchset #2 (id:20001) manually as 23478 (presubmit successful). https://codereview.chromium.org/458533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: Revert Enable out-of-line constant pool for Arm. (issue 502723002 by machenb...@chromium.org)

2014-08-28 Thread ulan
On 2014/08/27 17:54:51, Michael Achenbach wrote: On 2014/08/26 10:49:38, rmcilroy wrote: On 2014/08/23 18:38:48, Michael Achenbach wrote: Committed patchset #1 manually as 23325 (tree was closed). Thanks for reverting (apologies for not spotting this, the bot took a while to go red and

[v8-dev] Re: Remove dependency from generic lowering on compilation info. (issue 473263004 by sigu...@chromium.org)

2014-08-28 Thread sigurds
Committed patchset #11 manually as 23479 (presubmit successful). https://codereview.chromium.org/473263004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23479 committed - Remove dependency from generic lowering on compilation info for determ...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23479 Author: sigu...@chromium.org Date: Thu Aug 28 08:39:24 2014 UTC Log: Remove dependency from generic lowering on compilation info for determining strictness and builtins. This makes the graphs compositional for inlining (i.e. we can now inline a strict function

[v8-dev] [v8] r23480 committed - Fix build....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23480 Author: sigu...@chromium.org Date: Thu Aug 28 08:47:11 2014 UTC Log: Fix build. GCC needs definitions for constant members (clang doesn't). TBR=mstarzin...@chromium.org Review URL: https://codereview.chromium.org/511133002

[v8-dev] Fix build. (issue 511133002 by sigu...@chromium.org)

2014-08-28 Thread sigurds
Reviewers: Michael Starzinger, Message: Committed patchset #1 manually as 23480 (tree was closed). Description: Fix build. GCC needs definitions for constant members (clang doesn't). TBR=mstarzin...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23480 Please review

[v8-dev] Re: Fix build. (issue 511133002 by sigu...@chromium.org)

2014-08-28 Thread svenpanne
https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (left): https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h#oldcode28 test/cctest/compiler/function-tester.h:28: const uint32_t

[v8-dev] Revert Revert Remove C++11-ism, until all bots support it. (issue 513103002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Reviewers: Sven Panne, vogelheim, Message: Committed patchset #1 (id:1) manually as 23481 (presubmit successful). Description: Revert Revert Remove C++11-ism, until all bots support it. This reverts commit 1f07f57a4a13985f3a48b06d2848dd3bff165b4f. AOSP bot is still not ready.

[v8-dev] [v8] r23481 committed - Revert Revert Remove C++11-ism, until all bots support it....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23481 Author: machenb...@chromium.org Date: Thu Aug 28 09:20:49 2014 UTC Log: Revert Revert Remove C++11-ism, until all bots support it. This reverts commit 1f07f57a4a13985f3a48b06d2848dd3bff165b4f. AOSP bot is still not ready.

[v8-dev] [v8] r23482 committed - Version 3.29.25 (based on bleeding_edge revision r23481)...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23482 Author: machenb...@chromium.org Date: Thu Aug 28 09:24:16 2014 UTC Log: Version 3.29.25 (based on bleeding_edge revision r23481) Performance and stability improvements on all platforms. https://code.google.com/p/v8/source/detail?r=23482 Modified: /trunk/ChangeLog

[v8-dev] Add more inlining unit tests. (issue 515103002 by sigu...@chromium.org)

2014-08-28 Thread sigurds
Reviewers: Michael Starzinger, Message: PTAL Description: Add more inlining unit tests. - Scheduler can inline a function with a loop. - Inlining strict into non-strict works correctly. - Inlining non-strict into strict works correctly. R=mstarzin...@chromium.org Please review this at

[v8-dev] Re: Fix build. (issue 511133002 by sigu...@chromium.org)

2014-08-28 Thread sigurds
https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (left): https://codereview.chromium.org/511133002/diff/1/test/cctest/compiler/function-tester.h#oldcode28 test/cctest/compiler/function-tester.h:28: const uint32_t

[v8-dev] [v8] r23483 committed - Tagging version 3.29.25

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23483 Author: machenb...@chromium.org Date: Thu Aug 28 09:24:46 2014 UTC Log: Tagging version 3.29.25 https://code.google.com/p/v8/source/detail?r=23483 Added: /tags/3.29.25 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Disable running some instruction selector test on unsupported backends. (issue 515793002 by chunyang....@intel.com)

2014-08-28 Thread chunyang . dai
hello. Jarin. Please help to commit it. thanks https://codereview.chromium.org/515793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] Re: Revert Enable out-of-line constant pool for Arm. (issue 502723002 by machenb...@chromium.org)

2014-08-28 Thread rmcilroy
On 2014/08/28 08:30:11, ulan wrote: On 2014/08/27 17:54:51, Michael Achenbach wrote: On 2014/08/26 10:49:38, rmcilroy wrote: On 2014/08/23 18:38:48, Michael Achenbach wrote: Committed patchset #1 manually as 23325 (tree was closed). Thanks for reverting (apologies for not spotting

[v8-dev] Re: Issue 1942 in v8: JavaScript Harmony freezes Google Maps

2014-08-28 Thread codesite-noreply via v8-dev
Comment #12 on issue 1942 by waw...@gmail.com: JavaScript Harmony freezes Google Maps https://code.google.com/p/v8/issues/detail?id=1942 I was tracking down a bug today and found this thread while searching for similar error messages. The error message was fairly strange to me:

[v8-dev] Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Reviewers: titzer, Description: Preliminary lowering of typed array loads in TF. R=tit...@chromium.org TEST=cctest/test-run-properties/TypedArrayLoad Please review this at https://codereview.chromium.org/516853002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread titzer
https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc#newcode502 src/compiler/js-typed-lowering.cc:502: FieldAccess

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
PTAL. Could a v8 team member review? https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Add more inlining unit tests. (issue 515103002 by sigu...@chromium.org)

2014-08-28 Thread mstarzinger
https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc File test/cctest/compiler/test-run-inlining.cc (right): https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc#newcode234 test/cctest/compiler/test-run-inlining.cc:234:

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
On 2014/08/27 17:47:13, Slava Chigrin wrote: https://codereview.chromium.org/514783002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/514783002/diff/1/src/serialize.cc#newcode1640 src/serialize.cc:1640: } Seems, this increment was missed, so pointers go

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the quick review. The same has done for arm/V8_OOL_CONSTANT_POOL arches in r r23242. Wee

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread commit-bot
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/vchig...@yandex-team.ru/514783002/1 https://codereview.chromium.org/514783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread commit-bot
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do

[v8-dev] Re: Fix disassembly redirection from stdout into a file. (issue 458533002 by vego...@google.com)

2014-08-28 Thread 'Vyacheslav Egorov' via v8-dev
Oh! Sorry, I thought I landed it but somehow I didn't :( Thanks a bunch for landing it for me. // Vyacheslav Egorov On Thu, Aug 28, 2014 at 9:31 AM, svenpa...@chromium.org wrote: Committed patchset #2 (id:20001) manually as 23478 (presubmit successful).

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
On 2014/08/28 09:57:28, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread vchigrin
On 2014/08/28 10:30:17, Yang wrote: On 2014/08/28 09:57:28, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the quick review. The same has done for

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Comments addressed. PTAL. https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc#newcode502 src/compiler/js-typed-lowering.cc:502:

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
On 2014/08/28 10:38:09, Slava Chigrin wrote: On 2014/08/28 10:30:17, Yang wrote: On 2014/08/28 09:57:28, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread rmcilroy
On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the

[v8-dev] [v8] r23484 committed - Fix serialization references to Cell objects....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23484 Author: yang...@chromium.org Date: Thu Aug 28 10:51:43 2014 UTC Log: Fix serialization references to Cell objects. R=yang...@chromium.org Review URL: https://codereview.chromium.org/514783002 Patch from Slava Chigrin vchig...@yandex-team.ru.

[v8-dev] Re: Fix serialization references to Cell objects. (issue 514783002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
Committed patchset #1 (id:1) manually as 23484 (presubmit successful). https://codereview.chromium.org/514783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Add android tools to v8's deps. (issue 512183004 by machenb...@chromium.org)

2014-08-28 Thread machenbach
PTAL https://codereview.chromium.org/512183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Add more inlining unit tests. (issue 515103002 by sigu...@chromium.org)

2014-08-28 Thread sigurds
https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc File test/cctest/compiler/test-run-inlining.cc (right): https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc#newcode234 test/cctest/compiler/test-run-inlining.cc:234:

[v8-dev] Re: Disable running some instruction selector test on unsupported backends. (issue 515793002 by chunyang....@intel.com)

2014-08-28 Thread jarin
Committed patchset #2 manually as 23485 (presubmit successful). https://codereview.chromium.org/515793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23485 committed - Disable running some instruction selector test on unsupported backends...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23485 Author: ja...@chromium.org Date: Thu Aug 28 11:06:26 2014 UTC Log: Disable running some instruction selector test on unsupported backends. BUG= R=ja...@chromium.org Review URL: https://codereview.chromium.org/515793002 Patch from Chunyang Dai

[v8-dev] Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering of simplified operators Numb... (issue 509653003 by tit...@chromium.org)

2014-08-28 Thread titzer
Reviewers: Michael Starzinger, Description: Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering of simplified operators NumberToInt32/NumberToUint32. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/509653003/ SVN Base:

[v8-dev] Re: Add android tools to v8's deps. (issue 512183004 by machenb...@chromium.org)

2014-08-28 Thread hinoka via v8-dev
lgtm https://codereview.chromium.org/512183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread titzer
https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-lowering.cc#newcode502 src/compiler/js-typed-lowering.cc:502: FieldAccess

[v8-dev] Re: Add android tools to v8's deps. (issue 512183004 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Committed patchset #1 (id:1) manually as 23486 (presubmit successful). https://codereview.chromium.org/512183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] [v8] r23486 committed - Add android tools to v8's deps....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23486 Author: machenb...@chromium.org Date: Thu Aug 28 11:09:46 2014 UTC Log: Add android tools to v8's deps. BUG=408510 LOG=n R=hin...@google.com Review URL: https://codereview.chromium.org/512183004 https://code.google.com/p/v8/source/detail?r=23486 Modified:

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread titzer
https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-operator.h File src/compiler/simplified-operator.h (right): https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-operator.h#newcode99 src/compiler/simplified-operator.h:99: class Access : public

[v8-dev] Re: Issue 3527 in v8: Ensure that Turbofan handles Harmony features gracefully

2014-08-28 Thread codesite-noreply via v8-dev
Updates: Summary: Ensure that Turbofan handles Harmony features gracefully Status: Assigned Owner: mstarzin...@chromium.org Cc: rossb...@chromium.org Labels: Type-Bug Harmony Turbofan Comment #4 on issue 3527 by v8.team@gmail.com: Ensure that Turbofan

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
On 2014/08/28 10:50:17, Yang wrote: On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review?

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 11:14:04, balazs.kilvady wrote: On 2014/08/28 10:50:17, Yang wrote: On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Comments addressed. PTAL. https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-operator.h File src/compiler/simplified-operator.h (right): https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-operator.h#newcode99

[v8-dev] [v8] r23487 committed - MIPS: Fix [de]serialize problem of root objects....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23487 Author: balazs.kilv...@imgtec.com Date: Thu Aug 28 11:27:21 2014 UTC Log: MIPS: Fix [de]serialize problem of root objects. BUG TEST=mjsunit/deserialize-reference R=yang...@chromium.org Review URL: https://codereview.chromium.org/492303004

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
Committed patchset #2 manually as r23487. https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: Add more inlining unit tests. (issue 515103002 by sigu...@chromium.org)

2014-08-28 Thread mstarzinger
LGTM. https://codereview.chromium.org/515103002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix rare access violation during JS heap serialization. (issue 510013002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
On 2014/08/27 17:06:01, Slava Chigrin wrote: https://codereview.chromium.org/510013002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/510013002/diff/1/src/serialize.cc#newcode1545 src/serialize.cc:1545: } Before that sometimes current[repeat_count] can

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread titzer
lgtm https://codereview.chromium.org/516853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 3527 in v8: Ensure that Turbofan handles Harmony features gracefully

2014-08-28 Thread codesite-noreply via v8-dev
Updates: Cc: tit...@chromium.org Labels: -Turbofan TurboFan Comment #5 on issue 3527 by mstarzin...@chromium.org: Ensure that Turbofan handles Harmony features gracefully https://code.google.com/p/v8/issues/detail?id=3527 Yep, the blacklist needs to be fixed before we

[v8-dev] Add MachineSignature, which is an encapsulation of the machine types for parameters and return valu... (issue 515173002 by tit...@chromium.org)

2014-08-28 Thread titzer
Reviewers: jarin, Description: Add MachineSignature, which is an encapsulation of the machine types for parameters and return values in a graph. This utility will be used to simplify Linkage and fix representation inference to work with graphs where parameters and return values are something

[v8-dev] [v8] r23488 committed - Fix rare access violation during JS heap serialization....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23488 Author: yang...@chromium.org Date: Thu Aug 28 11:45:20 2014 UTC Log: Fix rare access violation during JS heap serialization. R=yang...@chromium.org Review URL: https://codereview.chromium.org/510013002 Patch from Slava Chigrin vchig...@yandex-team.ru.

[v8-dev] Re: Fix rare access violation during JS heap serialization. (issue 510013002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
Committed patchset #1 (id:1) manually as 23488 (presubmit successful). https://codereview.chromium.org/510013002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: [turbofan] Explicitly mark call sites as patchable. (issue 514643002 by bmeu...@chromium.org)

2014-08-28 Thread bmeurer
https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc#newcode224 src/compiler/js-generic-lowering.cc:224:

[v8-dev] Re: Fix rare access violation during JS heap serialization. (issue 510013002 by vchig...@yandex-team.ru)

2014-08-28 Thread vchigrin
On 2014/08/28 11:45:29, Yang wrote: Committed patchset #1 (id:1) manually as 23488 (presubmit successful). Thank you so much for help! I have one little question about serializer: why it have so big macro CASE_BODY in Deserializer::ReadChunk? May be using inline templatized function

[v8-dev] Re: Fix rare access violation during JS heap serialization. (issue 510013002 by vchig...@yandex-team.ru)

2014-08-28 Thread yangguo
On 2014/08/28 11:54:03, Slava Chigrin wrote: On 2014/08/28 11:45:29, Yang wrote: Committed patchset #1 (id:1) manually as 23488 (presubmit successful). Thank you so much for help! I have one little question about serializer: why it have so big macro CASE_BODY in Deserializer::ReadChunk?

[v8-dev] Re: Add MachineSignature, which is an encapsulation of the machine types for parameters and return valu... (issue 515173002 by tit...@chromium.org)

2014-08-28 Thread jarin
lgtm https://codereview.chromium.org/515173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r23489 committed - Simplify inlining now that the scheduler is smart(er)....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23489 Author: sigu...@chromium.org Date: Thu Aug 28 12:18:25 2014 UTC Log: Simplify inlining now that the scheduler is smart(er). * Only control adjustment is to move everything from the inlinee's start block to the block the call was in. * Add a unit test to ensure that

[v8-dev] Re: Simplify inlining now that the scheduler is smart(er). (issue 508953002 by sigu...@chromium.org)

2014-08-28 Thread sigurds
Committed patchset #1 manually as 23489 (presubmit successful). https://codereview.chromium.org/508953002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Better typing and type verification (issue 509343002 by rossb...@chromium.org)

2014-08-28 Thread rossberg
Reviewers: Michael Starzinger, titzer, Description: Better typing and type verification - Extend typer to handle Simplified nodes. - Extend verifier to check types of JS and Simplified nodes. - Untyped nodes now contain NULL as types, enforcing hard failure. - Distinguish between typed and

[v8-dev] Re: Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering of simplified operators Numb... (issue 509653003 by tit...@chromium.org)

2014-08-28 Thread mstarzinger
LGTM. https://codereview.chromium.org/509653003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Better typing and type verification (issue 509343002 by rossb...@chromium.org)

2014-08-28 Thread titzer
https://codereview.chromium.org/509343002/diff/1/src/compiler/generic-node-inl.h File src/compiler/generic-node-inl.h (right): https://codereview.chromium.org/509343002/diff/1/src/compiler/generic-node-inl.h#newcode26 src/compiler/generic-node-inl.h:26: inputs_.static_ =

[v8-dev] Re: Add MachineSignature, which is an encapsulation of the machine types for parameters and return valu... (issue 515173002 by tit...@chromium.org)

2014-08-28 Thread titzer
Committed patchset #1 manually as 23490 (presubmit successful). https://codereview.chromium.org/515173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23490 committed - Add MachineSignature, which is an encapsulation of the machine types f...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23490 Author: tit...@chromium.org Date: Thu Aug 28 13:17:38 2014 UTC Log: Add MachineSignature, which is an encapsulation of the machine types for parameters and return values in a graph. This utility will be used to simplify Linkage and fix representation inference to

[v8-dev] Re: Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering of simplified operators Numb... (issue 509653003 by tit...@chromium.org)

2014-08-28 Thread titzer
Committed patchset #1 manually as 23491 (presubmit successful). https://codereview.chromium.org/509653003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23491 committed - Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering...

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23491 Author: tit...@chromium.org Date: Thu Aug 28 13:31:55 2014 UTC Log: Use TruncateFloat64ToInt32 instead of ChangeFloat64ToInt32 in lowering of simplified operators NumberToInt32/NumberToUint32. R=mstarzin...@chromium.org BUG= Review URL:

[v8-dev] Do not expose termination exceptions to the API. (issue 516913003 by yang...@chromium.org)

2014-08-28 Thread yangguo
Reviewers: Toon Verwaest, Description: Do not expose termination exceptions to the API. R=verwa...@chromium.org BUG=403509 Please review this at https://codereview.chromium.org/516913003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+21, -0 lines): M

[v8-dev] Re: Let benchmark runner add summary traces. (issue 496183003 by machenb...@chromium.org)

2014-08-28 Thread jarin
lgtm https://codereview.chromium.org/496183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: More PNaCL fixes. (issue 513923005 by svenpa...@chromium.org)

2014-08-28 Thread svenpanne
There are still some obscure linker errors for 64bit div/mod operations, but please PTAL nevertheless... https://codereview.chromium.org/513923005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: More PNaCL fixes. (issue 513923005 by svenpa...@chromium.org)

2014-08-28 Thread svenpanne
On 2014/08/28 13:49:02, Sven Panne wrote: There are still some obscure linker errors for 64bit div/mod operations, but please PTAL nevertheless... ... and sem_timedwait still has no replacement. This will come soon, just want to get some early feedback.

[v8-dev] Issue 3543 in v8: Install of V8 on REHL 6 not connected to the internet.

2014-08-28 Thread codesite-noreply via v8-dev
Status: New Owner: New issue 3543 by n42...@gmail.com: Install of V8 on REHL 6 not connected to the internet. https://code.google.com/p/v8/issues/detail?id=3543 I am attempting to install V8 on a Linux server that is not connected to the internet and can not be connected to the

[v8-dev] Re: Preliminary lowering of typed array loads in TF. (issue 516853002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Committed patchset #5 (id:80001) manually as 23492 (presubmit successful). https://codereview.chromium.org/516853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r23492 committed - Preliminary lowering of typed array loads in TF....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23492 Author: mstarzin...@chromium.org Date: Thu Aug 28 14:35:11 2014 UTC Log: Preliminary lowering of typed array loads in TF. R=tit...@chromium.org TEST=cctest/test-run-properties/TypedArrayLoad Review URL: https://codereview.chromium.org/516853002

[v8-dev] Re: Let benchmark runner add summary traces. (issue 496183003 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Committed patchset #2 (id:20001) manually as 23493 (presubmit successful). https://codereview.chromium.org/496183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r23493 committed - Let benchmark runner add summary traces....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23493 Author: machenb...@chromium.org Date: Thu Aug 28 14:42:24 2014 UTC Log: Let benchmark runner add summary traces. BUG=374740 LOG=n R=ja...@chromium.org Review URL: https://codereview.chromium.org/496183003 https://code.google.com/p/v8/source/detail?r=23493 Modified:

[v8-dev] Move constructors for [Element/Field]Access into AccessBuilder. (issue 516943002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Reviewers: titzer, Description: Move constructors for [Element/Field]Access into AccessBuilder. R=tit...@chromium.org TEST=cctest/test-simplified-lowering Please review this at https://codereview.chromium.org/516943002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected

[v8-dev] Re: Deoptimize context value in Turbofan (and Crankshaft). (issue 515723004 by ja...@chromium.org)

2014-08-28 Thread jarin
Could you take a look, please? https://codereview.chromium.org/515723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] [v8] r23494 committed - Skip Windows failure after r23492....

2014-08-28 Thread codesite-noreply via v8-dev
Revision: 23494 Author: mstarzin...@chromium.org Date: Thu Aug 28 15:19:05 2014 UTC Log: Skip Windows failure after r23492. TBR=vogelh...@chromium.org TEST=cctest/test-run-properties/TypedArrayLoad Review URL: https://codereview.chromium.org/513223002

[v8-dev] Re: Fix Windows failure after r23492. (issue 513223002 by mstarzin...@chromium.org)

2014-08-28 Thread mstarzinger
Committed patchset #2 (id:20001) manually as 23494 (tree was closed). https://codereview.chromium.org/513223002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] [Auto-roll] Bump up version to 3.29.26.0 (issue 516973002 by machenb...@chromium.org)

2014-08-28 Thread machenbach
Reviewers: Michael Achenbach, Description: [Auto-roll] Bump up version to 3.29.26.0 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/516973002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/version.cc

  1   2   >