On 2015/02/06 07:37:28, Sven Panne wrote:
LGTM with nits.
https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc
File src/runtime/runtime-maths.cc (right):
https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc#newcode70
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/885643004/60001
https://codereview.chromium.org/885643004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 4 (id:??) landed as
https://crrev.com/158a87659f02ad4d5e41d2dc19eec1f0f4ded41f
Cr-Commit-Position: refs/heads/master@{#26483}
https://codereview.chromium.org/885643004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Invalid
Labels: Type-FeatureRequest
Comment #2 on issue 1425 by habl...@chromium.org: Low hanging
performance-fruit in Isolate::Enter.
https://code.google.com/p/v8/issues/detail?id=1425
Update done during clean-up of issue tracker.
Closed FR because of age.
lgtm
https://codereview.chromium.org/874693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
Committed patchset #3 (id:40001) manually as
878963a8a5f0a643ea9601177f68d1fc675dc55f (presubmit successful).
Description:
split interceptor tests off of test-api
BUG=
R=verwa...@chromium.org
Committed:
Patchset 3 (id:??) landed as
https://crrev.com/878963a8a5f0a643ea9601177f68d1fc675dc55f
Cr-Commit-Position: refs/heads/master@{#26484}
https://codereview.chromium.org/900033003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Michael Starzinger,
Description:
[turbofan] Fix loop analysis bug with certain phi structures.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/909463002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+39, -0
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/909473002/1
https://codereview.chromium.org/909473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/51c59ede18831d1c1a1d70fa9fa456f946ac486b
Cr-Commit-Position: refs/heads/master@{#26492}
https://codereview.chromium.org/893843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 1 (id:??) landed as
https://crrev.com/d9892bbd5a78b5a1e389cbf4854ec7fcbd645567
Cr-Commit-Position: refs/heads/master@{#26493}
https://codereview.chromium.org/886733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/886733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/883823002/diff/60001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/883823002/diff/60001/src/ast.h#newcode1696
src/ast.h:1696: VariableProxy(AstValueFactory *ast_value_factory,
On 2015/02/05 11:08:30, wingo wrote:
Humm, seems to me that
Comment #4 on issue 3870 by caitpott...@gmail.com: RegExp.multiline
(global) accessor should probably be deleted (or properly implemented)
https://code.google.com/p/v8/issues/detail?id=3870
Er, the implementation in V8 is compatible with JSC* =)
--
You received this message because this
Committed patchset #1 (id:1)
https://codereview.chromium.org/893843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #5 on issue 3870 by a...@chromium.org: RegExp.multiline (global)
accessor should probably be deleted (or properly implemented)
https://code.google.com/p/v8/issues/detail?id=3870
erikcorry: This bug is about removing RegExp.multiline, not the multiline
property on regexp instance
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/909463003/20001
https://codereview.chromium.org/909463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #2 (id:20001)
https://codereview.chromium.org/909463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/5c56665059891cbacf43f6efe483582029442f0b
Cr-Commit-Position: refs/heads/master@{#26494}
https://codereview.chromium.org/909463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info-is_eval() || info-is_global() ||
info-is_module());
Yeah, this is starting to get
Reviewers: Sven Panne, Michael Starzinger, alph,
Message:
PTAL
The patch is mostly cosmetic and has a few fixes in string comparison.
Description:
Simplify cpu-profiler test code with help of wrappers.
BUG=none
LOG=n
Please review this at https://codereview.chromium.org/892953004/
Base URL:
I like the idea a lot. But I am a bit worried about the code pollution.
Additionally to the gc_tracer, we would have to maintain these type of
tracing
calls as well. Would it make sense to integrate some of the calls (e.g. for
the
roots) in the GCTracer? That would mean we would have to add
LGTM.
https://codereview.chromium.org/909463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/2b0427a912a42bd0f45e35fec9bce3b7ff99ba9a
Cr-Commit-Position: refs/heads/master@{#26487}
https://codereview.chromium.org/879693005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: rossberg,
Message:
rossberg, ptal.
Description:
PreParser / Parser consistency: Make PreParser aware of Zone and
AstValueFactory.
Previously it just had hacks to have NULLs instead of them and pretended to
know
nothing about Zone. The hacks provided no real benefit (probably
Committed patchset #1 (id:1) manually as
2b0427a912a42bd0f45e35fec9bce3b7ff99ba9a (presubmit successful).
https://codereview.chromium.org/879693005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: dcarney,
Description:
Check that we're called on a valid heap during idle notifications
BUG=chromium:425035
R=dcar...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/892413006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
lgtm
https://codereview.chromium.org/892413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/909463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892413006/1
https://codereview.chromium.org/892413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/c6c1d8ffd65b4e4919bbfd167e73b19d6414e132
Cr-Commit-Position: refs/heads/master@{#26489}
https://codereview.chromium.org/909463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/909473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892953004/80001
https://codereview.chromium.org/892953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #2 (id:80001)
https://codereview.chromium.org/892953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/fb73392bfd41e84bdb029c4fded78bd2df010040
Cr-Commit-Position: refs/heads/master@{#26495}
https://codereview.chromium.org/892953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/899363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: rossberg_chrmoium.org,
Message:
Could you take a look, please?
Description:
[turbofan] Make the representation type component independent of the
semantic
component.
R=rossb...@chrmoium.org
BUG=
Please review this at https://codereview.chromium.org/904863002/
Base URL:
Updates:
Status: Fixed
Comment #7 on issue 1458 by u...@chromium.org: NewGC: Do meaningful work on
idle notifications.
https://code.google.com/p/v8/issues/detail?id=1458
Closing this old issue. After recent work by Hannes, Ross and Jochen,
Chrome calls idle notification from
Committed patchset #1 (id:1)
https://codereview.chromium.org/887013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/874693006/1
https://codereview.chromium.org/874693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/30787d4e564efe7f85182bd5b1b99e9f40e265ca
Cr-Commit-Position: refs/heads/master@{#26485}
https://codereview.chromium.org/874693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/878743006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Comment #6 on issue 1669 by u...@chromium.org: LowMemoryNotify isn't as
effective as it should be.
https://code.google.com/p/v8/issues/detail?id=1669
This was fixed long time ago. LowMemoryNotification does several full-GCs
and purges caches.
--
You
Patchset 1 (id:??) landed as
https://crrev.com/008f4732f78f71d8d37bc574b75d5bccff94025b
Cr-Commit-Position: refs/heads/master@{#26486}
https://codereview.chromium.org/887013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Fixed
Comment #2 on issue 2333 by u...@chromium.org: A Floating-point invalid
operation exception at Update Survival Rate Trend
https://code.google.com/p/v8/issues/detail?id=2333
It was fixed long time ago.
--
You received this message because this project is
lgtm
https://codereview.chromium.org/887013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/887013003/1
https://codereview.chromium.org/887013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
LGTM.
https://codereview.chromium.org/879693005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/874693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Updates:
Status: Fixed
Comment #4 on issue 1904 by u...@chromium.org: NewGC:
http://29a.ch/2010/6/2/realtime-raytracing-in-javascript stalls for 30s of
GCs on MacOS
https://code.google.com/p/v8/issues/detail?id=1904
Closing the issue. The demo runs at 100fps in Chrome 40 on mac.
PTAL
https://codereview.chromium.org/887013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Comment #7 on issue 3485 by bzbar...@gmail.com: EcmaScript internal method
invariants violated in some cases
https://code.google.com/p/v8/issues/detail?id=3485
Note that step 3.9 is not reached on the second call to
Object.getOwnPropertyDescriptor in
Reviewers: dcarney,
Description:
[x64] Assembler support for internal references and RIP relative addressing.
R=dcar...@chromium.org
BUG=v8:3872
LOG=n
Please review this at https://codereview.chromium.org/887013003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
Reviewers: jarin, Dmitry Lomov (chromium),
Message:
Jaro: PTAL.
Dmitry: FYI.
Description:
Make the Linkage::NeedsFrameState list more intuitive.
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/878743006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Reviewers: ulan, Dmitry Lomov (chromium), Ken Russell,
Message:
PTAL.
https://codereview.chromium.org/904633003/diff/40001/src/runtime/runtime-typedarray.cc
File src/runtime/runtime-typedarray.cc (right):
Updates:
Status: WorkingAsIntended
Comment #1 on issue 1850 by u...@chromium.org: Performance regression
in Page Cycler Intl1 Linux LowMem
https://code.google.com/p/v8/issues/detail?id=1850
Closing as obsolete.
--
You received this message because this project is configured to send
Updates:
Status: WorkingAsIntended
Comment #1 on issue 2040 by u...@chromium.org: Mandreel demo performance
regresses with the experimental profiler.
https://code.google.com/p/v8/issues/detail?id=2040
(No comment was entered for this change.)
--
You received this message because
lgtm
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode186
test/cctest/test-cpu-profiler.cc:186: CHECK_EQ(0,
Comment #2 on issue 3299 by wi...@igalia.com: Implement dynamic GDB JIT
interface
https://code.google.com/p/v8/issues/detail?id=3299
It's definitely more of a feature request :) The gain would be that you
would be able to get full backtraces from C++, even if there are
interleaved JS
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/878743006/40001
https://codereview.chromium.org/878743006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: jochen (slow),
Description:
Add release build checks to back reference deserialization.
R=joc...@chromium.org
BUG=chromium:441896
LOG=N
Please review this at https://codereview.chromium.org/909493002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2,
Reviewers: jochen (slow),
Message:
PTAL
Description:
Temporarily disable double fields unboxing.
Please review this at https://codereview.chromium.org/893843004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/globals.h
Index:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/909463002/1
https://codereview.chromium.org/909463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/909473002/20001
https://codereview.chromium.org/909473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h
File src/bit-vector.h (right):
https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h#newcode157
src/bit-vector.h:157: for (int i = 0; i data_length_; i++) {
On 2015/02/06 14:59:32, Michael Starzinger wrote:
Just out
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/893843004/1
https://codereview.chromium.org/893843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1)
https://codereview.chromium.org/909463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892953004/80001
https://codereview.chromium.org/892953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM. Sigh ... :/
https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h
File src/bit-vector.h (right):
https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h#newcode157
src/bit-vector.h:157: for (int i = 0; i data_length_; i++) {
Just out of curiosity, is there a reason
lgtm
https://codereview.chromium.org/893843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/886733005/1
https://codereview.chromium.org/886733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #3 (id:40001)
https://codereview.chromium.org/878743006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/c699a87be97d2afc94359eb29697993842d74f61
Cr-Commit-Position: refs/heads/master@{#26488}
https://codereview.chromium.org/878743006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 2 (id:??) landed as
https://crrev.com/7f4d207c8bd510cd1843ff3e30608f0e5290cb1e
Cr-Commit-Position: refs/heads/master@{#26490}
https://codereview.chromium.org/909473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode53
test/cctest/test-cpu-profiler.cc:53: static v8::Handlev8::Script
Comment #2 on issue 3870 by erikco...@google.com: RegExp.multiline (global)
accessor should probably be deleted (or properly implemented)
https://code.google.com/p/v8/issues/detail?id=3870
At the moment it is compatible with Safari:
re = /foo/m
re.multiline // true
re2 = /foo/
Patchset 1 (id:??) landed as
https://crrev.com/0c4327439472c4c7c9b7f9bb26bc906389d2e371
Cr-Commit-Position: refs/heads/master@{#26491}
https://codereview.chromium.org/892413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/892413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #3 on issue 3870 by caitpott...@gmail.com: RegExp.multiline
(global) accessor should probably be deleted (or properly implemented)
https://code.google.com/p/v8/issues/detail?id=3870
This thread is about RegExp.multiline, the static accessor of the RegExp
object
https://codereview.chromium.org/883823002/diff/120001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/883823002/diff/120001/src/ast.h#newcode3424
src/ast.h:3424: (name == ast_value_factory_-this_string())
Can we instead change from bool is_this, to Variable::Kind
variable_kind
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/899363002/40001
https://codereview.chromium.org/899363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/70079dab1386d1b5ffc80d05591597d015aeffde
Cr-Commit-Position: refs/heads/master@{#26496}
https://codereview.chromium.org/902093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/902093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/64abe65210adde13cb83aa0d3e747babd9979da8
Cr-Commit-Position: refs/heads/master@{#26497}
https://codereview.chromium.org/899363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/899363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/902093002/20001
https://codereview.chromium.org/902093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info-is_eval() || info-is_global() ||
info-is_module());
On 2015/02/06 12:36:56, rossberg
On 2015/02/06 16:05:08, aperez wrote:
https://codereview.chromium.org/883823002/diff/60001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/883823002/diff/60001/src/ast.h#newcode1696
src/ast.h:1696: VariableProxy(AstValueFactory *ast_value_factory,
On 2015/02/05 11:08:30,
Reviewers: Yang,
Message:
PTAL
Description:
Remove redundant source position information in RelocInfo
Previously, emitting two more more unique source positions at the same pc
would
generate two or more RelocInfo entries. Now, only the last emitted source
position for any pc is added to the
PTAL
There is some cleanup opportunities with how arrow functions checks their
paramaters but I thought I'd do that in another CL.
https://codereview.chromium.org/899363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Comment #7 on issue 3604 by joc...@chromium.org: Tests calling
sem_destroy() on semaphore with waiters
https://code.google.com/p/v8/issues/detail?id=3604
if you post the output, I can do the sifting
--
You received this message because this project is configured to send all
issue
Comment #6 on issue 3604 by havard.e...@gmail.com: Tests calling
sem_destroy() on semaphore with waiters
https://code.google.com/p/v8/issues/detail?id=3604
I've added stack backtrace printouts to the semaphore operations,
plus printout of the semaphore pointer given in the operations.
Comment #6 on issue 3870 by brian.te...@gmail.com: RegExp.multiline
(global) accessor should probably be deleted (or properly implemented)
https://code.google.com/p/v8/issues/detail?id=3870
Chakra doesn't implement RegExp.multiline at all so the risk of web
breakage due to removing it
Reviewers: Toon Verwaest,
Message:
ptal, i'll add some more tests on monday for nested iterators
Description:
add support for all can read interceptors
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/906463002/
Base URL:
101 - 194 of 194 matches
Mail list logo
