https://codereview.chromium.org/1323763002/diff/20001/src/mips/assembler-mips.cc
File src/mips/assembler-mips.cc (right):
https://codereview.chromium.org/1323763002/diff/20001/src/mips/assembler-mips.cc#newcode2030
src/mips/assembler-mips.cc:2030: DCHECK(!src.rm().is(t8));
On 2015/09/08 15:48:41
Reviewers: Michael Achenbach,
Message:
Hello!
This one seems to be very important for node.js, as we inherit our Buffer
from
the Uint8Array.
Note that while we are doing some prototype twiddling:
https://github.com/nodejs/node/blob/f8152df5e815c98be702fe58753258b58f02c4ad/lib/buffer.js#L51
Comment #10 on issue 4413 by bugdro...@chromium.org: Call sequence is
inconsistent and almost always wrong
https://code.google.com/p/v8/issues/detail?id=4413#c10
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b37907ff7f866873ddfbfc97670b43c19a5fc7
Patchset 2 (id:??) landed as
https://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9
Cr-Commit-Position: refs/heads/master@{#30648}
https://codereview.chromium.org/1330033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1330033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1330033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1330033002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1330033002/20001
https://codereview.chromium.org/1330033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Reviewers: Jarin,
Message:
Hey Jaro,
This unifies the handling of "actual number of arguments" for JSFunction
calls.
It basically removes premature optimization (saving one LoadImmediate for
some
calls).
Please take a look.
Thanks,
Benedikt
Description:
[calls] Consistent call protocol fo
Comment #12 on issue 4395 by ad...@chromium.org: assignments in default
parameter initializers
https://code.google.com/p/v8/issues/detail?id=4395
For all arrow functions that aren't immediately executed, we already parse
twice. I would imagine it's uncommon to immediately execute arrows, bu
On 2015/09/09 00:24:48, caitp wrote:
Thanks for the look. It's not clear this can land soon, but i can keep
working
on it
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromiu
Thanks for the look. It's not clear this can land soon, but i can keep
working
on it
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmo
Another high-level comment below. Performance aside, we should try to get
the
behavior correct.
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1308123007/diff/1/test/mj
Sounds good to me. I'll have a patchset later tonight
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
src/preparser.h:2663: goto shorthand_property;
On 2015/09/0
Patchset 3 (id:??) landed as
https://crrev.com/ce95a4db6995c824d52098b2ca05b162ee9ff6cc
Cr-Commit-Position: refs/heads/master@{#30647}
https://codereview.chromium.org/1317113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
I agree that some refactoring here would be helpful for readability, but
I'm not
sure the switch statement you landed on was it. So I'd suggest going with a
minimal fix and dealing with the refactoring separately.
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/p
Comment #19 on issue 2160 by bugdro...@chromium.org: Add support for
default parameters
https://code.google.com/p/v8/issues/detail?id=2160#c19
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/ce95a4db6995c824d52098b2ca05b162ee9ff6cc
commit ce95a4d
Committed patchset #3 (id:60001)
https://codereview.chromium.org/1317113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1317113007/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1317113007/60001
https://codereview.chromium.org/1317113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Comment #11 on issue 4285 by little...@chromium.org: Sloppy function in
block
https://code.google.com/p/v8/issues/detail?id=4285
One extra piece of complexity I realized since that previous post: the
DelegateStatement will need a pointer to the scope that it occurs in, so
that the assignm
lgtm
https://codereview.chromium.org/1317113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: dstence, joransiu, john.yan, michael_dawson, mvstanton,
Description:
PPC: Reland Vector ICs: platform support for vector-based stores.
Port 40fbed0609ddb3e4ee4338049383004b62d13853
Original commit message:
The last changes for vector store functionality, they are in 3 areas:
Reviewers: Benedikt Meurer, dstence, joransiu, john.yan, michael_dawson,
Description:
PPC: [builtins] Unify the various versions of [[Call]] with a Call builtin.
Port ccbb4ff00f1d8f32fd9227cd7aba1723791e5744
Original commit message:
The new Call and CallFunction builtins supersede the curre
Reviewers: Benedikt Meurer, dstence, joransiu, john.yan, michael_dawson,
Description:
PPC: [runtime] Replace many buggy uses of %_CallFunction with %_Call.
Port db2ba190dba6983b94eae36e111b0feebb97587e
Original commit message:
The semantics of the %_CallFunction intrinsic seem to be very un
Patchset 1 (id:??) landed as
https://crrev.com/e4a8161adbbb940cf836075a89f3643d3c2566b4
Cr-Commit-Position: refs/heads/master@{#30646}
https://codereview.chromium.org/1324553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1324553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/4329a7c2cf2f5641284251afe388edd65b17a4d7
Cr-Commit-Position: refs/heads/master@{#30645}
https://codereview.chromium.org/1318153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1318153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1324553004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1324553004/1
https://codereview.chromium.org/1324553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
On 2015/09/08 09:50:39, Jakob wrote:
LGTM.
Yang, is more caching something we want strategically? I wouldn't be
surprised
if this cache were a benchmark-specific hack that we'd rather get rid of.
If
you
don't like this change, feel free to revert it.
Seems alright to me. We have this ca
Nice, LGTM.
https://codereview.chromium.org/1324553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1318153006/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1318153006/1
https://codereview.chromium.org/1318153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Updates:
Cc: a...@chromium.org
Comment #11 on issue 4406 by a...@chromium.org: profiler has huge impact on
performance for some code (mac)
https://code.google.com/p/v8/issues/detail?id=4406
(No comment was entered for this change.)
--
You received this message because this project is
Comment #10 on issue 4406 by a...@chromium.org: profiler has huge impact on
performance for some code (mac)
https://code.google.com/p/v8/issues/detail?id=4406
yes, --noenable_avx fixes it.
This issue puzzles me very much. Can't figure out how could presence of AVX
instructions slow down sig
Reviewers: akos.palfi.imgtec, balazs.kilvady,
Message:
PTAL.
Description:
MIPS: minor cleanup in macro-assembler.
Fix some dodgy temp-register usage and remove some unnecessary
push/pop's.
BUG=
Please review this at https://codereview.chromium.org/1324553004/
Base URL: https://chromium.googl
On 2015/09/08 20:46:41, caitp wrote:
On 2015/09/08 20:41:36, caitp wrote:
> On 2015/09/08 20:23:54, adamk wrote:
> > I haven't looked at the patch yet (just back from vacation), but I
don't
think
> > we can switch from %AppendElement to simple assignment. V8 should
match
the
> > spec, not
On 2015/09/08 at 20:43:45, aperez wrote:
On 2015/09/08 07:10:34, cbruni wrote:
> Doesn't merge right now, I think due to some merge artifacts (I added
two
> comments).
Right, I am going to rebase the patch, upload a CL with the rebase.
Then I'll go through the suggested changes and upload a
On 2015/09/08 20:41:36, caitp wrote:
On 2015/09/08 20:23:54, adamk wrote:
> I haven't looked at the patch yet (just back from vacation), but I don't
think
> we can switch from %AppendElement to simple assignment. V8 should match
the
> spec, not Babel.
>
> What do you mean by "wasn't really co
On 2015/09/08 07:10:34, cbruni wrote:
Doesn't merge right now, I think due to some merge artifacts (I added two
comments).
Right, I am going to rebase the patch, upload a CL with the rebase.
Then I'll go through the suggested changes and upload a new CL just
with that, to make it easier to revi
On 2015/09/08 20:23:54, adamk wrote:
I haven't looked at the patch yet (just back from vacation), but I don't
think
we can switch from %AppendElement to simple assignment. V8 should match
the
spec, not Babel.
What do you mean by "wasn't really correct before"?
I mean, it didn't really be
Updates:
Status: Duplicate
Mergedinto: 4413
Comment #10 on issue 4234 by ad...@chromium.org: Wrapper created from wrong
realm (SHOULD_CREATE_WRAPPER built-in)
https://code.google.com/p/v8/issues/detail?id=4234
bmeurer is working on this by replacing %_CallFunction with %_Call.
Updates:
Cc: rossb...@chromium.org little...@chromium.org a...@chromium.org
Comment #9 on issue 4413 by ad...@chromium.org: Call sequence is
inconsistent and almost always wrong
https://code.google.com/p/v8/issues/detail?id=4413
Issue 4234 has been merged into this issue.
--
You rece
I haven't looked at the patch yet (just back from vacation), but I don't
think
we can switch from %AppendElement to simple assignment. V8 should match the
spec, not Babel.
What do you mean by "wasn't really correct before"?
https://codereview.chromium.org/1308123007/
--
--
v8-dev mailing list
On 2015/09/08 at 17:57:49, caseq wrote:
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h#newcode49
include/v8-tracing.h:49: virtual EventTracer::Handle AddTr
Status: Available
Owner:
Labels: Type-Bug Priority-Medium Harmony Area-Compiler
New issue 4414 by caitpott...@gmail.com: Implement inline-able
CreateDataProperty runtime method
https://code.google.com/p/v8/issues/detail?id=4414
CreateDataProperty() is used all over the spec, and is very
Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere
that
you are only handling SLOPPY for now.
Nice tests, again!
LGTM.
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chr
Patchset 1 (id:??) landed as
https://crrev.com/affd6dfcb5676347025dd8c8899e15fae1c56d53
Cr-Commit-Position: refs/heads/master@{#30644}
https://codereview.chromium.org/1314673010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1314673010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/444a933931b405bd33485e8c299ee850b47a9531
Cr-Commit-Position: refs/heads/master@{#30643}
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Comment #10 on issue 4285 by little...@chromium.org: Sloppy function in
block
https://code.google.com/p/v8/issues/detail?id=4285
At first, I was thinking that this didn't have to ship together with other
block-scoped constructs (let and class). However, I came across test cases
that look
lgtm
https://codereview.chromium.org/1322203005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, thanks for fixing this.
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and sto
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1309163006/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1309163006/1
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1314673010/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1314673010/1
https://codereview.chromium.org/1314673010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
LGTM
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2015/09/08 18:17:49, yurys wrote:
Committed patchset #1 (id:1) manually as
ff223e5a24342a6567c1e57ac58f8a2ec134f50f.
lgtm.
https://codereview.chromium.org/1324153005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message beca
Comment #32 on issue 2159 by caitpott...@gmail.com: Add support for rest
parameters
https://code.google.com/p/v8/issues/detail?id=2159
They were shipped temporarily, and then unshipped due to a bug in spread
calls (iirc), and haven't been reshipped due to a bug with arrow functions.
Unfor
Reviewers: akos.palfi.imgtec, balazs.kilvady, Benedikt Meurer,
Message:
PTAL
Description:
MIPS: Fix MacroAssembler::AssertFunction()
Porting mistake in ccbb4ff0 '[builtins] Unify the various versions of
[[Call]]
with a Call builtin.', which only showed as debug assertion in later commit
db2b
Comment #31 on issue 2159 by thelastf...@gmail.com: Add support for rest
parameters
https://code.google.com/p/v8/issues/detail?id=2159
This is marked as shipped on Chrome Status
(https://www.chromestatus.com/features/5937087912083456), but attempting to
use it in the console on Version 47
LGTM. But please add the bug number to the issue, so it gets tracked
properly.
https://codereview.chromium.org/1314673010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8
LGTM, thanks!
https://codereview.chromium.org/1318153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emai
Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
Description:
MIPS: Fix 'Optimize simulator.'
For simulator optimization we modified Instruction::InstructionType()
function
so a simpler but less complete InstructionType() function used by default.
This
fix enables the full
Committed patchset #1 (id:1) manually as
ff223e5a24342a6567c1e57ac58f8a2ec134f50f.
https://codereview.chromium.org/1324153005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: Yang OOO until mid October,
Description:
Version 4.6.85.14 (cherry-pick)
Merged 70dc24c22ff61b4b4d5a9f43597bdbb067b35304
Postpone interrupts while dipatching debugger events to listeners
BUG=chromium:520702
LOG=N
TBR=yang...@chromium.org
Please review this at https://codereview.chr
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h#newcode49
include/v8-tracing.h:49: virtual EventTracer::Handle AddTraceEvent(
On 2015/09/08 14:20:34, jochen wr
Patchset 1 (id:??) landed as
https://crrev.com/0faceaec7fb961738d9ee9a36b5080a91c8a5abc
Cr-Commit-Position: refs/heads/master@{#30642}
https://codereview.chromium.org/1314543014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1314543014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1314543014/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1314543014/1
https://codereview.chromium.org/1314543014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1314543014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Message:
Still cleaning up the repro to make a regression test.
Description:
[turbofan] Handle stack overflow exceptions in JSInliner.
R=bmeu...@chromium.org
BUG=chromium:527364
LOG=n
Please review this at https://codereview.chromium.org/1322203005/
Base URL: https
Committed patchset #13 (id:240001)
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group an
Patchset 13 (id:??) landed as
https://crrev.com/057514d3fa79af4732e136f5daad4b805a65e569
Cr-Commit-Position: refs/heads/master@{#30641}
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messa
https://codereview.chromium.org/1323763002/diff/20001/src/mips/assembler-mips.cc
File src/mips/assembler-mips.cc (right):
https://codereview.chromium.org/1323763002/diff/20001/src/mips/assembler-mips.cc#newcode2030
src/mips/assembler-mips.cc:2030: DCHECK(!src.rm().is(t8));
Why check for t8 here?
Reviewers: Jakob,
Message:
Hi Jakob,
Here is the fix we were talking about, thx for the look!
--Michael
Description:
Crankshaft: consolidated element loads always deopted on seeing the hole
Update the consolidated load case to carefully chose the load mode
based on the consolidated elements kin
Comment #10 on issue 4382 by mstarzin...@chromium.org: make always
regenerates snapshot
https://code.google.com/p/v8/issues/detail?id=4382
Yes, seems to work for me now without
having "v8_use_external_startup_data=0" in my GYP_DEFINES with top-of-tree
from two minutes ago. Thanks!
--
Yo
Updates:
Status: Fixed
Comment #9 on issue 4382 by vogelh...@chromium.org: make always regenerates
snapshot
https://code.google.com/p/v8/issues/detail?id=4382
Hopefully fixed now.
@titzer, mstarzinger: Please do try it out. Unfortunately I've had
several "almost" fixes in this area
Patchset 1 (id:??) landed as
https://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed
Cr-Commit-Position: refs/heads/master@{#30640}
https://codereview.chromium.org/1310273009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Comment #8 on issue 4382 by bugdro...@chromium.org: make always regenerates
snapshot
https://code.google.com/p/v8/issues/detail?id=4382#c8
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed
commit 244cc0a6a96
Committed patchset #1 (id:1)
https://codereview.chromium.org/1310273009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1265423002/240001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1265423002/240001
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1310273009/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1310273009/1
https://codereview.chromium.org/1310273009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Updates:
Status: Assigned
Owner: mstarzin...@chromium.org
Comment #3 on issue 4374 by mstarzin...@chromium.org: Math.max inside
asm.js produces the wrong result with --turbo_inlining
https://code.google.com/p/v8/issues/detail?id=4374
Yes, this is known issue, the C++ fallback
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/7828)
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/grou
Comment #4 on issue 4380 by mvstan...@chromium.org: 'Array' is slower
than 'new Array'
https://code.google.com/p/v8/issues/detail?id=4380
Really interesting. The slowdown is for two reasons, one of which is just a
bug, the other is a difference in element transition feedback between "new
Comment #40 on issue 4280 by bugdro...@chromium.org: Ignition interpreter
tracking bug
https://code.google.com/p/v8/issues/detail?id=4280#c40
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/c9f0368adda0436569076065367e59320327ca00
commit c9f0368a
Patchset 2 (id:??) landed as
https://crrev.com/c9f0368adda0436569076065367e59320327ca00
Cr-Commit-Position: refs/heads/master@{#30639}
https://codereview.chromium.org/1308693014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1308693014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/275cd657df645d9c6f2bb5c2ec7446fb84557edd
Cr-Commit-Position: refs/heads/master@{#30638}
https://codereview.chromium.org/1314253006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1314253006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Updates:
Status: Verified
Comment #5 on issue 4060 by conr...@chromium.org: Variable scoping error
involving eval
https://code.google.com/p/v8/issues/detail?id=4060
Seems to work now.
--
You received this message because this project is configured to send all
issue notifications to
Patchset 1 (id:??) landed as
https://crrev.com/6f454aa1a8891125583d5b16e1b45656643df182
Cr-Commit-Position: refs/heads/master@{#30637}
https://codereview.chromium.org/1319153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1319153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1265423002/220001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1265423002/220001
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #4 on issue 4266 by bugdro...@chromium.org: X is not a function
error messages with TurboFan.
https://code.google.com/p/v8/issues/detail?id=4266#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/819b40aae84111592ea524fd045037463e571838
c
Committed patchset #1 (id:1)
https://codereview.chromium.org/1316673008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/a93ffde366ee1d8bc42827f7e10f9ff20c2df065
Cr-Commit-Position: refs/heads/master@{#30636}
https://codereview.chromium.org/1316673008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
not sure why this would be a larger fix? it would require moving the files
in
chromium (large CL but automated), filing an infra ticket, and replacing the
files in the CLs with a DEPS entry.
some comments inline.
what's the plan with all the new trace macros? will they supersede the LOG()
macr
Reviewers: Michael Lippautz,
Description:
[heap] Prevent leakage of GCCallbacksScope outside of heap.
R=mlippa...@chromium.org
Please review this at https://codereview.chromium.org/1314543014/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-remove-alloc-failure-scope
Af
Updates:
Status: Fixed
Comment #5 on issue 4266 by mstarzin...@chromium.org: X is not a function
error messages with TurboFan.
https://code.google.com/p/v8/issues/detail?id=4266
Fixed by above change. Thanks for the report!
--
You received this message because this project is configu
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1319153006/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1319153006/1
https://codereview.chromium.org/1319153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
1 - 100 of 192 matches
Mail list logo
