e with this
>> code. See for instance date-delay.js that introduces and uses $floor
>> and $abs for the original versions of Math.floor and Math.abs.
>>
>> http://codereview.chromium.org/4065
>>
>>
>>
>
>
> --
> We can IMAGINE what is not
>
> >
>
ay adjust your issue notification preferences at:
> http://code.google.com/hosting/settings
>
> >
>
--
Lasse R.H. Nielsen
[EMAIL PROTECTED]
'Faith without judgement merely degrades the spirit divine'
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
n
> dependent then changing the implementation may break people's
> programs. If we choose a simple and well-defined behavior, and
> stability is an obvious choice, then it becomes easier to maintain
> that behavior across changes to the implementation.
>
> On Wed, Sep 24, 20
s message because you are listed in the owner
> or CC fields of this issue, or because you starred this issue.
> You may adjust your issue notification preferences at:
> http://code.google.com/hosting/settings
>
> >
>
--
Lasse R.H. Nielsen
[EMAIL PROTECTED]
'Faith without jud
n = subject_length -
> > pattern_length; i <= n; i++) {
> > I would move the declaration of n out just before the loop.
> >
> > http://codereview.chromium.org/6269/diff/1/5#newcode1060
> > Line 1060: int length = pattern.length();
&g
bler-ia32.cc
> M regexp2000/src/flag-definitions.h
> M regexp2000/src/heap.h
> M regexp2000/src/heap.cc
> M regexp2000/src/jsregexp.cc
> M regexp2000/src/objects.h
> M regexp2000/src/regexp-macro-assembler-ia32.h
> M regexp2000/src/regexp-macro-assembler-ia32.cc
>
>
>
AIL
> +
> +[ $system == macos ]
> +
> +test-regexp/MacroAssemblerIA32Simple: FAIL
>
>
>
--
Lasse R.H. Nielsen
[EMAIL PROTECTED]
'Faith without judgement merely degrades the spirit divine'
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
gt; +
> + RelativePath="..\..\src\rewriter.cc"
>>
>
>
>
>
--
Lasse R.H. Nielsen
[EMAIL PROTECTED]
'Faith without judgement merely degrades the spirit divine'
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
F_NO_CASE_LENGTH;
> } else {
> pc = code_base + Load32(pc + 2);
>
>
>
--
Lasse R.H. Nielsen
[EMAIL PROTECTED]
'Faith without judgement merely degrades the spirit divine'
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
wly
>> allocated stack.
>> StackPageHeader* new_header =
>> reinterpret_cast(new_stack + allocated_size -
>> sizeof(StackPageHeader));
>>
>> http://codereview.chromium.org/16538/diff/206/209#newcode1003
>&g
>> -__ lea(eax, Operand(edi, -char_size()));
>> +__ lea(eax, Operand(edi, -static_cast(char_size(;
>> Label init_loop;
>> __ bind(&init_loop);
>> __ mov(Operand(ebp, ecx, times_4, +0), eax);
>>
>>
>>
>>
>>
&
_MAX("(ab|cde)", 2, 3);
> - CHECK_MIN_MAX("(ab)\\1", 4, 4);
> - CHECK_MIN_MAX("(ab|cde)\\1", 4, 6);
> + CHECK_MIN_MAX("(ab)\\1", 2, 4);
> + CHECK_MIN_MAX("(ab|cde)\\1", 2, 6);
> CHECK_MIN_MAX("(?:ab)?", 0, 2);
>
scii = shape.IsAsciiRepresentation();
> + bool is_ascii = StringShape(*subject).IsAsciiRepresentation();
> Handle irregexp = GetCompiledIrregexp(regexp, is_ascii);
> if (irregexp.is_null()) {
> return Handle::null();
> @@ -800,7 +798,7 @@
> int i = 0;
> Handle matches;
>
> - if
t;>
>
>
>
> --
> Erik Corry, Software Engineer
> Google Denmark ApS. CVR nr. 28 86 69 84
> c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
> Copenhagen K, Denmark.
>
--
Lasse R.H. Nielsen
l...@google.c
message because you are listed in the owner
> or CC fields of this issue, or because you starred this issue.
> You may adjust your issue notification preferences at:
> http://code.google.com/hosting/settings
>
> >
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judg
t; +++ test/cctest/cctest.status (working copy)
> @@ -37,3 +37,5 @@
> # BUG(113): Test seems flaky on ARM.
> test-spaces/LargeObjectSpace: PASS || FAIL
>
> +# BUG(240): Test seems flaky on ARM.
> +test-api/RegExpInterruption: SKIP
>
>
>
--
Lasse
c_source =
> > Are they more likely to fail?
> > In any case, that would be another test case, since this one doesn't do
> > GC.
> >
> > http://codereview.chromium.org/42441
> >
> > > >
> >
>
--
Lasse R.H. Nielsen
l...@google.com
'Fa
s the same ascii-ness.
> > + ASSERT(StringShape(subject_ptr).IsAsciiRepresentation() == is_ascii);
> > + ASSERT(subject_ptr->IsExternalString() || subject_ptr->IsSeqString());
> > // String is now either Sequential or External
> > - bool is_ascii = StringShape(*subject).IsAsc
T+0200 (CEST)
> Rolling 1 sets of 4dF...
> Mon Mar 30 2009 22:48:33 GMT+0200 (CEST)
>
> real0m1.626s
> user0m1.624s
> sys 0m0.000s
>
>
> i'm on Ubuntu Linux on an i86/32, but i assume that this is a
> platform-independent behaviour.
>
>
> --
&
e potentially other 64-bit architectures outside x64. Please do
> not "improve" the code for 64-bit cleanliness while making it harder to
> port to other architectures. This will serve as a disservice in the long
> time. Thanks!
>
> http://codereview.chromium.org/100336/diff/11/100
iew.chromium.org/114010/diff/2002/2003#newcode89
> Line 89: #define V8PRIp V8_PTR_PREFIX "x"
> Certainly prefix is the wrong name; since it goes after the '%' it must
> be a suffix.
>
>
> http://codereview.chromium.org/114010
>
-
f/11/12#newcode57
> Line 57: v8::internal::byte* buffer;
> It seems easier to just use OS:Allocate here instead of virtual memory.
>
> You don't have to write v8::internal:: here, do you? I think it reads
> better to use it everywhere or not use it at all, consistently.
gt;
>> empty string)? Or is the code for that too big to be inlined?
>>
>
> I count more cases: null, undetectable, empty string, NaN, +0, -0. It
> is a lot of code, and I think these cases aren't hit as often.
>
>
> http://codereview.chromium.org/141030
>
:
> > If REX.W isn't required, we might as well use
> emit_optional_rex_32(dst)
>
>
> It is misleading to the code reader to read rex_32 for an actual 64-bit
> move. Actually, REX without REX.W may be diffrerent than no REX at all.
>
> http://codere
Correction: It doesn't ignore REX.W, it just happens that default size is 64
bits, and REX.W forces size to 64 bits, so it makes no difference. You could
probably make a difference by combining REX.W with the operand size prefix
(0x66).
On Mon, Jun 22, 2009 at 10:26 AM, Lasse R.H. Nielsen
Engineer
> Google Denmark ApS. CVR nr. 28 86 69 84
> c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
> Copenhagen K, Denmark.
>
> >
>
--
Lasse R.H. Nielsen / l...@chromium.org'Faith without judgement merely
degrades the spirit divine
it encodes
> using cl as the shift amount? Won't this guarantee that a shift of 0
> (or is that 64?) is disassembled wrong? We may not generate that, but
> it may as well be disassembled correctly.
Seems like a potential bug, yes.
>
> http://codereview.c
LGTM
On Thu, Aug 6, 2009 at 16:09, wrote:
> This was committed via svn while Rietveld was down.
>
> http://codereview.chromium.org/165053
>
--
Lasse R.H. Nielsen / l...@chromium.org'Faith without judgement merely
degrades
gt; bool SemiSpace::Grow() {
> // Commit 50% extra space but only up to maximum capacity.
> - int extra = capacity_/2;
> + int extra = RoundUp(capacity_/2, OS::AllocateAlignment());
> if (capacity_ + extra > maximum_capacity_) {
> extra = maximum_capacity_ - capacity_;
gt; - // way on ARM - yet.
> -}
> -
> -
> void Debug::GenerateStubNoRegistersDebugBreak(MacroAssembler* masm) {
> // Generate nothing as CodeStub CallFunction is not used on ARM.
> }
>
>
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrade
wBuffer();
> #ifdef DEBUG
> space_before_ = assembler_->available_space();
> #endif
>
>
>
> >
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal -
m, to, div) {
> Why is the divider for the medians a variable? We only use the value 3,
> don't we?
>
>
> http://codereview.chromium.org/6004001/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark Ap
gt; 1360 København K
> Denmark
> CVR nr. 28 86 69 84
>
> If you received this communication by mistake, please don't forward it to
> anyone else (it may contain confidential or privileged information), please
> erase all copies of it, including all attachments, and please let t
Variable::VAR));
>> num_parameters++;
>> done = (peek() == Token::RPAREN);
>> if (!done) Expect(Token::COMMA, CHECK_OK);
>> @@ -3387,32 +3299,6 @@
>> Expect(Token::RBRACE, CHECK_OK);
>> end_pos = scanner().location().end_pos;
>> }
>> -
>> -// Validate strict mode.
>> -if (temp_scope_->StrictMode()) {
>> - if (IsEvalOrArguments(name)) {
>> -int position = function_token_position != RelocInfo::kNoPosition
>> - ? function_token_position
>> - : (start_pos > 0 ? start_pos - 1 : start_pos);
>> -ReportMessageAt(Scanner::Location(position, start_pos),
>> -"strict_function_name", Vector> char*>::empty());
>> -*ok = false;
>> -return NULL;
>> - }
>> - if (eval_loc.beg_pos != RelocInfo::kNoPosition) {
>> -ReportMessageAt(eval_loc, "strict_param_name",
>> -Vector::empty());
>> -*ok = false;
>> -return NULL;
>> - }
>> - if (dupe_loc.beg_pos != RelocInfo::kNoPosition) {
>> -ReportMessageAt(dupe_loc, "strict_param_dupe",
>> -Vector::empty());
>> -*ok = false;
>> -return NULL;
>> - }
>> - // TODO(mmaly): Check for octal escape sequence here.
>> -}
>>
>> FunctionLiteral* function_literal =
>> new FunctionLiteral(name,
>> @@ -3426,8 +3312,7 @@
>> start_pos,
>> end_pos,
>> function_name->length() > 0,
>> -temp_scope.ContainsLoops(),
>> -temp_scope.StrictMode());
>> +temp_scope.ContainsLoops());
>>
>> function_literal->set_function_token_position(function_token_position);
>>
>> if (fni_ != NULL && !is_named) fni_->AddFunction(function_literal);
>> ===
>> --- /branches/bleeding_edge/src/scopes.cc Tue Jan 18 08:43:53 2011
>> +++ /branches/bleeding_edge/src/scopes.cc Tue Jan 18 15:01:50 2011
>> @@ -443,18 +443,6 @@
>> }
>> return n;
>> }
>> -
>> -
>> -bool Scope::IsParameterDeclared(Handle name) {
>> - ASSERT(name->IsSymbol());
>> - for (int i = 0, length = num_parameters(); i < length; i ++) {
>> -ASSERT(parameter(i)->name()->IsSymbol());
>> -if (name.is_identical_to(parameter(i)->name())) {
>> - return true;
>> -}
>> - }
>> - return false;
>> -}
>>
>>
>> #ifdef DEBUG
>> ===
>> --- /branches/bleeding_edge/src/scopes.hTue Jan 18 08:43:53 2011
>> +++ /branches/bleeding_edge/src/scopes.hTue Jan 18 15:01:50 2011
>> @@ -288,10 +288,6 @@
>> // The number of contexts between this and scope; zero if this == scope.
>> int ContextChainLength(Scope* scope);
>>
>> - //
>> ---
>> - // Strict mode support.
>> - bool IsParameterDeclared(Handle name);
>> -
>> //
>> ---
>> // Debugging.
>>
>> --
>> v8-dev mailing list
>> v8-dev@googlegroups.com
>> http://groups.google.com/group/v8-dev
>>
>
>
>
> --
> Cheers,
> --MarkM
>
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K -
Denmark - CVR nr. 28 86 69 84
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
right place to check all things
> scope-related?
>
> We should avoid adding extra passes and auxiliary data structures to the
> parser.
>
>
> http://codereview.chromium.org/6144005/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spi
Doh, not , SyntaxError for delete is not early.
/L
On Wed, Jan 19, 2011 at 10:21, Lasse R.H. Nielsen wrote:
> It would make sense, as long as we can emit a SyntaxError with the correct
> location at that time.
> ES5 requires an "early error" for these syntax errors,
his communication by mistake, please don't forward it to
> anyone else (it may contain confidential or privileged information), please
> erase all copies of it, including all attachments, and please let the sender
> know it went to the wrong person. Thanks.
>
>
--
Lasse R.H. Ni
, STRICT LIABILITY, OR TORT
> +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +"use strict";
> +
> +// arguments must be read only in strict mode.
> +// NOTE: this test will be obsol
review.chromium.org/6286043/diff/1/src/runtime.cc#newcode7671
> src/runtime.cc:7671: JavaScriptFrame* frame =
> locator.FindJavaScriptFrame(0);
> On 2011/02/02 05:07:26, Martin Maly wrote:
>
>> Alternative to walking the stack frames is passing additional argument
>>
> (strict
Argh, that's section 10.1.1, not 10.10.1, which specifies when eval code is
strict.
On Wed, Feb 2, 2011 at 13:37, Lasse R.H. Nielsen wrote:
> I just checked what Safari (or really: Webkit Nightly) does.
>
> 1. It doesn't follow the spec on whether an aliased call to eval
n and get the benefit of inlining.
Inlining an uncompiled function is probably rare to begin with, so I don't
think this is going to affect performance of anything important (but it's
worth a check).
/L
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K -
Denmark - CVR nr. 28 86 69 84
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
rently works, it's going to
traverse the data two or three times anyway - first to check if the string
is all ASCII (which can bail out early but might not), then, if it's not
ASCII, traverse the UTF-8 to find the length of the resulting string, and
then finally to copy the characte
e scoped object that set and unset/reset both
>> labels. This seems like unnecessary book-keeping.
>>
>> http://codereview.chromium.org/371070
>>
>>
>>
>
> >
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the sp
set of the
chunk as well then.
On Thu, Jan 7, 2010 at 12:28, wrote:
> LGTM
>
> I guess the max sizes are as high as they can be to ensure that the
> computations
> cannot overflow?
>
>
> http://codereview.chromium.org/525064
>
--
Lasse R.H. Nielsen
l...@googl
-undefined behaves like 0 (which is expected), but
> single arg form behaves like len (which is slice compatible as you say).
>
>
> http://codereview.chromium.org/618002
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google
rguments having the value undefined.
I.e., it's not spec-conforming.
/L
On Wed, Feb 17, 2010 at 10:38, Lasse R.H. Nielsen wrote:
> A quick test of Opera, Firefox, Safari and IE shows that only IE differ
> from the rest. Everybody else lets an omitted argument default to length,
> but
ping = kAllowNativesSyntax * 2
>> Not sure there is a reason. In the preparser, the parser gets the
>> harmony-scoping bool from the scanner, so it doesn't need an extra flag.
>
>
>
> http://codereview.chromium.org/8306024/
>
--
Lasse R.H. Nielsen
l...@google.
t; src/x64/codegen-x64.cc:409: __ j(zero, call_runtime);
>> Not necessary?
>>
>>
>> http://codereview.chromium.org/8569008/diff/5002/src/x64/codegen-x64.cc#newcode439
>> src/x64/codegen-x64.cc:439: // Check whether the string is sequential.
>> The only non-seque
=== 0 && !%_IsSmi(arg1) && 1 / arg1 < 0) ?
>> arg1
>
> :
>>
>> arg2;
>> Same problem here if +0 and -0 both are non-smi, so ariginal code is
>> correct.
>
>
>
>
> http://codereview.chromium.org/9065008/
--
Lasse R.H. Nielsen
l...@google.c
nore it now.
>>
>
> You are right about Function.prototype.call for the natives can be
> overwritten,
> and %_CallFunction should be used. However there are 50 usages of .call in
> the
> natives, so this should be cleaned up in a separate change. I can see you
> changed a f
> >
> > void ProfilerEventsProcessor::Run() {
> > unsigned dequeue_order = 0;
> > - running_ = true;
> >
> > while (running_) {
> > // Process ticks until we have any.
> >
> >
> >
>
> --
> v8-dev mailing list
> v8-dev@
f code objects, which is not nice for
>>> debugging and we often have to debug release binaries.
>>>
>>
>> What about a command-line option/api that makes the feature opt-in and if
>> not it always initializes the cookie to NULL? It would would make the
>> valu
By bad.
Thanks for fixing.
/L
On Thu, Sep 16, 2010 at 10:07, wrote:
> On 2010/09/16 08:02:03, tfarina wrote:
>
>
> LGTM!
>
> I will land it for you, I don't see you in project members list.
>
>
> http://codereview.chromium.org/3442004/show
>
--
Lasse
t? Shouldn't
> it
> be the stack limit?
>
>
>
> http://codereview.chromium.org/6594115/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K -
Den
,
> if
> there's any way to make it possible, pls let me know.
>
>
>
> http://codereview.chromium.org/6673011/
>
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith
; back ported to the 3.2 branch?
>
> On Fri, Apr 15, 2011 at 1:43 PM, wrote:
> > LGTM.
> >
> > http://codereview.chromium.org/6875002/
> >
> > --
> > v8-dev mailing list
> > v8-dev@googlegroups.com
> > http://groups.google.com/group/v8-dev
&g
; I think the right thing is to treat it as an object, since it's used in an
>> object context, not a test context. I.e., we should not throw on an
>> undetectable
>> object/string as receiver (we should treat it as a valid argument to
>> ToObject).
>>
>&g
return this; }
> foo(); // returns global object
>
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmar
ss there is a good reason, though. It's not
guaranteed to stay that way.
And if you use is_nan (which you must, because NaN != NaN, even if
it's the same NaN representation), it won't matter.
/L
--
Lasse R.H. Nielsen
l...@chromium.org
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
son to wait on account of this concern.
Well, I'm still concerned.
/L
[1] It's a feature, not a bug :)
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K -
Denmark
} read-only as per ES5
> (issue 89490).
> Had to revert this earlier today (r8800). Please remove it from the
> ChangeLog.
>
> http://codereview.chromium.org/7465079/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Goo
> On Fri, Aug 26, 2011 at 5:43 PM, wrote:
>>
>> LGTM.
>> You shouldn't need crankshaft, just a compacting GC that moves the calling
>> Code
>> object. I'm not sure there is a good way to do that consistently, though.
>>
>> http://codereview.chr
1 at 22:22, wrote:
> Is there a regression test for this?
>
> http://codereview.chromium.org/7776008/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K
egexp
> execution
> is interrupted, in CheckStackGuardState. All these checks could be made
> obsolete.
>
> http://codereview.chromium.org/7977001/
>
--
Lasse R.H. Nielsen
l...@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Fred
64 matches
Mail list logo
