Re: [v8-dev] Is Multiple 'EmbedderHeapTracer's Feasible?

#x27; via v8-dev < > v8-dev@googlegroups.com> wrote: > >> For some reason my replies seem to be automatically deleted :( >> >> On Thursday, 14 June 2018 03:17:05 UTC-4, Jochen Eisinger wrote: >>> >>> I'd rather move tracing functionality into g

Re: [v8-dev] Is Multiple 'EmbedderHeapTracer's Feasible?

h gin than trying to write their own bindings. On Wed, Jun 13, 2018 at 7:04 PM d.haresign via v8-dev < v8-dev@googlegroups.com> wrote: > On Tuesday, 12 June 2018 22:15:01 UTC-4, mlip...@chromium.org wrote: >> >> +Jochen Eisinger who is gin >> <https://cs.chromium.org/chr

Re: [v8-dev] how to test wasm fuzzer in v8?

The simple fuzzers not really fuzzers but just testing the libfuzzer backends against known inputs. Even if you run them using libfuzzer, they shouldn't output anything - we just test for "not crashing". On Mon, Jun 5, 2017 at 11:51 AM wrote: > > i want running wasm fuzzer in v8 > > >

[v8-dev] Modifying the V8 C++ API

point for information about using the C++ API. Feel free to extend the document, clarify unclear things, and add missing pieces! best -jochen -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google G

Re: [v8-dev] Re: Introduce function_view to src/base

sn't exactly lightweight. > > What do you think? > > On Tuesday, May 16, 2017 at 9:43:02 PM UTC+8, looro...@gmail.com wrote: >> >> On Tuesday, May 16, 2017 at 9:13:32 PM UTC+8, Jochen Eisinger wrote: >>> >>> I'd vote for either importing chromium&#

Re: [v8-dev] Re: Introduce function_view to src/base

codes also use a bit of std::function + lambda, so this refactoring will > still benefit snapshot build slightly. > > By the way, Official Node.js binary is built with snapshot or nosnaphot > configuration? > > >> >> On Tue, May 16, 2017 at 2:52 PM wrote: >> >

[v8-dev] Re: Introduce function_view to src/base

Thanks for the summary! I'm wondering whether you also plan other refactoring work for V8? Also, why not just import base::Bind and friends from Chromium? On Tue, May 16, 2017 at 2:04 PM wrote: > Hi V8 devs, > > I saw a few functions in src/builtin/builtin-*-gen.cc and > src/code-stub-assemble

Re: [v8-dev] About v8 heap compaction on M55

Please please don't ship a product based on M48 - it's full of known severe security holes, long fixed bugs, and meanwhile outdated HTML and JavaScript support. For the sake of your users, please don't. Jiadong Zhu schrieb am Di., 9. Mai 2017, 08:10: > Hi, > > It is said there is v8 memory opti

Re: [v8-dev] Significance of Builtins::AllowDynamicFunction

On Fri, Mar 31, 2017 at 2:54 PM Jens Widell wrote: > On Fri, Mar 31, 2017 at 2:24 PM, Jochen Eisinger > wrote: > > > > > > On Fri, Mar 31, 2017 at 1:38 PM Jens Widell wrote: > >> > >> Hi all, > >> > >> while working on getting

Re: [v8-dev] Significance of Builtins::AllowDynamicFunction

promise constructor when creating the context, and then during microtask execution check that the microtask context as defined above has access to the current context. hth -jochen > By potentially changing what is the entered context in a given > situation, what could go wrong, given

Re: [v8-dev] how to integrate V8 into a Visual Studio project?

to get those files, you need to set v8_static_library = true in your gn args (only works on latest v8 dev versions) On Fri, Jan 6, 2017 at 7:40 PM wrote: > hi all, > > I'm trying to compile and run the v8 "hello world" example but ran into > numerous linking errors. I was able to compile v8 wit

Re: [v8-dev] Does WeakCell store weak references?

Yes, that's how a WeakCell works. I'm not sure, however, I understand what you're doing with the slots there, and what you mean by the WeakCell becoming free space (the WeakCell should always stay alive, it's just the link to whatever object it points to that gets cleared)? On Sun, Dec 11, 2016 a

Re: [v8-dev] strict build for developers which treat non numeric values in math operations as exception

Given the many places that are affected by number handling, I'd say this is not possible. Several JS frameworks provide ways to navigate some of the rougher edges here, have you considered using one that provides the kind of math guarantees you're looking for? On Sun, Dec 11, 2016 at 6:07 AM wro

Re: [v8-dev] what went wrong?

did you run gclient sync? is "depot_tools" in your $PATH? On Tue, Nov 8, 2016 at 4:40 AM Jason Zoo wrote: > tools/dev/v8gen.py x64.debug -vv > > > /usr/bin/python -u tools/mb/mb.py gen -f infra/mb/mb_config.pyl -m >

Re: [v8-dev] Questions about concurrent recompilation for Crankshaft

On Thu, Nov 10, 2016 at 9:30 PM Jay wrote: > Hi, > > I have some questions about concurrent recompilation for Crankshaft. > > 1. Crankshaft's compilation is 3-step: CreateGraph, OptimizeGraph and > GenerateCode. It seems like only the second step is done on the background > thread concurrently.

Re: [v8-dev] Why sort slower in v8 vs js?

What about them causes so much overhead if they are the ones > responsible?) > > Really appreciate all the help Thanks so much again! > > On Monday, October 24, 2016 at 3:42:00 AM UTC-4, Jochen Eisinger wrote: > > compared to the JS function, the C implementation has a lot

Re: [v8-dev] Why sort slower in v8 vs js?

compared to the JS function, the C implementation has a lot of overhead to copy the data back and forth, so it's not surprising that this overhead shows up especially on larger arrays On Mon, Oct 24, 2016 at 2:47 AM Samantha Krieger wrote: > Just wondering if I'm crazy/doing something incredibly

Re: [v8-dev] When to use which macro for component builds

On Mon, Oct 17, 2016 at 11:39 PM Adam Klein wrote: > On Mon, Oct 17, 2016 at 8:18 AM, Jochen Eisinger > wrote: > > > > On Fri, Oct 14, 2016 at 8:19 PM Adam Klein wrote: > > I take it from your omission that code which isn't accessed anywhere but > within s

Re: [v8-dev] When to use which macro for component builds

to be exported. (d8.cc goes into d8 while factory.h goes into v8_base). Same holds true for src/ vs src/base. best -jochen > > On Fri, Oct 14, 2016 at 6:47 AM, Jochen Eisinger > wrote: > > Hey, > > we recently started to support component builds for almost all binaries.

[v8-dev] When to use which macro for component builds

depend on v8_libbase (in this example) - you'll have to add the dependency in the BUILD.gn (and corresponding gyp file) then - but this should be rare, only if you add new binaries. best -jochen -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

Re: [v8-dev] Does V8 use one stack's for js function and native code?

We use the same stack Best Jochen Dmitriy - schrieb am Do., 29. Sep. 2016, 12:01: > For example: > > c frame > js frame > c frame > js frame > js frame > c frame > > OR > > c frame > c frame > c frame > c frame > -- >

Re: [v8-dev] Deprecated function in test/cctest/interpreter/generate-bytecode-expectations.cc

Please file a bug at crbug.com/v8/new thanks -jochen On Wed, Sep 28, 2016 at 6:06 PM wrote: > I found that the current code on GitHub of V8 uses a deprecated function, > namely readdir_r (more about it here: > http://man7.org/linux/man-pages/man3/readdir_r.3.html). I am not able to

Re: [v8-dev] gn binary for other platforms

It should be possible to build from source. You'll need a complete chromium checkout (run fetch chromium). There's a bootstrap script here: https://chromium.googlesource.com/chromium/src/tools/gn/+/master/bootstrap/bootstrap.py On Sun, Sep 25, 2016 at 5:58 AM Atiq Rahman wrote: > Currently gn bi

[v8-dev] Re: Please add new cctests / unittests to both gyp and gn

... and there's now a presubmit check to help you remember that :) On Wed, Sep 14, 2016 at 9:00 PM Jochen Eisinger wrote: > Hey, > > with the progress on our gn migration, I disentangled the gyp and gn files > for cctests and unittests. In the past, it was enough to add a new

Re: [v8-dev] TemplateHashMap changes proposal

would replacing it with std::unordered_map<> gain the same advantages? On Thu, Sep 15, 2016 at 10:29 AM wrote: > Hi all, > > We (ignition) are looking to use base/hashmap (TemplateHashMap), but there > are a couple of things that I want to change/add for efficiency's sake. > Because these change

[v8-dev] Please add new cctests / unittests to both gyp and gn

src/ anyways). best -jochen -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an em

Re: [v8-dev] How to get v8 printf() messages in adb logcat?

If the v8_android_log_stdout gyp define is set to 0, the printf message should go to the log On Thu, Aug 18, 2016 at 5:10 PM Singapati wrote: > Hello, > > How to get v8 printf() messages in adb logcat? > > Thank you. > Sarath > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://g

Re: [v8-dev] Re: PSA: In-process stack trace dumping is changing

Great work, thank you! Some questions: You only added the initialization call to d8. Will this also work for other binaries / when run inside chromium? You also stripped out the libsymbolize specific code. Is there some functionality we're now missing? Last but not least, I guess you can now rem

Re: [v8-dev] Cannot get stack trace in GC

I guess we could also walk some objects, as long as we teach the stack frame machinery to follow forwarding pointers. On Fri, Aug 19, 2016 at 3:43 PM Michael Lippautz wrote: > As you already pointed out, during compaction and new space evacuation the > GC moves objects around. We cannot assemble

[v8-dev] New gdb macro to skip x64 jitted stack

gc=1, args=0x7f50d02c0518, new_target=...) at ../../v8/src/execution.cc:111 isolate=0x2f001c9e2020, callable=..., receiver=..., argc=1, argv=0x7f50d02c0518) at ../../v8/src/execution.cc:168 ... Note that the macro modifies the cpu registers BR Jochen -- -- v8-dev mailing l

[v8-dev] Re: PSA: replacing smart pointers with C++11 unique_ptr

This has landed On Mon, Jul 25, 2016 at 10:46 AM Jochen Eisinger wrote: > Hey, > > I'm about to land a CL replacing SmartArrayPointer with > std::unique_ptr and SmartPointer with std::unique_ptr. > > Both should be pretty similar, except for minor naming differences: >

[v8-dev] PSA: replacing smart pointers with C++11 unique_ptr

nes unique_ptr is MSVS might complain about a deleted operator if you have add a unique_ptr member to a class. In that case, you forgot to add DISALLOW_COPY_AND_ASSIGN() to your class, or, if you actually want to copy it around, you need to implement move constructors. best -jochen -- -- v8-de

Re: [v8-dev] git cl try now runs a CQ dry run instead of starting bots directly

See the corresponding intent to implement on chromium-dev. This was done so git cl try would also trigger bots defined via CQ_INCLUDE_TRYBOTS Adam Klein schrieb am Fr., 15. Juli 2016, 00:18: > Was this an intentional change? Unintentional side effect of something > else? Mostly curious if anyone

[v8-dev] Fwd: [blink-dev] [ANN] Moving from Rietveld to Gerrit

fyi, as we'll probably continue to use the same codereview tool as the rest of chromium projects -- Forwarded message - From: Andrew Bonventre Date: Di., 12. Juli 2016, 23:24 Subject: [blink-dev] [ANN] Moving from Rietveld to Gerrit To: Chromium-dev , blink-dev < blink-...@chromiu

[v8-dev] Design doc for OOPIF / v8 context support

org/p/chromium/issues/detail?id=618305 best -jochen -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

Re: [v8-dev] fetch failing on recently released Fedora 24

ying is not working. > > > > Thanks, > > Atiq > > > > *From:* v8-dev@googlegroups.com [mailto:v8-dev@googlegroups.com] *On > Behalf Of *Jochen Eisinger > *Sent:* Thursday, June 30, 2016 1:21 AM > > > *To:* v8-dev@googlegroups.com > *Subject:

Re: [v8-dev] Patch release of the 3.14 branch

I'd recommend including your own version of V8 instead of relying on whatever the OS provides. That also allows you to keep upgrading the version of V8 whenever new stability or security fixes are released. best -jochen On Fri, Jul 1, 2016 at 9:06 AM Michael Hablich wrote: > H

Re: [v8-dev] fetch failing on recently released Fedora 24

ly (happening across all Linux Machines > in this network). I have applied that command manually. Output of that is > here: http://collabedit.com/vetyg > > > > It did succeed on Fedora 20 on my notebook which is connected to a > different network (the network does not requi

Re: [v8-dev] Poor performance in the V8 C++ API functions respnsible for processing strings.

;l=94 Having said that, we also observe certain patterns where string conversion shows up high in the profile, and we're working on improving this over time. hth -jochen On Fri, Jun 17, 2016, 4:46 PM wrote: > Many thanks for the suggestions, Jochen. > > However, I'm not sure tha

Re: [v8-dev] fetch failing on recently released Fedora 24

Do you get a more detailed error when you run the download_from_google_storage command manually? It's failing to download clang-format btw. If you don't want to use clang to compile you'll need to set the environment variable GYP_DEFINES to clang=0 Atiq Rahman schrieb am Mi., 22. Juni 2016, 01:4

Re: [v8-dev] Poor performance in the V8 C++ API functions respnsible for processing strings.

Thanks for the detailed analysis, very interesting. Some comments inline: On Fri, Jun 10, 2016 at 10:45 AM wrote: > Hello, > > * This post is mainly for the attention of any V8 Developers who might be > monitoring this group. However, all thoughts and suggestions are welcome! > > First some bac

[v8-dev] Fwd: [blink-dev] ACTION (possibly) REQUIRED: get a new depot_tools checkout

fyi -- Forwarded message - From: Aaron Gable Date: Di., 31. Mai 2016, 18:24 Subject: [blink-dev] ACTION (possibly) REQUIRED: get a new depot_tools checkout To: Chromium-dev , blink-dev < blink-...@chromium.org>, infra-annou...@chromium.org < infra-annou...@chromium.org> As previ

Re: [v8-dev] How does GC work in v8?

There is no low-level description available. You can look at (old) high level descriptions here: http://jayconrod.com/posts/55/a-tour-of-v8-garbage-collection and check out some of our blog posts about new features in the gc on http://v8project.blogspot.de/ (search for garbage) On Wed, Apr 27, 201

Re: [v8-dev] How to execute external JS file from script in V8

V8 doesn't have support for loading files. To implement this on the C++ side, have a look at the samples/shell.cc that implements a load() method. best -jochen On Wed, Apr 20, 2016 at 10:59 AM wrote: > Thanks for your reply, > To be precise I have written an equivalent function

Re: [v8-dev] How can I test my own port v8 engine with small example?

is a significant piece of work, and I don't know of any short cuts. best -jochen On Wed, Apr 20, 2016 at 1:26 PM wrote: > Hello guys. > > I'm writing my own port v8 engine with exotic architecture. > As I can see in code v8 load a lot of built-in js files: > array-itera

Re: [v8-dev] How to execute external JS file from script in V8

h out to the authors / maintainers of the crypto library for how to use it. best -jochen On Wed, Apr 20, 2016 at 6:52 AM wrote: > I need to execute following script which uses crypto-js library in V8. How > should I write my js file. > > http://cryptojs.altervista.org/api/functions_cryptog

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

safe again to dereference any persistent handle still alive. the second pass callback might very well get invoked after further JS execution happened. hth -jochen On Wed, Apr 13, 2016 at 9:14 PM wrote: > Just for clarification: the new callback (the one that takes a > WeakCallbackInfo) func

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

u clarify how I would be able to get the old behaviour back by > changing the node-weak module? > > > On Tuesday, April 12, 2016 at 8:22:25 PM UTC+2, Jochen Eisinger wrote: > >> ok, so the update to NAN 2.0 broke the node-weak module. Using the >> kParameter weakness ty

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

; On Tuesday, April 12, 2016 at 7:48:11 PM UTC+2, Jochen Eisinger wrote: > >> What function is "callback" in the HandleApiCallHelper frame pointing to? >> >> On Tue, Apr 12, 2016, 7:36 PM wrote: >> >>> I should have mentioned my original bug report agains

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

gt; Btw I am able to run IsOddball() and that returns false. > > On Tuesday, April 12, 2016 at 7:31:23 PM UTC+2, Jochen Eisinger wrote: > >> and the value of "this" when you hit the FATAL() >> >> On Tue, Apr 12, 2016 at 7:33 PM Jochen Eisinger >> wrote: &

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

and the value of "this" when you hit the FATAL() On Tue, Apr 12, 2016 at 7:33 PM Jochen Eisinger wrote: > Could you post a stack trace that leads to the FATAL()? > > On Tue, Apr 12, 2016 at 7:27 PM Ben Noordhuis wrote: > >> On Tue, Apr 12, 2016 at 7:11 PM,

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

Could you post a stack trace that leads to the FATAL()? On Tue, Apr 12, 2016 at 7:27 PM Ben Noordhuis wrote: > On Tue, Apr 12, 2016 at 7:11 PM, wrote: > > Hi, > > > > we (Microsoft VS Code team) are tracking down a very weird native crash > in > > our use of node.js (5.10.0, V8 46) that only e

Re: [v8-dev] Exposing JSON::Stringify to Blink

ScriptValue is structured clone, which doesn't define a > wire format and instead is just an algorithm to serialize/deserialize. ex. > This thing shouldn't allow message ports, array buffers, dates, regexes, > etc. > > On Thu, Mar 31, 2016 at 3:09 PM, Jochen Eisinger &

Re: [v8-dev] Exposing JSON::Stringify to Blink

Do you plan to support the additional parameters (replacer and gap)? Anyways, feel free to send the CL to me and verwaest@. Out of curiosity, why this odd definition of an object that can be serialized and deserialized instead of the standardized SerializedScriptValue IDL type? On Thu, Mar 31, 20

Re: [v8-dev] How to increase JS Heap size limit?

--* >> >> >> Page* p = heap()->isolate()->memory_allocator()->AllocatePage(size, this, >>

Re: [v8-dev] CVE-2016-1007, CVE-2016-1009

CVEs are very specific to the product they refer to - usually, they don't affect other products that don't use the exact product and version referenced in the CVE. So, no, V8 is not affected by those two CVEs Best Jochen On Mon, Mar 14, 2016, 12:57 AM Barry Dawson wrote: > Adobe

Re: [v8-dev] How to increase JS Heap size limit?

Is configuring the size via the ResourceConstraint class not covering your use case? On Fri, Mar 11, 2016, 5:14 PM wrote: > Hi, > > We need to increase the V8 heap size limit for certain case. Can some one > please point me the source code where we can change this limit? > > Regards, > T. Umapat

Re: [v8-dev] Build optdebug mode for android build.

Does eg "make android_arm.optdebug" not work for you? On Fri, Mar 11, 2016 at 10:43 AM wrote: > Hi, v8-dev folks. > > Regular build, i.e. windows, linux, has 'optdebug' option which compiles > binary with no compiler optimization(-O0) and leaves symbol info. > However, build for android doesn't

Re: [v8-dev] Re: Debugging via gdb with possibility see local variables

try "info locals" to see all variables that gdb knows about in the current context. This is, however, not v8 specific, I'd recommend reading a tutorial about gdb or use a graphical frontend such as ddd On Wed, Mar 9, 2016 at 9:50 AM wrote: > Hi, thanks for the answer, but I of course check bt:

Re: [v8-dev] Building on OSX problems

filed https://bugs.chromium.org/p/v8/issues/detail?id=4821 to track this On Tue, Mar 8, 2016 at 3:04 PM Jochen Eisinger wrote: > Yeah, I guess we should invest in updating the tutorial for other OSs as > well. The set of libraries you have to link against is the same as on > Linux, how

Re: [v8-dev] Building on OSX problems

unning "make x64.release" worked and I was able to run the hello_world > example, so I guess building works. > > Now how would link against this on OSX? I'm at a bit of a loss, since the > example is for Linux and there are no example for OSX. > > On Tuesday, March

Re: [v8-dev] Building on OSX problems

p or whatever? > If the example is outdated then how am I supposed to do it? > The example assumes you use Linux. If you chose to deviate from some parts of the tutorial, you're more or less on your own. > > On Tuesday, March 8, 2016 at 12:35:56 PM UTC+1, Jochen Eisinger wrote:

Re: [v8-dev] Building on OSX problems

make x64.release" should not work on Mac? > > > On Tuesday, March 8, 2016 at 11:51:49 AM UTC+1, Jochen Eisinger wrote: > >> This example command line only works on 64bit Linux. >> >> On Mac, just build the hello_world target. I don't know off the top of my >&

Re: [v8-dev] Building on OSX problems

This example command line only works on 64bit Linux. On Mac, just build the hello_world target. I don't know off the top of my head what the corresponding command line would be for xcodebuild, sorry On Mon, Mar 7, 2016 at 5:59 PM Frank Lyder Bredland wrote: > I tried to follow this guid: > http

[v8-dev] V8 Code of Conduct

ory: https://chromium.googlesource.com/v8/v8/+/master/CODE_OF_CONDUCT.md referencing the Chromium Code of Conduct here: https://chromium.googlesource.com/chromium/src/+/master/CODE_OF_CONDUCT.md best -jochen -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received th

Re: [v8-dev] Build lib distribution

I'd expect you'll need libicui18n.so libicuuc.so libv8.so, snapshot_blob.bin, and natives_blob.bin If you don't want to implement your own v8::Platform, you'll also need libv8_libbase.a libv8_libplatform.a as headers. everything under include/ is needed. hth -jochen On Thu

Re: [v8-dev] How does the V8 perform deoptimization?

There's a highlevel blog post here: http://floitsch.blogspot.de/2012/03/optimizing-for-v8-inlining.html For details, you'll have to read the source. hth -jochen On Thu, Feb 18, 2016 at 11:54 AM wrote: > I think the question is clear :) > > -- > -- > v8-

Re: [v8-dev] How to debug v8 natives

a js > function and go to it. V8 doesn't support this for debug purpose in gdb? > > > On Wednesday, February 17, 2016 at 6:35:24 PM UTC+6, Jochen Eisinger wrote: > >> There is no unique address of a js function. The code for the js function >> can move around, it can

Re: [v8-dev] How to debug v8 natives

7, 2016 at 5:34:36 PM UTC+6, Yang Guo wrote: > >> I'd google for "gdb set break point at address" :) >> >> On Wed, Feb 17, 2016, 09:42 wrote: >> >>> Thank Jochen, but I don't clearly understand how to set breakpoint on JS >>> funct

Re: [v8-dev] How to debug v8 natives

V8 will move code objects around during garbage collection. If you want to debug code in code objects, you'll have an easier time if you disable this by passing --nocompact_code_space. Otherwise, using the regular commands to set breakpoints in gdb should work just fine. On Wed, Feb 17, 2016 at 8

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

gt;> Thanks for adding data parameter. >> >> I tried v8 from 4.10.148 tag (which has >> https://github.com/v8/v8/commit/a75b2c8f69634685288b419c8b4daf2d661b4bf4 >> commit), but data from AccessCheckCallback is reported as IsEmpty() >> regardless what I set it to =( &g

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

rowser cross-origin policy), so having data property to migrate from > deprecated checkers to newer one is mandatory for me. And if no data passed > to callback, what is the purpose of that data parameter in > SetAccessCheckCallback()? > > > On Tuesday, February 2, 2016 at 3:

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

Blink was merged into chromium a while ago, so there is no separate repo. As Toon points out, access checks will only trigger on cross-context accesses, and probably not work for the code snippet you posted. Maybe your use case can be modelled using regular interceptors? best -jochen On Tue

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

some of data > https://github.com/v8/v8/commit/e2675937d5b6d2e555edeaabcda7ce70551ea236). > I checked blink code and if one decides to move to SetAccessCheckCallback > there, passing data to callback is a must. > > > On Tuesday, February 2, 2016 at 10:36:58 AM UTC+2, Jochen Eisin

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

afaik there was no reason to drop data from the callback other that we didn't know of anybody using it. I guess it's fine to add it back. On Mon, Feb 1, 2016 at 10:44 PM wrote: > I guess something like this may allow data passing to callback: > > diff --git a/include/v8.h b/include/v8.h > index

Re: [v8-dev] Re: Local::Local(S* that) constructor screws up implicit conversions for overloaded functions

well. Have you considered contributing a patch? best -jochen On Thu, Jan 28, 2016 at 2:28 AM wrote: > or perhaps the template on the constructor isn't even necessary? > > http://ideone.com/MXwvp9 > > shows the same behavior. > > V8_INLINE Local(T* that) > : val

Re: [v8-dev] A bug in android-sync tool

hould be able to use git cl upload On Fri, Jan 22, 2016 at 8:46 AM Bangfu Tao wrote: > Hi Jochen, > > I can also login with Samsung address on codereview.chromium.org. > Just wondering, do I need to do "git cl config"? If yes, please show me > how to. > > Thanks &

Re: [v8-dev] A bug in android-sync tool

can you login with your samsung address on codereview.chromium.org? If not, did you ever create a google account for that address? best -jochen On Thu, Jan 21, 2016 at 12:08 PM 'Daniel Vogelheim' via v8-dev < v8-dev@googlegroups.com> wrote: > On Thu, Jan 21, 2016 at 10:36

[v8-dev] Add support for compiling V8 standalone using gn (issue 1067293002 by joc...@chromium.org)

Reviewers: CL: https://codereview.chromium.org/1067293002/ Description: Add support for compiling V8 standalone using gn BUG=chromium:474921 LOG=y Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+101, -0 lines): M .gitignore A .gn M DEPS A build/module_args

[v8-dev] Re: Implement tracing interface for v8 (issue 988893003 by fmea...@chromium.org)

https://codereview.chromium.org/988893003/diff/420001/include/v8-platform.h File include/v8-platform.h (right): https://codereview.chromium.org/988893003/diff/420001/include/v8-platform.h#newcode120 include/v8-platform.h:120: virtual const uint8_t* GetCategoryGroupEnabled(const char* name) = 0;

[v8-dev] Re: Implement tracing interface for v8 (issue 988893003 by fmea...@chromium.org)

On 2015/12/01 at 17:04:41, jochen wrote: https://codereview.chromium.org/988893003/diff/420001/DEPS File DEPS (right): https://codereview.chromium.org/988893003/diff/420001/DEPS#newcode16 DEPS:16: "v8/src/tracing/common": I think this line should be v8/base/trace_event/common

Re: [v8-dev] Re: An update on bit_cast

thanks for the heads-up. Did you keep the bit_casts in fletch for non-pointer types? On Thu, Dec 3, 2015 at 2:34 PM 'Erik Corry' via v8-dev < v8-dev@googlegroups.com> wrote: > Slava points out that I am writing about use of bit_cast for pointer types > (eg casting an Object** to a Class**), but

[v8-dev] Re: Implement tracing interface for v8 (issue 988893003 by fmea...@chromium.org)

https://codereview.chromium.org/988893003/diff/420001/DEPS File DEPS (right): https://codereview.chromium.org/988893003/diff/420001/DEPS#newcode16 DEPS:16: "v8/src/tracing/common": I think this line should be v8/base/trace_event/common https://codereview.chromium.org/988893003/ -- -- v8-dev ma

[v8-dev] Re: Implement tracing interface for v8 (issue 988893003 by fmea...@chromium.org)

i guess v8 needs to depend on a target defined in the new DEPS entry to build with chromium https://codereview.chromium.org/988893003/diff/41/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/988893003/diff/41/BUILD.gn#newcode1271 BUILD.gn:1271: "src/tracing/trace-event.

[v8-dev] Re: [turbofan] Add backend support for float32 operations. (issue 1044793002 by bmeu...@chromium.org)

https://codereview.chromium.org/1044793002/diff/20001/test/cctest/test-disasm-arm.cc File test/cctest/test-disasm-arm.cc (right): https://codereview.chromium.org/1044793002/diff/20001/test/cctest/test-disasm-arm.cc#newcode98 test/cctest/test-disasm-arm.cc:98: // clang-format off please don't do

[v8-dev] Re: Finish 'MIPS: [turbofan] Add backend support for float32 operations.' (issue 1047213002 by balazs.kilv...@imgtec.com)

https://codereview.chromium.org/1047213002/diff/20001/test/cctest/test-assembler-mips.cc File test/cctest/test-assembler-mips.cc (right): https://codereview.chromium.org/1047213002/diff/20001/test/cctest/test-assembler-mips.cc#newcode49 test/cctest/test-assembler-mips.cc:49: // clang-format off

[v8-dev] making fast math functions per-isolate?

ate instead, so instead of getting to the methods via global static variables, all callsites have to get to them via the isolate, and we'd automatically have the correct isolate to use (also the comment about the icache would be true again...) comments? -jochen -- -- v8-dev mailing list v8-

[v8-dev] Re: Use msvs toolchain from depot_tools. (issue 1237803003 by machenb...@chromium.org)

no idea lgtm anyways https://codereview.chromium.org/1237803003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiv

Re: [v8-dev] Re: Isolate entry stacking bug?

ibute code to make this possible, that's highly appreciated. As you point out, we work towards having the embedder always provide the isolate to use, so we would no longer have to store any data in tls, but that's still far out in the future. best -jochen On Wed, Oct 21, 2015 at 7:27 PM Al

Re: [v8-dev] Re: Stack limits and AST visitors

t; AstVisitors should have, with a few exceptions? Or is it something that a > few AstVisitors care about, but most don't need to. Answering this question > will help decide what the right way of refactoring the base class stuff is. > > On Mon, Oct 12, 2015 at 12:31 PM, Jochen Ei

Re: [v8-dev] Re: Stack limits and AST visitors

We use the stack limit to request interrupts from different threads, so checking it on a regular basis is important On Mon, Oct 12, 2015, 9:30 PM Adam Klein wrote: > Any thoughts here? Caitlin is currently running into exactly the same need > in her do expression patch, so it'd be good to unders

[v8-dev] Re: [es6] ignore @@isConcatSpreadable if access check fails (issue 1230793002 by caitpotte...@gmail.com)

include/ lgtm https://codereview.chromium.org/1230793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

Re: [v8-dev] Code structure bikeshed: Where should spec reference implementations live?

dumping everything in objects.cc? really? On Fri, Sep 25, 2015 at 1:39 PM Benedikt Meurer wrote: > One important bit tho: The (static) methods should be somewhere close the > classes they relate to, otherwise we just go back to runtime-*.cc. > > On Fri, Sep 25, 2015 at 1:37 PM, Benedikt Meurer

[v8-dev] Re: Prototype CL for faster DOM accessors. (issue 1292283005 by vogelh...@chromium.org)

https://codereview.chromium.org/1292283005/diff/1/src/runtime/runtime-ptr.cc File src/runtime/runtime-ptr.cc (right): https://codereview.chromium.org/1292283005/diff/1/src/runtime/runtime-ptr.cc#newcode84 src/runtime/runtime-ptr.cc:84: RUNTIME_FUNCTION(Runtime_PtrLoadOffsetInt) { why not PtrTest

Re: [v8-dev] Code structure bikeshed: Where should spec reference implementations live?

I think (3) would be nice. There's also a bunch of code in api.cc and execution.cc that could be moved there. On Fri, Sep 25, 2015 at 11:58 AM Jakob Kummerow wrote: > As we have discussed at various occasions recently, we generally want to > move in the direction of having C++ implementations of

[v8-dev] Re: Fix a segment-fault caused by Value::IntegerValue (issue 1303093004 by pmq2...@gmail.com)

On 2015/09/09 at 23:35:56, info wrote: https://codereview.chromium.org/1303093004/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1303093004/diff/1/src/api.cc#newcode3271 src/api.cc:3271: has_pending_exception = On 2015/09/09 14:16:59, jochen wrote: > can you p

[v8-dev] Re: Continuing removing deprecated functions from cctests (issue 1331013003 by myth...@google.com)

overall looks good can you please run tryjobs? ToLocalChecked() corresponds to FromJust() which checks that the Maybe<> value is "just", so I'd use that where possible. https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc File test/cctest/test-u

[v8-dev] Re: Fix a segment-fault caused by Value::IntegerValue (issue 1303093004 by pmq2...@gmail.com)

thanks for the fix https://codereview.chromium.org/1303093004/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1303093004/diff/1/src/api.cc#newcode3271 src/api.cc:3271: has_pending_exception = can you pull the if() case in here instead of duplicating the returns? some

[v8-dev] Re: ArrayBuffers vs External strings

we used to have such a list and that resulted in second long pauses during gc when traversing the list. Using the map spreads out this work to the incremental marking, so there are no long pauses anymore. On Wed, Sep 9, 2015 at 12:41 PM Fedor Indutny wrote: > Hello again! > > Kindly reminding abo

[v8-dev] Re: [accessors] second-chance typed array field lookup (issue 1313493005 by fe...@indutny.com)

Jakob, can you take a look please? https://codereview.chromium.org/1313493005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group an

  1   2   3   4   5   6   7   8   9   10   >