+vogelheim: Could you take a look please? The external snapshot code was
crashing for Andre before he added this fix.
https://codereview.chromium.org/496253003/diff/1/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/496253003/diff/1/tools/js2c.py#newcode513
On 2014/08/22 10:46:59, baixo wrote:
On 2014/08/22 10:17:20, rmcilroy wrote:
+vogelheim: Could you take a look please? The external snapshot code
was
crashing for Andre before he added this fix.
https://codereview.chromium.org/496253003/diff/1/tools/js2c.py
File tools/js2c.py (right
Committed patchset #1 manually as 23323 (presubmit successful).
https://codereview.chromium.org/498433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as 23276 (presubmit successful).
https://codereview.chromium.org/494733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Thanks Ulan.
https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc#newcode3810
src/arm/assembler-arm.cc:3810: Assembler::PatchShiftImm(instr, (offset
0xff)));
Committed patchset #2 manually as 23278 (presubmit successful).
https://codereview.chromium.org/496443003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ulan,
Description:
Fix unused-variable error on release builds.
TBR=u...@chromium.org
Please review this at https://codereview.chromium.org/466333006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M src/arm/assembler-arm.cc
Committed patchset #1 manually as 23279 (tree was closed).
https://codereview.chromium.org/466333006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ulan,
Message:
Let's give this another go :).
Description:
Enable out-of-line constant pool for Arm.
Please review this at https://codereview.chromium.org/498433002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M src/globals.h
Reviewers: ulan,
Message:
PTAL Ulan, thanks.
Description:
Add ARMv6 support for the out-of-line constant pool.
Please review this at https://codereview.chromium.org/496443003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+276, -69 lines):
M
Committed patchset #1 manually as 23241 (presubmit successful).
https://codereview.chromium.org/479553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as 23242 (presubmit successful).
https://codereview.chromium.org/475753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Hannes Payer,
Description:
Change size of old pointer space first page back to 112KB (as it was before
r23241)
This broke ReleaseOverReservedPages on Windows ia32.
TBR=hpa...@chromium.org
Please review this at https://codereview.chromium.org/493703002/
SVN Base:
Committed patchset #1 manually as 23244 (tree was closed).
https://codereview.chromium.org/493703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ulan,
Message:
PTAL Ulan, thanks.
Description:
Add missing ConstantPoolUnavailableScopes on JS return.
Please review this at https://codereview.chromium.org/494733002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+21, -17 lines):
M
On 2014/08/15 20:34:34, andrew_low wrote:
Finally got caught up to bleeding edge again.
Code is again ready for tire-kicking.
The architecture-independed constant pool changes look good to me, thanks!
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
The architecture-indepent constant pool changes look good to me (with a
comment
on object-printer.cc), thanks!
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):
On 2014/08/14 12:04:21, rmcilroy wrote:
Yang, could you please take a look, thanks.
I fixed the issue we discussed last night with regards to the roots getting
copied - this turned out to be due to no support for root pointers from
code in
the serializer (which is required under certain
Reviewers: Hannes Payer,
Message:
Hannes, could you please take a look, thanks.
Description:
Modify SizeOfFirstPage to take ool constant pool into account.
The OOL constant pool places constants in the old pointer space rather than
the
code space
which makes
Committed patchset #1 manually as 23134 (tree was closed).
https://codereview.chromium.org/469283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Yang, could you please take a look, thanks.
Description:
Add serializer support for builtins pointed by InnerPointer for out-of-line
constant pool.
This is required for test-serialize tests which fail at the DCHECK on L1874
of
serialize.cc otherwise.
Please review
Reviewers: Benedikt Meurer,
Message:
Benedikt could you please take a look, thanks.
Description:
[turbofan]: Fix TurboFan for out-of-line constant pool on Arm.
Use LeaveFrame so that the constant pool pointer register is correctly
restored
when using the out-of-line constant pool. Also
Awesome, looks good to me. I don't know the x64 code too well though so
I'll
leave it to someone else to lg.
https://codereview.chromium.org/419803009/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
On 2014/07/31 07:53:55, Yang wrote:
The CQ bit was unchecked by mailto:yang...@chromium.org
The Android team fixed the issue, however should I still land this to be
safe?
Can I land it now while the tree is still throttled, it should be safe?
https://codereview.chromium.org/433463002/
--
On 2014/07/31 11:24:53, rmcilroy wrote:
On 2014/07/31 07:53:55, Yang wrote:
The CQ bit was unchecked by mailto:yang...@chromium.org
The Android team fixed the issue, however should I still land this to be
safe?
Can I land it now while the tree is still throttled, it should be safe
https://codereview.chromium.org/427863003/diff/20001/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):
https://codereview.chromium.org/427863003/diff/20001/src/arm/assembler-arm.h#newcode814
src/arm/assembler-arm.h:814: inline static Address
break_address_from_break_address(Address
On 2014/07/30 09:47:01, danno wrote:
Ross, could you please take a look at this and land it for Andrew?
lgtm, thanks. I'll land this with a slight change (moving the setting to be
above setting the pc).
https://codereview.chromium.org/430523002/
--
--
v8-dev mailing list
Committed patchset #2 manually as r22701 (presubmit successful).
https://codereview.chromium.org/430523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Yang, could you please take a look. Thanks.
Description:
Avoid calling memchr with a zero range as this is undefined behavior.
Calling memchr with a zero range is not explicitly specified to return
NULL, and
on Android arm64 it
returns an undefined value instead.
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h#newcode2605
src/objects-inl.h:2605: WRITE_UINT32_FIELD(this, kSmallLayout3Offset,
small_layout_3);
Why did you have to add
Thanks.
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc
File test/cctest/test-constantpool.cc (right):
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc#newcode287
test/cctest/test-constantpool.cc:287:
Committed patchset #5 manually as r22634 (presubmit successful).
https://codereview.chromium.org/396803009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/420753002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/420753002/diff/1/src/heap.cc#newcode58
src/heap.cc:58: // a multiple of Page::kPageSize.
move up to line above
On 2014/07/25 10:08:20, Hannes Payer wrote:
https://codereview.chromium.org/420753002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/420753002/diff/1/src/heap.h#newcode2283
src/heap.h:2283: void* idle_notification_histogram_;
On 2014/07/25 09:38:29, rmcilroy wrote
On 2014/07/25 11:26:25, Hannes Payer wrote:
I added a new category.
I think you need to add code to counters.cc don't you? E.g., creating the
Histogram object in Counters::Counters(...).
https://codereview.chromium.org/420753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2014/07/24 18:13:28, rmcilroy wrote:
Committed patchset #3 manually as r22608 (presubmit successful).
Hannes, I had to revert this because I forgot I was also using new-space
pointers in the other tests. I've removed this in the new patch set and
also
added a test to ensure
lgtm with a nit and an optional suggestion.
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc
File src/counters.cc (right):
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Fixed test and added asserts to ensure we don't add new space pointers in
constant pool array.
https://codereview.chromium.org/396803009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
This CL does fix the ConstantPoolPreciseGC test.
lgtm, thanks!
https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h#newcode1495
src/objects-inl.h:1495: if (type ==
Committed patchset #3 manually as r22597 (presubmit successful).
https://codereview.chromium.org/413693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Committed patchset #1 manually as r22598 (tree was closed).
Description:
Revert r22597 (which should have been called: Tests that the GC doesn't
mistake
non-pointer constant pool entries as poitners.)
TBR=yang...@chromium.org
Committed:
Committed patchset #3 manually as r22608 (presubmit successful).
https://codereview.chromium.org/396803009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h#newcode1495
src/objects-inl.h:1495: if (type == CONSTANT_POOL_ARRAY_TYPE) return
false;
The constant pool array does contain
Committed patchset #1 manually as r22554 (presubmit successful).
https://codereview.chromium.org/404333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
of
replacements (cf. build/detect_v8_host_arch.py; might even extend that
file
and
have Make call out to Python).
lgtm too (btw, I'm rmcilroy, not mcilroy - not sure who that is :))
https://codereview.chromium.org/408133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com
Reviewers: jochen, paul.l...,
Message:
This change is to avoid the following warning in a WebView build using
clang:
external/chromium_org/v8/src/arm64/constants-arm64.h:18:9: warning:
'__STDC_FORMAT_MACROS' macro redefined [-Wmacro-redefined]
#define __STDC_FORMAT_MACROS
^
Reviewers: Jakob,
Message:
PTAL Jakob, thanks.
Description:
Add CXX cross-compile detection into Makefile after it was removed from gyp.
Please review this at https://codereview.chromium.org/405113002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1
Committed patchset #1 manually as r22509 (presubmit successful).
https://codereview.chromium.org/405113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22512 (presubmit successful).
https://codereview.chromium.org/402923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Achenbach, Jakob,
Message:
I think this should fix the issue you were seeing in
http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/93944/steps/compile/logs/stdio
PTAL.
Description:
Fix the android_webview build's gyp files after the changes in
Committed patchset #1 manually as r22467 (presubmit successful).
https://codereview.chromium.org/399413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Jakob,
Message:
PTAL, thanks.
Description:
Move android_webview_build variable to toolchain.gypi to fix arm builders.
Please review this at https://codereview.chromium.org/392033005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -3 lines):
M
Committed patchset #1 manually as r22470 (presubmit successful).
https://codereview.chromium.org/392033005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: jochen,
Message:
Jochen, ptal, thanks.
Description:
[Arm]: Assert that movw/movt is only emitted for Armv7 targets
Please review this at https://codereview.chromium.org/402923002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M
Reviewers: Jakob,
Message:
Committed patchset #1 manually as r22444 (presubmit successful).
Description:
Reland Remove erroneous uses of CXX / CXX_target / CXX_host from gyp.
The current gyp config tries to test whether the compiler is an arm / mips
compiler and whether it supports -m32 / -m64
Committed patchset #2 manually as r22445 (presubmit successful).
https://codereview.chromium.org/385163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Benedikt Meurer,
Message:
Benedikt could you please take a look at this CL, thanks.
Description:
Add back a static_castint32_t to assembler-arm.cc to fix WebView build.
The WebView Mac builder is having trouble with resolving set_at_offset with
an
intptr_t argument to the correct
Committed patchset #1 manually as r22446 (presubmit successful).
https://codereview.chromium.org/398893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Hannes Payer,
Message:
Please take a look, thanks.
Description:
Tests that the GC doesn't mistake non-pointer constant pool entries as
poitners.
Adds a test for ConstantPoolArray to ensure that the GC doesn't mistake non-
pointer entries as pointers and try to modify them during
Thanks Jacob
https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi#newcode472
build/toolchain.gypi:472: ['_toolset==target', {
On 2014/07/16 08:25:34, Jakob wrote:
Committed patchset #2 manually as r22425 (presubmit successful).
https://codereview.chromium.org/382343003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Jakob,
Description:
Revert Remove erroneous uses of CXX / CXX_target / CXX_host from gyp.
This reverts commit r22425 for breaking the Arm debug builder.
BUG=384474
TBR=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/393273002/
SVN Base:
Committed patchset #1 manually as r22427 (tree was closed).
https://codereview.chromium.org/393273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/385163005/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/385163005/diff/1/src/spaces.cc#newcode3065
src/spaces.cc:3065: // strings), fixed arrays, byte arrays and constant
pool arrays in the
On 2014/07/16 15:23:28, Hannes Payer
Reviewers: Jakob,
Message:
Jacob, could you take a look please. Thanks.
Description:
Remove erroneous uses of CXX / CXX_target / CXX_host from gyp.
The current gyp config tries to test whether the compiler is an arm / mips
compiler and whether it supports -m32 / -m64 based on a test within
It seems I forgot to add you to the review... oops. Original message below:
Thanks for finding the InvalidateEmbeddedObjects fix Ulan! There were a
couple
of other things which needed fixing. The logs for the failing builds which
these changes fix are:
Hannes: looks like Ulan is OOO until August - could you please take a look
at
this CL?
https://codereview.chromium.org/385163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: ,
Message:
Thanks for finding the InvalidateEmbeddedObjects fix Ulan! There were a
couple
of other things which needed fixing. The logs for the failing builds which
these changes fix are:
Committed patchset #2 manually as r22332 (presubmit successful).
https://codereview.chromium.org/228633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: dslomov_gmail.com,
Description:
Revert Enable out-of-line constant pool on Arm
This reverts r22332 due to Arm breakages.
Please review this at https://codereview.chromium.org/384953002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -4 lines):
Committed patchset #1 manually as r22335 (tree was closed).
https://codereview.chromium.org/384953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22293 (presubmit successful).
https://codereview.chromium.org/376973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
I think we are ready to try this now Ulan :).
https://codereview.chromium.org/228633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Hannes Payer,
Message:
Hannes, could you please take a look. The change in
CONSTANT_POOL_ARRAY_TYPE
causes tests to fail when enabling the out-of-line constant pool on Arm (see
https://codereview.chromium.org/228633002/ which I was trying to land).
Description:
Move
Reviewers: ulan,
Message:
PTAL Ulan, thanks.
Description:
[Arm]: Optimize ConstantPoolBuilder::Populate code by minimizing calls to
OffsetOfElementAt
Calling OffsetOfElementAt becomes expensive when compiling functions with
many
constant pool entries. This was causing a regression in
Committed patchset #4 manually as r22209 (presubmit successful).
https://codereview.chromium.org/356393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc
File src/store-buffer.cc (right):
https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc#newcode560
src/store-buffer.cc:560: // We skip filler, free space, and constant
pool objects.
Could you add back
On 2014/07/02 12:39:07, rmcilroy wrote:
lgtm
https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc
File src/store-buffer.cc (right):
https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc#newcode560
src/store-buffer.cc:560: // We skip filler, free space
Thanks Ulan.
https://codereview.chromium.org/356393003/diff/60001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/356393003/diff/60001/src/arm/assembler-arm.cc#newcode1073
src/arm/assembler-arm.cc:1073: int Operand::instructions_required(const
lgtm, thanks.
https://codereview.chromium.org/365593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: ulan,
Message:
Ulan, please take a look, thanks.
Description:
[Arm]: Make Assembler::movw only emit a movw instruction.
Currently Assembler::movw is really the mov macro instruction, leading to
raw
emit calls to generate the real movw instruction. Replace all calls of mow
with
Reviewers: ulan,
Message:
This change depends on:
https://codereview.chromium.org/338053003/
https://codereview.chromium.org/329233002/
Ulan, please take a look, thanks.
Description:
[Arm]: Enable use of extended out-of-line constant pool for Arm.
- Adds support to the Arm assembler to
Committed patchset #1 manually as r22084 (presubmit successful).
https://codereview.chromium.org/338053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22085 (presubmit successful).
https://codereview.chromium.org/329233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Yang, please take a look, thanks.
Description:
[Arm]: Fix liveedit support if --enable_ool_constant_pool is true.
If the out of line constant pool is enabled, there is an extra value on the
stack frame (the
constant pool pointer). This change fixes
Weirdly this doesn't fail locally on my machine either. Maybe you are
using a
different gcc version? (I'm using gcc 4.6.3)
In any case, thanks for making the fix! lgtm
https://codereview.chromium.org/337273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 manually as r21932 (presubmit successful).
https://codereview.chromium.org/317653003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #3 manually as r21934 (presubmit successful).
https://codereview.chromium.org/304223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r21935 (presubmit successful).
https://codereview.chromium.org/340373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/20 11:40:07, ulan wrote:
[+Ross for Android perspective]
I wonder about cost vs benefit of this change. At the moment we do not
test or
run benchmarks for Aarch32. After this change we will have to. I am not
sure
of
there are embedders that going to run 32-bit V8 on arm64. Do
Reviewers: Jakob,
Message:
Jakob, could you please review this CL.
Vincent / Rodolph, as mentioned in crbug.com/384474, this CL changes
simulator
builds such that they don't implicitly set arm_test=on. I think this is
more
consistent with native builds. As far as I know, you are the only
lgtm, thanks!
https://codereview.chromium.org/338523005/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):
https://codereview.chromium.org/338523005/diff/1/src/arm64/assembler-arm64.h#newcode2103
src/arm64/assembler-arm64.h:2103: // * code generation is finished
On
Looks like a nice cleanup overall, couple of comments.
Note - the Arm backend is very close to switching over to the OOL constant
pool,
and we want to switch Arm64 to this soon after. I'm not sure if you have
any
more plans for the Arm64 constant pool, but if so it may make more sense to
it
as it is. I
am happy to push a follow up CL if we decide to change this.
On 2014/06/06 22:48:58, rmcilroy wrote:
How about having the argument be a byte offset from PC (like the old
LoadLiteral). This seems clearer to me. WDYT?
I prefer that it stays consistent with what's already here, so
Lgtm with a couple of suggestions. Thanks.
https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc#newcode1482
src/arm64/assembler-arm64.cc:1482:
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2876
src/mark-compact.cc:2876: if (!(compacting_
dst-IsConstantPoolArray())) {
On 2014/06/03 22:57:11, Michael
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2874
src/mark-compact.cc:2874: // We special case ConstantPoolArrays below
since they could contain
On 2014/06/04
Reviewers: ulan,
Message:
PTAL, thanks.
Description:
[Arm] Various cleanups to the Arm assembler backend.
A couple of cleanups to the Arm backend to enable support of extended
OOL constant pools in a following CL.
- Remove instruction pattern extern const's and replace their use with
Thanks for the review Ulan, PTAL.
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc#newcode134
src/factory.cc:134: HandleConstantPoolArray
Factory::NewExtendedConstantPoolArray(
On 2014/06/02 13:14:00, mvstanton wrote:
Just as a DBC: this is great. I'm thinking to be able to use these handy
ConstantPoolArrays as elements in the feedback vector when feedback for a
particular node (say a LoadIC) would like to store code addresses as well
as
object pointers. You've
301 - 400 of 765 matches
Mail list logo
