Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (17 inline comments)
Thanks!
Some more questions...
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for editBonding/removeBonding
..
Patch Set 9: Looks good to me, but someone else must approve
Good!
--
To view, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: (1 inline comment)
Looks good to me, just a minor comment.
Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/15445
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: (1 inline comment)
File vdsm/netconf/ifcfg.py
Line 29:
Giuseppe Vallarelli has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Antoni Segura Puimedon has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: (1 inline comment)
File lib/vdsm/netinfo.py
Line 517:
Antoni Segura Puimedon has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 3: (2 inline comments)
Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 3: (2 inline comments)
Lukas Bednar has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 2: (1 inline comment)
File vdsm/codeCoveragePlugin.py
Line 37:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2753/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 4:
Build Successful
Lukas Bednar has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 3: Verified
built rpms, installed, checked whether coverage was generated
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
Lukas Bednar has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 3: (2 inline comments)
File vdsm/codeCoveragePlugin.py
Line 17: #
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2756/ :
Sergey Gotliv has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Simplify setNewMtu()
..
Patch Set 10: Looks good to me, approved
Thanks.
--
To view, visit http://gerrit.ovirt.org/15355
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Simplify setNewMtu()
..
Simplify setNewMtu()
It will update the interface's MTU only if its user being removed has
the maximum MTU.
Change-Id:
Ayal Baron has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 14: Looks good to me, but someone else must approve
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 4: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/15545
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12003
To
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Giuseppe Vallarelli has posted comments on this change.
Change subject: netmodels code cleanup
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/15478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yeela Kaplan has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11: I would prefer that you didn't submit this
oops. This patch incurs and API change
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2758/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11: I would prefer that you didn't submit this
Let's expose the API we agreed upon:
Federico Simoncelli has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: add the live diskSizeExtend method
..
vm: add the live diskSizeExtend method
This patch adds the diskSizeExtend HSM method to implement the live disk
Federico Simoncelli has posted comments on this change.
Change subject: volume: add the extendVolumeSize method
..
Patch Set 3: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
..
Patch Set 1: (2 inline comments)
File client/vdsClient.py
Eduardo has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 14: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 3: (2 inline comments)
A race condition made me not post these comments but they still apply.
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 5: I would prefer that you didn't submit this
Please see my comments to ps3
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: add the BLOCK_SIZE constant
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2759/ : SUCCESS
Daniel Erez has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: add the extendVolumeSize method
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2760/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2761/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 6: (3 inline comments)
-1 Some questions need answers.
Giuseppe Vallarelli has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 6: I would prefer that you didn't submit this
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: netmodels for editBonding/removeBonding
..
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
relatively minor question
Giuseppe Vallarelli has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Except for a minor comment in
Dan Kenigsberg has posted comments on this change.
Change subject: Separate libvirt network configuration from ifcfg
..
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add NFS storage domain functional tests
..
Patch Set 4: (1 inline comment)
File
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: functional test: boot VM with network interface device
..
functional test: boot VM with network interface device
Change-Id:
Zhou Zheng Sheng has posted comments on this change.
Change subject: functional test: boot VM with network interface device
..
Patch Set 1: Verified
Test on Fedora17 and RHEL6.
--
To view, visit http://gerrit.ovirt.org/15633
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add NFS storage domain functional tests
..
Patch Set 5: Verified
Test on Fedora17 and RHEL6.
--
To view, visit http://gerrit.ovirt.org/13105
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: Storage Domain V3 Functional Tests
..
Patch Set 2: Verified
Test on Fedora17 and RHEL6, rebase to latest master.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: functional test: boot VM with network interface device
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2764/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add NFS storage domain functional tests
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2763/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: avoid service action redirections
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2765/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: extend service module to cover alternative service
names
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: extend service module to check existence of a
service
..
Patch Set 5:
Build Successful
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: extend service module to cover alternative service
names
..
Patch Set 9: Verified
Rebase to master.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: extend service module to check existence of a
service
..
Patch Set 5: Verified
Rebase to master
--
To view, visit http://gerrit.ovirt.org/15100
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: avoid service action redirections
..
Patch Set 5: Verified
Rebase to master
--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe,
59 matches
Mail list logo
