Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2862/ : SUCCESS htt

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2861/ : SUCCESS htt

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix multiple default gateways reporting .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2860/ : SUCCESS http://jenkin

Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2859/ : SUCCESS htt

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2858/ : SUCCESS htt

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix multiple default gateways reporting .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2857/ : SUCCESS http://jenkin

Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2856/ : SUCCESS htt

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2855/ : SUCCESS htt

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) ..

Change in vdsm[master]: netinfo: fix getMaxMtu generator handling

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: fix getMaxMtu generator handling .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Thanks for this catch, Toni! But clear

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: fix handleBondings regression .. Patch Set 1: I would prefer that you didn't submit this Ouch. that's not nice. If only we had an easily-run func

Change in vdsm[master]: netinfo: fix getMaxMtu generator handling

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: fix getMaxMtu generator handling .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2854/ : SUCCESS http://jenk

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: fix handleBondings regression .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2853/ : SUCCESS http://j

Change in vdsm[master]: netinfo: fix getMaxMtu generator handling

2013-06-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: fix getMaxMtu generator handling .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15903 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: configNetwork: fix handleBondings regression .. Patch Set 1: Verified Turns out that when I verified the original patch, the server I normally use had

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-19 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: configNetwork: fix handleBondings regression .. configNetwork: fix handleBondings regression during the rebase destroy was not updated to its new name

Change in vdsm[master]: netinfo: fix getMaxMtu generator handling

2013-06-19 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: netinfo: fix getMaxMtu generator handling .. netinfo: fix getMaxMtu generator handling getMaxMtu was changed to use iterables instead of just lists. Th

Change in vdsm[master]: [WIP] hooks: Add OVS support to Quantum vNIC hook

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) ..

Change in vdsm[master]: [WIP] hooks: Add OpenStack Network vNIC hook

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] hooks: Add OpenStack Network vNIC hook .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments) Almost ready :) .

Change in vdsm[master]: iproute2 binary wrapper

2013-06-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: iproute2 binary wrapper .. iproute2 binary wrapper Initially to be used by the upcoming multiple gateways feature. Only the needed commands were implem

Change in vdsm[master]: iproute2 binary wrapper

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 20: Looks good to me, approved (1 inline comment) File vdsm/ipwrapper

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS http://jenki

Change in vdsm[master]: tests: Adding functional tests for networking

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2852/ : SUCCESS http:/

Change in vdsm[master]: tests: Adding functional tests for networking

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 21: Verified rebase -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http

Change in vdsm[master]: [WIP] Feature hidden bond: Adding support for hiding bonds.

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Feature hidden bond: Adding support for hiding bonds. .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2851/ :

Change in vdsm[master]: [WIP] Feature hidden bond: Adding support for hiding bonds.

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Feature hidden bond: Adding support for hiding bonds. .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2850/ :

Change in vdsm[master]: [WIP] Feature hidden bond: Adding support for hiding bonds.

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] Feature hidden bond: Adding support for hiding bonds. .. Patch Set 3: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovi

Change in vdsm[master]: [WIP] Feature hidden bond: Adding support for hiding bonds.

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] Feature hidden bond: Adding support for hiding bonds. .. Patch Set 3: (1 inline comment) File li

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix multiple default gateways reporting .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2849/ : SUCCESS http://jenk

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS http://jenki

Change in vdsm[master]: tests: Adding functional tests for networking

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 20: Verified; I would prefer that you didn't submit this needs an easy manual rebase. -- To view, v

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Fix multiple default gateways reporting .. Patch Set 1: Fails Forgot to add ipwrapper to lib/vdsm/Makefile.am -- To view, visit http://gerrit.ovirt.or

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix multiple default gateways reporting .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2848/ : SUCCESS http://jenk

Change in vdsm[master]: Fix multiple default gateways reporting

2013-06-19 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: Fix multiple default gateways reporting .. Fix multiple default gateways reporting Up until now there was just a default gateway per host, defining def

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS http:/

Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2846/ : SUCCESS http:/

Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2845/ : SUCCESS h

Change in vdsm[master]: iproute2 binary wrapper

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 18: (2 inline comments) File tests/ipwrapperTests.py Line 25: Line 26

Change in vdsm[master]: iproute2 binary wrapper

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 20: (2 inline comments) File vdsm/ipwrapper.py Line 37: Line 38: Lin

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 16: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2844/ : SUCCESS h

Change in vdsm[master]: volume: add the BLOCK_SIZE constant

2013-06-19 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14589 To unsubscri

Change in vdsm[master]: vdsm: report migration status in getVMList() call

2013-06-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call .. Patch Set 3: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: vdsm: migration progress: count memRemaining also

2013-06-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS http://jenki

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS http://jenki

Change in vdsm[master]: volume: add the extendVolumeSize method

2013-06-19 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: volume: add the extendVolumeSize method .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14590 To unsub

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 7: All previous comments have been addressed. -- To view, visit http://gerrit

Change in vdsm[master]: Ignore partially deleted images in getAllImages().

2013-06-19 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Ignore partially deleted images in getAllImages(). .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/129

Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2843/ :

Change in vdsm[master]: gluster: add task support

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add task support .. Patch Set 10: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/28

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS http:/

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 2: (1 inline comment) Commit Message Line 7: Fix

Change in vdsm[master]: functional test: boot VM with network interface device

2013-06-19 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: functional test: boot VM with network interface device .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Remove unused onlyDataDomains parameter from getImageDomains...

2013-06-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove unused onlyDataDomains parameter from getImageDomainsList. .. Remove unused onlyDataDomains parameter from getImageDomainsList. This patch is r

Change in vdsm[master]: Remove unused onlyDataDomains parameter from getImageDomains...

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Remove unused onlyDataDomains parameter from getImageDomainsList. .. Patch Set 7: Verified Copying Elad Ben Aharon's verification. -- To view, visit http://g

Change in vdsm[master]: Remove unused onlyDataDomains parameter from getImageDomains...

2013-06-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Remove unused onlyDataDomains parameter from getImageDomainsList. .. Patch Set 7: Looks good to me, approved Ok, I'll believe you that this API change is harml

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-19 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 2: Fails (1 inline comment) Back to the drawing board. It works on command line, but the automated env