Change in vdsm[master]: hooks: README for OpenStack Network vNIC hook

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: README for OpenStack Network vNIC hook .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-24 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: configNetwork: fix handleBondings regression .. configNetwork: fix handleBondings regression during the rebase destroy was not updated to its new name

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: fix handleBondings regression .. Patch Set 8: Looks good to me, approved Thanks for the quick fix! -- To view, visit

Change in vdsm[master]: netinfo: get an interface using one of IP addresses assigned...

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: get an interface using one of IP addresses assigned to it .. Patch Set 6: Looks good to me, approved We already require libvirt = 1.0.2-1, which is

Change in vdsm[master]: netinfo: get an interface using one of IP addresses assigned...

2013-06-24 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: get an interface using one of IP addresses assigned to it .. netinfo: get an interface using one of IP addresses assigned to it We record

Change in vdsm[master]: netinfo: get an interface using one of IP addresses assigned...

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: get an interface using one of IP addresses assigned to it .. Patch Set 7: Verified; Looks good to me, approved rebase -- To view, visit

Change in vdsm[master]: Remove StoragePool.getImageDomainsList().

2013-06-24 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Remove StoragePool.getImageDomainsList(). .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12927 To unsubscribe, visit

Change in vdsm[master]: Ignore partially deleted images in getAllImages().

2013-06-24 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Ignore partially deleted images in getAllImages(). .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12938 To unsubscribe,

Change in vdsm[master]: vdsm: migration progress: count memRemaining also

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15124 To unsubscribe,

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: net_functional_tests: bondWithManyVlans. .. net_functional_tests: bondWithManyVlans. This patch adds a tests for adding several vlanned networks over

Change in vdsm[master]: WIP: Introduce a base network configurator class

2013-06-24 Thread wudxw
Mark Wu has abandoned this change. Change subject: WIP: Introduce a base network configurator class .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/15300 To unsubscribe, visit

Change in vdsm[master]: Add basic test cases for configuring network interfaces

2013-06-24 Thread wudxw
Mark Wu has abandoned this change. Change subject: Add basic test cases for configuring network interfaces .. Patch Set 5: Abandoned -- To view, visit http://gerrit.ovirt.org/14306 To unsubscribe, visit

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 1: Fails; I would prefer that you didn't submit this Build Failed

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/16025 To unsubscribe, visit

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 2: I would prefer that you didn't submit this I appreciate that you're adding new tests and they are

Change in vdsm[master]: configNetwork: fix handleBondings regression

2013-06-24 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: configNetwork: fix handleBondings regression .. Patch Set 9: I meant to verify this patch as well before getting it merged. -- To view, visit

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 2: I would appreciate specific comments. -- To view, visit http://gerrit.ovirt.org/16025 To

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 1: (4 inline comments) File

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 1: (4 inline comments) File

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 1: (2 inline comments) File

Change in vdsm[master]: net_functional_tests: bondWithManyVlans.

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_functional_tests: bondWithManyVlans. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2900/ : SUCCESS

Change in vdsm[master]: Add balloon_min to VM.getVmBalloonInfo

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add balloon_min to VM.getVmBalloonInfo .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2901/ : SUCCESS

Change in vdsm[master]: Fix the charset conversion logic in hooks.py

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2902/ : SUCCESS

Change in vdsm[master]: vdsm: [WIP] Reboot capability for VM

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: [WIP] Reboot capability for VM .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2903/ : SUCCESS

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 19: (2 inline comments) File

Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration .. Patch Set 7: I would prefer that you didn't submit this (3 inline comments) minor comments only.

Change in vdsm[master]: vdsm: report migration status in getVMList() call

2013-06-24 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call .. Patch Set 3: (1 inline comment) Commit Message

Change in vdsm[master]: vdsm: [WIP] Reboot capability for VM

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: [WIP] Reboot capability for VM .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2904/ : SUCCESS

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-24 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 19: (1 inline comment) File

Change in vdsm[master]: RAM snapshots feature

2013-06-24 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 7: (8 inline comments) File vdsm/BindingXMLRPC.py Line 279: def

Change in vdsm[master]: RAM snapshots feature

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2905/ : SUCCESS

Change in vdsm[master]: Avoid redundant check for volume create rollback.

2013-06-24 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Avoid redundant check for volume create rollback. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Reimplement hsm.getVolumesList().

2013-06-24 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Reimplement hsm.getVolumesList(). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15766 To

Change in vdsm[master]: Reimplement hsm.getVolumesList().

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reimplement hsm.getVolumesList(). .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2906/ : SUCCESS

Change in vdsm[master]: volume: add the BLOCK_SIZE constant

2013-06-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14589 To

Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module .. Patch Set 19: I would prefer that you didn't submit this Marking -1 given Assaf's comment. -- To view,

Change in vdsm[master]: hooks: README for OpenStack Network vNIC hook

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: README for OpenStack Network vNIC hook .. Patch Set 1: BTW, I find it much nicer to include a README within the same patch as the code it describes.

Change in vdsm[master]: functional test: boot VM with network interface device

2013-06-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: functional test: boot VM with network interface device .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15633 To

Change in vdsm[master]: functional test: boot VM with network interface device

2013-06-24 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: functional test: boot VM with network interface device .. functional test: boot VM with network interface device Change-Id:

Change in vdsm[master]: hotunplug: identify a nic according to its alias

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: hotunplug: identify a nic according to its alias .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2907/ : SUCCESS

Change in vdsm[master]: Decouple images and volumes from pool path

2013-06-24 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Decouple images and volumes from pool path .. Decouple images and volumes from pool path Change-Id: Ibde0becf2600ddf2390d12a4e854e1abbd3b1e40 Signed-off-by: Eduardo

Change in vdsm[master]: [WIP] Decouple images and volumes from pool path

2013-06-24 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Decouple images and volumes from pool path .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2909/ : SUCCESS