oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3043/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 5: (3 inline comments)
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 5: (1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixing pep8 and pyflake errors after updating to new pep8
version
..
Patch Set 3:
Build Successful
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: [WIP] Reboot capability for VM
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Agreeing with tony on vm.py
Vinzenz Feenstra has posted comments on this change.
Change subject: Fixing spec file for python-ethtool requirements
..
Patch Set 2: (1 inline comment)
File vdsm.spec.in
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 12: (8 inline comments)
File vdsm/vm.py
Line 2852: if
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3045/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: Verified
Tests pass.
--
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Clean the imports a bit
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3046/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3047/ : SUCCESS
ofri masad has posted comments on this change.
Change subject: API: Add free memory to stats
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/16253
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: Add free memory to stats
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3048/ : SUCCESS
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: vdsm-tool: service management work with previous systemd release
..
vdsm-tool: service management work with previous systemd release
The service management
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 1: Verified
Test on F17
--
To view, visit http://gerrit.ovirt.org/16379
To
Peter V. Saveliev has uploaded a new change for review.
Change subject: vdsClient: check getFileList arguments
..
vdsClient: check getFileList arguments
A simple check of getFileList arguments on the function call.
Bug-Url:
Peter V. Saveliev has posted comments on this change.
Change subject: vdsClient: check getFileList arguments
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/16380
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsClient: check getFileList arguments
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3050/ : SUCCESS
Peter V. Saveliev has uploaded a new change for review.
Change subject: vdsm: fix config comment for migration_timeout
..
vdsm: fix config comment for migration_timeout
The migration_timeout variable means not overall migration
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix config comment for migration_timeout
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3051/ : SUCCESS
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsClient: check getFileList arguments
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16380
To
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing pep8 and pyflake errors after updating to new pep8
version
..
Patch Set 3: Looks good to me, approved
I have no idea why you wouldn't state the version
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing pep8 and pyflake errors after updating to new pep8
version
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/16339
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixing pep8 and pyflake errors after updating to new pep8
version
..
Fixing pep8 and pyflake errors after updating to new pep8 version
Change-Id:
mooli tayer has uploaded a new change for review.
Change subject: Decoupling libvirtconnection.py from clintIf.py
..
Decoupling libvirtconnection.py from clintIf.py
1.) Decoupling libvirtconnection.py from clientIF.py
adding
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Decoupling libvirtconnection.py from clintIf.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3052/ : SUCCESS
Kiril Nesenko has posted comments on this change.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3053/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Patch Set 1: No score
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3053/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: vm: Fix custom device properties on hot operation
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Verified:
Used the engine GUI to set
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Fix custom device properties on hot operation
..
vm: Fix custom device properties on hot operation
On hot plug unplug of a vNIC/vDisk the custom
Dan Kenigsberg has posted comments on this change.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16394
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix pep8 compliance after updating to latest pep8
..
Fix pep8 compliance after updating to latest pep8
Change-Id:
Assaf Muller has uploaded a new change for review.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Fixed rollback of port-mirroring enabled nic during hotplugNic
During vm.py:hotplugNic, if the
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16400
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 1: Fails
Build Failed
Assaf Muller has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 1: Verified
Verification -
I checked 'Verified', however I did not ran the code
Dan Kenigsberg has posted comments on this change.
Change subject: Decoupling libvirtconnection.py from clintIf.py
..
Patch Set 1: I would prefer that you didn't submit this
(7 inline comments)
Thanks Mooli, I really want to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsClient: check getFileList arguments
..
vdsClient: check getFileList arguments
A simple check of getFileList arguments on the function call.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsClient: check getFileList arguments
..
Patch Set 1: Looks good to me, approved
Fine by me.
--
To view, visit http://gerrit.ovirt.org/16380
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: (1 inline comment)
File vdsm/hooks.py
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/15856
To
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 9: Looks good to me, approved
Martin, would you please verify that this actually passes custom
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 1: I would prefer that you didn't submit this
Please rebase on top of recent
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 2: Fails
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3056/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 23: (1 inline comment)
File vdsm/gluster/services.py
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 23: (1 inline comment)
File
Assaf Muller has uploaded a new change for review.
Change subject: before/after_update_device hook now receives custom properties
..
before/after_update_device hook now receives custom properties
Change-Id:
Assaf Muller has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 2: Verified
Copied verified flag from last patch set.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 1: Fails
Build Failed
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 5: (3 inline comments)
File vdsm_api/vdsmapi-schema.json
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 6: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3058/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 12: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3059/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Clean the imports a bit
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3060/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3061/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16400
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixed rollback of port-mirroring enabled nic during hotplugNic
..
Fixed rollback of port-mirroring enabled nic during hotplugNic
During
Eduardo has uploaded a new change for review.
Change subject: Use more fine lock for hsm.deleteImage().
..
Use more fine lock for hsm.deleteImage().
When removing an image from a specific SD, lock the image in this
SD
Eduardo has uploaded a new change for review.
Change subject: Remove unused hsm._hsmSchedule()
..
Remove unused hsm._hsmSchedule()
Related to: BZ#960952.
Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Signed-off-by:
Eduardo has uploaded a new change for review.
Change subject: Avoid running scheduled jobs when not SPM.
..
Avoid running scheduled jobs when not SPM.
Related to: BZ#960952.
Change-Id: I0402817df9c2c08a5a945082edfbb03e832facbe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove unused hsm._hsmSchedule()
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3064/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove StoragePool.createVolume().
..
Patch Set 2: Fails; I would prefer that you didn't submit this
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid running scheduled jobs when not SPM.
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3063/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Improve StoragePool.detachAllDomains() monitoring.
..
Improve StoragePool.detachAllDomains() monitoring.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use more fine lock for hsm.deleteImage().
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3065/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
mooli tayer has uploaded a new change for review.
Change subject: Adding intellij project files to .gitignore
..
Adding intellij project files to .gitignore
Change-Id: I337ff8ea0e950ae94effb226a5170570b489d68a
Signed-off-by:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding intellij project files to .gitignore
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3066/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 13: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3067/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 11: Fails; I would prefer that you didn't submit this
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Clean the imports a bit
..
Patch Set 5: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3069/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 15: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3070/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: Simplify configWriter to use netmodels
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16324
To
Giuseppe Vallarelli has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 1: I would prefer that you didn't submit this
Hi Assaf you got a pep8 issue:
Mark Wu has posted comments on this change.
Change subject: netconf: Add a base configurator class
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/16178
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: Add a base configurator class
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3073/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3072/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: enable multiple gateways for iproute2 configurator
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3071/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3074/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: Simplify configWriter to use netmodels
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
See comment.
Eduardo has uploaded a new change for review.
Change subject: Failing to deactivate LVs is a serious issue.
..
Failing to deactivate LVs is a serious issue.
Changing volumes that are active in multiple hosts can lead to DC.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Failing to deactivate LVs is a serious issue.
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3076/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot teardown.
..
Patch Set 7: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3075/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix the charset conversion logic in hooks.py
..
Fix the charset conversion logic in hooks.py
The proper way to convert text from byte oriented string
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 11: Verified; Looks good to me, approved
I do not know what is wrong with our slaves' pep8 tool, and
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 1: (1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 2: Fails
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 3: Fails
Build Failed
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: PEP8: fix tests/hooksTests.py
..
PEP8: fix tests/hooksTests.py
pep8 1.4.6 gives the following error
tests/hooksTests.py:140:23: E127 continuation line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP8: fix variours errors
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2269/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 5: Fails
Build Failed
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8: fix variours errors
..
Patch Set 2: Verified
Test on RHEL6 and Fedora.
It seems the RHEL6 slave needs update the python-pep8 tool.
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 5: Verified
Jenkins error does not related to this patch. It seems the RHEL6
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit
97 matches
Mail list logo
