Francesco Romani has posted comments on this change.
Change subject: nestedvt hook: identify kvm_amd properly
..
Patch Set 3: Code-Review+1
looks good, check for the exact match (kvm_intel=Y, kvm_amd=1) would probably
be
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: Log unhandled exception for new Thread
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23085
To unsubscribe, visit
Hello Bala.FA,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23201
to review the following change.
Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume
stats info.
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume
stats info.
..
Patch Set 1: Code-Review-1
Build Unstable
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: exclude HWADDR lines if requested
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit
Itamar Heim has abandoned this change.
Change subject: new API call getVersionInfo()
..
Abandoned
no activity - feel free to re-open if relevant
--
To view, visit http://gerrit.ovirt.org/8431
To unsubscribe, visit
Itamar Heim has abandoned this change.
Change subject: vdsm: cope with I/O errors, getting permissions
..
Abandoned
no activity - feel free to re-open if relevant
--
To view, visit http://gerrit.ovirt.org/18371
To
Itamar Heim has abandoned this change.
Change subject: vdsm: catch timeout while starting VM
..
Abandoned
no activity - feel free to re-open if relevant
--
To view, visit http://gerrit.ovirt.org/12235
To unsubscribe, visit
Itamar Heim has abandoned this change.
Change subject: [WIP] objectfs integration
..
Abandoned
no activity - feel free to re-open if relevant
--
To view, visit http://gerrit.ovirt.org/8383
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume
stats info.
..
Patch Set 2:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23183
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Removing unnecessary check-local from storage Makefile.am
We used that to run
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: Log unhandled exception for new Thread
..
Patch Set 1:
(1 comment)
File vdsm/netconf/ifcfg.py
Line
Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23202
to review the following change.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23202
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: vm: Update LUN size when starting a vm
..
Patch Set 6: Code-Review-1
(1 comment)
File vdsm/clientIF.py
Line 267:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Vdsm changes
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6705/ : SUCCESS
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Removing unnecessary check-local from storage Makefile.am
We used that to run
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing unnecessary check-local from storage Makefile.am
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23202
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: ifcfg: Log unhandled exception for new Thread
..
Patch Set 1:
(2 comments)
Looks good except » that sneaked in to the commit message.
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/21789/26//COMMIT_MSG
Commit Message:
Line 39:
Line 40:
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Code-Review+1
Fine by me if you're sure that timeOffset was/is mandatory and it's already
present in all the running
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line 357:
Itamar Heim has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3:
ignore this comment
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 2: Code-Review+1
+1 but please switch to tuples.
--
To view, visit http://gerrit.ovirt.org/21036
To
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
* addressed comments
* added an update to the vm container to reflect changes when migrating etc
--
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Verified+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6706/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: exclude HWADDR lines if requested
..
ifcfg: exclude HWADDR lines if requested
In prehistoric days, our ifcfg files included HWADDR lines for
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: exclude HWADDR lines if requested
..
Patch Set 5: Code-Review+2
So let's take it in!
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: add mechanism to persist vmDevice defaults
..
Patch Set 2: Code-Review+1
(1 comment)
I like the idea, just check if the getattr part can be
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Determine bootproto without ifcfg files
..
Patch Set 2:
(6 comments)
http://gerrit.ovirt.org/#/c/23098/2/lib/vdsm/netinfo.py
File
Assaf Muller has posted comments on this change.
Change subject: Extend setupNetworks API to accept defaultRoute
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/22720/2/lib/vdsm/tool/unified_persistence.py
File
Michal Skrivanek has posted comments on this change.
Change subject: nestedvt hook: identify kvm_amd properly
..
Patch Set 3: Verified+1 Code-Review+1
Verified by Sander Grendelman san...@grendelman.com
--
To view, visit
Hello Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23213
to review the following change.
Change subject: Move zombieReaper to its own package
..
Move zombieReaper
Yaniv Bronhaim has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23213
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using old form of zombiereaper
..
Using old form of zombiereaper
In ovirt-3.3 we don't include the change [1] that modifies zombieReaper
to zombiereaper.
The
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23213
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File vdsm/guestIF.py:
Line
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/22928/5/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
Patch set 6: address comments.
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6707/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6708/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Using old form of zombiereaper
..
Patch Set 1: Code-Review+1
I prefer this minimal fix to ovirt-3.3/
--
To view, visit http://gerrit.ovirt.org/23215
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Using old form of zombiereaper
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23215
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Using old form of zombiereaper
..
Using old form of zombiereaper
In ovirt-3.3 we don't include the change [1] that modifies zombieReaper
to
Nir Soffer has posted comments on this change.
Change subject: Using old form of zombiereaper
..
Patch Set 1:
Seems that renaming the package in ovirt-3.3 is simpler and more forward
compatible solution.
How zombiereaper
Federico Simoncelli has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 7: Verified+1
Commit message change.
--
To view, visit http://gerrit.ovirt.org/21787
To
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
Jenkins failure is unrelated (and quite strange to me)
Fetching upstream changes from origin
Yaniv Bronhaim has abandoned this change.
Change subject: Move zombieReaper to its own package
..
Abandoned
instead of taking it to ovirt-3.3 the patch http://gerrit.ovirt.org/#/c/23215/
fixes the import error introduced by
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File
Francesco Romani has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Vdsm changes
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6710/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6709/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21787
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: nestedvt hook: identify kvm_amd properly
..
nestedvt hook: identify kvm_amd properly
kvm_amd uses 1 for it's nested flag, kvm_intel uses Y
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: nestedvt hook: identify kvm_amd properly
..
Patch Set 3: Code-Review+2
Thanks, Sander.
--
To view, visit http://gerrit.ovirt.org/23164
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 2: Code-Review-1
Changes: rewrote the commit message, hopefully it is clearer now.
Nir: yes, on second
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6711/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Assaf Muller has uploaded a new change for review.
Change subject: Fix VDSM boot
..
Fix VDSM boot
Fix regression introduced in Gerrit 22750, hash 114692f.
The unified net persistence upgrade name was changed, changing
the name
Assaf Muller has posted comments on this change.
Change subject: Fix VDSM boot
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23218
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix VDSM boot
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6712/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix VDSM boot
..
Fix VDSM boot
Fix regression introduced in Gerrit 22750, hash 114692f.
The unified net persistence upgrade name was changed,
Dan Kenigsberg has posted comments on this change.
Change subject: Fix VDSM boot
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/22419/5//COMMIT_MSG
Commit Message:
Line 14: - refactor out
Yaniv Bronhaim has uploaded a new change for review.
Change subject: moving zombieReaper to lib/vdsm
..
moving zombieReaper to lib/vdsm
Change-Id: I0d6040f3bfe2cdc34c04e3d460cccaa9df1048b1
Signed-off-by: Yaniv Bronhaim
Nir Soffer has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/22419/5//COMMIT_MSG
Commit Message:
Line 14: - refactor out all the
Yaniv Bronhaim has restored this change.
Change subject: Move zombieReaper to its own package
..
Restored
--
To view, visit http://gerrit.ovirt.org/23213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert Using old form of zombiereaper
..
Revert Using old form of zombiereaper
This reverts commit d1bb20a892d32822e8f04488fb12df0ffea76a04.
This patch
Nir Soffer has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 6: Code-Review+1
I would be happier if this patch was separated to smaller patches which are
easier to review, but
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6713/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 6: Verified+1
Just verified again with a couple of masterMigrate
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert Using old form of zombiereaper
..
Revert Using old form of zombiereaper
This reverts commit d1bb20a892d32822e8f04488fb12df0ffea76a04.
This
Dan Kenigsberg has posted comments on this change.
Change subject: Revert Using old form of zombiereaper
..
Patch Set 1: Verified+1 Code-Review+2
Former patch was not really verified. Reveting.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
Introducing new API for setting the number of cpus of a
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21787
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
Build Successful
Ayal Baron has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 2: Code-Review+1
Yaniv, is it require now then? (Asking based on your restore)
--
To view,
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert utils: Create AsyncProcessOperation
..
Revert utils: Create AsyncProcessOperation
This reverts commit ed426e5590df421bace0aef9fc802baf2a24a5f2.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert iscsi: Iscsi rescan cleanup
..
Revert iscsi: Iscsi rescan cleanup
This reverts commit 9df615a98ef98a3111f691c0f1dd47a979b48032.
Change-Id:
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
vdsm.spec: specify sysV commands for EL6 only
To provide EL7 builds we must update the spec to
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23235
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert iscsi: Iscsi rescan cleanup
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/335/ :
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/23235
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
Patch Set 2:
the second version I have updated the commit message..
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6714/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/17004/5/vdsm/guestIF.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: specify sysV commands for EL6 only
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6715/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Revert utils: Create AsyncProcessOperation
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23234
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert iscsi: Iscsi rescan cleanup
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/336/ : SUCCESS
1 - 100 of 127 matches
Mail list logo
