Nir Soffer has posted comments on this change.
Change subject: blockSD: Refactor matadataValidity
..
Patch Set 1:
ping!
--
To view, visit http://gerrit.ovirt.org/25208
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
ping!
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11/tests/samplingTests.py
File tests/samplingTests.py:
L
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7039/
Federico Simoncelli has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 2: Code-Review+1
(1 comment)
Looks ok. I am not confident enough for a +2 today yet.
http://
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 8:
This is completely misguided. VDSM must not persist “polluted” bonding optio
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 25:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7037/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 6:
(1 comment)
Another comment.
http://gerrit.ovirt.org/#/c/26374/6/vdsm/netw
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 6:
(2 comments)
Comments on the dictionary of defaults.
http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7033/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
Yeela Kaplan has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/23645/7/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 2:
The second run of functional tests failure is 'connectivity check' and it is a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7028/
Ondřej Svoboda has uploaded a new change for review.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
network: Reset bonding options we did not modify to defaults (WIP)
This is an attempt to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_network_functional_tests/120
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7027/ : FAILURE
http://jenkins.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Verified+1
Patch set 4:
* added a couple of tests to catch the corner cased mentioned in the comment of
the previou
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7026/ : FAILURE
http://jenkins.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 3: Verified+1
Patch set 3:
* rebased (needed changes, so no trivial rebase, +1/+2 lost :( )
* added explicit boolean ca
oVirt Jenkins CI Server has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_network_functional_tests
Hello Douglas Schilling Landgraf, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26373
to review the following change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
.
Nir Soffer has posted comments on this change.
Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
..
Patch Set 1: Verified+1
Verified on RHEL 6.5
- Create data center/cluster/storage domain
- Creat
Nir Soffer has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 1: Verified+1
Verified on RHEL 6.5
- Create data center/cluster/storage domain
- Create vms/st
Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 1: Verified+1
Verified on RHEL 6.5
- Create data center/cluster/storage domain
- Create vms/sta
Nir Soffer has posted comments on this change.
Change subject: Revert "clientIF: rescan devices on failed hotplugDisk"
..
Patch Set 1: Verified+1
Verified on RHEL 6.5
- Create data center/cluster/storage domain
- Create vms/sta
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] json-rpc: AMQP test reactor
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7025/ : FAILURE
http://jenkins
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/23645/7/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
mooli tayer has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/25927/10/vdsm/API.py
File vdsm/API.py:
Line 1204: for s in vm
Dima Kuznetsov has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11/tests/samplingTests.py
File tests/samplingTests.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7024/
Nir Soffer has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 2: Code-Review+1
Even worse, but good enough if this fix is urgent.
--
To view, visit http://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
(1 comment)
Nice, but the tests are modifying stuff in unsafe way now.
http://gerrit.ovirt.org/#/c/258
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py
File lib/vdsm/n
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 21: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_un
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Patch Set 1: Verified+1
Passed the functional tests (jenkins) and tried to create the no n
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_network_functional_tests
Dan Kenigsberg has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py
File vdsm/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lvm: remove unused add/remove tags
..
lvm: remove unused add/remove tags
Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337
Signed-off-by: Yeela Kapl
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7022/ : FAILURE
http
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26367
to review the following change.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Do not allow
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_e
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7020/ : FAILURE
http
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
Ok, will split
--
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7019/ : FAILURE
Vinzenz Feenstra has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25927/10/vdsm/hooking.py
File vdsm/hooking.py:
Line
Federico Simoncelli has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py
File vds
Nir Soffer has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1: Code-Review+1
Ugly, but good enough for temporary bug fix.
--
To view, visit http://gerrit.ovirt.o
Liron Ar has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3
Federico Simoncelli has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/10/vdsm/hooking.py
File vdsm/hooking.py:
Line 56: def wr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7018/ : FAILURE
Federico Simoncelli has posted comments on this change.
Change subject: Avoid redundant volume produces.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/17991/1/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 640:
Liron Ar has uploaded a new change for review.
Change subject: core: fixing attribute error on fenceSpmStorage
..
core: fixing attribute error on fenceSpmStorage
In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metad
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7017/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7016/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7015/ : FAILURE
Liron Ar has abandoned this change.
Change subject: core: fixing attribute error on fenceSpmStorage
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/26357
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Liron Ar has uploaded a new change for review.
Change subject: core: fixing attribute error on fenceSpmStorage
..
core: fixing attribute error on fenceSpmStorage
In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metad
Federico Simoncelli has posted comments on this change.
Change subject: lvm: remove unused add/remove tags
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25013
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 7: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_e
Federico Simoncelli has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25970
To unsubscribe, visit ht
Vinzenz Feenstra has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/25927/10/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vd
Antoni Segura Puimedon has posted comments on this change.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
Patch Set 1: Verified+1
Passed the functional tests at
http://jenkins.ovirt.org/job/vdsm_netwo
Dan Kenigsberg has posted comments on this change.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26263
To unsubscribe, visit h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Do not allow empty network names (bridged nor bridgeless)
It was possible to create empty
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_e
Michal Skrivanek has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23703/8/vdsm/caps.py
File vdsm/caps.py:
Line 165:
Line 166:
Line 16
Allon Mureinik has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1: Code-Review+1
This bug was probably solved before the 3.4 split, so there is no such GERRIT
Martin Sivák has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 8:
I like it. Fix Francesco's comments and it should be ready.
--
To view, visit http://gerrit.ovirt.org/23703
To un
Eyal Edri has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 3:
still fails on other issues:
http://pastebin.com/uMaXEfaT
--
To view, visit http://gerrit.ovirt.org/26248
To un
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7012/ : FAILURE
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7011/ : FAILU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7009/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename migration threads
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7010/ : FAILURE
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7008/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 15:
Patch set 15: rebased
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 4:
Patch set 4: rebased
--
To view, visit http://gerrit.ovirt.org/26279
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7006/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7007/ : FAILU
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 14:
Patch set 14:
* rebased
* improved the commit message
--
To view, visit http://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 13:
Patch set 13:
* rebased
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, vi
Francesco Romani has posted comments on this change.
Change subject: virt: migration: rename migration threads
..
Patch Set 4:
Patch set 4:
- rebased
--
To view, visit http://gerrit.ovirt.org/26260
To unsubscribe, visit http:
Francesco Romani has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 12: Verified+1
Patch set 12:
* rebased
* improved the commit message
re-ticking verified.
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 11: Verified+1
Patch set 11:
* rebased after pep8 1.5.x fixes
* verified to be pep8 1.5.x clea
Nir Soffer has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1:
Note: gerrit is drunk again:
$ git checkout ovirt-3.4
$ git log --grep=I46d7c36b48f5d58edbc89
Nir Soffer has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1: Verified+1
Verified on RHEL 6.5 with ISCI storage with engine 3.4
- Create data center, cluster,
Hello Ayal Baron, Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26349
to review the following change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
hsm
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: virt cleanups for pep8-1.5
..
pep8: virt cleanups for pep8-1.5
virt is now pep8-1.5 clean
Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f
S
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: virt cleanups for pep8-1.5
..
Patch Set 1: Verified+1 Code-Review+2
verified with gitpydiff for having not syntactical change.
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: virt cleanups for pep8-1.5
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7005/ : FAILURE
http://jenkins.
Francesco Romani has uploaded a new change for review.
Change subject: pep8: virt cleanups for pep8-1.5
..
pep8: virt cleanups for pep8-1.5
virt is now pep8-1.5 clean
Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f
Signed-
99 matches
Mail list logo
