Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
ping!
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: blockSD: Refactor matadataValidity
..
Patch Set 1:
ping!
--
To view, visit http://gerrit.ovirt.org/25208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michal Skrivanek has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25164/2/vdsm/vm.py
File vdsm/vm.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: correct GLUSTER_RPM_PACKAGES
..
Patch Set 1:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7040/ : To avoid
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: correct GLUSTER_RPM_PACKAGES
..
Patch Set 2:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7041/ : To avoid
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: correct GLUSTER_RPM_PACKAGES
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7042/ : To avoid
mooli tayer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
Regarding yaniv previous comment the tool tests were merged:
Francesco Romani has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 3:
I got a few more fixes for pep8 1.5.x in the pipeline, I'll post some patches
soon
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
pep8: vdsm cleanups for pep-1.5.x
vdsm/*.py is now pep8 1.5.x clean.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7043/ : FAILURE
Francesco Romani has uploaded a new change for review.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
pep8: hooks cleanups for pep-1.5.x
hooks/* is now pep8 1.5.x clean.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Francesco Romani has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1:
Not trivially verifiable because of a string format change.
Unit tests however pass cleanly (but likely the
Francesco Romani has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 1:
Patch set 2:
* resubmit from branch, gitpydiff unexpectedly leaved a detached HEAD
* mostly trivial
Francesco Romani has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 2: Verified+1
(1 comment)
Verification:
mostly trivial whitespace changes, verified with gitpydiff and
Michal Skrivanek has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4:
Did you actually see the menu?:)
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: -Verified
To be honest I trusted libvirt/qemu. Un-ticking verified, I want to see it.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7045/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Verified+1
Verification:
* forced bootMenuEnable in the config
* actually seen press F12 to boot menu (RHEL 6.x)
*
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
vnic QoS: Fix specParams to XML definition conversion
VDSM API specifies specParams input and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: move threads in a separate module
..
virt: migration: move threads in a separate module
This patch moves the migration control
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25970
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: rename migration threads
..
virt: migration: rename migration threads
drop the now redundant 'Migration' prefix.
No functional or
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: rename migration threads
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26260
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 11:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 12: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/25975/12//COMMIT_MSG
Commit Message:
Michal Skrivanek has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+1
it's not always good to trust them:-) Thanks for the extra verification!
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26382
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Antoni Segura Puimedon has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 2: Code-Review+1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1: Code-Review-1
(1 comment)
if I'm not missing anything - I think it should be
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26383/2/vdsm_hooks/fileinject/before_vm_start.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: add boot menu support
..
vm: add boot menu support
libvirt supports interactive boot menu at guest startup,
depending on the support of the
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26382
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26383/2/vdsm_hooks/fileinject/before_vm_start.py
File
Francesco Romani has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 3: Verified+1
patch set 3:
* restored URL line (used noqa)
* gitpydiff and make check clean
--
To view,
Francesco Romani has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1:
I just want to try this once before ticking verified.
--
To view, visit http://gerrit.ovirt.org/26382
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26383
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7046/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1: Verified+1
verified manually using vdsClient
--
To view, visit http://gerrit.ovirt.org/26382
To
Federico Simoncelli has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26383
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26382
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP]tests: add simple balloon functional testcase
..
Patch Set 3: Code-Review-1
(2 comments)
It would be nice to have such a test, interactive with mom and a
Federico Simoncelli has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25164/2/vdsm/vm.py
File vdsm/vm.py:
Line 2337:
Federico Simoncelli has posted comments on this change.
Change subject: blockSD: Refactor matadataValidity
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25208
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 6:
Build Failed
Arik Hadas has uploaded a new change for review.
Change subject: pad memory volume only when the storage domain is file based
..
pad memory volume only when the storage domain is file based
Memory volume should be padded only
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2:
Build Failed
Federico Simoncelli has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/25978/15/vdsm/virt/migration.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7050/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7051/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25276/5/tests/functional/recoveryTests.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: Code-Review-1
./vdsm_reg/engine.py.in:151: local variable 'item' is assigned to but never
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: -Code-Review
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
pep failured not related to patch
--
To view, visit http://gerrit.ovirt.org/22462
To
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25243
To
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25242
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25241
To unsubscribe,
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26407
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25240
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7: Code-Review-1
(1 comment)
-1 since I have a question.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: blockSD: Refactor matadataValidity
..
blockSD: Refactor matadataValidity
The previous code was confusing, using positive conditions to set the
falsy
Amador Pahim has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 6: Verified+1
Build error not part of this patch:
./vdsm_reg/engine.py.in:151: local
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm_reg: remove engine.py.in
..
vdsm_reg: remove engine.py.in
engine.py.in was stored in vdsm_reg as part of ovirt-node
TUI registration stuff.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7052/ : FAILURE
Nir Soffer has posted comments on this change.
Change subject: logging: Enable all storage loggers
..
Patch Set 1:
Take it :-)
--
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 1: Code-Review-1
going to update..
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7:
Build Failed
Amador Pahim has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7: Verified+1
Build failure not related to the path:
./vdsm_reg/engine.py.in:151:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Revert clientIF: rescan devices on failed hotplugDisk
Commit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: Check all devices visibility after multipath rescan
..
hsm: Check all devices visibility after multipath rescan
After invoking multipath rescan,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: Do not hide errors when checking device visibility
..
hsm: Do not hide errors when checking device visibility
When checking devices visibility,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
..
clientIF: Rescan devices if device not found after vmHotplugDisk
According to the
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: vdsm cleanups for pep-1.5.x
..
pep8: vdsm cleanups for pep-1.5.x
vdsm/*.py is now pep8 1.5.x clean.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26383
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: hooks cleanups for pep-1.5.x
..
pep8: hooks cleanups for pep-1.5.x
hooks/* is now pep8 1.5.x clean.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26407
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26407
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26407/2//COMMIT_MSG
Federico Simoncelli has uploaded a new change for review.
Change subject: sd: improve metadata sizes definition
..
sd: improve metadata sizes definition
This refactoring is moving the definition of the metadata sizes in a
Federico Simoncelli has uploaded a new change for review.
Change subject: fileSD: enable the storage mailbox
..
fileSD: enable the storage mailbox
Change-Id: Iba8036e33ed8718d05e9d83cad1d63949794f067
Signed-off-by: Federico
Federico Simoncelli has uploaded a new change for review.
Change subject: fileSD: unify the metadata permissions definition
..
fileSD: unify the metadata permissions definition
This refactoring is unifying the metadata
Federico Simoncelli has posted comments on this change.
Change subject: fileSD: enable the storage mailbox
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26414/1//COMMIT_MSG
Commit Message:
Line 4: Commit:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7054/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7055/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: enable the storage mailbox
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7056/ : FAILURE
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26407/2//COMMIT_MSG
Commit Message:
Line 8:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 4: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/25275/4//COMMIT_MSG
Commit Message:
Line 21:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 27:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7058/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7059/ : FAILURE
98 matches
Mail list logo
