Darshan N has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 7:
(6 comments)
http://gerrit.ovirt.org/#/c/17766/7//COMMIT_MSG
Commit Message:
Line 3:
Darshan N has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/17766
To unsubscribe, visit
Petr Horáček has abandoned this change.
Change subject: netlink: event monitor functional tests
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/35288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks
..
network: Make vdsmd delNetwork use supervdsmd setupNetworks
delNetwork is part of a
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Make _addNetwork and _delNetwork private
..
Make _addNetwork and _delNetwork private
Change-Id: Ie043a26c795a8c8d71a6142d4df45f6584120338
Antoni Segura Puimedon has posted comments on this change.
Change subject: Make _addNetwork and _delNetwork private
..
Patch Set 1: Code-Review-1
Unfinished
--
To view, visit http://gerrit.ovirt.org/35311
To unsubscribe,
Sandro Bonazzola has uploaded a new change for review.
Change subject: sos: fix config import
..
sos: fix config import
config module is in not a platform-specific module so
it's in lib and not in lib64 tree.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _addNetwork and _delNetwork private
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12710/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sos: remove vdsm pki private keys collection
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12711/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sos: fix config import
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12712/ : FAILURE
Bala.FA has posted comments on this change.
Change subject: Provide device details using python-blivet module
..
Patch Set 5: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/35028/5//COMMIT_MSG
Commit Message:
Line 3:
Bala.FA has posted comments on this change.
Change subject: Provide device details using python-blivet module
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/35028/5/vdsm/gluster/storagedev.py
File
Sandro Bonazzola has posted comments on this change.
Change subject: sos: fix config import
..
Patch Set 1: Verified+1
This avoid to crash while importing the vdsm plugin but it doesn't work with
sos-3 anyway because of wrong
Hello Ondřej Svoboda, Antoni Segura Puimedon,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35317
to review the following change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 1: Verified+1
Verified by Ciprian Cosma
https://bugzilla.redhat.com/show_bug.cgi?id=1165210#c2
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit/29/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: switch to the simplejson module
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35290
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: virt: migration: simplify the remote port handling
..
virt: migration: simplify the remote port handling
When the destination port for migrations is
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: jsonrpc: switch to the simplejson module
..
jsonrpc: switch to the simplejson module
During testing, we discovered that on RHEL 6.x
and Centos 6.x we
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Send to cannonizeHostPort port parameter as string instead of
integer.
..
Send to cannonizeHostPort port parameter as string instead of integer.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: unified configureLibvirtNetwork parameters
..
Patch Set 2:
Build Failed
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 22:
(3 comments)
http://gerrit.ovirt.org/#/c/33309/22/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 324:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Send to cannonizeHostPort port parameter as string instead of
integer.
..
Patch Set 3:
Build Failed
Ido Barkan has posted comments on this change.
Change subject: network: Make vdsmd addNetwork use supervdsmd setupNetworks
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35090/1/vdsm/API.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: switch to the simplejson module
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/87/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12715/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 21:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12716/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pyroute2: reuse created devices
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12714/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: vm: return full copy of the conf data on status()
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34982
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm: return full copy of the conf data on status()
..
vm: return full copy of the conf data on status()
It is unsafe for status() to return a shallow
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Extract the DOM to Drive name, alias and path logic to reusable method
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tests: make api check support falsey values
..
tests: make api check support falsey values
the current vmApiTests assume truthy values in the replies.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Fix the API definition for cpu tune methods
..
Fix the API definition for cpu tune methods
Bug-Url:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Improve the _validateIoTuneParams so the params are passed as argument
This
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Refactor updateVmPolicy to use DOM manipulation
This allows updating the old values instead of just
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Collect current QoS settings for IO devices and report through
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: janitorial: move isVdsmImage into utils
..
janitorial: move isVdsmImage into utils
this patch moves vdsm/virt/vm.isVdsmImage into utils without code
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Add setIoTune and getIoTunePolicy to the xml-rpc API
Bug-Url:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Add API.VM.setIoTune
..
Add API.VM.setIoTune
This allows MoM (and the engine if necessary) to set the iotune
limits for disk devices.
Bug-Url:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Add API.VM.getIoTunePolicy
..
Add API.VM.getIoTunePolicy
This method can be used by MoM to retrieve the current ioTune
boundaries from the domain xml
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm: fix getVmPolicy return type.
..
vm: fix getVmPolicy return type.
in case of error, getVmPolicy will return a VDSM API return
value, which may
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Change method names in vmtune.py to the PEP8 style
..
Change method names in vmtune.py to the PEP8 style
Bug-Url:
Darshan N has posted comments on this change.
Change subject: gluster: Added geo-replication status and status detail
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/18414
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: gluster: Added geo-replication status and status detail
..
Patch Set 11:
(6 comments)
http://gerrit.ovirt.org/#/c/18414/11//COMMIT_MSG
Commit Message:
Line 11:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added geo-replication status and status detail
..
Patch Set 12: Code-Review-1 Verified-1
Build Failed
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 23:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/23/vdsm/rpc/vdsmapi-schema.json
File
Dan Kenigsberg has posted comments on this change.
Change subject: adding tx/rx statistic to getInterfacesStats
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35061
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: vm: re-enable HPET clock for non-windows guests
..
vm: re-enable HPET clock for non-windows guests
In commit 6167a6c33f150be we adhered to the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sos: remove vdsm pki private keys collection
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35241
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12718/ : FAILURE
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35317
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: mom.d: make CpuTuneEnabled True by default
..
mom.d: make CpuTuneEnabled True by default
we should ship vdsm with that policy enabled otherwise cpu tuning isn't
Roy Golan has posted comments on this change.
Change subject: mom.d: make CpuTuneEnabled True by default
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35330
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35331
to review the following change.
Change subject: utils: faster albeit less general deepcopy
..
utils: faster albeit less
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12719/ :
Petr Horáček has posted comments on this change.
Change subject: network: unified configureLibvirtNetwork parameters
..
Patch Set 2: Verified+1
Doesn't affect the results of ifcfg and iproute network functional tests.
Fixed
Amador Pahim has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 19: Verified+1
Setting rp_filter to loose mode only for devices distinct from
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: re-enable HPET clock for non-windows guests
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12720/ :
Francesco Romani has posted comments on this change.
Change subject: utils: faster albeit less general deepcopy
..
Patch Set 2: Verified+1
verified on 3.5 branch on RHEL6.6 by doing the usual routine of booting a few
tenths
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12721/
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/34535
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/17766
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: libnl: non-existing link exception
..
Patch Set 12: Verified+1
Fedora 20, libnl3-3.2.24
Compiled, installed, started OK.
Passed unit tests except
Bala.FA has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/17766/7/vdsm/gluster/exception.py
File
Bala.FA has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
..
Patch Set 9: Code-Review-1
Please respond to comment in patch set#7
--
To view, visit
Bala.FA has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 4: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/34535/4/vdsm.spec.in
File vdsm.spec.in:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mom.d: make CpuTuneEnabled True by default
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12724/ :
Ondřej Svoboda has posted comments on this change.
Change subject: avoid reading ifcfg files in netinfo
..
Patch Set 2: Code-Review+1
Nice :-)
--
To view, visit http://gerrit.ovirt.org/35043
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: re-enable HPET clock for non-windows guests
..
Abandoned
wrong direction. Solution is not to go back to HPET, but to improve kvm-clock
in qemu. See bz entry for
Ondřej Svoboda has posted comments on this change.
Change subject: make isVDSMInterface and it's helpers static
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34139
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: client: add option to make quiet
..
client: add option to make quiet
When used for (quite brutal) benchmarking, the output
from vdsClient can add noise and
Francesco Romani has posted comments on this change.
Change subject: profile: runtime support to enable/disable profile
..
Patch Set 5: Code-Review-1
it is unsafe to do this at runtime, because yappi handles internal python
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profile: add trivial benchmark runner
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12725/ : FAILURE
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 26:
getExternalVMs JSON, username and password are mandatory. (remove the optional
prefix)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return full copy of the conf data on status()
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 25:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12729/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profile: runtime support to enable/disable profile
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12727/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: client: add option to make quiet
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12728/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: client: vm params from JSON
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12726/ : FAILURE
Francesco Romani has uploaded a new change for review.
Change subject: jsonrpc: revert switch to the simplejson module
..
jsonrpc: revert switch to the simplejson module
This reverts commit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12730/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: make api check support falsey values
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/90/ :
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: revert switch to the simplejson module
..
Patch Set 3:
rebased with no code changes.
--
To view, visit http://gerrit.ovirt.org/35347
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the API definition for cpu tune methods
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/91/ :
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: revert switch to the simplejson module
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35347
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: revert switch to the simplejson module
..
Patch Set 3: Verified+1
Verification:
on a 3.5 branch with this patch applied, rebuilt, installed and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: revert switch to the simplejson module
..
jsonrpc: revert switch to the simplejson module
This reverts commit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 5:
Build Failed
Lior Vernia has posted comments on this change.
Change subject: host QoS: have service curve parameters be integers
..
Patch Set 2: Verified+1
Works fine when they're multiples of 8 :)
--
To view, visit
Lior Vernia has posted comments on this change.
Change subject: change qosOutbound for a nested 'hostQos':{'out':
bandwidth_params}
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/33165
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 5:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12731/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12732/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: move isVdsmImage into utils
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/95/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor XMLElement to virt.utils
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/96/ :
FAILURE
Francesco Romani has uploaded a new change for review.
Change subject: utils: add elapsed_time function
..
utils: add elapsed_time function
We currently use time.time() to get timestamp
with (near) second precision.
We we just
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add elapsed_time function
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12733/ : FAILURE
1 - 100 of 166 matches
Mail list logo
