Yeela Kaplan has posted comments on this change.
Change subject: Remove orphaned files
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add initial HostStatsThread tests
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29566/3/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add initial HostStatsThread tests
..
Patch Set 4: Verified+1
version 4 uses monkey patch to avoid a test-only argument, as Dan suggested.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove orphaned files
..
Remove orphaned files
This patch removes files than are neither mentioned in any code nor
shipped int the dist tar file.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list, restore and status verbs.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13800/ :
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2:
Ido - that's my problem. How can the hook work, if it does not have sudoers
configured
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: sampling: add initial HostStatsThread tests
..
tests: sampling: add initial HostStatsThread tests
This patch adds a unit test to
Dan Kenigsberg has posted comments on this change.
Change subject: tests: sampling: add initial HostStatsThread tests
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29566
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: sampling: add initial HostStatsThread tests
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13801/ :
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fixed %post script error during upgrade
..
Fixed %post script error during upgrade
During post script we initiates vdsm-tool set-saslpasswd call. On
upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: Verified+1
its cool and all, but should be part of vdsm-tool configure imo . later..
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35739/1/init/vdsmd_init_common.sh.in
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1:
I know, but i won't make it today
--
To view, visit http://gerrit.ovirt.org/35739
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2:
I don't recall us dropping privileges when invoking hooks. Since this hook
happens
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: -Code-Review
Ok, but don't it slow vdsm start-up?
--
To view, visit http://gerrit.ovirt.org/35739
To
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35725
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: move _netinfo and libvirt_nets decleration right before it's
used
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35687
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: rename networkAttrs to attrs
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ido Barkan has posted comments on this change.
Change subject: factor out parts of setupNetworks for better readability
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35691
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: do not delete networks from parameters
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35690
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: rename networksAdded to connectivity_check_networks
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35688
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: factor out hook logic in setupNetworks
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35693
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2: Code-Review-1
hooks.before_network_setup() is called in the context of
Ido Barkan has posted comments on this change.
Change subject: removed unused parameter duplication
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35692
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1:
no.. its quite fast
--
To view, visit http://gerrit.ovirt.org/35739
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: Code-Review+2
Ok, accepting as an emergency fix to 3.5 upgrade.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixed %post script error during upgrade
..
Fixed %post script error during upgrade
During post script we initiates vdsm-tool set-saslpasswd call. On
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fixed %post script error during upgrade
..
Fixed %post script error during upgrade
During post script we initiates vdsm-tool set-saslpasswd call. On
upgrade
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35744
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35744
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Fixed %post script error during upgrade
..
Fixed %post script error during upgrade
During post script we initiates vdsm-tool set-saslpasswd call. On
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 30: -Verified
--
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit
Hello Yaniv Bronhaim, Dima Kuznetsov, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35745
to review the following change.
Change subject: supervdsm: enable coredumping
..
Yeela Kaplan has posted comments on this change.
Change subject: supervdsm: enable coredumping
..
Patch Set 1: Verified+1
Same as master.
Does not break the build.
--
To view, visit http://gerrit.ovirt.org/35745
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/122/ :
Dan Kenigsberg has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 30: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/33309/30/vdsm/v2v.py
File vdsm/v2v.py:
Line 27:
Ido Barkan has posted comments on this change.
Change subject: move _netinfo and libvirt_nets decleration right before it's
used
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35687/1/vdsm/network/api.py
File
Francesco Romani has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 30:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/30/vdsm/virt/vmstatus.py
File vdsm/virt/vmstatus.py:
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Do not use lscpu on ppc64
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/33872/4//COMMIT_MSG
Commit Message:
Line 7: caps: Do not use lscpu on
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Do not use lscpu on ppc64
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33872/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2:
Ok, I'll drop the changes, and remove sudoers file (along with its install
rules)?
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: enable coredumping
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35745
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 30:
(3 comments)
http://gerrit.ovirt.org/#/c/33309/30/vdsm/v2v.py
File vdsm/v2v.py:
Line 27: '''
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Include sudoers file in ethtool_options rpm
..
Patch Set 2:
yep, all refs to sudo should be dropped from this hook
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: move _netinfo and libvirt_nets decleration right before it's
used
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35687
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: move _netinfo and libvirt_nets decleration right before it's
used
..
move _netinfo and libvirt_nets decleration right before it's used
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rename networkAttrs to attrs
..
rename networkAttrs to attrs
Change-Id: I978aad73b0981785b3e7e05d94b8f7d0250fd82f
Signed-off-by: ibarkan
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rename networksAdded to connectivity_check_networks
..
rename networksAdded to connectivity_check_networks
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: rename networksAdded to connectivity_check_networks
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35688
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: rename networkAttrs to attrs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35689
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: remove updating libvirt_nets, it has no effect
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35694
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sampling: live merge: avoid wasteful picklecopy
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35621
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Search only the current image for children
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35096
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: Do not extend volume beyond truesize
..
Do not extend volume beyond truesize
When calling getNextVolumeSize on a volume that is close to fully
allocated, the
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Search only the current image for children
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/35096/2//COMMIT_MSG
Commit Message:
Adam Litke has posted comments on this change.
Change subject: Do not extend volume beyond truesize
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35757
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: Do not extend volume beyond truesize
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35757
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: Proactively extend merge target volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35614/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Adam Litke has posted comments on this change.
Change subject: storage: Search only the current image for children
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/35096/2//COMMIT_MSG
Commit Message:
Line 12: problem
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35758
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing persisted value to libvirt logrotate configure
..
Changing persisted value to libvirt logrotate configure
Setting persisted to false means that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsm: enable coredumping
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/26/
:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allowing to skip checks from command line
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/105/
Yeela Kaplan has uploaded a new change for review.
Change subject: sosreport: remove Base class
..
sosreport: remove Base class
Use of Base class inheritance breaks with sos=3.1
Change-Id:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing persisted value to libvirt logrotate configure
..
Changing persisted value to libvirt logrotate configure
Setting persisted to false means that
Yeela Kaplan has posted comments on this change.
Change subject: sosreport: remove Base class
..
Patch Set 1: Verified+1
verified vdsm.log is created on:
sos-3.0-23.el7.noarch
sos-2.2-47.el6.noarch
sos-3.1-1.pkvm2_1.1.noarch
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 31:
Added obfuscation for password in log via xmlrpm currently this is not
available via json!
--
To view,
Sandro Bonazzola has posted comments on this change.
Change subject: sosreport: remove Base class
..
Patch Set 1:
(1 comment)
I would still prefer having 2 separate files avoiding this kind of workaround.
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35761
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: supervdsm: enable coredumping
..
supervdsm: enable coredumping
Enable coredump both on el6 (sysvinit)
and on el7 (systemd).
Also, limit core size to 0
Francesco Romani has posted comments on this change.
Change subject: Do not extend volume beyond truesize
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35757
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Proactively extend merge target volume
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35614
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debian: Add noipspoof files to dist
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/27/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lib: add support for utillinux commands
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/106/ :
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
..
Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add set-sasl to
spec
To
Federico Simoncelli has posted comments on this change.
Change subject: storage: Search only the current image for children
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35096
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: sosreport: Don't try to collect info from sockets
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/35513/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Federico Simoncelli has posted comments on this change.
Change subject: Do not extend volume beyond truesize
..
Patch Set 1: Code-Review+2
This seems good. Sadly it will finally help us to discover if truesize is not
properly
Yeela Kaplan has posted comments on this change.
Change subject: sosreport: Don't try to collect info from sockets
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35513
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: fix HostStatsThread tests
..
tests: fix HostStatsThread tests
In commit 4567f368bc3b initial tests for HostStatsThread
were added. Unfortunately, the
Dan Kenigsberg has posted comments on this change.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35763
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove orphaned files
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/28/
: SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 4:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: tests: fix HostStatsThread tests
..
Patch Set 2: Verified+1
Version 2 improves the commit message.
- Verified *on master*:
1117 17:49:30 fromani@musashi
Francesco Romani has posted comments on this change.
Change subject: vm: Allow to use 'serial' or 'virtio' type consoles
..
Patch Set 8:
(2 comments)
I'm fine with the concept, but I'd like to pack as much as possible the
Dan Kenigsberg has posted comments on this change.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
..
Patch Set 1: Verified+1
The reverted patch causes failure on clean install.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
..
Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add set-sasl to
spec
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: sampling: add initial HostStatsThread tests
..
Patch Set 5:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix HostStatsThread tests
..
tests: fix HostStatsThread tests
In commit 4567f368bc3b initial tests for HostStatsThread
were added.
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix HostStatsThread tests
..
Patch Set 2: Code-Review+2
Ooh, my bad.
--
To view, visit http://gerrit.ovirt.org/35764
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 30:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/108/ :
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35765
to review the following change.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
Yaniv Bronhaim has posted comments on this change.
Change subject: Revert Ib7808f4f217ba3d6d30a60fab6233e36a29f0098 and add
set-sasl to spec
..
Patch Set 1: Verified+1
yeela, dan - can you please double verify me ?
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 18:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixed %post script error during upgrade
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert 'Create default multipath.conf during install'
..
Patch Set 17:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: sosreport: remove Base class
..
Patch Set 1: Code-Review+1
The big refactoring request should keep open. We need to find a hack-less
solution that does not
Federico Simoncelli has posted comments on this change.
Change subject: Live Merge: Proactively extend merge target volume
..
Patch Set 2: Code-Review+2
Le sigh
--
To view, visit http://gerrit.ovirt.org/35614
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Do not extend volume beyond truesize
..
Do not extend volume beyond truesize
When calling getNextVolumeSize on a volume that is close to fully
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Live Merge: Proactively extend merge target volume
..
Live Merge: Proactively extend merge target volume
Since libvirt is not yet providing the write
1 - 100 of 178 matches
Mail list logo
