Change in vdsm[master]: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6

2014-12-09 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6 .. Patch Set 40: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/30532/40/tests/functional/netwo

Change in vdsm[master]: lvm: Cleanup lvm udev rules

2014-12-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Cleanup lvm udev rules .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33874/5/vdsm/storage/vdsm_lvm_rules.template.in File vdsm/storage/vdsm_lvm_rule

Change in vdsm[master]: net tests: rename temporary variable

2014-12-09 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net tests: rename temporary variable .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35910 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: testSetupNetworksAddDelDhcp: Improve readability

2014-12-09 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: Improve readability .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35983 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: netinfo: Modernize functions recognizing the usage of DHCP f...

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Modernize functions recognizing the usage of DHCP from lease files .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pe

Change in vdsm[master]: netinfo, tests: Rename internal 'dhcp4' variables to get in ...

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tests: Rename internal 'dhcp4' variables to get in line with 'dhcpv6' .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master

Change in vdsm[master]: net tests: rename temporary variable

2014-12-09 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net tests: rename temporary variable .. Patch Set 2: Verified+1 The test still works on F20 after applying it and its predecessor. And it _should_ continue wor

Change in vdsm[master]: testSetupNetworksAddDelDhcp: Improve readability

2014-12-09 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: Improve readability .. Patch Set 1: Verified+1 The test still works on F20 after applying it and its predecessor. And it _should_

Change in vdsm[master]: netinfo: Move 'dhcp4' parameters to the end in helper functions

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Move 'dhcp4' parameters to the end in helper functions .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/140

Change in vdsm[master]: testSetupNetworksAddDelDhcp: Check for DHCPv4 also on the de...

2014-12-09 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: Check for DHCPv4 also on the device (or bridge) .. Patch Set 1: Verified+1 (1 comment) The test still works on F20, and it _shoul

Change in vdsm[master]: netinfo: Assess and report 'dhcpv6' from dhclient -6 leases

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Assess and report 'dhcpv6' from dhclient -6 leases .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14078/

Change in vdsm[master]: netinfo: Make bootproto4 a boolean and rename it while it is...

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt

Change in vdsm[master]: netinfo: Modernize functions recognizing the usage of DHCP f...

2014-12-09 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo: Modernize functions recognizing the usage of DHCP from lease files .. netinfo: Modernize functions recognizing the usage of DHCP from lease files Cha

Change in vdsm[master]: netinfo, tests: Rename internal 'dhcp4' variables to get in ...

2014-12-09 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo, tests: Rename internal 'dhcp4' variables to get in line with 'dhcpv6' .. netinfo, tests: Rename internal 'dhcp4' variables to get in line with 'dhcpv6

Change in vdsm[master]: netinfo: Move 'dhcp4' parameters to the end in helper functions

2014-12-09 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo: Move 'dhcp4' parameters to the end in helper functions .. netinfo: Move 'dhcp4' parameters to the end in helper functions Change-Id: I593919713cd09666

Change in vdsm[master]: net tests: rename temporary variable

2014-12-09 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net tests: rename temporary variable .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35910/1/tests/functional/networkTests.py File tests/functional/net

Change in vdsm[master]: libnl: non-existing link returns exception instead of None

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: non-existing link returns exception instead of None .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms

Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: VM_setCpuTuneQuota .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/82/ : FAILUR

Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: VM_setCpuTunePeriod .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/81/ : FAILU

Change in vdsm[master]: Fixed parted utils for newer parted

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/80/

Change in vdsm[master]: lvm: Cleanup lvm udev rules

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Cleanup lvm udev rules .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33874/5/vdsm/storage/vdsm_lvm_rules.template.in File vdsm/storage/vdsm_lvm_

Change in vdsm[master]: libnl: non-existing link returns exception instead of None

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: libnl: non-existing link returns exception instead of None .. libnl: non-existing link returns exception instead of None Because of backward compatibil

Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: VM_setCpuTuneQuota .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35553 To unsubscribe, visit http://gerrit.ovirt.org/setting

Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: VM_setCpuTuneQuota .. jsonrpc: VM_setCpuTuneQuota Align naming between API.py and schema. Change-Id: I397d12419ff1e108c57ad6098f7ca1be5ef4471

Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: VM_setCpuTunePeriod .. jsonrpc: VM_setCpuTunePeriod Align naming between API.py and schema. Change-Id: Iac8159c951bb9b85914a51e78e9678c291809

Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: VM_setCpuTunePeriod .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35552 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: Fixed parted utils for newer parted

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fixed parted utils for newer parted .. Fixed parted utils for newer parted In the newer parted, the new flag 'esp' is added to the 'boot' flag on all p

Change in vdsm[master]: Fixed parted utils for newer parted

2014-12-09 Thread dcaroest
David Caro has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/35700 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: lvm: Cleanup lvm udev rules

2014-12-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Cleanup lvm udev rules .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/33874/5/vdsm/storage/vdsm_lvm_rules.template.in File vdsm/storage/vdsm_lvm_rul

Change in vdsm[master]: adding tx/rx statistic to getInterfacesStat

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: adding tx/rx statistic to getInterfacesStat .. Patch Set 4: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/35061/4/tests/functional/networkTests.py Fil

Change in vdsm[master]: jsonrpc: VM_getStats

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: VM_getStats .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35551/3/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6695

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck .. Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35901/3/tests/ipwrapperTests.py File tests/ipwrap

Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_setCpuTuneQuota .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35553 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_setCpuTunePeriod .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35552 To unsubscribe, visit http://gerrit.ovirt.org/sett

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 3: Code-Review+1 (1 comment) this patch makes things consistent, so good to have. http://gerrit.ovirt.org/#/c/35556/

Change in vdsm[master]: jsonrpc: VM_setIoTune

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_setIoTune .. Patch Set 3: Code-Review+1 drop my comment, same considerations as per 35556 -- To view, visit http://gerrit.ovirt.org/35554 To uns

Change in vdsm[master]: jsonrpc: VM_getDiskAlignment

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_getDiskAlignment .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35550 To unsubscribe, visit http://gerrit.ovirt.org/sett

Change in vdsm[master]: vm: ensure graphics configuration data in recovery

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: ensure graphics configuration data in recovery .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14076/ : SUCCESS

Change in vdsm[master]: External hypervisor VMs integration

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: External hypervisor VMs integration .. Patch Set 33: (2 comments) http://gerrit.ovirt.org/#/c/33309/33/vdsm/v2v.py File vdsm/v2v.py: Line 38: for vm i

Change in vdsm[master]: infra: Switch utils calls to filecontrol

2014-12-09 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: infra: Switch utils calls to filecontrol .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35919 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: vm: ensure graphics configuration data in recovery

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: ensure graphics configuration data in recovery .. Patch Set 2: Verified+1 Verification: - did plain recovery, twice (no regression test) - OK - reproduced

Change in vdsm[master]: libnl: non-existing link returns exception instead of None

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: libnl: non-existing link returns exception instead of None .. Patch Set 16: Verified+1 Passed unit and network functional tests on Fedora 20. All get and iter* n

Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: ignore_enodev parameter in *_info .. Patch Set 14: Passed unit and network functional tests on Fedora 20. All get and iter* netlink functions work as ex

Change in vdsm[master]: storageServer: Improve iscsi connection logging

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Improve iscsi connection logging .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14075/ : SUCCESS h

Change in vdsm[master]: storageServer: Improve iscsi connection logging

2014-12-09 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: storageServer: Improve iscsi connection logging .. storageServer: Improve iscsi connection logging We have several bugs where iscsi storage connection are not disc

Change in vdsm[master]: Make pep8/flake8 happy with the indentation

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make pep8/flake8 happy with the indentation .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14074/ : SUCCESS http:

Change in vdsm[master]: vm: ensure graphics configuration data in recovery

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: ensure graphics configuration data in recovery .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14072/ : SUCCESS

Change in vdsm[master]: Handle iscsi iface.net_ifacename for existing iface

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handle iscsi iface.net_ifacename for existing iface .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14073/ : SUCCES

Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: teach delNetworks to remove a network entity under a bridge .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_m

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14070/ : SUCCESS http://j

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14069/ : SUCCESS http://jen

Change in vdsm[master]: jsonrpc: Host_setupNetworks

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Host_setupNetworks .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/79/ : FAILUR

Change in vdsm[ovirt-3.5]: mom.d: make CpuTuneEnabled True by default

2014-12-09 Thread rgolan
Roy Golan has posted comments on this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36027 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[ovirt-3.5.0]: mom.d: make CpuTuneEnabled True by default

2014-12-09 Thread rgolan
Roy Golan has abandoned this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Abandoned -- To view, visit http://gerrit.ovirt.org/36026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messag

Change in vdsm[ovirt-3.5]: openstacknet: Fix migration when using security groups

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 1: Verified+1 recently verified by Toni on master. -- To view, visit http://gerrit.ovirt.o

Change in vdsm[master]: gluster: add createBrick verb

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/164/ : SUCCESS

Change in vdsm[ovirt-3.5.0]: mom.d: make CpuTuneEnabled True by default

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Patch Set 1: Code-Review-2 3.5.0 branch is dead now. -- To view, visit http://gerrit.ovirt.org/36026 To unsubscr

Change in vdsm[master]: jsonrpc: VM_setIoTune

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_setIoTune .. Patch Set 3: Code-Review-1 (1 comment) same question as 35556 http://gerrit.ovirt.org/#/c/35554/3/vdsm/rpc/Bridge.py File vdsm/rpc/

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 3: Code-Review-1 (1 comment) -1 because a question http://gerrit.ovirt.org/#/c/35556/3/vdsm/rpc/Bridge.py File vdsm/

Change in vdsm[master]: assertNetworkExists should also verify that bridges are actu...

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: assertNetworkExists should also verify that bridges are actually created .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/35872/7/tests/functional/networ

Change in vdsm[master]: jsonrpc: Host_setupNetworks

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: Host_setupNetworks .. jsonrpc: Host_setupNetworks Align naming between API.py and schema. Change-Id: Id3b4bef7cd654afa5eceb9d4cc5ce3e7d15d6e5

Change in vdsm[master]: jsonrpc: Host_setupNetworks

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Host_setupNetworks .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35527 To unsubscribe, visit http://gerrit.ovirt.org/setting

Change in vdsm[ovirt-3.5]: mom.d: make CpuTuneEnabled True by default

2014-12-09 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: mom.d: make CpuTuneEnabled True by default .. mom.d: make CpuTuneEnabled True by default we should ship vdsm with that policy enabled otherwise cpu tuning isn't tak

Change in vdsm[ovirt-3.5.0]: mom.d: make CpuTuneEnabled True by default

2014-12-09 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: mom.d: make CpuTuneEnabled True by default .. mom.d: make CpuTuneEnabled True by default we should ship vdsm with that policy enabled otherwise cpu tuning isn't tak

Change in vdsm[master]: remove needless parameter

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: remove needless parameter .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35913 To unsubscribe, visit http://gerrit.ovirt.org/settings G

Change in vdsm[master]: remove needless parameter

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: remove needless parameter .. Patch Set 6: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/35913/6/tests/functional/networkTests.py File tests/functional/net

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/13

Change in vdsm[master]: remove needless parameter

2014-12-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: remove needless parameter .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35913/6/tests/functional/networkTests.py File tests/functional/ne

Change in vdsm[master]: jsonrpc: VM_setIoTune

2014-12-09 Thread msivak
Martin Sivák has posted comments on this change. Change subject: jsonrpc: VM_setIoTune .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

Change in vdsm[master]: gluster: Added volume snapshot list and restore verbs.

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added volume snapshot list and restore verbs. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14067/ : SUC

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: fix selinux-policy requirement for EL6 .. spec: fix selinux-policy requirement for EL6 Change-Id: I910e04c5ac6e6a6f0991af7d144dca3ceba444c4 Bug-U

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36018 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 6: on my F20: testAddDelBondedNetwork(kwargs=False) OK testAddDelBondedNetwork(k

Change in vdsm[master]: Make pep8/flake8 happy with the indentation

2014-12-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Make pep8/flake8 happy with the indentation .. Patch Set 1: I wonder why my pyflakes/pep8 hasn't warned me of this. Which versions are you using? -- To vie

Change in vdsm[master]: Make pep8/flake8 happy with the indentation

2014-12-09 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Make pep8/flake8 happy with the indentation .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36024 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 6: and now with no skips: Ran 101 tests in 998.581s OK -- To view, visit http://gerrit.ovirt.org/35311

Change in vdsm[master]: Make pep8/flake8 happy with the indentation

2014-12-09 Thread vfeenstr
Vinzenz Feenstra has uploaded a new change for review. Change subject: Make pep8/flake8 happy with the indentation .. Make pep8/flake8 happy with the indentation Change-Id: Ieca0fb3e4664fc2c2cfd1e92d7b7db2d74d3d7e8 Signed-off-by

Change in vdsm[master]: profile: transform into a subpackage

2014-12-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profile: transform into a subpackage .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36010/1/lib/vdsm/profiling/cpu.py File lib/vdsm/profiling/cpu.py: Lin

Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: teach delNetworks to remove a network entity under a bridge .. Patch Set 5: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35921/5/vdsm/network/api.py

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 2: Verified+1 pushed right patch, sorry for the mixup. -- To view, visit http://gerrit.ovirt.org/360

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 1: Verified-1 -- To view, visit http://gerrit.ovirt.org/36018 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 1: Code-Review-1 Wrong patch pushed - do not merge! -- To view, visit http://gerrit.ovirt.org/36018

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 6: Verified+1 verified on el6: NetworkTest testAddDelBondedNetwork(kwargs=False)

Change in vdsm[master]: vm: ensure graphics configuration data in recovery

2014-12-09 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: ensure graphics configuration data in recovery .. vm: ensure graphics configuration data in recovery Graphics Devices may be not sent by Engine. To cover

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36018 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35311 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: network: Make vdsmd addNetwork use supervdsmd setupNetworks

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: Make vdsmd addNetwork use supervdsmd setupNetworks .. Patch Set 4: Code-Review+2 I'm told that supervdsmServer is cleaned in a follow up patch; I can l

Change in vdsm[master]: network: Make vdsmd delNetwork use supervdsmd setupNetworks

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35310 To unsubscribe, visit

Change in vdsm[master]: Make _addNetwork and _delNetwork private

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make _addNetwork and _delNetwork private .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35311/5/vdsm/network/api.py File vdsm/network/api.py: Line 21

Change in vdsm[master]: doc: Add index for vdsm-infra package

2014-12-09 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: doc: Add index for vdsm-infra package .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35917 To unsubscribe, visit http://gerrit.ovirt.org

Change in vdsm[master]: doc: Remove create_sl.sh

2014-12-09 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: doc: Remove create_sl.sh .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35916 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

Change in vdsm[master]: Handle iscsi iface.net_ifacename for existing iface

2014-12-09 Thread apahim
Amador Pahim has posted comments on this change. Change subject: Handle iscsi iface.net_ifacename for existing iface .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35976/2/vdsm/storage/iscsi.py File vdsm/storage/iscsi

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36018 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[ovirt-3.5]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: spec: fix selinux-policy requirement for EL6 .. spec: fix selinux-policy requirement for EL6 Change-Id: I910e04c5ac6e6a6f0991af7d144dca3ceba444c4 Bug-Url: http

Change in vdsm[master]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_mer

Change in vdsm[master]: Handle iscsi iface.net_ifacename for existing iface

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Handle iscsi iface.net_ifacename for existing iface .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35976/2/vdsm/storage/iscsi.py File vdsm/storage/isc

Change in vdsm[master]: gluster: volume snapshot create and delete verbs.

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_crea

Change in vdsm[master]: assertNetworkExists should also verify that bridges are actu...

2014-12-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: assertNetworkExists should also verify that bridges are actually created .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_

Change in vdsm[master]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: fix selinux-policy requirement for EL6 .. spec: fix selinux-policy requirement for EL6 Change-Id: I910e04c5ac6e6a6f0991af7d144dca3ceba444c4 Bug-U

Change in vdsm[master]: spec: fix selinux-policy requirement for EL6

2014-12-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: fix selinux-policy requirement for EL6 .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/35973/1/vdsm.spec.in File vdsm.spec.in: Lin

  1   2   >