Dan Kenigsberg has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix schema
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13775/ : FAILURE
http://jenkins.ovirt.org/job/
Amador Pahim has posted comments on this change.
Change subject: Fix schema
..
Patch Set 2: Verified+1
Build ok.
--
To view, visit http://gerrit.ovirt.org/36427
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Dan Kenigsberg has posted comments on this change.
Change subject: Fix schema
..
Patch Set 1: Code-Review-1
(1 comment)
Thanks for unbreaking the build!
http://gerrit.ovirt.org/#/c/36427/1/vdsm/rpc/vdsmapi-schema.json
File vd
Dan Kenigsberg has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 51: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/30532/51/tests/functional/ne
Amador Pahim has posted comments on this change.
Change subject: Fix schema
..
Patch Set 1: Verified+1
No more build error.
--
To view, visit http://gerrit.ovirt.org/36427
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix schema
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13773/ : FAILURE
http://jenkins.ovirt.org/job/
Amador Pahim has uploaded a new change for review.
Change subject: Fix schema
..
Fix schema
Current schema is presenting the build error:
ValueError: 'HostDeviceParams' comment mentions 'physfn' which is not defined
This patc
Amador Pahim has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 20:
(9 comments)
http://gerrit.ovirt.org/#/c/31529/20/vdsm/storage/iscsi.py
F
oVirt Jenkins CI Server has posted comments on this change.
Change subject: protocoldetector: Fix polling timeout
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/147/ :
SU
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: protocoldetector: Fix polling timeout
..
protocoldetector: Fix polling timeout
The event loop was calculating timeout in seconds, but poll timeout
shou
Yaniv Bronhaim has posted comments on this change.
Change subject: protocoldetector: Fix polling timeout
..
Patch Set 2: Code-Review+2
consider backports
--
To view, visit http://gerrit.ovirt.org/36409
To unsubscribe, visit h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: report physfn
..
hostdev: report physfn
Each sr-iov virtual function is actually a separate function on a pci
bus. Libvirt reports these funct
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: report physfn
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35974
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: infra: Switch utils calls to filecontrol
..
infra: Switch utils calls to filecontrol
Change all call to functions moved to filecontrol to appropriate m
Yaniv Bronhaim has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 1: Code-Review+1
more right to say that over systemd "service multipathd reload" returns 1
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Enable vhostmd on non-koji Fedora builds
..
spec: Enable vhostmd on non-koji Fedora builds
with_vhostmd is configurable since vhostmd is missing
Dan Kenigsberg has submitted this change and it was merged.
Change subject: qemu-img: Allow creation of zero-sized volumes
..
qemu-img: Allow creation of zero-sized volumes
In previous version if size is zero it was omitted fro
Dima Kuznetsov has posted comments on this change.
Change subject: qemu-img: Allow creation of zero-sized volumes
..
Patch Set 2: Verified+1
Verified by running unit tests and creating a disk over NFS storaged domain
--
To vi
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/36263
To unsubscribe, visit http://gerrit.ovirt.org/setti
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13772/ : FAILURE
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 39:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13771
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/36263/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 35:
Line 36:
Line 37: de
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35940/1/lib/yajsonrpc/stomp.py
File lib/yajs
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 1:
seems right
--
To view, visit http://gerrit.ovirt.org/35939
To unsubscribe, visit http://gerrit.ovirt.org/setting
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35938
To unsubscribe, visit h
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: use the atomic dict.setdefault() instead for check and
set
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35937
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 1: Code-Review+1
seems right
--
To view, visit http://gerrit.ovirt.org/3593
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 1: Code-Review+1
seems right ...
--
To view, visit http://gerrit.ovirt.org/35935
To unsubscribe, visit h
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35934
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Optimize stomp encoder\decoder
..
Patch Set 2:
(1 comment)
you don't reply to comments and than scream that we don't review it.. not nice..
http://gerr
Yeela Kaplan has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py
Federico Simoncelli has posted comments on this change.
Change subject: qemu-img: Allow creation of zero-sized volumes
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36276
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13769/ : FAILURE
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 38:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13768/ : F
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36263/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 121: try:
Line
Nir Soffer has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36263/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 121:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 37:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13766/ : F
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13767/ : FAILURE
http:/
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 37: Verified-1
No need to review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, vi
Shahar Havivi has posted comments on this change.
Change subject: v2v: add volume size to disk info
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36263
To unsubscribe, visit http://gerrit.ovirt.org/setti
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Remove JsonRpcClientPool
..
Patch Set 2:
please get pioter to review this as well. it's way too long, complicated and
sensitive to review that without
Yaniv Bronhaim has posted comments on this change.
Change subject: enable-rhev adds hooks and disable check on build
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36360/1/vdsm.spec.in
File vdsm.spec.in:
Line 76: Lic
44 matches
Mail list logo
